From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.3438.1633309811873177642 for ; Sun, 03 Oct 2021 18:10:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=BVm2Byub; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: chasel.chiu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10126"; a="311453755" X-IronPort-AV: E=Sophos;i="5.85,344,1624345200"; d="scan'208";a="311453755" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2021 18:10:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,344,1624345200"; d="scan'208";a="712087527" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga005.fm.intel.com with ESMTP; 03 Oct 2021 18:10:10 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sun, 3 Oct 2021 18:10:09 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Sun, 3 Oct 2021 18:10:09 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Sun, 3 Oct 2021 18:10:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EpfL2P+DXA1pUpXsDB1E9CeoY/wN4Dq65U+327Jgp7nUiWy3xgtbW1/EoZFrWmyHs1iphGJ45Ur5b95Ix624UHgbEsZY1Jr9orol3BOkc9M+y3WW21uTUvgwXyiYRnxVd45LjTE2NAeTceKOJadwi6FTxQcAOMdXeaVKG/XFLvBq3xH2mWr7KkAEQV762YDihM+plNBh9i4l7pq0froMdiGu75ZNtVDhxR6oqcR0+CR+tWrDHiBF8A7/hgM/g5TbOyU7HQY1KHXdCC8f95iGyYQVLM1neDNqgmZpqjjKg3Mw1Mzphf4rdj6+zAGFjsVszBtn/TW2mC9eD3ttPibGJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=32JE1Th2n053QdS9XXxaQEQN/rTcjmm7/IDSXtZQgwI=; b=WMvLhIxP991mXNkmBHC9lOr7JpJTzbAobIwlDkO76NxVExOtQiYDUQA2y71WWVPNMv9QhHPfPGwJ0QfkIcb1uRsy2mgbbrO+fPZmsqrtlTaK5/G7rn7WMZ8ImyPslUqtJAW/jenowFTZ84z1NpA8sMEjx4Fq7ANNI44R0UE2durtvGHC18GJ4gfS28utIhCPpfgwcxz/TtImSz+fFG2EoES3TwS8slolsw+F+LLR9hepyhEhrmbRN23hpXIQeA9Jnm2+RtsqAWdbbYGSveqD6zQ5Ywaqi8/j6ZNR9irG5h8IWnxYm13vtcuzr7lg3L6VQNAM7uk3Tx6lIzTF8+6RZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=32JE1Th2n053QdS9XXxaQEQN/rTcjmm7/IDSXtZQgwI=; b=BVm2ByubLnfB8HNYQ0hjWbTPX6u7XHKxSdTtdM4TFq5wTV6X7Fj2ZboVFMNyHDijCYLDuNosA7rHHqy20qThVCruSDXzhFR6UPPjwxeb3ljWhCETCdUcNATCO50899MCMVcCypPe7pKFWRoJPk9dJ69Rohwn6wyaTGB/pCVXwHM= Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN6PR11MB1859.namprd11.prod.outlook.com (2603:10b6:404:104::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Mon, 4 Oct 2021 01:10:08 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::882:4e40:b0e4:239e]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::882:4e40:b0e4:239e%8]) with mapi id 15.20.4566.022; Mon, 4 Oct 2021 01:10:08 +0000 From: "Chiu, Chasel" To: "devel@edk2.groups.io" CC: "Ma, Maurice" , "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [PATCH] IntelFsp2Pkg: Adopt FSP 2.3 specification. Thread-Topic: [PATCH] IntelFsp2Pkg: Adopt FSP 2.3 specification. Thread-Index: AQHXtp5nwa30F0+DqkCn57a+gLtWbKvCC9LA Date: Mon, 4 Oct 2021 01:10:08 +0000 Message-ID: References: <20211001082848.2710-1-chasel.chiu@intel.com> In-Reply-To: <20211001082848.2710-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6b0a5aec-2aba-40d1-c1ca-08d986d3b536 x-ms-traffictypediagnostic: BN6PR11MB1859: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NhobtVBqp7YlPhD/zlloH3Q/iibBiO5cK+tkqITa7HGSIi8nlv+B/qXI7ffsCvqIZv5BlvpL9QiEEtynEU4+qUDDVu1k35GE6jaZrOBinnqoSNgcpjPvtJjyrf2tLf0pDZPfKFGRQEZwVsnT9S4KGY2MbTptKMEvocy3TAmB28BM5TaevdY4vcP4CtbyCf4gm8yjvTIk/VtYO4Dld/oM3B0DUNpuFIWm9O8KrvVDobQlQj/qq3Pn/xGiGHc5Zoozo+IrZhZqfBi2b3N/fvJpQdJNxIi2VnrSsamREhWVC/nIeKV1NS339lL7RkKFDhOZ2vsOhXzJZNa+ZFaH0NkQc2jpZoEN41I2ALoUo2K/KlM5FfNICGNtJBhw1V09Wp3ZZyJxXik02ri9/lpI+xqEY3F3yZcC+26P35kp4s8BiEHvZCRFdxBLUTmxAUj5OAUDqJ9dDMMfK55t01E5vTTg8UBBRtJGA9DlwJesPWFvgbaZ7L8RU/+1n5RrUVkv5JgNtwOq2spSt2faHiM+2vh98RXc52YH199KNdEV+5TGAYZIUQXxMNSU/uFAga2JLqvOkoTHV5EvIEYUnQxSHdxpI+XdD5EMLeU8G4d90tiKcTayZC7zyZwegzbDKzyyJN0CNQgAuBI0YXRbGXPrXqX4ZPA9jrGgRFw3npsZtuaFZbszJ1rgDVam5EUSM8ZFaoHPIU7c4jjATrbQUiqhuAeHtJ3LfkxZIg4J751E7gaOHrnCmSXN/7at5AvU9YbdGpo5ZW9jvFeP+EnlyrxO1XRI3ohUNESNoZwerJ4KFVFkjiaW4K2H3+RpwLesHyB6p01AocZHsINKlhXD9YLWFPg9yA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(64756008)(5660300002)(66446008)(4326008)(66556008)(52536014)(86362001)(83380400001)(53546011)(6506007)(7696005)(33656002)(186003)(6916009)(55016002)(8676002)(508600001)(66946007)(8936002)(107886003)(19627235002)(122000001)(316002)(2906002)(38100700002)(71200400001)(26005)(54906003)(966005)(76116006)(38070700005)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?t3CRmDYEuvrtz91aD1EaKwQBfPKX4AsEP3nYV7ZFnWZdaQEhO41Uk93gaHyM?= =?us-ascii?Q?XyS1bc++GgxDTOhymTD0jGBux8S0E28GbORaUE44CdXB6g+nafUGtLAU3aVy?= =?us-ascii?Q?qTJaj+kRO4DyZ2CXXw9QFBfZdSCLWChFzCQcwrl6Jcj4QQqjdh210emZsUYI?= =?us-ascii?Q?KwPXtM3UjTzfUy1owl9z6G4v/3LabI/sdX0Nt1ovCCW28L334a1Ghk0Vd4G+?= =?us-ascii?Q?ner5zOUzFZLD6FE+aeYlS1WTK1Gl7CPjbylF4REPRKhVmoibfNs71SdsnXBu?= =?us-ascii?Q?mNAH5Q0O9dczkO6oq28dilgTC+JynPxYvWMpjFXGP3YtldXR4DYN/E284J4u?= =?us-ascii?Q?fbJhDj4gydtYRoR2PBJoqDQ5V36FBweswEEIXUphUzuJ4B7cNSi1fFNnre8r?= =?us-ascii?Q?lj182JcZ6+85WacOH4kKay2XMtt2yrme3k3ZNNFgv7h8TIJj7KoNuzp3ukkN?= =?us-ascii?Q?3//He62l1stjkXCY+VI/pxehikOUYthhDYYgAX4ecQKKPyhDY4pBy/Nly//c?= =?us-ascii?Q?fRKHdJJJNO0mxDoTtQpNbLVUAfuIKzPCcx10KHjBKm6B7E95azMLNcnoCxKC?= =?us-ascii?Q?r2+EDGZTXFOAdWi+6a6nNb+K+Rk/XPDMa4O3XTkQxDOUvZCcpSeP9RycsUDw?= =?us-ascii?Q?fjzMwnhRd6ucQusOvwbr4hkMRfBEPdpr/PQu9RMf1J/nv2+uk1uVw9u6xbMT?= =?us-ascii?Q?909U/kB1pTG2jdgmDYphI0SI3cK9kn9eCTB28DA/y2nPB0JTl2lkHr20IERH?= =?us-ascii?Q?omG0lpXxygECMM68Oi2FIL5bbqNnqa0Ujne6NGUsjTHvco2HwyUOxsw54Ipo?= =?us-ascii?Q?dI72tMtZ5bofA7hB05SPVWAb+nnaAGSjok0Ift3MxNe37g6lb9LveV68O139?= =?us-ascii?Q?88m1PmCgPtzGXUqdq5LIwzjl13HnqOcjSnDHiztxUwTdLYbcwFWarfEyTxzv?= =?us-ascii?Q?jsx/NGnMl+AtK9x4JJcjKx7Y3alNK9W/8ipsJFy66mrAzpaOVLzdzOOoOUWw?= =?us-ascii?Q?Kn9/zyBx251Kh6/vSBvUWiEB2QtHW7qfIeKN0Qf/2DYyKWojyCftFWmMn7l2?= =?us-ascii?Q?KcIacosY3R8XtnFSJjrzFkOsjLO92yFHxdpZyKbV2yKRac/x5Hnp9TyDS+Sf?= =?us-ascii?Q?pXYhPL6WE178MRofsrxsB8Djc6CJGufaSKoNTDTdWy88B7CZaCIlPLnXl3tI?= =?us-ascii?Q?UOVecGy6SYqpqZQf1MT8Xp3qDTjZaEBAMIyunAzxALHrkZrSvAm3dInbKnSQ?= =?us-ascii?Q?hL9IChgZKDlawCb3pH6PF4zCBqrmb/B/VR+U8z6IuwJh4yxVI20Osgz9gu7V?= =?us-ascii?Q?+hY=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b0a5aec-2aba-40d1-c1ca-08d986d3b536 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2021 01:10:08.5006 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: P1LD5dQHmDa6F1YBgunBOmyvnnf7vsyhOJrttHP5lFuqJuBz0Jj7VttcnkgSYBXikl6K9uhn1ravQ0YxR1nq4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1859 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Patch pushed: https://github.com/tianocore/edk2/commit/4cc1458dbe004b1d7053= 4caa55f475f6d19fe14a Thanks, Chasel > -----Original Message----- > From: Chiu, Chasel > Sent: Friday, October 1, 2021 4:29 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Ma, Maurice > ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH] IntelFsp2Pkg: Adopt FSP 2.3 specification. >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3674 >=20 > Add ExtendedImageRevision in FSP_INFO_HEADER structure, also add > FSP_NON_VOLATILE_STORAGE_HOB2 header. >=20 > Cc: Maurice Ma > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Chasel Chiu > --- > IntelFsp2Pkg/Include/Guid/FspHeaderFile.h | 33 > ++++++++++++++++++++++++++++++++- > IntelFsp2Pkg/Include/Guid/FspNonVolatileStorageHob2.h | 27 > +++++++++++++++++++++++++++ > IntelFsp2Pkg/IntelFsp2Pkg.dec | 1 + > 3 files changed, 60 insertions(+), 1 deletion(-) >=20 > diff --git a/IntelFsp2Pkg/Include/Guid/FspHeaderFile.h > b/IntelFsp2Pkg/Include/Guid/FspHeaderFile.h > index 3474bac1de..11e0ede65b 100644 > --- a/IntelFsp2Pkg/Include/Guid/FspHeaderFile.h > +++ b/IntelFsp2Pkg/Include/Guid/FspHeaderFile.h > @@ -2,7 +2,7 @@ > Intel FSP Header File definition from Intel Firmware Support Package E= xternal >=20 > Architecture Specification v2.0 and above. >=20 >=20 >=20 > - Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.
>=20 > + Copyright (c) 2014 - 2021, Intel Corporation. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 >=20 > **/ >=20 > @@ -44,14 +44,28 @@ typedef struct { > UINT8 Reserved1[2]; >=20 > /// >=20 > /// Byte 0x0A: Indicates compliance with a revision of this specificat= ion in the > BCD format. >=20 > + /// For revision v2.3 the value will be 0x23. >=20 > /// >=20 > UINT8 SpecVersion; >=20 > /// >=20 > /// Byte 0x0B: Revision of the FSP Information Header. >=20 > + /// The Current value for this field is 0x6. >=20 > /// >=20 > UINT8 HeaderRevision; >=20 > /// >=20 > /// Byte 0x0C: Revision of the FSP binary. >=20 > + /// Major.Minor.Revision.Build >=20 > + /// If FSP HeaderRevision is <=3D 5, the ImageRevision can = be decoded as > follows: >=20 > + /// 7 : 0 - Build Number >=20 > + /// 15 : 8 - Revision >=20 > + /// 23 : 16 - Minor Version >=20 > + /// 31 : 24 - Major Version >=20 > + /// If FSP HeaderRevision is >=3D 6, ImageRevision specifie= s the low-order > bytes of the build number and revision >=20 > + /// while ExtendedImageRevision specifies the high-order by= tes of the > build number and revision. >=20 > + /// 7 : 0 - Low Byte of Build Number >=20 > + /// 15 : 8 - Low Byte of Revision >=20 > + /// 23 : 16 - Minor Version >=20 > + /// 31 : 24 - Major Version >=20 > /// >=20 > UINT32 ImageRevision; >=20 > /// >=20 > @@ -116,6 +130,23 @@ typedef struct { > /// If the value is set to 0x00000000, then this API is not= available in this > component. >=20 > /// >=20 > UINT32 FspMultiPhaseSiInitEntryOffset; >=20 > + /// >=20 > + /// Byte 0x4C: Extended revision of the FSP binary. >=20 > + /// This value is only valid if FSP HeaderRevision is >=3D = 6. >=20 > + /// ExtendedImageRevision specifies the high-order byte of = the revision > and build number in the FSP binary revision. >=20 > + /// 7 : 0 - High Byte of Build Number >=20 > + /// 15 : 8 - High Byte of Revision >=20 > + /// The FSP binary build number can be decoded as follows: >=20 > + /// Build Number =3D (ExtendedImageRevision[7:0] << 8) | > ImageRevision[7:0] >=20 > + /// Revision =3D (ExtendedImageRevision[15:8] << 8) | > ImageRevision[15:8] >=20 > + /// Minor Version =3D ImageRevision[23:16] >=20 > + /// Major Version =3D ImageRevision[31:24] >=20 > + /// >=20 > + UINT16 ExtendedImageRevision; >=20 > + /// >=20 > + /// Byte 0x4E: Reserved4. >=20 > + /// >=20 > + UINT16 Reserved4; >=20 > } FSP_INFO_HEADER; >=20 >=20 >=20 > /// >=20 > diff --git a/IntelFsp2Pkg/Include/Guid/FspNonVolatileStorageHob2.h > b/IntelFsp2Pkg/Include/Guid/FspNonVolatileStorageHob2.h > new file mode 100644 > index 0000000000..8c07dc7e7e > --- /dev/null > +++ b/IntelFsp2Pkg/Include/Guid/FspNonVolatileStorageHob2.h > @@ -0,0 +1,27 @@ > +/** @file >=20 > + Intel FSP Non-Volatile Storage (NVS) HOB version 2 definition from >=20 > + Intel Firmware Support Package External Architecture Specification v2.= 3. >=20 > + >=20 > + Copyright (c) 2021, Intel Corporation. All rights reserved.
>=20 > + SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > + >=20 > +**/ >=20 > + >=20 > +#ifndef __FSP_NON_VOLATILE_STORAGE_HOB2_H__ >=20 > +#define __FSP_NON_VOLATILE_STORAGE_HOB2_H__ >=20 > + >=20 > +/// >=20 > +/// The Non-Volatile Storage (NVS) HOB version 2 provides > 64KB buffer > support. >=20 > +/// >=20 > +#define FSP_NON_VOLATILE_STORAGE_HOB2_GUID \ >=20 > + { 0x4866788f, 0x6ba8, 0x47d8, { 0x83, 0x06, 0xac, 0xf7, 0x7f, 0x55, 0x= 10, > 0x46 } } >=20 > + >=20 > +typedef struct { >=20 > + EFI_HOB_GUID_TYPE GuidHob; >=20 > + EFI_PHYSICAL_ADDRESS NvsDataPtr; >=20 > + UINT64 NvsDataLength; >=20 > +} FSP_NON_VOLATILE_STORAGE_HOB2; >=20 > + >=20 > +extern EFI_GUID gFspNonVolatileStorageHob2Guid; >=20 > + >=20 > +#endif >=20 > diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.dec b/IntelFsp2Pkg/IntelFsp2Pkg.de= c > index ec7b9a7702..58eac7220d 100644 > --- a/IntelFsp2Pkg/IntelFsp2Pkg.dec > +++ b/IntelFsp2Pkg/IntelFsp2Pkg.dec > @@ -68,6 +68,7 @@ > # Guid define in FSP EAS >=20 > gFspHeaderFileGuid =3D { 0x912740BE, 0x2284, 0x4734= , { 0xB9, 0x71, > 0x84, 0xB0, 0x27, 0x35, 0x3F, 0x0C } } >=20 > gFspReservedMemoryResourceHobGuid =3D { 0x69a79759, 0x1373, 0x4367= , > { 0xa6, 0xc4, 0xc7, 0xf5, 0x9e, 0xfd, 0x98, 0x6e } } >=20 > + gFspNonVolatileStorageHob2Guid =3D { 0x4866788f, 0x6ba8, 0x47d8= , { 0x83, > 0x06, 0xac, 0xf7, 0x7f, 0x55, 0x10, 0x46 } } >=20 > gFspNonVolatileStorageHobGuid =3D { 0x721acf02, 0x4d77, 0x4c2a= , { 0xb3, > 0xdc, 0x27, 0x0b, 0x7b, 0xa9, 0xe4, 0xb0 } } >=20 > gFspBootLoaderTolumHobGuid =3D { 0x73ff4f56, 0xaa8e, 0x4451= , { 0xb3, > 0x16, 0x36, 0x35, 0x36, 0x67, 0xad, 0x44 } } # FSP EAS v1.1 >=20 >=20 >=20 > -- > 2.28.0.windows.1