From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.12188.1679701940347279860 for ; Fri, 24 Mar 2023 16:52:20 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=eBe0913a; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679701940; x=1711237940; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=S8v0K7o8EBxQBhrlUEeoUPWwyGXP84NETvYGQoR4LpY=; b=eBe0913aAcehPnx6t7x6kV1rpdbOGjdETSzUfVEGrZzSs4rO3Mr6Chls P0bWSemSoAIhINee5j+gf63KkjoohrtLlt5rd8weokNGhApcW0oMGgBBy fKybEXjZkdMjUnRj1znKVBkWqlCnrtf4xqFp95auYxDlDoGW/ONqeAI2e q8GzY9UZjGfaS4CQfg7yiXoPjMitDCSUU3uiYSDUy/ehfbQFHtStZW19x G6SlkV/ox8g9epHzoqrKh+ytGIHKB82e4gePOxg2GLTUIw77/6DSh9DRy FgPVk6KDxSUfOvvA3kaaLd3em6B5Z15yEaLNhKW/0Wfvf6UGNEbcXx+4F g==; X-IronPort-AV: E=McAfee;i="6600,9927,10659"; a="342306152" X-IronPort-AV: E=Sophos;i="5.98,289,1673942400"; d="scan'208";a="342306152" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2023 16:52:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10659"; a="928839168" X-IronPort-AV: E=Sophos;i="5.98,289,1673942400"; d="scan'208";a="928839168" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 24 Mar 2023 16:52:19 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 24 Mar 2023 16:52:19 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Fri, 24 Mar 2023 16:52:19 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Fri, 24 Mar 2023 16:52:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X22kY2yqwVqt1MOiFaplhb1bFzQmlJ6jkPSe2A7b2FuvyKsCF6I6UXTabdc/aYuBsbK2bOEEVroVY4VTAidgI/EH4p+zQB/OiWgnCE5m6IZA36Lk9Gd4qhcDDG8cTuGuRowQjko2xOnY5FL5caZkDxbORCAT7iTQdNLC7+tH9+92ZNCEFIfXBIYU8SOiAw4dUs+5cwBMtFBXYZ9k7BDTkUEeEbSdpF3jFKFmqAzT6djBPkWoTh5KJtMauzp6dPk6pDVSfMVMLIWrBITwSF3XR6T1SkvHKh2wclk2J7oHiqJIDAQctszPbWDcpu2V+2Fz2LtVdrUJUu6k1nKodZFbZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2W7y+qp8OHZCV1n9vReDNrAbwuRx0YtVAKBPvE2UrB4=; b=evUkfK3YWiV6LFfIomZa/Zh7bK5+XBG7UBi3mnrQYF5uTWGvkZS7PZ5Or9ZkpDwaTOLdEVCU0AEn32chSwjHrEXvCVJiT5Pw7MvUib72dgiH4mFh/PG41WZj7zgRsQezK/6ewUD/oSdIgftDg7i+Y8r6utBQq4TkwTIkMe5DO1V2SFmr/RQ2dmGjR8AeizEW4ympOBLqFOH6YPLCwkECoZl1OQYvogySHFreBNQLA0AG+IJh83YFltDtsCz/PZzJXWVDcJa8lifUt6cnxEMOUSEm8eqOxURlqyu69t8NJa+mnnn/6rl0/x3Vph85lp8d8rpuqrqLNam2SxcjNRLr0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by DM4PR11MB6336.namprd11.prod.outlook.com (2603:10b6:8:b9::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Fri, 24 Mar 2023 23:52:16 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::af70:de56:4a6f:b2cc]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::af70:de56:4a6f:b2cc%6]) with mapi id 15.20.6178.040; Fri, 24 Mar 2023 23:52:16 +0000 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "Chiu, Chasel" CC: "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [edk2-devel] [PATCH v3] IntelFsp2Pkg: Fix NASM X64 build warnings. Thread-Topic: [edk2-devel] [PATCH v3] IntelFsp2Pkg: Fix NASM X64 build warnings. Thread-Index: AQHZXFNKPXPLbZtLZ0SvIktX0+gSL68KnpCg Date: Fri, 24 Mar 2023 23:52:16 +0000 Message-ID: References: <174E957ABDBD6AF4.22739@groups.io> In-Reply-To: <174E957ABDBD6AF4.22739@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|DM4PR11MB6336:EE_ x-ms-office365-filtering-correlation-id: 0e4b715a-44f3-4d24-c770-08db2cc2cc3b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: q1B+7yU4Y1LpCTMtcYP/xywGZi/BU0k3/a/M7ryZ4IvP8PoQl6L7+MB1mVvmDalaHxg3ZWzvXqz7U+fvu0U0S2t6rh8WIavDz1DLNWjWcgwNH17jy9vDn0PVG1yN7loE/gsxSlN7YC8Orn39JfK8QcCAvmnY/ADQR8klOGnrJbz9hXzuHUld4nXe6pL5BY6pratCq/SO7NtprF2MDOiXGv2MjHizMtkaQ/hbOn4rGSr8WcoFEf5b1fqxOyUz7UrB9iGlEFtK5vgWpLn+VBBALXqYkfEy5nTf5LzEs3Hd+Xdn1qjMHX5lowSQIQndIpdXMIM3dVO104SeK31703CGNRlogeRHzXhRogu0MqiLuusYwXblkTsnILfHRj/f+1OZPlDj/7AkoG4zMKqsbAZS+OnPsIKUBEJFE3PSyJCS06o92WkphCsZpJvbddd3VnzLt/AUwmbEEJObI3tVK5cw88RdaLgwGzDRfDmUU8Qnpytf3IemcM12e/Xh9VZvRUH/pXbPXfi3WxeSknuVJ9ZWfxkK+LIOepf2XjQnagWxsDyk0p/r0RAhV4rHwev5jiRtOpY+Q7o19FIdvFJqr/BeyQnfTBR9e9L+dzCW4maM9OeYCcjstUJAQNyVKr+u6PKqxAg5gZDjYgGIOyjfvd0AmQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(366004)(376002)(136003)(396003)(39860400002)(451199021)(966005)(66899021)(2906002)(82960400001)(66476007)(66556008)(38100700002)(4326008)(107886003)(19627235002)(64756008)(83380400001)(76116006)(66946007)(52536014)(54906003)(5660300002)(122000001)(41300700001)(110136005)(8936002)(53546011)(26005)(7696005)(6506007)(55016003)(38070700005)(8676002)(86362001)(33656002)(316002)(71200400001)(9686003)(478600001)(66446008)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gxdGLfzlBoJQGjoPZsN0jxvbw8oyH59aSqLZeMJ+BIDdgB4QztsaCDsy0HJe?= =?us-ascii?Q?LQPhEtBvxvWgQtw3YHF9p2mxpWMd28pcDvIRR5nstD+VECuPikHcVm4Wm84/?= =?us-ascii?Q?V+yx4tM2DGBtV/FuOqJ8aZKyoBlJjXTWujj9UizqWDAC5o103lnjfjycettz?= =?us-ascii?Q?sjU6BCBSR9kyKi/jnJUITWaxcfkbWGU+uQqvNNlPqmylUxIstk1fzRbs9WdB?= =?us-ascii?Q?HI/5szlGSye/BJFUbDuXQFAyrLlquj6iqT4Labk2ItZ9XNmr+RtVyUql1B5P?= =?us-ascii?Q?7ymQk6ZxSvetJ2HAZeNeQtrMJQFxIvfDYi33XshTJ6dXT+9Qp5rmyPc/MGkI?= =?us-ascii?Q?89R4N5ITzHlJmF3mHJons/9Qe0v9mXunZ/+sGJBTVx5LH6TVXfKnlW6k54Q0?= =?us-ascii?Q?OahmUlWWqm0HHu+7mWWdzSeEPEYShZ7nxgn9VS8yKb9TwPPHCn1TiI9GEiMX?= =?us-ascii?Q?BElj7SRpxpEB3CXjYDBHrJeZMJPaVf/pSgwHIZ3Y6AIujsLvaSz5Ap1Ci0nb?= =?us-ascii?Q?omIi86GYVIN29p+2hQBgvRCHGJiobpp2O5A+azWPUaZa1mehLtL8yyCXxB0F?= =?us-ascii?Q?h7Ah65GStqCwoHaPOPSN/hb33DPRuu11wO5afJml0umlNJEdQv8nTioDQg48?= =?us-ascii?Q?Km0079C77f8aQEmks+l4VwwhImsOuu616u/BSVkbq/F1ufgMW29T3kNDb75b?= =?us-ascii?Q?A9flhzczABtsB9+PAZ9n/Sng9r4kFvwerbn0Oe18/ZJlqv0gjrmsEKqJm9oQ?= =?us-ascii?Q?y1LaLCy/zIyAMD5F/D+I8sHm2EIyuZIqR0HNnxFsHtyMCB0tvhZTXGqyNVIx?= =?us-ascii?Q?lhmP5P5bkjeBL9BfvALGeswd1mvF5H8jj0nddKXwBNWnvhwSYJxmFOGeEFa1?= =?us-ascii?Q?YKEcI/sC12OIhGged0K8WJ8JSylph8WEGyB4LKz6F0X14CPtAyt85Ikf4rfB?= =?us-ascii?Q?A5gIcJ5A6DwztOjOR1rzwT7ZwhqU2BuC+k72uWgQbTZ8ZqnA2Jx6syP3yccj?= =?us-ascii?Q?gdcjAbJKEhDd/nvpUKhvD/eUXJ9yKAVujL5wD5EcRVMCI6UxYgVxkyl+mKVs?= =?us-ascii?Q?0XwliqXBLZaXSHRSFL9yKSBbrUfEf7kw32sXbHCQ6CbvsDLng1bv+2SUei3Q?= =?us-ascii?Q?n/8Du5x8D2MSZ4kuArc1KOy0TZKNikJ8q/nhkpoyAJl6AHwqUCSWFjz0heyx?= =?us-ascii?Q?BCGGghxk5aUdl/6HVv3rprbZAvs7ovsDaoV3M+cbJcZkmU2l3naSr8pBnIQg?= =?us-ascii?Q?ScIoOnax+iW42oFSuUlEX2s7C19vCzq70Y0pFwEmslqH1boM+AE+BcbLGXlu?= =?us-ascii?Q?wmP6r+W/rHbyQsd0H3kOSnaf/MhB5SuWPJ/Z+IxA6oANsphufAA2NHScxk5S?= =?us-ascii?Q?XoC0xOXfQI7Rwm0/JwihILTYToACf5NPAzA57BK/9v3mMfjKV6go9r4e+4Ke?= =?us-ascii?Q?4crG+/UL45z6M6rFAB+CnBCIogJXRSXptdMiizYz/sbxQYeMs79N8JyUtH5b?= =?us-ascii?Q?59P4Fjxle+4IqKB1CIk/dAdU+5nJVayeYo7/T71/27SWcvAGK56sGK0rN1aL?= =?us-ascii?Q?fTVJ4VzyYvMhSEDnQqt/z4x5le0fD5CNOTtn3UeW?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e4b715a-44f3-4d24-c770-08db2cc2cc3b X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2023 23:52:16.4648 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wAxkWHqu2LQQGJsyTkvgGcMVOi+NUIv5eZpEJLSHxB0RrUKssbWt/Tr3J0ZMsRC1K8wC39QBP00HdV+5MoKoXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6336 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Patch merged:=20 https://github.com/tianocore/edk2/commit/f6bd3286edfbe5eb6b50946cc8bb89e5c6= 0b9388 Thanks, Chasel > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chiu, Chas= el > Sent: Tuesday, March 21, 2023 5:14 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [edk2-devel] [PATCH v3] IntelFsp2Pkg: Fix NASM X64 build warning= s. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4377 >=20 > Fix below warnings generated by NASM X64 build: > /X64/FspHelper.iii:26: warning: signed dword value exceeds bounds > /X64/FspHelper.iii:35: warning: signed dword value exceeds bounds > /X64/FspApiEntryT.iii:320: warning: dword data exceeds bounds >=20 > Also replaced "cmp reg, 0" with "test reg, reg" per optimization suggesti= on. >=20 > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Chasel Chiu > --- > IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm | 18 +++++++++--------- > IntelFsp2Pkg/FspSecCore/X64/FspHelper.nasm | 2 -- > 2 files changed, 9 insertions(+), 11 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm > b/IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm > index cdebe90fab..b32fa32a89 100644 > --- a/IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm > +++ b/IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm > @@ -135,9 +135,9 @@ ASM_PFX(LoadMicrocodeDefault): > ; LOAD_RBP - cmp rsp, 0+ test rsp, rsp jz ParamErr= or- cmp rcx, 0+ > test rcx, rcx jz ParamError mov rsp, rcx @@ -151,13 +151,1= 3 @@ > ASM_PFX(LoadMicrocodeDefault): > ; UPD structure is compliant with FSP spec 2.4 mov rax, qword = [rsp + > LoadMicrocodeParamsFsp24.MicrocodeCodeSize]- cmp rax, 0+ test ra= x, > rax jz Exit2 cmp rax, 0800h jl ParamError mov = rsi, qword [rsp + > LoadMicrocodeParamsFsp24.MicrocodeCodeAddr]- cmp rsi, 0+ test rs= i, rsi > jnz CheckMainHeader ParamError:@@ -315,9 +315,9 @@ Done: > mov ecx, MSR_IA32_BIOS_SIGN_ID rdmsr ; G= et current > microcode signature xor eax, eax- cmp edx, 0+ test edx, edx = jnz Exit2- > mov eax, 0800000000000000Eh+ mov rax, 0800000000000000Eh Exit2: > jmp rbp@@ -464,7 +464,7 @@ ParamValid: > ; Sec Platform Init ; CALL_YMM ASM_PFX(SecPlatformInit)- cmp = eax, 0+ > test rax, rax jnz TempRamInitExit ; Load microcode@@ -476= ,12 > +476,12 @@ ParamValid: > ; Call Sec CAR Init LOAD_RCX CALL_YMM ASM_PFX(SecCarInit)- cmp = rax, > 0+ test rax, rax jnz TempRamInitExit LOAD_RCX CALL_YMM > ASM_PFX(EstablishStackFsp)- cmp rax, 0+ test rax, rax jnz > TempRamInitExit LOAD_UCODE_STATUS rax ; Restore microcode = status > if no CAR init error from SLOT 0 in YMM9 (upper 128bits).diff --git > a/IntelFsp2Pkg/FspSecCore/X64/FspHelper.nasm > b/IntelFsp2Pkg/FspSecCore/X64/FspHelper.nasm > index 71624a3aad..32a60270b8 100644 > --- a/IntelFsp2Pkg/FspSecCore/X64/FspHelper.nasm > +++ b/IntelFsp2Pkg/FspSecCore/X64/FspHelper.nasm > @@ -23,7 +23,6 @@ ASM_PFX(AsmGetFspInfoHeader): > global ASM_PFX(FspInfoHeaderRelativeOff) > ASM_PFX(FspInfoHeaderRelativeOff): DD 0x12345678 ; Th= is value > must be patched by the build script- and rax, 0xffffffff ret glob= al > ASM_PFX(AsmGetFspInfoHeaderNoStack)@@ -32,5 +31,4 @@ > ASM_PFX(AsmGetFspInfoHeaderNoStack): > lea rcx, [ASM_PFX(FspInfoHeaderRelativeOff)] mov ecx, [rcx] = sub rax, > rcx- and rax, 0xffffffff jmp rdi-- > 2.35.0.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#101526): https://edk2.groups.io/g/devel/message/10152= 6 > Mute This Topic: https://groups.io/mt/97768328/1777047 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.chiu@intel.com]= -=3D- > =3D-=3D-=3D-=3D-=3D >=20