From: "duntan" <dun.tan@intel.com>
To: "Gao, Liming" <gaoliming@byosoft.com.cn>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>
Subject: Re: [Patch V3 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure
Date: Fri, 10 Mar 2023 06:17:20 +0000 [thread overview]
Message-ID: <BN9PR11MB54839256D76722D3641F14C9E5BA9@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <007601d952f6$3e2efec0$ba8cfc40$@byosoft.com.cn>
Hi Liming,
I've checked edk2 and edk2-platforms repo. This code change doesn't impacted any code.
The MultiprocessorWakeupMailbox structure has not been used yet.
Thanks,
Dun
-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Friday, March 10, 2023 10:16 AM
To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>
Subject: 回复: [Patch V3 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure
Dun:
Is there any code impact with this change?
Thanks
Liming
> -----邮件原件-----
> 发件人: Dun Tan <dun.tan@intel.com>
> 发送时间: 2023年3月9日 11:40
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>
> 主题: [Patch V3 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in
> MpWakeupStructure
>
> modify the wrong 'AcpiId' to 'ApicId' of MpWakeupStructure defination
> in Acpi64.h.
>
> Signed-off-by: Dun Tan <dun.tan@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
> MdePkg/Include/IndustryStandard/Acpi64.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
> b/MdePkg/Include/IndustryStandard/Acpi64.h
> index fe5ebfac2b..bfd022b6b6 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi64.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi64.h
> @@ -607,7 +607,7 @@ typedef struct {
> typedef struct {
> UINT16 Command;
> UINT16 Reserved;
> - UINT32 AcpiId;
> + UINT32 ApicId;
> UINT64 WakeupVector;
> UINT8 ReservedForOs[2032];
> UINT8 ReservedForFirmware[2048];
> --
> 2.31.1.windows.1
next prev parent reply other threads:[~2023-03-10 6:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 3:40 [Patch V3 0/2] Modify defination for MpWakeupStructure duntan
2023-03-09 3:40 ` [Patch V3 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure duntan
2023-03-10 2:15 ` 回复: " gaoliming
2023-03-10 6:17 ` duntan [this message]
2023-03-23 1:16 ` gaoliming
2023-03-24 8:52 ` [edk2-devel] " duntan
2023-03-09 3:40 ` [Patch V3 2/2] MdePkg: Add define for MultiprocessorWakeupMailboxStructure Version duntan
2023-03-09 7:05 ` [edk2-devel] [Patch V3 0/2] Modify defination for MpWakeupStructure Ni, Ray
[not found] ` <174AA33E822F73AE.24021@groups.io>
2023-03-23 3:06 ` [edk2-devel] [Patch V3 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure duntan
[not found] ` <174AA33F258FCD3B.23432@groups.io>
2023-03-23 3:06 ` [edk2-devel] [Patch V3 2/2] MdePkg: Add define for MultiprocessorWakeupMailboxStructure Version duntan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB54839256D76722D3641F14C9E5BA9@BN9PR11MB5483.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox