From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.47644.1681314997920628084 for ; Wed, 12 Apr 2023 08:56:38 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=HHl+vE/X; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681314997; x=1712850997; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2w43s5Z5zzYwwORDNZqd9xxCwpkVJ8bTB8XB4KI7kzg=; b=HHl+vE/X0FThKup8BfGr8C+DBXDFKbaFXqivwP1eJ9lg3RMrFwFXvU+o z0yQXWW80X9e9M06zguBVvBN9oAOZz3VU2vTg9M9oyFx88ilohZ6RuBZt i0LNslvys95Krcslk+qO3/SJ9KgVDhkH5BgDcLxSPWo5w8kuAc5cS8Jw0 2xwbfu6AGNeEOD6wzRmGt86CuCGeEfFVpih5oOd+7l8fwvuvVMUXQ2QBx waW1OgSXovFxH45AiofsF07L8/V1SYFWHD3b9MJeLteKAD4fSpYxuaA62 Xq7u3uRXqV8TJpRD8dZXeJsGTUKPFo5bNozqcdmCrB/6rAZZYMib6Q/VI g==; X-IronPort-AV: E=McAfee;i="6600,9927,10678"; a="332637057" X-IronPort-AV: E=Sophos;i="5.98,339,1673942400"; d="scan'208";a="332637057" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2023 08:56:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10678"; a="639275474" X-IronPort-AV: E=Sophos;i="5.98,339,1673942400"; d="scan'208";a="639275474" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 12 Apr 2023 08:56:36 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 12 Apr 2023 08:56:36 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 12 Apr 2023 08:56:36 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 12 Apr 2023 08:56:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b50lQoaybtW6QCFkrfuJVukI9ANhvnLv5EQYIEia6J9xILXrPoPp5WO2uKqb3fiajCgO5+CP8JGJ/O0ZRB17MmhR5vWD5uiOO5APCJvQk/UJbtpgA2tU0098PuFlt56Hyzsl90+6eTZcDQITtRQWfGiZ6h5w4lNOvETkvRZHwNU3iCEw3E/tXaBxNmrcWr5AWZhJoL20QqOt5wsrMWkqPzq+6w5nX3oDXjscMm23QiuO3o/IL2vu+HcGpmgimLcLc7U8kYOF7G/MIfNexZPl1VylAN7xBuzs0bidt9RrePegDGUqOb6hZaXopSoLg215xO7sNSQkev69Pzek6+ngqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RZ1kcte/OMUGE96xfnMj4e/sgsGF3RdYjz/bw9mZy8o=; b=QcMMdM2h5WNXK5YRnQnWuq/6qpcUTKjYSx7iVeJlzorconyCpemxx+i3NM9Ld96xUN2Ny+BoMvZzOKe7XEn7NbwdKZWTdQqm4sxwXJRq3QcMqmUJ5o6mQ9oTwPtRyapI9Br7lOLLjNm7gS2LWcyIK+jU/qP/z9rPgZR8N7CzWpLjA1Fz4Ptu8MMsBnR0ez6nu49R05phi20KIFJEexkGTxv/MeOH8U5o+tFGIkRVn78M9eZzHJXsVOakNoZbjl8sRaEuRfoy1PjF1N7prX7LDdvKNtwIp79niWykyG+mDwvGFpfv4CSd2iWDgXi0bl7/eLVa5t4ftrI7SX+sd6FOqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by SJ0PR11MB5087.namprd11.prod.outlook.com (2603:10b6:a03:2ad::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28; Wed, 12 Apr 2023 15:56:33 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::1eb1:2222:1823:8e7a]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::1eb1:2222:1823:8e7a%6]) with mapi id 15.20.6277.038; Wed, 12 Apr 2023 15:56:33 +0000 From: "Chiu, Chasel" To: "Chen, Aryeh" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Oram, Isaac W" , "Gao, Liming" , "Dong, Eric" , "Sinha, Ankit" Subject: Re: [PATCH v1] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package. Thread-Topic: [PATCH v1] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package. Thread-Index: AQHZbTDb5gPATAUgeEq6eI/5/CYCfq8n0ehg Date: Wed, 12 Apr 2023 15:56:33 +0000 Message-ID: References: <20230412112021.1016-1-aryeh.chen@intel.com> In-Reply-To: <20230412112021.1016-1-aryeh.chen@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|SJ0PR11MB5087:EE_ x-ms-office365-filtering-correlation-id: c94cfd21-d7fb-44dc-3cda-08db3b6e7ce1 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iZ72FMILmvIxScrl1E1ZP2lG5m9TLoZ/lKl4V8WuV0+nJKp/aiIjVu40XaXW71icRREZVUoCsS91YlXCzi6VQDc3a70P02sjPBw31+/jxmsO4+IHtveese8rQ2mi/TJC/iahvcpJtNf41v0tB/WqWmPsPbrcb9ZNCPpyDngzC6rJeRslNCGaBWNCFwpHFAQnHH+U6e/8+9y+h7O7takcNaj/8WvxCopILJO7yt7rD6mpoddbFSYMD7GjahhYJsZ+2OVC1oc6t97pGc0O/wkXhFW34MLZfzALh+G56q4MNJI/cIwBPfm84V7h96jie1uCXlxfaryBE7DqW1MbprTm8vjl/WCa2EgBDD2dIjoxrkwqB6Tx20Iah4UEZAMvIRJsFARLzC6IXCxLrpHuZkMkLVL+dkNseJaBUy0nGVE3Vb0fE8tGHhvPfbaOSD8sk8oJodysSHkaDw5RNvVisFW8P3NIHlRKxKtJDMse/IaDM3818OWUuvtUQg8b3in5qGZqe3wSkJr3faV1WP8yPLEeSCRdBQmPflp9YhRvjraV83WxgNiHw3K18qUbbXTEhCy190TxpXUkbcys5b4wzS9ryeeh8uPw8eqfs3+lrMLsev8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(136003)(346002)(366004)(376002)(451199021)(64756008)(82960400001)(9686003)(53546011)(6506007)(122000001)(38070700005)(107886003)(26005)(38100700002)(83380400001)(186003)(33656002)(8936002)(7696005)(41300700001)(316002)(71200400001)(4326008)(8676002)(5660300002)(52536014)(86362001)(55016003)(2906002)(15650500001)(478600001)(66476007)(110136005)(54906003)(66446008)(66556008)(76116006)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?c/CV0rNKkq0bsbP1iyZnBnvsl1DihD+3gblsyk8BZmwIEvbvHw2QdlUxvlxQ?= =?us-ascii?Q?KpiuNeuLRboyiB4GhBDUpQK3HdrqqJ83ZgtVx3300s+mvZHz+hsE25boylGa?= =?us-ascii?Q?wnSxUyk5jqyJw4X1v4LwEjSmPsMMp6o61nI7BTjck3g5psHmb0vmzn6Sdw/7?= =?us-ascii?Q?x3Fp55T+vt0xiHNvO6oAWv6E2uxGhsVJRYbJv1c2NYGTLSyIFQLN4O+IxbQe?= =?us-ascii?Q?uqjsXuVzI7A6O2SWfnpr7cOY3W7SO29E8S5bEPj8R8MYvvMS1Eg05vSR5OG8?= =?us-ascii?Q?STxNZvQx9RYsOquDjXf4rBQy9xzta9LRZPWXAyDjsXQzCX0DjeuRHGZ+gO8Z?= =?us-ascii?Q?sCMMf2bZnYXxEhRCDyGtHmCppz1cA+OJNBnOlVcIECh3hrnus82LxQ+9rQ+O?= =?us-ascii?Q?Z4F4O/s3jvR6mz5XRKo/8JH75c1gH7DE83SRzFnwVESJthSpVABqwF4tliq6?= =?us-ascii?Q?JVNd9iCQnnyKwJV6JQRp20sKql4oTnnGzvuufplMROcYzzYCrBM8AUXgJ56D?= =?us-ascii?Q?+q/EW4baqMTpVMXOFF5N6DUNkuen48ntX/sgHx0+jxSO6zG10Zb69KHIaP2w?= =?us-ascii?Q?M95wEcPHH9gW9ZXubd0MH0QXSYDTLxdB+7DnL93xkybp1sBF7OQLN4sbO0dc?= =?us-ascii?Q?lDb3+66wPXL+nzh+WD5kKKZ1qRhTSBy2+aAUvONoPqW4jJrAyVAoIF8us/er?= =?us-ascii?Q?Y2Woao4PYijWa608ZjaUbJunnCLmEjQrlZSUF6xhai9OcR36X392MtVVGHQT?= =?us-ascii?Q?Q03E2lWxLZ8TdtNHCcE5x/UN+9PU30doPj1kifdYPampNhYPOPVZCuRgwIqe?= =?us-ascii?Q?zK0fEUdMcymA5QW9t8X1MPdZVEYb4jRges8xuGMbfjRPbPWIwlXFOj5kTm/m?= =?us-ascii?Q?FQCc90QjDRspyFGYDEkYWPCRulOMS4cV2j1LcMHTS8JAGjSwhEPHGOJUwCCj?= =?us-ascii?Q?uoKu+0PFS4TN8ug7e79OQsjQY0ikM6jDSRAXmLve3B0A+pCYkd5THF4Cuhy3?= =?us-ascii?Q?uXs9DZtHct0OC31i9jJsZEwhJd5XYDtOubeimfirKbOgSzj+Gn8w2/NDiYZ2?= =?us-ascii?Q?2TuDASHjsSgU8/fKjZG3qiXJRC0Hqe+CjQMpFOliaQAMRZ+BqlVfHR+lyD6X?= =?us-ascii?Q?e/+6GFekqVexGsqBz0uAzc/3G7ri9ONlNOxEf3h/MvIsBeOoJ6Tcpgv27Vyk?= =?us-ascii?Q?NniIEBufYtSfxH9iMhQqgxYz/d2UYNbwW4kNEGtHxYlItJkWXIQfAj4lTKkc?= =?us-ascii?Q?R94CThYYQlSRL+IoAHsMDkhSLjfkdASB+u4exvbboXyp+p8WK6CDkHQSOFxg?= =?us-ascii?Q?5/5VXQ6jjlUhqoLgRSVglnwmuzsXSrrWYj9aCtmB3e1CDdCitWmZgrbbMjtm?= =?us-ascii?Q?wxbhXgqzkfTqRShp3GJuq//OgeikrVHmI5OOg/yEanAOU0KIuxYQrvxpgAjY?= =?us-ascii?Q?70IP7GGhcZoBgopEa98EclRKSShKQorKW+wJGfWRvBNM5Jl2YwT6aAYI7E38?= =?us-ascii?Q?i819sj7yvi96NoLW1zbPbehJMjKxH7LLq658/1C/g70pJG0dHNP9wpXa+ZFu?= =?us-ascii?Q?Y5CPlg0EmDknNJ21DNmXcp+r0EDShbNu9sq2L4NT?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c94cfd21-d7fb-44dc-3cda-08db3b6e7ce1 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2023 15:56:33.0459 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vD5RvJFdTxQUhdEJcEXLyIKHYyjFQfRCOJnXe8neREVROOxQ0ejnNTWxqEGtMF16SUn5cpOwHuiUSrEdtX0d1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5087 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Aryeh, Please see below inline for comments. Thanks, Chasel > -----Original Message----- > From: Chen, Aryeh > Sent: Wednesday, April 12, 2023 4:20 AM > To: devel@edk2.groups.io > Cc: Chen, Aryeh ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Oram, Isaac W ; > Gao, Liming ; Dong, Eric > Subject: [PATCH v1] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR > REVISION to update FADT entries from board package. >=20 > From: Aryeh Chen >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4409 >=20 > Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from > board package. >=20 > Signed-off-by: Aryeh Chen > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Isaac Oram > Cc: Liming Gao > Cc: Eric Dong > --- > Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 2 ++ > Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 2 ++ > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 2 ++ > 3 files changed, 6 insertions(+) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > index 6e57b638e0..a844d9c445 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > @@ -1096,6 +1096,7 @@ PlatformUpdateTables ( > case EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE: > FadtHeader =3D (EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE *) Table; + > FadtHeader->Header.Revision =3D PcdGet8 (PcdFadtRevisio= n); > FadtHeader->PreferredPmProfile =3D PcdGet8 > (PcdFadtPreferredPmProfile); FadtHeader->IaPcBootArch = =3D > PcdGet16 (PcdFadtIaPcBootArch); FadtHeader->Flags = =3D > PcdGet32 (PcdFadtFlags);@@ -1113,6 +1114,7 @@ PlatformUpdateTables ( > FadtHeader->Gpe1Blk =3D PcdGet16 (PcdAcpiG= pe1BlockAddress); > FadtHeader->Gpe1BlkLen =3D PcdGet8 (PcdAcpiGpe1Blo= ckLength); > FadtHeader->Gpe1Base =3D PcdGet8 (PcdAcpiGpe1Bas= e);+ > FadtHeader->MinorVersion =3D PcdGet8 (PcdFadtMinorRe= vision); > FadtHeader->XPm1aEvtBlk.Address =3D PcdGet16 > (PcdAcpiPm1AEventBlockAddress); FadtHeader->XPm1bEvtBlk.Address > =3D PcdGet16 (PcdAcpiPm1BEventBlockAddress);diff --git > a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > index 451034fb8a..9d83cbf73c 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > @@ -67,6 +67,8 @@ > gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags > gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyOffset > gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyWidth+ > gMinPlatformPkgTokenSpaceGuid.PcdFadtRevision+ > gMinPlatformPkgTokenSpaceGuid.PcdFadtMinorRevision > gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddressdiff --git > a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > index e6f714b181..6e44287256 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > @@ -346,6 +346,8 @@ >=20 > gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x9 > 0000025 > gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x900 > 00026 > gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x90000 > 027+ > gMinPlatformPkgTokenSpaceGuid.PcdFadtRevision|0x06|UINT8|0x90000030+ To be more align with specification, it looks to me better naming is PcdFad= tMajorVersion > gMinPlatformPkgTokenSpaceGuid.PcdFadtMinorRevision|0x03|UINT8|0x90000 To be more align with specification, it looks to me better naming is PcdFad= tMinorVersion > 031 [PcdsFixedAtBuild] -- > 2.26.2.windows.1