From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web09.5445.1650610748660023237 for ; Thu, 21 Apr 2022 23:59:09 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=DsK67KA5; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650610748; x=1682146748; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fsmFqTlSEkSHtpHhZInVdgu79UTuNE8pePMl9Kiz0bU=; b=DsK67KA5hSljik4ul6FGqgYdOZH1C9qQOYjbexh0UG/Se+aXM5m89TpV WNmuzqFq6wa8tvrQsoJhfMDNSipBTqtHg8Et6KsMsBm7EH9+bRfMKIKqF Xi6SR6nBfwL7R88F9ek25+LwJe/P6Ruz1VMpE0dylvPVnssVPQaQNGg7P KolV3cvGRgoygltOGkGFMSBsDMUQZA/Zs6wbvf1vGWvaLm8nF9Bty1jub xAi0KPSE6BApfuxYIgLMCoSVp/pt8Op/WcRYRnQCi6ovUAV1cyo0m9abu GVgtbBP5oo963sp6bKhhdbgNM0AS/JZ+Kv2BXJEJ1X1N8kOTifgWkhq7U g==; X-IronPort-AV: E=McAfee;i="6400,9594,10324"; a="246500035" X-IronPort-AV: E=Sophos;i="5.90,281,1643702400"; d="scan'208";a="246500035" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2022 23:59:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,281,1643702400"; d="scan'208";a="867259204" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP; 21 Apr 2022 23:59:07 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 21 Apr 2022 23:59:06 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 21 Apr 2022 23:59:06 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 21 Apr 2022 23:59:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AyKVAWG5FAWvD/sok/CUw4TV1NdSEAgmFl5g3x9c7UKdd3r+iilA1Ts4QbEoqZkcMqSoOP/q/xWAtrZ90O9IZBuf6w3EgQ9WesFYJdIPe0m55VlKJ9iwIQE1PegswRXBqRbrDmPc0AjvZh2aoCBN1oz/YuOBQaukhvYwXswQjZ+dtTXmRGe0yMPvn2gNHN/AAduu4YRzbIB1BsweO/CPClqLtbm2D7P7EsJOFPuXyyDzGLPgVo0p8+fkSbphak++f4YizbhPryJnS2KQPyRLX11FEzkZIMwS2yY7n1bKjOXcuVvXXWpH0ZFioJStZN25NnnmzRqSDkS7DZPTIeEikQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zJcmql8zmtHUYPQqxdu2Orh7KJmeouvQGVKa1+d/jSQ=; b=TvvcpVkU3fBZ+oDPhIRAyYAMluRM4aulczU7jdgqs9SHcltL0bGBIKAhQzkl0IDHAvobn4R7gYbAlRPjDp2e12XC74TziybGnxn1crviUTB1d288/choO0OWAnkb1mEhwzNKo2tbsxFdKOgyP7LmBceED2ubG+7mLNKeBqKEnLmmk/nTLsZc8Bb8QmwE767MNZ6K6MI8scbqaxk9XccVakGy2Mj4FS0vPZp4FlPyAIcPThcFVZ9/l99PG4ZgDlp1L4H+lsHSwTyaQoNabdSmwK14gxbkFU7/4kAPoWvu4KyQzXTJv/JILL9rQSHaZxRIY29IvEVx0KsWkIvVga3HlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by DM4PR11MB5309.namprd11.prod.outlook.com (2603:10b6:5:390::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 22 Apr 2022 06:59:04 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::c076:6436:db8e:ee22]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::c076:6436:db8e:ee22%9]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022 06:59:04 +0000 From: "duntan" To: "Dong, Guo" , "devel@edk2.groups.io" CC: "Ni, Ray" , "You, Benjamin" , "Rhodes, Sean" , "Liu, Zhiguang" Subject: Re: [PATCH] UefiPayloadPkg: Add definition for LinuxCommandLine HOB Thread-Topic: [PATCH] UefiPayloadPkg: Add definition for LinuxCommandLine HOB Thread-Index: AQHYVgcCP0SvLbSGgUils6lZfwCf6qz7cpxQ Date: Fri, 22 Apr 2022 06:59:04 +0000 Message-ID: References: <20220422035047.1130-1-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 484e8869-d646-42bd-56ed-08da242d968a x-ms-traffictypediagnostic: DM4PR11MB5309:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Rcj5zw522+P7QA1c7KWStimaWAsxH6GafkMZHmqz8QaJYAmPImqFOZ+ET30kCqMuymm12cuGQYYNSllEhnBreXbg3TP7mVOYiCMK9BEIvdEoOPV7Q/KOnBVftauauc5tT7e0jzPIv2gG16i3qj+kDB3gd2EH093ERIdSYKKmwF4t/hkptV6v2BCBFc4MIVdMqlf/dXV2ora9GX4aMXRoujFfLhvUEiBIKfOOreSYQtT3V65iPMMjjWlr6X7ZCxCWnmGcbZCNJzpoqpohUqvAhO+aWdQnrMnLz4Y4JgmCXjaHfmyhJ2p9jx2+rJjyMMk+Rl3lZjnMHRIPY8zrfQxlkl04uumBsJodykdLSL3LnG0N52KfpcfsXNQUmE0G+8mFWIatLegHvSPe9d5N9qG2njOmDLw1VFiacw1Jp2kiRbFNC5PllpsuGGi0/ko4vGz4WOB1axT3jgIZIaCrj87+NpNSKPpxnQao6xyZNblhJvVyZLPrSUF0c+1J6ShDF59ZEKAgQ4YIJ8YHOx4eEjRxJenbHP7unRyfZy59molUupLwPeEzugZTVo/HBJXyZQqMJ5YiJ9L5xfm+IqtQVk8578NBS5eEyAVi7CXKcEiPkT4o2A9BSwL9ujDkpyo4qqT68QV9o/2QJtyE0sIZWxNpUAhYjPOX/IerVFa72T2ow0bmz8krFldc0e/Mq5tne2T1jdw1Lz5MFjzevNH8QVM0SQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(54906003)(122000001)(508600001)(52536014)(4326008)(8676002)(26005)(53546011)(6506007)(9686003)(8936002)(7696005)(86362001)(316002)(186003)(64756008)(66946007)(66556008)(66476007)(66446008)(83380400001)(33656002)(107886003)(38100700002)(55016003)(38070700005)(110136005)(71200400001)(5660300002)(82960400001)(76116006)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ilBWCPrzJ9UBYKSGdpV1reDr2dM/xjZDNvkvtX+HkAVwpwYZc82cLHLN9WQP?= =?us-ascii?Q?WdcH8YVUIQWB6GUPThpRHzwj8U6zM/bpU1VBQas/f/Bp7t47Py78K2it4jyt?= =?us-ascii?Q?Qt5A6MG1DmgE4DloeJ2CdKNgKRjXpE0jFsFINCjffcHG278jzHHkxljszr32?= =?us-ascii?Q?p+A2UjF1adirmR50rFXTzyA2JOZzWLvJQEoQvAz+K9nu9b6ofRo6wMUuPraH?= =?us-ascii?Q?DNYaUf7vgIFoFYy4YXLid2po6iokEEZ4O149I/hIj6ctgsQddlsnyfyCGS91?= =?us-ascii?Q?EpVraw12aU2KVM8CQ7W3XMBehfWY2cMUTEaGOMO9NMXl0E0ix0mC0QutAp4Q?= =?us-ascii?Q?j7abN41xG3ItN/5laxvGRnZx/aaaf5hNyX2/X3jv0ingAuYIXWLLkCoLeoV1?= =?us-ascii?Q?KKN4OqmA2oZd2gpJz2DupD39WecnLp7ksbex1exf7vcP+A5VeXcbq8DCJI70?= =?us-ascii?Q?xIrgOUKosPSutew5rzXUJeOA4KyB0IL00/SLUUtHydLYqibUH+mhs2Z6bAwe?= =?us-ascii?Q?DDhNEPegGICnqe0jNOt89Ce1wSYpyszQdPJfz29tm+SsvVseSSdO416E7Pj8?= =?us-ascii?Q?SdznhPwE0pJIREu0zP0BRav7toBpIDmWHe/t5p2DoIrMr9J+c6kFEfdU1W95?= =?us-ascii?Q?gwzbQe/MwrLK3nskIZthr/g4jq0jvh97ohKdwcpI8xeKLwJCuu1H6JzeUM9w?= =?us-ascii?Q?kn16BTaAlXCDz27TuTkbaXh1Bsad9mnPkDyPI5YbFKTGJMaEkUuHhj8e/5kA?= =?us-ascii?Q?zVN+7H5Ny4JXZ8Fya7+1VaXPWkfuQBNEaKbbXDZVkBxRPJLavGmPHakFdBub?= =?us-ascii?Q?u4TaliTP7ndlMF04dE3caRFzBqq30NsIlMYYFR1sUkrX5ZyCQWXMqvcsrRza?= =?us-ascii?Q?0i22oNsNkb4nwwdV+Ktrd4q8pbWSJptmtZIfChOqhEqecXKziZYRuJx5Bs22?= =?us-ascii?Q?ee50pA2IRdt/caJPRSb2aqNtTGbIrA6A+fGDGxTgrS4cw07DtRrOWysTgUG0?= =?us-ascii?Q?uuU/c4xN6vvwqVugIMl8+bJO/QqwLBn5hVeILdlF/igDX9u7cKk1DgvhK+Dz?= =?us-ascii?Q?GluFNNlsEoiG9WZKEJxm6Em/5IZimvEqjQDM/bes9oKWawO3FiqKmV7TApmG?= =?us-ascii?Q?x1VS+EBqpw2LrSQ6+CwStUK6GkgS+F2xH0ICw1mDhBjZIgtR01D/LQoORCm+?= =?us-ascii?Q?hUoDVhY2F0c7bb+Lw49GPFIX8s69a5CQQNEqx7VNY4x9ZtS8jp5QhMHGnEr5?= =?us-ascii?Q?T0G2z3SmaUiPCRc9rLEpTnKsXE9fUZvAaJdyM06B619urXRzzb4iS6Pksmk5?= =?us-ascii?Q?C2VuKtQvefTUIVwPL5qTji1uTodfs45CdaOE2gQCXl3S4sGJ3Xy3Poi7L/zb?= =?us-ascii?Q?ZFqMKCzxNtoen5y1Z83rDm3zlJ1ghT15xNWxOwOkNMn3QPL+fFpcADVKwyHA?= =?us-ascii?Q?jqydeuXYNHf/fSGwIZo7SZA1I8XkkcqyMWj/ZCPeLyrewSt5mPHyimzxt6tz?= =?us-ascii?Q?JmkGdKbv8aBid5XntSHdzK4bo5LbmRKWAKH7BNSCIKmdAhoP1nvvFKTYRbuI?= =?us-ascii?Q?LeG77/cI1YzukRRs3gX+gghTG/c1Gymyx8HYLhZzR4EER+7peatjuxAGXAdf?= =?us-ascii?Q?FabqfWpimQubcYMNupBE5I1pR7UWsFv7IgOn6odD+BxDEJmNOUmCjd6RxqFQ?= =?us-ascii?Q?erUDW6MX5mXkPBK3wx1e6RguNVtINLYgkm7n/aUx/Hf76gG+p25tSfTv1Zy8?= =?us-ascii?Q?Pe0Jn7VDzw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 484e8869-d646-42bd-56ed-08da242d968a X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2022 06:59:04.3810 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4atEruq4CoFz86VVZKhnrwuDPZcLjwv1nSNeSwmlgchX7kvQyNi44jv7AUD9sZyBtFCTLcTfELvUs50hR6hw0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5309 Return-Path: dun.tan@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Guo, Thanks for the comments!=20 This Hob is used to pass Linux command line to LinuxPayload instead of OSes= . For LinuxPayload, it only needs the Linux Command Line. Thanks, Dun -----Original Message----- From: Dong, Guo =20 Sent: Friday, April 22, 2022 1:09 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Ni, Ray ; You, Benjamin ; Rho= des, Sean ; Liu, Zhiguang Subject: RE: [PATCH] UefiPayloadPkg: Add definition for LinuxCommandLine HO= B Minor comments: It would be great if adding some descriptions to the fields to make its usa= ge more clear. Maybe we need give this header file and structure a more generic name by us= ing "OS" instead of "LINUX" so that bootloader could pass command line to A= ndroid and other OSes using same structure. With current definition it looks bootloader could only pass 1 command line = to payload. I am not sure if there is a case that bootloader need pass mult= iple command line so that payload could pick up one of them for OS. +typedef struct { + UNIVERSAL_PAYLOAD_GENERIC_HEADER Header; + UINT32 Count; + CHAR8 CommandLine[0]; +} UNIVERSAL_PAYLOAD_LINUX_COMMAND_LINE; Thanks, Guo -----Original Message----- From: Tan, Dun Sent: Thursday, April 21, 2022 8:51 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Dong, Guo ; You, Benjam= in ; Rhodes, Sean ; Liu, Zhi= guang Subject: [PATCH] UefiPayloadPkg: Add definition for LinuxCommandLine HOB Add definition for UNIVERSAL_PAYLOAD_LINUX_COMMAND_LINE Hob. This Hob is used to pass Linux Kernel command Line to Payload Signed-off-by: Dun Tan Cc: Ray Ni Cc: Guo Dong Cc: Benjamin You Cc: Sean Rhodes Cc: Zhiguang Liu Signed-off-by: Dun Tan --- UefiPayloadPkg/Include/Guid/LinuxCommandLine.h | 28 ++++++++++++++++++++++= ++++++ UefiPayloadPkg/UefiPayloadPkg.dec | 1 + 2 files changed, 29 insertions(+) diff --git a/UefiPayloadPkg/Include/Guid/LinuxCommandLine.h b/UefiPayloadPk= g/Include/Guid/LinuxCommandLine.h new file mode 100644 index 0000000000..0bb75238e7 --- /dev/null +++ b/UefiPayloadPkg/Include/Guid/LinuxCommandLine.h @@ -0,0 +1,28 @@ +/** @file + Define the structure for the Linux command line Hob. + +Copyright (c) 2022, Intel Corporation. All rights reserved.
+SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#ifndef LINUX_COMMAND_LINE_GUID_H_ +#define LINUX_COMMAND_LINE_GUID_H_ + +#include +#include + +#pragma pack (1) + +typedef struct { + UNIVERSAL_PAYLOAD_GENERIC_HEADER Header; + UINT32 Count; + CHAR8 CommandLine[0]; +} UNIVERSAL_PAYLOAD_LINUX_COMMAND_LINE; + +#pragma pack() + +#define UNIVERSAL_PAYLOAD_LINUX_COMMAND_LINE_REVISION 1 + +extern GUID gEdkiiLinuxCommandLineGuid; #endif diff --git a/UefiPayloadPkg/UefiPayloadPkg.dec b/UefiPayloadPkg/UefiPayload= Pkg.dec index 5c1aeb8235..494ef94932 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dec +++ b/UefiPayloadPkg/UefiPayloadPkg.dec @@ -35,6 +35,7 @@ gUefiAcpiBoardInfoGuid =3D {0xad3d31b, 0xb3d8, 0x4506, {0xae, 0x71, 0x= 2e, 0xf1, 0x10, 0x6, 0xd9, 0xf}} gUefiSerialPortInfoGuid =3D { 0x6c6872fe, 0x56a9, 0x4403, { 0xbb, 0x98,= 0x95, 0x8d, 0x62, 0xde, 0x87, 0xf1 } } gLoaderMemoryMapInfoGuid =3D { 0xa1ff7424, 0x7a1a, 0x478e, { 0xa9, 0xe4,= 0x92, 0xf3, 0x57, 0xd1, 0x28, 0x32 } } + gEdkiiLinuxCommandLineGuid =3D {0xb5aeb34f, 0x3047, 0x4955, {0xb8,=20 + 0x80, 0xad, 0xd3, 0x6d, 0x86, 0xdc, 0x0f}} =20 # SMM variable support gNvVariableInfoGuid =3D { 0x7a345dca, 0xc26, 0x4f2a, { 0xa8, 0x9a,= 0x57, 0xc0, 0x8d, 0xdd, 0x22, 0xee } } -- 2.31.1.windows.1