From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.2327.1678844820832087843 for ; Tue, 14 Mar 2023 18:47:00 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=USXi6Wko; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678844820; x=1710380820; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=phNNsMayTPZNlek/jI3bnwLHyChziOo/QNJohswzYTA=; b=USXi6Wkobt65YDdmaK2MxKgXYFjgOaObIazYX0U+qwuskUDfvnfj4ZqJ oG1IT82Pu9+k+HXmMtcgFLYYotPigpx7CEUeO8r28P/i847uoQy1AHA1M HGsWFIkW6yLyehYanmsayvoo+IK9ozWtydBddOaxWj818raSS/DX1gYKK xAqv9sa3yjgdGUtXkp2st3x1WuNd4aggFKRfqDujSmkphRb+M39sMsMtj QMFkz+O4Qjgc9NyenaJfJHtRumYFtgCm6bxRBrZH0xeSoE5cNbFns3T7q MHdvM1vIGOaCqL5+refq2g9JCQRh1CR6ldkQOm710ZPamyBqX0X+f0jtH g==; X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="402459607" X-IronPort-AV: E=Sophos;i="5.98,261,1673942400"; d="scan'208";a="402459607" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2023 18:47:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="853415887" X-IronPort-AV: E=Sophos;i="5.98,261,1673942400"; d="scan'208";a="853415887" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 14 Mar 2023 18:47:00 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 14 Mar 2023 18:46:59 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 14 Mar 2023 18:46:59 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 14 Mar 2023 18:46:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T4uaGTDkJ3RzutGDRAV1V948knhEkIXB7vtuX5k+t6Xdku+L1I/X2ZICfx+F7x0+tNB1JOyj3aAcrUDqWfvZ+RiFs9qMglffeFyXKLaZFsxN+clkPqFAasc8FZoVX4y32hF2McqZcXg4lyjHpXSu2sKCcZvt3aFyF3PdScRN4UctSn9iMziA+8m3j5UgGkKyHj8M8iQRh2+veyqOTt+Tsg+92fNtJz8+0Px5wdteny1FJlCOfGyftuUknXJBs65G62oqsClJixj1WxkjV1jeD8mRc3Lm1k3WPrRUOo34vXKV82uTchAhSyX5cxgsB3qoST6cKFDW2szCh1cbknP+3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f1cxJ6y9Kaylq9+Ka5x2zU7hIymTKd85OZyw6B8jpVw=; b=niQr+eUseRfoTA0+7PKCgdJwBMZd/PBRi0AbqpAnDWwfyPoX6eQEWlzpI2i0IDA48N5FybW+8UtGw6dwajfhJbWAMNA4AI/mG7CHJ22xn541krP1WJUYx1MInF46bohzDfg5r+2rMS0q4W1pGbqZmb24fzl/VwgBn98m5UZ2dXBpuR4Lp8PWoCxWxyu/VJjLe8AjOL/+HXX/AAkdWMCPTbfx1LeoUyyD1TAddiXZ+vR0ZYXXSeoB4GpCslfEc1Ap3h54EaInGn8sctLfaUirOmqemojwCvPsPuxcBakrCFcQkbK4hzzfb7O1lejQc6KMFexxsRxnWP9a12UKz8yZGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by SA2PR11MB5099.namprd11.prod.outlook.com (2603:10b6:806:f9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.26; Wed, 15 Mar 2023 01:46:57 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::af70:de56:4a6f:b2cc]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::af70:de56:4a6f:b2cc%8]) with mapi id 15.20.6178.029; Wed, 15 Mar 2023 01:46:57 +0000 From: "duntan" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [Patch V2 02/14] UefiCpuPkg/CpuPageTableLib: Add check for input Length Thread-Topic: [Patch V2 02/14] UefiCpuPkg/CpuPageTableLib: Add check for input Length Thread-Index: AQHZUaX3sQFXw7rJ1k6DgmnSKyk7xa77FnxAgAAF37A= Date: Wed, 15 Mar 2023 01:46:57 +0000 Message-ID: References: <20230308100758.669-1-dun.tan@intel.com> <20230308100758.669-3-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|SA2PR11MB5099:EE_ x-ms-office365-filtering-correlation-id: 11575f67-9f0b-4eae-7f30-08db24f7299b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ti1GuuCSbJXfDXNv80h/wlctEgfOzG0MgeXrFpQws+GO+VChc48YUUScR27FT0wfEolas4+VH8cY4eSd/b82+GRGCtDJTZe8Kwnz9OcOtMN1yD+Ig75vUYxwgjZ5wGVRYE0LM3z2G5MOJTGX4lDWAoP/bE+DL+titf6C0aSz50eMl/UmDETebKLqfDDMmX8aJa50GomrEAngI8Sc9+9S/9MhNAB/OYv78PW46zlS+0SfZOJ0RMhG9IAO7kkDPSraR4hrc/D/BNUpGMMKKIEEpzVgN2BGnPOIhM027KcHByAEdMlrLcTjpjLN4YAu4F0ozZUBPMoNXSZrn4f+st9JPK5zPz/pkESg6C2x6i+eCVX3nsCpprqjY20gxkUtjiEfKLlOcviLtfszTWzY1I8b82blMERQyE6lcCnAjip4dWFXsl6F6LmEhcgrl41BAsyIG7rS/YvjzEWOZn/4xTkF4fETbBpuxk7OVF3fo8udm2FbknIooyyonWdjCq9SyAM/jAfHDtUZRL3vgBCI6vtIPFiPFMUVBVEqBy38mQAHM5mcgGwFEqsBvkcEHWLnjRFm2mZdBqGpA2jYoVRqfh1Dlij2NZwszbvamTbELYMI/gQgLIJ4PftH48f+x0YvzoLD7+7EZb0sc4OVfJROdYpgiDNsfTncfT8JtjPrtRStFpnblLxjKaE2MWLgO0aiKaN7B1Q1r5XRGabrlxOs6SLi7w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(376002)(346002)(366004)(39860400002)(136003)(451199018)(38100700002)(82960400001)(122000001)(66446008)(64756008)(4326008)(41300700001)(316002)(83380400001)(66556008)(66946007)(54906003)(110136005)(76116006)(8676002)(66476007)(38070700005)(52536014)(8936002)(5660300002)(71200400001)(7696005)(478600001)(86362001)(53546011)(6506007)(9686003)(26005)(55016003)(2906002)(186003)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XmeqEW3lyTqcPzFU82GsiKFBj/G3j13BTg79DqC4pE3K+L5AlyIuK5pGjGgk?= =?us-ascii?Q?vu4YFdzErgsDWefgJNOEDkTbuXDJxvqrXoKHFvhTcsSuPWan3inuvZ+q//fp?= =?us-ascii?Q?LHYnl5R8tuqXsNQA/yyz/x47lX1JdBlAxM1YgY+CJnWYbMYjhHO6geC7cceU?= =?us-ascii?Q?8GFFJFGby83QHbIjmVs3iRvd/ZlStNMACmXoynyFBhtwofGaNd9fd9RwzD4n?= =?us-ascii?Q?5VysAmO5+FKLUW+RmDFuu1gWpHIlaEhJKk6bkTaqlZfGTigZ6+ltgVwl0eQl?= =?us-ascii?Q?t65Q6cQz2uRLibEwLuU3wAZ9b9KKBQuXYwxc73wn5An5GmrpIjcTCCQV16nJ?= =?us-ascii?Q?MQmRXO25TzckQ1efzZz7gDMQ/cazm5UWsP4+bPwgSkxeZhYL5UQaW7dpOkSr?= =?us-ascii?Q?lQznLq7yV5lqzkaR+JILIwqsN4VnKDxWlBM/cclPghKamZ2pwc7NwNsqkkjK?= =?us-ascii?Q?OTKkE4nXd8FbVcNTq7xsvynmTgwiriOBl9JwBSv3aeNZbAmeRQJSnc41YBep?= =?us-ascii?Q?MDY6gjHnl+lYkdJVbPDmZnvaqmtzko9wMTyXS4SvADWBQWcxGQuvbrQMD3ER?= =?us-ascii?Q?Z9LZUA4I5+0/gV7TwHxvsmqdHk1iGnyD93LTaXL+EkX0UcvXQj4uyx4ojgYs?= =?us-ascii?Q?Halp4Qr5wHYWh7zqVzlTrHyby2OMv8t34tVM+CYtXHTJtLxx2dGjHshFvrTk?= =?us-ascii?Q?6c6h0v6uXsGzGjvwGM+rcZZb+YZ8dtasnmP15PMLoKFvdnlRhxvsNmn0/J/X?= =?us-ascii?Q?iepfvgpOfzQEcrqOKy/zT/0az4VRaSD0Zyq8++QMHej9Q+AdXZ6hk7aR7a4C?= =?us-ascii?Q?aijkxPXtMUrDL0AVg+sGppgDgJ7PjGg/2fsn27svM9KvwNqR1pQdupIwbX27?= =?us-ascii?Q?+ZxH0HDs2ycO6E/sOilkpdxpu580kiu9benx83lxYp2XsBT/QDWtsqX3KDqM?= =?us-ascii?Q?+EzFCILtBg4X1x8FlA5S9bqtaMya4k3yCSDVEQ27F8d/RnZEghDWRyKf7giA?= =?us-ascii?Q?OSQDOWTXHzHn4AjoA4BmDlNB8drWDsQ7HlcY0aqlBN2RGhPYGN5suDxL33KU?= =?us-ascii?Q?js4sGt2IQBOE8YvW6x3UKTbR8PoEiJUkuMw6W3qellOWHTZqwEc+9XlLJFjj?= =?us-ascii?Q?Mw4Vn5jG+sbigMEL+UkLYdJs7EkLDlAXshrOQaNy0yw7nhBjuZuNCHZtds1s?= =?us-ascii?Q?wzXNQcUa7UgnsDlk5Jt80H94Ey+gr6z2HgWlSPtWyKIDgUhYtA8e9caQ2BHY?= =?us-ascii?Q?F5lLuCOtxLs9jy1ygEZjLkOl5xX4J87aHW+UZCr8owDyEXntkTUp2LN9DuWv?= =?us-ascii?Q?lJdcbvnClI7VLqwZkwQp9N7PkJmX8kZs7XPqXUe0EI7lVNjigNkpcn0cBmIh?= =?us-ascii?Q?pkSJRDtRqEAATZv4uiC3b6xbce38aN/Ee9jy6PdHXfkjyboKn2WzZMmkDvf0?= =?us-ascii?Q?nh7YyyYE8uJSIwExVcUlVNxgVi08uAKOrrnupJCV6nvuqb98YyDVKHi8moMQ?= =?us-ascii?Q?KgJyq/LLId2itjuhnfq3SJmZiN8Ziq1dvkZNgFBTKGGu0rhS5s+iuP+rpZ6q?= =?us-ascii?Q?/zy5VZ+VIjv6P1MHWPFjNH6KPuUlXNRhI6ylhnJG?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11575f67-9f0b-4eae-7f30-08db24f7299b X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2023 01:46:57.6168 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bTXZEXQw6xnrwa9dQkk971//V0HHiqAfoPxu0ywGtmpVo+Tgf8on7JBKhdrR0HbQY7Wqr8g9UZBvaMtCFTqDsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5099 Return-Path: dun.tan@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Ray. Will update the corresponding function header comments in next = version. Thanks, Dun -----Original Message----- From: Ni, Ray =20 Sent: Wednesday, March 15, 2023 9:25 AM To: Tan, Dun ; devel@edk2.groups.io Cc: Dong, Eric ; Kumar, Rahul R ; Gerd Hoffmann Subject: RE: [Patch V2 02/14] UefiCpuPkg/CpuPageTableLib: Add check for inp= ut Length The function header comments in lib header and C file should be updated as = well to document a new condition when success is returned. > -----Original Message----- > From: Tan, Dun > Sent: Wednesday, March 8, 2023 6:08 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ;=20 > Kumar, Rahul R ; Gerd Hoffmann=20 > > Subject: [Patch V2 02/14] UefiCpuPkg/CpuPageTableLib: Add check for=20 > input Length >=20 > Add check for input Length in PageTableMap (). Return RETURN_SUCCESS=20 > when input Length is 0. >=20 > Signed-off-by: Dun Tan > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > --- > UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > index 47027917d9..4c9d70fa0a 100644 > --- a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > +++ b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > @@ -567,6 +567,10 @@ PageTableMap ( > IA32_PAGE_LEVEL MaxLeafLevel; > IA32_MAP_ATTRIBUTE ParentAttribute; >=20 > + if (Length =3D=3D 0) { > + return RETURN_SUCCESS; > + } > + > if ((PagingMode =3D=3D Paging32bit) || (PagingMode =3D=3D PagingPae) |= |=20 > (PagingMode >=3D PagingModeMax)) { > // > // 32bit paging is never supported. > -- > 2.31.1.windows.1