From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5DAFCD806DD for ; Mon, 13 May 2024 03:38:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=3Cp4Q9Tp6BGrO5NqitC4NdjlFnRHYWYtQlWU6/TIahU=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1715571511; v=1; b=rcGwl8o2+XYT56qs6f8hztIuhbFqRBUG02JayXv9WNpbHxT5EamDZkiRZlNLw09vpnIqi2CZ EgSK05/xd/XxYp1xTeDVXJagrhDG/sj14/7tMaJzuy31G6fKhK5dSuBcUW6ZBgZ1stNHeguuJ9I XHLIyv292SP7kcWMOBgS4gpofjiKg9fgiAGDOceLhCUsE5B9KxbjT1pA3QXTJLSP8EZeNG31Mo0 pmLvpltETqXaGdHJeaKae3iR7kPQFlAPrFNG9dP0fhreNOK06drQFn2Cr1T0bzmwjNNjqKqnG3P zdXDKDM+DS9T0V8a2IzYm/hrLxYXNs7D0dOLAJxTQmdLg== X-Received: by 127.0.0.2 with SMTP id qsynYY7687511xvTZj4jgvUD; Sun, 12 May 2024 20:38:31 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mx.groups.io with SMTP id smtpd.web10.51956.1715571510736403098 for ; Sun, 12 May 2024 20:38:30 -0700 X-CSE-ConnectionGUID: FzFFs7uCS5aSifStXU2mcA== X-CSE-MsgGUID: 02qOu0/7REeznyqirNPjcA== X-IronPort-AV: E=McAfee;i="6600,9927,11071"; a="15282647" X-IronPort-AV: E=Sophos;i="6.08,157,1712646000"; d="scan'208,217";a="15282647" X-Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2024 20:38:31 -0700 X-CSE-ConnectionGUID: UQOyJ1VvRLqjppbGCXJU1g== X-CSE-MsgGUID: V1AFWd5ESZeaH7RLLBf/+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,157,1712646000"; d="scan'208,217";a="34963931" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 May 2024 20:38:31 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 12 May 2024 20:38:29 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 12 May 2024 20:38:29 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 12 May 2024 20:38:29 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 12 May 2024 20:38:29 -0700 X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by IA0PR11MB8377.namprd11.prod.outlook.com (2603:10b6:208:487::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Mon, 13 May 2024 03:38:27 +0000 X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::3baa:3852:4315:38f7]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::3baa:3852:4315:38f7%7]) with mapi id 15.20.7544.052; Mon, 13 May 2024 03:38:27 +0000 From: "duntan" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Wang, Jian J" , Liming Gao Subject: Re: [edk2-devel] [PATCH 18/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE Thread-Topic: [PATCH 18/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE Thread-Index: AQHaosIv2r42yjR6RUyV2ktTDmEOmLGUdn1EgAAHkaA= Date: Mon, 13 May 2024 03:38:27 +0000 Message-ID: References: <20240510100827.1903-1-dun.tan@intel.com> <20240510100827.1903-19-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|IA0PR11MB8377:EE_ x-ms-office365-filtering-correlation-id: 849d3911-819d-4bca-da84-08dc72fe26c7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?I1POpU3LDh2YvEYW1JZVweHMF4YJegAWHHVv1DS2DH7f4y9wFC88Ulip+UY0?= =?us-ascii?Q?G8nvHIzRUQTKOySBPwHy0gA4wWlXQp1lSwucvdsTo6rQD6wX7CZbhTboG7sK?= =?us-ascii?Q?gvOcRq1YrpNJYC+OJlAaFCRmygfu9MXLIrFqU+MxLNSfMDI+lrZ8VnjdhqCa?= =?us-ascii?Q?Jneq5EODH6tYJ/gaYapdb3wDC9Xa8gAf+gZvSoqS4tFIhKfm26DjOToW8Cut?= =?us-ascii?Q?0ZqosS4FWN2q7lnoOutbSCvQ80t3rDRsj20d2X3b4W9jrgnFD2/BIdw/DjO/?= =?us-ascii?Q?Nw8IGixAgDSNqBAXooe9ROkniRa7tDzTbz+zWh4ce9A12SSZvJYDh09bcn8U?= =?us-ascii?Q?6vgb51jDGC4TrVjpDDZPlEqSYRCZvOlywM0C4p0B/fBxw73DzscdHK4+4KgQ?= =?us-ascii?Q?yRUR9GcE2oU1UhIz6ZPzeZFTVbBGOnSObMQkxS49FLlshhug8HZIeT2PWWiN?= =?us-ascii?Q?bqtNZlYWB7SGgFNgvpB7O0Oe1LTWp+f8m5gZz20XSvBRRQYldmlfwTQneHL4?= =?us-ascii?Q?V54d2GOQLs4+2h+xEcLoUhNurg3ZkV445uXocEb9nZz9VsdMQ8ZJTCEzTG1p?= =?us-ascii?Q?JEgxy7+ii7DXBYKOMwrKpZd+lsk0Bm4bCHqnTxBQ9x2WAAu9RMR7aWX4WVit?= =?us-ascii?Q?yRHZiykXrKvtyTaTk7MiVuMX6EJlP3DJ9WsgSYrjkYr8sjzmMg/kW1Sudq/U?= =?us-ascii?Q?FSGGOq6ZcaxibFLi8VAw9f0jHQjygCEBZzIThf8T6M95Bre56EPjdnzJtEcg?= =?us-ascii?Q?WbcH558UjscIZYkD8NmwKxCjaDMDTGKA5K4wYFtqY09DZLEJ14Vl5GPXNd1w?= =?us-ascii?Q?gQsTn75//rSHyiDZ0gVN8+R6o6tI7heYXrZ3aMcI/muBN0AXEaka41lTBtLO?= =?us-ascii?Q?opi89jaB0MV4TMnrc3YxsvnCpL4iVNYvWQs7/pQbXj2CRmP95zE/FA6+bf4Q?= =?us-ascii?Q?zLZENNM4Fw5NywJr5Pb0zwxwtai31YwDhIvJRERTKp4Uu9n0dU9/WhdtCq1w?= =?us-ascii?Q?yE7GroWZhOXG6eLe/jzQlnDGVxTxc103DJlBvOmR0LYKvhFLR66dhi8SMm+U?= =?us-ascii?Q?xJ5uM7g9BDI09LL3d3B8dPioTaUyQqGplpziwe0tBp6abBdW5/W5JnahV0bK?= =?us-ascii?Q?wnlZJKwCYLVY9eHUN+Pbf2eIY9vwziEyLhuN925822wgv5jpeteIVzbRbdhz?= =?us-ascii?Q?Y+6B/4P5XSvPhVRqkBUFi518aOqziXjuf5FCM6CMkP3feWBK+vLVveXV6iCA?= =?us-ascii?Q?TNR8Yd70vZo5kS4ICPcQmFggOaRqQV4LnK8qOD4mgu71NTRkSz49xLaQY0ee?= =?us-ascii?Q?UJBxIOX56CpA4TjyhwwfeM0np01fBt0Jkay1x94FSLzMVg=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/S1HDE3v0HvrLhzaYDOvgdp5AI3exZ3Uqu9NrHF2Ky/9dpbnF6Yg+LvvzcLO?= =?us-ascii?Q?Q42cmNbGyXfyHcY+zhPnQJ4sDWGONVAccr5Wj8CNVcbaqxVorjpvYTb/sH2q?= =?us-ascii?Q?ugJ5WersvJZ6x9NGDlf3bH6ZtxAKN46GIAWQ3buy+ioUGtUmhOOgPzyNxZhK?= =?us-ascii?Q?zIU33pLqVQV7SkRT+j839C02C/WfwIbe5Zv0dj2+0is+j3+ZLGhNNe269VFU?= =?us-ascii?Q?X8Jspbgrpc5yPxa3Ugl0ysjs/8rzFbvfnxWJbzVWv6yuCyVwJwbxVFo2CCQg?= =?us-ascii?Q?4R7W4+MiOes23SfQOyqdeVQ5OfmTRsTWIuPYdhyZFmbQ/aOYZa/vK2iPnuK5?= =?us-ascii?Q?i0FXOinwW9nrAmbY4Nivxd2xrlnzPZP+3lKEO0+q/y81sziF7bG0k2sZcORa?= =?us-ascii?Q?oCXzepGmPLI4ujRk7XhcutI3xaSNxP1qLM6xVHG1GI6g/8Pd6Zu4/H5HobBN?= =?us-ascii?Q?vmonJVuOnCF/PB6a2Oc0drLkeeHG4OStNg6IrlLAypYvw3qafT4xI3tWtxmX?= =?us-ascii?Q?delqsfULgCOa/NAWBddBHXGpNkYAjSqNJD2Mqo9n+y/ld58l0KeHlzISM+tl?= =?us-ascii?Q?5aAQgrQEvpxyLiRz9RoM9S9JIrVTItYXWg7o1CLRthxorqzO93jurKIycU86?= =?us-ascii?Q?H4LLS8rV7rW53y8oU9wU5H+5wM+vj1WLPUxqooydzSAuFp0yLCcUFf79bpXS?= =?us-ascii?Q?Sz5pBA/v0PqLuSj7ai2PMFdFoHG7YqdTgFPwi7hcgBb25VMjMI0FPIP4yVfl?= =?us-ascii?Q?7ThPgt/1wkYbRIH0AUkViQ+ok34VUjjbLS0RDLrQIyIshYx4FjB/L7ixzM3R?= =?us-ascii?Q?YYsCaM/cwaztA3rxCEUFW/yaTwHzeZt9U5BU4G+NMAFZmspSrWfX9Q8xJY4a?= =?us-ascii?Q?mdxZcea5cKDUUbhnkZu9gR1A2y4RBsp5uirwPon5ZQsFmOkF7z/b/XGESguJ?= =?us-ascii?Q?rTh9O4ved7bMzGoze1TIfddSerEbeABTr1cLyRjYy9IoWLEs2yiNGyqAo+Xz?= =?us-ascii?Q?Dr3NZCBls5AFNPbhsRrVC7VhBuqBc4mhqxX7hgu4uV9nEhT35W8TC1XJTN2D?= =?us-ascii?Q?khZeZuCP01vsSdjKOhprkF3I5ZpmppraypzhPtGPtbSJrNx5KpaOVE1Bq9rw?= =?us-ascii?Q?gsK2Hj7lUNIn0zOQkZobChzvJKWdiE+3llkP226UFLCG/4fEO1hEn3SkXhgn?= =?us-ascii?Q?E4YtDRaoUxbDo8Puw9S5muUIE3hPZFhauF93DOGJHOj1DK6J7luc2yB9nQGA?= =?us-ascii?Q?FUfFq09mQN1e3PPtlrQ+BSItcW3ELdRCgn1AB8+NhrwK+IxIQDwVrWVjwIVd?= =?us-ascii?Q?Rgax7CtftGih36aXchVkXwhJnJrEhQeUnSyBEiIOKh7oH6h+LiwRZQ2tNTtZ?= =?us-ascii?Q?kXnHxzn1JPXCQFSbWbAUiRTGxmURfNVA0DfEkWy/xd0bogTtNgH1Fj0SYsAw?= =?us-ascii?Q?YOL1qADDa6QNU7vX01gyoqmr7YaxXU99uDaNM6jCCCk9hZQbPoisZkFhQTQB?= =?us-ascii?Q?yw4RONTqKl1s89l9qIdMCp+bIfaZtgtn2v9QqDlzCip/U5KFh1O3NTMM3UrK?= =?us-ascii?Q?4jggOFmxYSRBQGmKvfI=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 849d3911-819d-4bca-da84-08dc72fe26c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2024 03:38:27.7583 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yYbLcgdRM5zB/8VYzEuBUTZhKNUogtmO5mUeT23aI+2GmeH79cdGO3Htzm3rNZyCZl1I6RJKCEBFlZoGD50HpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB8377 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 12 May 2024 20:38:30 -0700 Resent-From: dun.tan@intel.com Reply-To: devel@edk2.groups.io,dun.tan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: JyQc6cRkKXo6ZHHVX0IHUogvx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BN9PR11MB548398604E5F223953DE6794E5E22BN9PR11MB5483namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=rcGwl8o2; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) --_000_BN9PR11MB548398604E5F223953DE6794E5E22BN9PR11MB5483namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the comments. How about change the commits order to be like: 1) S3 MTRRs operation: 2) AP page table unavailiable issue fix: 3) S3 ApHltLoopCode Operation: > UefiCpuPkg:Abstract some DxeMpLib code to function > UefiCpuPkg:Move some code in DxeMpLib to common place > UefiCpuPkg: Install gEdkiiEndOfS3ResumeGuid in S3Resume > UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib > UefiCpuPkg:Remove code to handle APIC setting and Interrupt > UefiCpuPkg:Rremove code to wakeup AP and relocate ap > UefiCpuPkg: Remove the duplicated mpservice locate > MdeModulePkg: remove MpService2Ppi field in SMM_S3_RESUME_STATE 4) Register table cleanup: Then the patch to remove the assignment for MpService2Ppi will be after the= patch to remove the MpService2Ppi field consumption. Also I'll change the title of "UefiCpuPkg: Remove the duplicated mpservice = locate" to "UefiCpuPkg: Remove unneeded MpService2Ppi assignment" to make i= t look clearer. Thanks, Dun From: Ni, Ray Sent: Monday, May 13, 2024 10:36 AM To: Tan, Dun ; devel@edk2.groups.io Cc: Wang, Jian J ; Liming Gao Subject: Re: [PATCH 18/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S= 3_RESUME_STATE My comment to patch #6 suggested to keep the assignment to SmmS3ResumeState= ->MpService2Ppi. How about you keep the "SmmS3ResumeState->MpService2Ppi =3D 0" there and re= move that assignment and the field together in this patch? Thanks, Ray ________________________________ From: Tan, Dun > Sent: Friday, May 10, 2024 18:08 To: devel@edk2.groups.io > Cc: Ni, Ray >; Wang, Jian J >; Liming Gao > Subject: [PATCH 18/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RE= SUME_STATE This MpService2Ppi field in SMM_S3_RESUME_STATE is used to wakeup AP to do the CPU initialization during smm s3 boot when the execution mode of PEI and DXE are the same. Currently, in CpuS3.c of smm cpu driver, BSP doesn't need to wakeup AP anymore. The initialization for AP will be done in S3Resume.c before transfer to CpuS3.c of smm cpu driver. So we can remove the MpService2Ppi field in SMM_S3_RESUME_STATE. Signed-off-by: Dun Tan > Cc: Ray Ni > Cc: Jian J Wang > Cc: Liming Gao > --- MdeModulePkg/Include/Guid/AcpiS3Context.h | 1 - 1 file changed, 1 deletion(-) diff --git a/MdeModulePkg/Include/Guid/AcpiS3Context.h b/MdeModulePkg/Inclu= de/Guid/AcpiS3Context.h index 72d173c4fd..0cfc81b49b 100644 --- a/MdeModulePkg/Include/Guid/AcpiS3Context.h +++ b/MdeModulePkg/Include/Guid/AcpiS3Context.h @@ -30,7 +30,6 @@ typedef struct { EFI_PHYSICAL_ADDRESS ReturnContext1; EFI_PHYSICAL_ADDRESS ReturnContext2; EFI_PHYSICAL_ADDRESS ReturnStackPointer; - EFI_PHYSICAL_ADDRESS MpService2Ppi; EFI_PHYSICAL_ADDRESS Smst; } SMM_S3_RESUME_STATE; -- 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118854): https://edk2.groups.io/g/devel/message/118854 Mute This Topic: https://groups.io/mt/106018145/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_BN9PR11MB548398604E5F223953DE6794E5E22BN9PR11MB5483namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Thanks for the comments.

How about change the commits order to be like:<= /o:p>

 

1) S3 MTRRs operation:

2) AP page table unavailiable issue fix:

3)  S3 ApHltLoopCode Operation:

>   UefiCpuPkg:Abstract some DxeMpLi= b code to function

>   UefiCpuPkg:Move some code in Dxe= MpLib to common place

>   UefiCpuPkg: Install gEdkiiEndOfS= 3ResumeGuid in S3Resume

>   UefiCpuPkg:Relocate AP to new sa= fe buffer in PeiMpLib

>   UefiCpuPkg:Remove code to handle= APIC setting and Interrupt

>   UefiCpuPkg:Rremove code to wakeup AP and relocate ap

>   UefiCpuPkg: Remove the duplicated mpservice locate

>   MdeModulePkg: remove MpService2P= pi field in SMM_S3_RESUME_STATE

4) Register table cleanup:

 

Then the patch to remove the assignment for MpServic= e2Ppi will be after the patch to remove the MpService2Ppi field consumption= .

Also I’ll change the title of “UefiCpuPk= g: Remove the duplicated mpservice locate” to “UefiCpuPkg: Remo= ve unneeded MpService2Ppi assignment” to make it look clearer.

 

Thanks,

Dun

 

From: Ni, Ray <ray.ni@intel.com>
Sent: Monday, May 13, 2024 10:36 AM
To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io
Cc: Wang, Jian J <jian.j.wang@intel.com>; Liming Gao <gaoli= ming@byosoft.com.cn>
Subject: Re: [PATCH 18/18] MdeModulePkg:Remove MpService2Ppi field i= n SMM_S3_RESUME_STATE

 

My comment to patch #6 suggested to keep the assignment to= SmmS3ResumeState->MpService2Ppi.

How about you keep the "SmmS3ResumeState->MpServic= e2Ppi =3D 0" there and remove that assignment and the field together i= n this patch?

 

Thanks,

Ray

 

From: Tan, Dun <dun.tan@intel.com>
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.g= roups.io <devel@edk2.groups.io> Cc: Ni, Ray <ray.= ni@intel.com>; Wang, Jian J <<= a href=3D"mailto:jian.j.wang@intel.com">jian.j.wang@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>=
Subject: [PATCH 18/18] MdeModulePkg:Remove MpService2Ppi field = in SMM_S3_RESUME_STATE

 

This MpService2Ppi fi= eld in SMM_S3_RESUME_STATE is used to
wakeup AP to do the CPU initialization during smm s3 boot when
the execution mode of PEI and DXE are the same.
Currently, in CpuS3.c of smm cpu driver, BSP doesn't need to
wakeup AP anymore. The initialization for AP will be done in
S3Resume.c before transfer to CpuS3.c of smm cpu driver.
So we can remove the MpService2Ppi field in SMM_S3_RESUME_STATE.

Signed-off-by: Dun Tan <dun.tan@int= el.com>
Cc: Ray Ni <ray.ni@intel.com>=
Cc: Jian J Wang <jian.j.wang@in= tel.com>
Cc: Liming Gao <gaoliming@by= osoft.com.cn>
---
 MdeModulePkg/Include/Guid/AcpiS3Context.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MdeModulePkg/Include/Guid/AcpiS3Context.h b/MdeModulePkg/Inclu= de/Guid/AcpiS3Context.h
index 72d173c4fd..0cfc81b49b 100644
--- a/MdeModulePkg/Include/Guid/AcpiS3Context.h
+++ b/MdeModulePkg/Include/Guid/AcpiS3Context.h
@@ -30,7 +30,6 @@ typedef struct {
   EFI_PHYSICAL_ADDRESS    ReturnContext1;
   EFI_PHYSICAL_ADDRESS    ReturnContext2;
   EFI_PHYSICAL_ADDRESS    ReturnStackPointer;
-  EFI_PHYSICAL_ADDRESS    MpService2Ppi;
   EFI_PHYSICAL_ADDRESS    Smst;
 } SMM_S3_RESUME_STATE;
 
--
2.31.1.windows.1

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118854) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_BN9PR11MB548398604E5F223953DE6794E5E22BN9PR11MB5483namp_--