From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.120.1628217630896696948 for ; Thu, 05 Aug 2021 19:40:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=EpT6Cb+k; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: chasel.chiu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10067"; a="193888882" X-IronPort-AV: E=Sophos;i="5.84,299,1620716400"; d="scan'208";a="193888882" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2021 19:40:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,299,1620716400"; d="scan'208";a="420042593" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga006.jf.intel.com with ESMTP; 05 Aug 2021 19:40:29 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 5 Aug 2021 19:40:29 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 5 Aug 2021 19:40:29 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 5 Aug 2021 19:40:29 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 5 Aug 2021 19:40:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n0Kk3/19xkvjT+9IRH/90jzwoGPOSHBn3k2Y3abA87tDJF7wTiW0ugfanx4vvcZw9c30PA1kV1CE4doD0xs0p7/eMoTHRZKan6woZFvf8eN2c1sFDADY93dP29ComDz2+NfMjivo0CWqXLX95b7+1f7AdXQpksydGGmGJQtKXqxowl7FfaLdTEedYUaS/KNqGGm8abrfqYpCSsJHczkLUBaOWFQXTiP1bkBVutVhSKb3TaareB5PdCWIeTF3W9naBlkeic6Ekh0oVfWw1iQLl+6ufrtF+FcUrVuj5ygJ87igzulDhMD+QUwY5CPSkUSWXm7fH42tDMQEr8J3ThUCoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aBTJG+xgPVU0a+ENsytWWnd0RLy8oizWiHoLN/NOKOw=; b=gYykLwWqqszeXU97/FCtwM8WwKMXwl//Hqv/PldMNXiEI2HjSsKSXTn4xUj6PhvxrnHeDYn6WV09GfoX5K/ZepcAliKXo3gn3NTmyBleb3EjE3wPGEn2HnahCicZaX9V902UYYGj3RcugN6XiXlTG3yA3B88dDxRrMjqfbQw/jXq7DAssRkLCHE7ex3sQ2XCM8GBQ0eNMTBLpC2KS5tktRuCV9b/kZoKRLO8eCsDuEMHXsCVwaDUGxOsa1uMp5JrE8ue92g26xpL1TPZaWrf4UVvWMjk+fqSnM2PANT0Gz1oE0kjYH4pBGvwuG+oz4VlDoS7byYR2p1LgkF6a5Qa3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aBTJG+xgPVU0a+ENsytWWnd0RLy8oizWiHoLN/NOKOw=; b=EpT6Cb+ko9S7LFWeINbVvpqdgbdD8JIVBs5HLM88emo1KaWfoQi7RAuRuUGKHpcI7mJznKSIgTEqZKda7ZnvgKX2ubJ8F0/6b7K2Nmw7aQNa9aBIUA8fYZaG5mtwN/LSLXCiwOXJLaQ1MtOJep0ycrh9U1Lps5LD5DGbHBg6GYE= Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN6PR11MB1394.namprd11.prod.outlook.com (2603:10b6:404:49::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.29; Fri, 6 Aug 2021 02:40:24 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::6413:4198:3c40:777f]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::6413:4198:3c40:777f%3]) with mapi id 15.20.4394.017; Fri, 6 Aug 2021 02:40:24 +0000 From: "Chiu, Chasel" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" , Benjamin Doron CC: "Desimone, Nathaniel L" Subject: Re: [edk2-platforms][PATCH v5 43/46] KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Update for new SPI PPI API Thread-Topic: [edk2-platforms][PATCH v5 43/46] KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Update for new SPI PPI API Thread-Index: AQHXiHh7fI7K7+4iG0eeMhdmhwEYGqtlxvEw Date: Fri, 6 Aug 2021 02:40:24 +0000 Message-ID: References: <20210803150042.1150-1-mikuback@linux.microsoft.com> <20210803150042.1150-7-mikuback@linux.microsoft.com> In-Reply-To: <20210803150042.1150-7-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2c574355-8706-4f97-57e8-08d958838af3 x-ms-traffictypediagnostic: BN6PR11MB1394: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3631; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wNCdLfZ8Nkaoxuo3y+/HsBV/iteR5fyhND9tHNgqUTcOIP1SE0rUqmey+cbBYyzjcsbUn+tXAOAVlnwXKQCU0H2MQkYmzSskNDGuTc3NN9bliwfLX98ONobA7qpQ+JeEjqdLnYYSs0SClTVk/g8bMj/QI28Xtx0EI1+GpA8D+F3hM2aChGHalNFNQbN0y9EvcnpCXUiVcTFBeRf3fdFmCQ6+HsHRdDjJnDiWFZu7CGs8MzC7bPvAbIJsIHHxECADG35BWw4miVGNYMPLHnoTvfe+xuoDSDYK5rA4y70d7mwQJv2yCAg3cu1BV3bfs0GybySntd4I6UutaPS/v+AvRPh6BiGYCVQ6TfhzI/ges5ELRPoyXUcrH/FzuGRE1ptDLxt81ZZzmM+DKRzaJCp0QxRm4Y0SGosOKDHiQVRM+cjRx8YCW0+MWhy5Kv+Ic6LO1qrsae5CmtXM9zwjM0UBotszNJ3l5OHVGUrjOHqg55oysTPxFahtuJpiMHYBa9cwaBqDVAEbOm+arRqsJUh//4O7A2sa1JatT0Pgj6EDod8qQs7wJ+ARjGe/ph4v8MSEHosekl/wnZihfJHAA3RnKHu0/N3JxdH9pmneIEMuZ1uqfDIOaGabtVplTeRxFdiWJmFHzem48+57OoP1XmRZhTOlY6KlyHPlswCkF8H78/RU0lmNeyptNjSHUbdaF42PixD0UU/5gCcc5ps9U+vlgQzEluisqt8/gK2rJwANgUAni7Jtrvi8qyNCbwIa6b6YU8I8Aa3Q9YPgNXgP8ouKbrAT0pA/GtLCH5ocFOZ5IX51UmbrawEcpOEv4Qh9eo+E x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(39860400002)(136003)(396003)(366004)(4326008)(33656002)(55016002)(122000001)(86362001)(186003)(83380400001)(52536014)(2906002)(26005)(5660300002)(110136005)(64756008)(66556008)(8936002)(7696005)(76116006)(66446008)(66946007)(9686003)(478600001)(66476007)(8676002)(38070700005)(6506007)(107886003)(15650500001)(316002)(71200400001)(53546011)(38100700002)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fPZe5Rd/I9O7AUbhoZAmQRkW4abtNnnw6YqlY8hzwA7/4b3ed1U7f1+Oh1Ol?= =?us-ascii?Q?PPLahRL4K3GkXzS2v+eTyT+VUxGa/9DXD1d117sTif1ETxIhWc1EiqZW2QC6?= =?us-ascii?Q?mp43861PO2FDzjIIBVNz3t1kThd3a9WCtbDWtTVItv0zaFe6hZ1cN+QpeqDF?= =?us-ascii?Q?gB0wsIbvTC8zhhZVR5DTpINmwcBtjducLre3oDLcJbozmCYEza3pwogt2tKU?= =?us-ascii?Q?tTt0kQNt4bF/sE1SNWK5B7DUaZMdjBDsHchM3tkuwx6itde7GCxLrdzyCdTz?= =?us-ascii?Q?BWoCaWPLYwf+nNrq9yrJBAH6g6ebMzWDZA7YpWP/oFSg34fTlxPM7ltVFNwb?= =?us-ascii?Q?vA4HfnAiLZEaJ0h0x86HA3tzP+PudgpwH/aY9pNWt8/tkFomS4SLTV0MLl5V?= =?us-ascii?Q?Pr9vRqsBgjeA4AXH7fMiqPBb+c+wDycPsLU1ZBPHo2dEw40lM7jyq0YhuZic?= =?us-ascii?Q?BwrrvIqenkRCXwUirfp6Mm5/zlVP4qnlKgx0qZ6S6aWPBgvkADq7ZBVGIqoY?= =?us-ascii?Q?1FgQMjyUbiuOEcDrWLyF+07atoQ/6SO2Bf8l+9F1yIsJfIC0qTopE59PTnJG?= =?us-ascii?Q?dpYVwuT/0cevg4zqdYltw7j3ekVLqN62fnxIIN2CaBHf5BL1PhHypupGp0vl?= =?us-ascii?Q?aFhPj49BLoyXIX3ThrbNF+6qOLH4IJlTCXh24CG0fYGuZ68pLQLfpfreznYa?= =?us-ascii?Q?3KqOqqVCwjbVAf2DUvMSM94fOHgwE8SVHtaJ1QQFlTURSL7BhaI9Ky8nnwX8?= =?us-ascii?Q?NaDQVvtcj+5f6walrKeTKyHBi1b12huZ0j6KHyiVycGZY3xbp7BExtza9FD2?= =?us-ascii?Q?cYOBHdqJh/vsJbpQOoThOaYGSurmA/OPyTRJeUi8q641fj3TYX/7OYTyaPst?= =?us-ascii?Q?OxuZTGp0oH93O3wnMgy2vPD52/LHT3eWGHXnGxEupQlX19dTE8UwxI4Pfy5n?= =?us-ascii?Q?lC9Y+oUm9ANNOnpUCSl3IHYVu50mNugUQr1RaOVybceYDzawILO/8GRhBOT6?= =?us-ascii?Q?M66Bjb/4XvlfQjnz79O/GdINdo+P6nzLpp4Ef+hG2BANIOYnF85f2wM2gw9t?= =?us-ascii?Q?FdGsH+dujUZXf73KLhBUt/k91RVZH6wTmx+u/lMa4JLTfi+T9A2GPpkjmBSB?= =?us-ascii?Q?adjfjPewQXjmanwQz4jviW3FfXxPaDJBFyinaQRe5ZrSuKKxWHjUHIoYHeA/?= =?us-ascii?Q?OCNoaJDJ+lEZUeft+uxIs2O0P7mKJmew5PGMeiysxRSyLBvKgFNo0R9rAme1?= =?us-ascii?Q?Rbno/DjKiG5D62w+L7gYVbVpsj/ZVvnTfkiJRmArRu0Y8yMcmDhcDL2tyBAX?= =?us-ascii?Q?hM6xtagcyWMOHi21PZmIwv8s?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c574355-8706-4f97-57e8-08d958838af3 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2021 02:40:24.3554 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qra/qqSn/zcguDhMAju50fMKvXiMsQAKhtytkPaswveYqiGDdY3B9KYcmqgqSUUT6Q3dVOaSMKCBObhx8l1ChA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1394 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu Tested-by: Benjamin Doron > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Tuesday, August 3, 2021 11:01 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v5 43/46] > KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Update for new SPI PPI API >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 >=20 > Updates usage of gPchSpiPpiGuid to use the new interface that identifies = SPI > flash regions by GUID. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Signed-off-by: Michael Kubacki > --- >=20 > Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/PeiS > erialPortLibSpiFlash.c | 4 ++-- >=20 > Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/PeiS > erialPortLibSpiFlash.inf | 1 + > 2 files changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/P > eiSerialPortLibSpiFlash.c > b/Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/P > eiSerialPortLibSpiFlash.c > index fc48bdc6fccb..fe8883a8af29 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/P > eiSerialPortLibSpiFlash.c > +++ b/Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFla > +++ sh/PeiSerialPortLibSpiFlash.c > @@ -98,7 +98,7 @@ SerialPortWrite ( > LinearOffset =3D (UINT32) (FixedPcdGet32 (PcdFlashNvDebugMessageBase= ) > - FixedPcdGet32 (PcdFlashAreaBaseAddress)); > Status =3D PchSpiPpi->FlashErase ( > PchSpiPpi, > - FlashRegionBios, > + &gFlashRegionBiosGuid, > LinearOffset, > NvMessageAreaSize > ); > @@ -118,7 +118,7 @@ SerialPortWrite ( >=20 > Status =3D PchSpiPpi->FlashWrite ( > PchSpiPpi, > - FlashRegionBios, > + &gFlashRegionBiosGuid, > LinearOffset, > BytesWritten, > (UINT8 *) &Buffer[SourceBufferOffset] diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/P > eiSerialPortLibSpiFlash.inf > b/Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/P > eiSerialPortLibSpiFlash.inf > index b959cd1f4612..b8ae214f0920 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/P > eiSerialPortLibSpiFlash.inf > +++ b/Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFla > +++ sh/PeiSerialPortLibSpiFlash.inf > @@ -43,6 +43,7 @@ [Ppis] > gPchSpiPpiGuid >=20 > [Guids] > + gFlashRegionBiosGuid > gSpiFlashDebugHobGuid >=20 > [Pcd] > -- > 2.28.0.windows.1