public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "duntan" <dun.tan@intel.com>
To: "Ni, Ray" <ray.ni@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Eric" <eric.dong@intel.com>,
	"Kumar, Rahul R" <rahul.r.kumar@intel.com>
Subject: Re: [Patch V3 4/4] UefiCpuPkg: Add CpuExceptionHandlerTest.h in ECC IgnoreFile
Date: Fri, 14 Oct 2022 10:01:17 +0000	[thread overview]
Message-ID: <BN9PR11MB54839EBE456F9B27CF832814E5249@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CY4PR11MB1622E194F845413B774507358C249@CY4PR11MB1622.namprd11.prod.outlook.com>

Ok, I'll try to add this format code for R8/R9/etc.
"ExceptionList": [
          "<ErrorID>", "<KeyWord>"
        ],

Thanks,
Dun
-----Original Message-----
From: Ni, Ray <ray.ni@intel.com> 
Sent: Friday, October 14, 2022 5:40 PM
To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io
Cc: Dong, Eric <eric.dong@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>
Subject: RE: [Patch V3 4/4] UefiCpuPkg: Add CpuExceptionHandlerTest.h in ECC IgnoreFile

Can we use BaseTools/Source/Python/Ecc/exception.xml to mark exceptions of R8/R9/etc.
instead of ignoring the entire H file?

Thanks,
ray

> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Friday, October 14, 2022 5:20 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; 
> Kumar, Rahul R <rahul.r.kumar@intel.com>
> Subject: [Patch V3 4/4] UefiCpuPkg: Add CpuExceptionHandlerTest.h in 
> ECC IgnoreFile
> 
> Add CpuExceptionHandlerTest.h in EccCheck IgnoreFiles of 
> UefiCpuPkg/UefiCpuPkg.ci.yaml to pass ECC check. The
> GENERAL_REGISTER.R8 in this file triggers EccCheck failure since no 
> lower case characters in R8/R9/R10.
> 
> Signed-off-by: Dun Tan <dun.tan@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> ---
>  UefiCpuPkg/UefiCpuPkg.ci.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/UefiCpuPkg/UefiCpuPkg.ci.yaml 
> b/UefiCpuPkg/UefiCpuPkg.ci.yaml index bbdc44a45b..1acc6daa76 100644
> --- a/UefiCpuPkg/UefiCpuPkg.ci.yaml
> +++ b/UefiCpuPkg/UefiCpuPkg.ci.yaml
> @@ -19,6 +19,7 @@
>          ],
>          ## Both file path and directory path are accepted.
>          "IgnoreFiles": [
> +            "CpuExceptionHandlerUnitTest/CpuExceptionHandlerTest.h"
>          ]
>      },
>      "CompilerPlugin": {
> --
> 2.31.1.windows.1


      reply	other threads:[~2022-10-14 10:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-14  9:19 [Patch V3 0/4] Add Unit tests for Pei/DxeCpuExceptionHandlerLib duntan
2022-10-14  9:19 ` [Patch V3 1/4] UefiCpuPkg: Add Unit tests for DxeCpuExceptionHandlerLib duntan
2022-10-14 11:57   ` Ni, Ray
2022-10-14  9:19 ` [Patch V3 2/4] UefiCpuPkg: Add Unit tests for PeiCpuExceptionHandlerLib duntan
2022-10-14 11:58   ` Ni, Ray
2022-10-14  9:19 ` [Patch V3 3/4] UefiCpuPkg: Add Pei/DxeCpuExceptionHandlerLibUnitTest in dsc duntan
2022-10-14  9:19 ` [Patch V3 4/4] UefiCpuPkg: Add CpuExceptionHandlerTest.h in ECC IgnoreFile duntan
2022-10-14  9:39   ` Ni, Ray
2022-10-14 10:01     ` duntan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN9PR11MB54839EBE456F9B27CF832814E5249@BN9PR11MB5483.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox