From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.4765.1672888173323234216 for ; Wed, 04 Jan 2023 19:09:33 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Y9Qpbxxe; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672888173; x=1704424173; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=e/RbmNjJR43LPjhf+siQrW4maoQ9tGWnkQh5JISUwas=; b=Y9Qpbxxe/4VHHFuZBhg0Cjf98h1yZrEXlXzNggc7qsUAAlZFKuvwn09Z p9iywmxDiw1+CXc9/k3SAkGeqsPx0ttZn08gGtk+lGHoz4GWx5rN9D8NN ceocExpbewrksawK4+gROjiKlY45LsWFLIFb18Qv6OsTL69MZ27osWhAA +BLU+uQVuxfV5DN1XIGa3maqS4jPLGxUhFSCVtulVR9KdPsRzwMtLVp9j xWSIOGqlZyZ0hoOypVQzrrafJWdcYxa3IECj0eNvrLMwYsmpHCIp2g/2/ vdjUY9eQ0WTAJkXAw7vkSCLBv3nI4oGbpoOYtKGpQIGA04miLN1J9EsCD w==; X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="320812130" X-IronPort-AV: E=Sophos;i="5.96,301,1665471600"; d="scan'208";a="320812130" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 19:09:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="687746833" X-IronPort-AV: E=Sophos;i="5.96,301,1665471600"; d="scan'208";a="687746833" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP; 04 Jan 2023 19:09:31 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 4 Jan 2023 19:09:31 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 4 Jan 2023 19:09:31 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 4 Jan 2023 19:09:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wr+PpZ6GtdsLV731rSYs54wuDDOGqw9QwIUlN+Wu6gcf09W5Lv770A/+cAcyZKbGovHPYesNgIVN0IGlrI8fsavlRNNUFdy4MvsAmVgMTm3GkySjaRjBvLYbPWN4Xx0RA3V9R057SfdgSPCJCa86mGTivQk4fiude8PchX5cz5sK3FaU9TU9xarkfF6vVA5UbmiOQNROpvIYOEAHSXvcmyPgDYL2VUxZjzugP9w//6/NptVwbGWMB97c8n6o83ID83Fva6yi1fT0bqg0oNwrcT+Yjlb9sz46PWAH7TXOsCdXz9aCSizDWPSS25dJYF72zsrtSMN5+yL3PIh/eEay4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=azSEZLdKBvJnuQURKlestW6edMoPqfTvtNZtMM3x8iw=; b=ZyefDvsV8wRtaYEhv2AZfuo6hffjDAMFSVTNnTToAe4/J4P5+P7j6289UAy+bMWdoSzgrVDpHXTNufz6af2KaUwTyemqXLodiP8B3hEuQqCS10/f0wVA14b0Xi1nSoVwclskYz92IOPBhU7aiomv8I+1S6QyKoTEYdZnJoPyyC9YadxIhVC5PnayC4BhWX/i94g2xshWOS4ZewccGE1ybrCW85Ykto5R+1ebr8Ipe0kZB3H7itPVMx/yJQv1OdzUW2+k8LSfY3+MKTm0Kz5tONeSxz74SPxwKAIjr+q9sB6GpPs/V6UpPIjJ3JKpT5/Ej4JLnLK3Op5uHVaY/plwJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by PH8PR11MB7071.namprd11.prod.outlook.com (2603:10b6:510:215::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Thu, 5 Jan 2023 03:09:20 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::ca77:cd37:7de9:ec7a]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::ca77:cd37:7de9:ec7a%4]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 03:09:20 +0000 From: "Chiu, Chasel" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Sinha, Ankit" , "Ponnusamy, Suresh" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiTables: Fix EFI_ACPI_GPE0_BLK_LEN calculation Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiTables: Fix EFI_ACPI_GPE0_BLK_LEN calculation Thread-Index: AQHZIKXdZSM0jX+Sz0ucvqUMu+F1xK6PJLTA Date: Thu, 5 Jan 2023 03:09:20 +0000 Message-ID: References: <154285e560df24b2cf6a0a7dd9b09577dd10ce37.1672882404.git.isaac.w.oram@intel.com> In-Reply-To: <154285e560df24b2cf6a0a7dd9b09577dd10ce37.1672882404.git.isaac.w.oram@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|PH8PR11MB7071:EE_ x-ms-office365-filtering-correlation-id: c5385596-dac7-4e0f-47cf-08daeeca3d27 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pu7uG7yV+DoqQtoBWvCWSkBcaaMcaQdiWl+gkTWYcdf8+3N86Bu+QTyJylbIel9WwWdFgd+ezWwv/It025Up4VJ5HIDEFUn1zMuCELMQ7u8biLdNu7aAd7N01W/zZMIWgU2u0T6DiFn/j7Z4p+/FAVzaaUW8orXTPxuTfiOoJJ08SHIkffomoXOp6pu0cu1UPE+W9VtwZqXWP7cUKggn15idjMire/Z5+buRhVKoSHQ3Ct3YOyDCVDS/uguwR6Yc0/EgKuG0O1AjxODcS6/jI7Ybr9Sh7wE1faPCvcKZHKEgUl+AQA9xTPwlnjGMgP8vEWILmZ7p9GBSQrqFR3ydvDM+H0b5uSD6mBWT0ZBJg4ecGU7zcu01094of0wPt7NC9JZlrUwthUnEL3YV7DTun8SGmRtM0D9+BcVVLEJEotXSfN+2XM37tpiqgaluIe+jMpzEHIK81E4IBGYXgB8ofpjIwQcjwQtyPIGK0SCjTCEyJZEwF9/woQs0xIM3t1I0GvO7SlY+W/Y23WCQ6QDkZmjZ2zazWd37aGKEB0kccj/OHi3Ab15qGU6wwx7u3Qez6pDJa9+U2/LIvgpS3wRoGZANlEZfnPegVoZBYUKOZGJta4HfTtHgVZ7tgsVnSieMUPGejMuq0w0lYi4WlLeX4mVwxcC/ghHIrOfZ+mNJG31WqIGETXKA5nZMqehkw9EsFhJ0WAZNbprp6g3my+3w/g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(396003)(346002)(366004)(39860400002)(451199015)(66556008)(8676002)(66476007)(66446008)(76116006)(38070700005)(66946007)(2906002)(33656002)(41300700001)(86362001)(122000001)(8936002)(64756008)(5660300002)(53546011)(478600001)(9686003)(186003)(83380400001)(19627235002)(26005)(38100700002)(110136005)(71200400001)(55016003)(54906003)(7696005)(6506007)(316002)(82960400001)(52536014)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?R+e26ylqZdFgGZJZ4aMeWFO/28HHvaEYlsCCQEtPSQvKzNLGGvhpn+jvW3pV?= =?us-ascii?Q?k1lipy9q3yU2snhcUkydlaqLpF25DLJ0kRbV2TvGREJfi6GvaNx1HqPsCDHj?= =?us-ascii?Q?YPOkBrcdMmxlF22nzXxler14ExoUP7y0uneMYx4Z/82lgVyJT1mNAS32ECCu?= =?us-ascii?Q?gY5X/EtZMiP5Hch0RGW7jp2npyhUhkH63X2Rubd5X5aiwawena6myS+MYeV3?= =?us-ascii?Q?oO8PLd07D8r39DqIFxZ3ROTQF5bkWGMwEZ7YxkGhxVpR2xhaOcmJIfHcjhuI?= =?us-ascii?Q?iRaZ/0+aK6U+ao/J6HqtsOzGA+7NupbFY6McrlaX4ZW55MJmXyWdw8sR+VIy?= =?us-ascii?Q?mRAZOzxZhgPGxLwCY7QTX6ScJ7YLBFLdzM54jlRCrMUhjfDMKTl0drN9TENn?= =?us-ascii?Q?e5qB2rBL2JB5aT3ASexWzupFOsfGxvKWgXyqDqS1iBkRJcneK/WswlA1I1CP?= =?us-ascii?Q?f9orq+gcsdKdDu6bwwTEotYZc+YGv6s725RfZSFQia0Jt0haiGFl0ZThwIaY?= =?us-ascii?Q?k48u2lVP9gSvy+kokAC+gxhPAS6m5jkoT0TX+M9JKtOrW1u1unxIOmR0T/88?= =?us-ascii?Q?KtxDRFpHG6yT8XQy4l2EJ32u8SKgXtlFZIMCBYJMqk4uFN4e79YS6xQCP6BL?= =?us-ascii?Q?DaxzctxneGMHxXrhsWvBKHYCUPhdPU7ci84MzXkwn41kNBBU85ld/rK/SViq?= =?us-ascii?Q?hczk3ZY0FXrEy7Msx0WcX2EErK3Y55gKz6F0TpmjpyRWG6L9MLQ4BqIgT7Pt?= =?us-ascii?Q?lK851BUmWNGdqtmKzzUSdruMjqASETJs7x0B/qFM2VqTiR2ZlN9rbUsKmZKr?= =?us-ascii?Q?OeNhhZm/0iUrlFow7lVAEn4LYl2v3GcCHnX67xysCJ6oXC9SVYl/7/okZHyU?= =?us-ascii?Q?5p8/kwaFhKD6rLraG0slA+XsDvMcX/bAHmzybg7U9dTSYnkBg9qKjetP3Iuv?= =?us-ascii?Q?aC4UMR8k7oeyY3W+uKV1D8ZwKL2Quhv/Fu2rXXLTZiUZX9drFbmGYmNhgX4K?= =?us-ascii?Q?6TmsxwuldHUgV1ZGnJjAUVde7FxhL7RQz2dWAQt+3Brhz+2xkKXEqVF650Dj?= =?us-ascii?Q?U26LxQhsxP6DRSwYh1EdlTJSc1mPbHaFPoxj0EYou50YQ/0irYCZeJTjhspN?= =?us-ascii?Q?LAbLtt6u4HamVr+AhdJ8h1ZJjQWQf05gFUnLVI4de/nnP8c7m2xiog9HD0zF?= =?us-ascii?Q?JvpfzwuaQlpxEWBcXmjYfyrfiiWbsb0Px6cJINBfflLrF1/VtEoSgy+H9yM4?= =?us-ascii?Q?CQAfWGAPdXAc9EKPgRFi6x7bQROeFaeu10q+N/DdK8HJbTWmxYT2cbkyTMXH?= =?us-ascii?Q?fXJ+Xl44GTROo58Z6bdQGz/WdcaNV71/TDqxVCp7Kz6mXTev2l9iZiw9YlMm?= =?us-ascii?Q?TBebTKVQOKC7QhSS0wpYZWmm2n8Gxpv5mb3WUYKeaynNFB9Bnl6Kaw5BXMqG?= =?us-ascii?Q?rF71BI7jj3b8IDZEjO821MXKBMzDUg/jRPZJ/j+IAG+Q6mG2OKYoWD0IZEKP?= =?us-ascii?Q?BoT5Difz+u2GLBaAmS9+2LWQJWEAgCkAfjJiIQXDc9XX50FUlUyxPPLajLXP?= =?us-ascii?Q?/cg6iCJw5xy+Ql61vqKmxcLqZyb5QjWz8qpbAgN4?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5385596-dac7-4e0f-47cf-08daeeca3d27 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 03:09:20.2498 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rgVvA5rrLq90ckggMDqLw5uSKRCUA9eDtU20qL/V7s4+YilTGi/LOKkd9q6jAPlEV7xi27Ez75WAMXMEVePcSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7071 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Oram, Isaac W > Sent: Wednesday, January 4, 2023 5:34 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L > ; Chiu, Chasel ; > Sinha, Ankit ; Ponnusamy, Suresh > > Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] > WhitleyOpenBoardPkg/AcpiTables: Fix EFI_ACPI_GPE0_BLK_LEN calculation >=20 > Block length incorrectly calculated off of the block width. > Reverted EFI_ACPI_GPE0_BLK_WIDTH change and added #defines for > X_GPE0 and X_GPE1 contents. >=20 > Cc: Nate DeSimone > Cc: Chasel Chiu > Cc: Ankit Sinha > Cc: Suresh Ponnusamy > Signed-off-by: Isaac Oram > --- > .../Features/Acpi/AcpiTables/Fadt/Fadt62.aslc | 16 +++++++------- > .../WhitleyOpenBoardPkg/Include/Acpi/Fadt.h | 21 > ++++++++++++++++++- > 2 files changed, 28 insertions(+), 9 deletions(-) >=20 > diff --git > a/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiTables/Fadt/Fa > dt62.aslc > b/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiTables/Fadt/Fa > dt62.aslc > index f37cf0a508..b7f15ef716 100644 > --- > a/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiTables/Fadt/Fa > dt62.aslc > +++ > b/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiTables/Fadt/F > +++ adt62.aslc > @@ -143,19 +143,19 @@ EFI_ACPI_6_2_FIXED_ACPI_DESCRIPTION_TABLE > Fadt =3D { > // > // X_General Purpose Event 0 Register Block > // > - {EFI_ACPI_GPE0_BLK_ADDRESS_SPACE_ID, > - EFI_ACPI_GPE0_BLK_BIT_WIDTH, > - EFI_ACPI_GPE0_BLK_BIT_OFFSET, > + {EFI_ACPI_X_GPE0_BLK_ADDRESS_SPACE_ID, > + EFI_ACPI_X_GPE0_BLK_BIT_WIDTH, > + EFI_ACPI_X_GPE0_BLK_BIT_OFFSET, > EFI_ACPI_6_2_BYTE, > - EFI_ACPI_GPE0_BLK_ADDRESS}, > + EFI_ACPI_X_GPE0_BLK_ADDRESS}, > // > // X_General Purpose Event 1 Register Block > // > - {EFI_ACPI_GPE1_BLK_ADDRESS_SPACE_ID, > - EFI_ACPI_GPE1_BLK_BIT_WIDTH, > - EFI_ACPI_GPE1_BLK_BIT_OFFSET, > + {EFI_ACPI_X_GPE1_BLK_ADDRESS_SPACE_ID, > + EFI_ACPI_X_GPE1_BLK_BIT_WIDTH, > + EFI_ACPI_X_GPE1_BLK_BIT_OFFSET, > EFI_ACPI_6_2_UNDEFINED, > - EFI_ACPI_GPE1_BLK_ADDRESS} > + EFI_ACPI_X_GPE1_BLK_ADDRESS} > }; >=20 > VOID* > diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/Fadt.h > b/Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/Fadt.h > index ebfd21b6cc..8857879370 100644 > --- a/Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/Fadt.h > +++ b/Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/Fadt.h > @@ -152,10 +152,19 @@ For Watson Creek we set this to 0 and then > dynamically update this to 1 in the D // Information // #define > EFI_ACPI_GPE0_BLK_ADDRESS_SPACE_ID EFI_ACPI_6_2_SYSTEM_IO > -#define EFI_ACPI_GPE0_BLK_BIT_WIDTH 0 // size of > R_PCH_ACPI_GPE0_STS_127_96 + R_PCH_ACPI_GPE0_EN_127_96 > +#define EFI_ACPI_GPE0_BLK_BIT_WIDTH 0x100 // size of > R_PCH_ACPI_GPE0_STS_127_96 + R_PCH_ACPI_GPE0_EN_127_96 > #define EFI_ACPI_GPE0_BLK_BIT_OFFSET 0x00 > #define EFI_ACPI_GPE0_BLK_ADDRESS > (EFI_ACPI_PM1A_EVT_BLK_ADDRESS + 0x80) >=20 > +// > +// X General Purpose Event 0 Register Block Generic Address // > +Information // #define EFI_ACPI_X_GPE0_BLK_ADDRESS_SPACE_ID > +EFI_ACPI_6_2_SYSTEM_IO > +#define EFI_ACPI_X_GPE0_BLK_BIT_WIDTH 0x00 > +#define EFI_ACPI_X_GPE0_BLK_BIT_OFFSET 0x00 > +#define EFI_ACPI_X_GPE0_BLK_ADDRESS > EFI_ACPI_GPE0_BLK_ADDRESS > + > // > // General Purpose Event 1 Register Block Generic Address // Informatio= n > @@ -164,6 +173,16 @@ For Watson Creek we set this to 0 and then > dynamically update this to 1 in the D > #define EFI_ACPI_GPE1_BLK_BIT_WIDTH 0x0 > #define EFI_ACPI_GPE1_BLK_BIT_OFFSET 0x0 > #define EFI_ACPI_GPE1_BLK_ADDRESS 0x0 > + > +// > +// X General Purpose Event 1 Register Block Generic Address // > +Information // #define EFI_ACPI_X_GPE1_BLK_ADDRESS_SPACE_ID > +EFI_ACPI_6_2_SYSTEM_IO > +#define EFI_ACPI_X_GPE1_BLK_BIT_WIDTH 0x00 > +#define EFI_ACPI_X_GPE1_BLK_BIT_OFFSET 0x00 > +#define EFI_ACPI_X_GPE1_BLK_ADDRESS 0x00 > + > // > // Reset Register Generic Address Information // > -- > 2.39.0.windows.1