From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.4892.1685678370252934021 for ; Thu, 01 Jun 2023 20:59:30 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=cCS5hSWT; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685678370; x=1717214370; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=thQp7YUuGhpPnsI6nEAgAnWMyVAviemxz2wAa/xsryM=; b=cCS5hSWThdFVypqyA2/fQ7yr9jhfeyYR4dpRWGwemdDdtlHQ2sdBfReR HER541Gogej8vcKc4EFRHiFZJ2nTwZoEOykfHm0rDFsdGlOir0C5G/fz9 2T2+W8rTEnT4qI32Es+MDiVHMmgV1jDsgwIM9X6jgOx7KeMZ3m7apscJ9 PMHfYJBsNynwwlTw1sRzg0GXhyTu9CF1HvL/gN4nbsC0SIlJG0kgNjT1s gNf7t5rdoLm/DbLZ9AOdHHwi8IcY80jcriXJY3Z7I4D38Yy/nQ6sNnCn6 OcXq4ODf1wCCvDOR+BVB1UTsKXAQ831GzkWJIURw0RIN6t2N2qWmS2U5p Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10728"; a="345335958" X-IronPort-AV: E=Sophos;i="6.00,211,1681196400"; d="scan'208";a="345335958" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2023 20:59:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10728"; a="701800778" X-IronPort-AV: E=Sophos;i="6.00,211,1681196400"; d="scan'208";a="701800778" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga007.jf.intel.com with ESMTP; 01 Jun 2023 20:59:29 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 1 Jun 2023 20:59:29 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 1 Jun 2023 20:59:29 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 1 Jun 2023 20:59:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SZD5jbdmAjsYq9knWBygmjZ4c3kTr65VpjOf/E+HJaF5/dwFC1gqcQhNIy+Mk3giFZxbZgesIrL/skFiL7eTR5v0/0yWHy1iXNt5DEvXux7nUAYdDIS4PpkNQ33qbUTFIZ2ENKyyRG2KnOYSDIL/kz5B+TvWH7w8yqViNIyYqc4ftTdDHRb5nlS8nc0GDBZCzrio1MiVoteIopWrj1eYX19v9F+MMqsriSkLynZ9ZKnFeezk+3B5HGqbHvXg9kiaWC3j6ekmaeCZglPBEt/QwT4/TKywqxOxbMDvht2WEEGNSianA5uyahTaRHnCT3FPWTChjkSDoXYUc1EdyZJ2Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3gD0K6p3zIUZz/qFfV5gkMsddtnMofs7frUVzEpCRyU=; b=YXAMW4Wy0iwvEecKBCVsj+6B1Rjz610l8eSX8E7fdfShJeSNPIk/eYwdwgqn8MX/U56938S9NiUcZARw/LHkh40rxDmG2DVSUeqml9IBXAd7ByhPNFASKlHFi3+6Yw5H009CJZuv85EYQBhwq1lgu4W17SQhs8Ks0KSOifDuzzR8cjB5qIsRI9xCFAWQElHip86G9nQcviGzkyYevBWujg/QZ2kWkA7tmjhZeXlasq+qrWH/BDTrIHt599RWYB2ohtvC+/aIZCi5D6Sj3jb2bNonb+DlNzcFxcim+OqNcQdcsTePrvuLyW3FopYCNPit413w7YSeVh9lscu5VibkZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by IA0PR11MB7353.namprd11.prod.outlook.com (2603:10b6:208:435::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.22; Fri, 2 Jun 2023 03:59:21 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::3023:34d3:bd4e:7901]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::3023:34d3:bd4e:7901%3]) with mapi id 15.20.6455.024; Fri, 2 Jun 2023 03:59:20 +0000 From: "duntan" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [edk2-devel] [Patch V4 14/15] UefiCpuPkg: Refinement to smm runtime InitPaging() code Thread-Topic: [edk2-devel] [Patch V4 14/15] UefiCpuPkg: Refinement to smm runtime InitPaging() code Thread-Index: AQHZlQX5sBtrjd+C702R/vwTi+gcDK924soQ Date: Fri, 2 Jun 2023 03:59:20 +0000 Message-ID: References: <20230516095932.1525-1-dun.tan@intel.com> <20230516095932.1525-15-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|IA0PR11MB7353:EE_ x-ms-office365-filtering-correlation-id: f8e6d772-2826-4cb1-d550-08db631dbece x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rx3cyXJFbD/ZnnNp+6v1h8g+yg8icoCuTPxIBhpEYD9kQBK31zaR0hOxtuXjdwdFlqYwcM/7mgeozqfnmylaJCyRWWP+uEsG9ocNd501jYmM52vJST/nID/YFx3OeUM7GPPo0Ts0osp4xXTqyIkk7AM+Ks79xORKIhFTbWGzQ46hxYm/HKAa9FriNpPqHCmK9CAhPHnp1c4Ibz1KnjOxgyrCY3Wyps+a2gaN4MmwE3wdHyWiFWy3TkLHLMZMlBsQGHhNoyLs6W8l673B6fg+Sdxb8ADrOyfyWlZoNgEf9Q2CUQCK+71iSVabgVXDoQRQr0nwYGba9P0dVxyWmtxy33RH+RqLWyLQ22Cac/twngxaPQdQOzbr4oAs99/37ZKke0s2hCktCx4Gpy//dG3/75TDTU6niNeaKAOA6BZxBXBJ+2L9nXZEQZUPXUJO3PS0Vw0rHAoGWKzaRwGX8Zkn24wdJAk7nbO4nboH0azqP0H1+mJEu74S/5oKSHVACgz3yBQtU+unjZxzwDu5NwHUp89U+u7tQa8G6xVVj1Y9J7i1ZmNrK0Rsy0ccQqQp6LvoXKIa1WupmMRUYXQwxig8t45buEfujm3CcIoVJ63M8kqKdBOa9eK89ZK311aREaUA x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(136003)(39860400002)(346002)(396003)(366004)(451199021)(26005)(186003)(33656002)(7696005)(6506007)(9686003)(53546011)(71200400001)(316002)(2906002)(55016003)(52536014)(5660300002)(41300700001)(8676002)(8936002)(4744005)(122000001)(82960400001)(38100700002)(66446008)(110136005)(4326008)(86362001)(54906003)(66946007)(76116006)(38070700005)(83380400001)(478600001)(66556008)(64756008)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?h0hPUcU5hbleZbUo+kfAD2AXWe4vYJoIPr2H4y8Af37wEPtc2taMvAkhayZ6?= =?us-ascii?Q?7Zms/4KSmyupcL6cJRvbyetPfEipXPIq+V9bq9vXe68APwFzlhD7cRotQgkh?= =?us-ascii?Q?hG3pH5iPsL0jPonZQS8jgrhaONAYOtoFwiyD+tl1dsj/x4tAD9e0goj6/JcB?= =?us-ascii?Q?Gza3VHAUv/Oau6r4KzRJ1Qm4HQfypsmbUpe5EomYDCbTnG8jPa9qNrxDVcDR?= =?us-ascii?Q?tGetoYdqw5dqfGQaz6YK6MVmXRQjkoW9LmODQtdlZCEvx9griU2TLCae2mUc?= =?us-ascii?Q?EybwxWreCGR84eWSnp06m/29MSYSjuqguZgiIcqScsKUIfqQmqn2cBDTB1UX?= =?us-ascii?Q?A/A01YxAYM0G8kLsPeYvYSvrHueX2H32YR/hrQBC6jQdzKDUPKC0SBO6X6T8?= =?us-ascii?Q?o0kZmhGNCMkKeexHAVtQiC6IFq1jGoBOIWi9ywIA99HPt+//XVuUCu5vf8AZ?= =?us-ascii?Q?hoFu5e8RIaAQ7B44xMQSAgAPu9he7Z349KF4WzJvaDno28wQ6aO9nC/xVqsb?= =?us-ascii?Q?YmMNN7Vk8vymO5cego1qN5YI0MORG/sPeGOZUln0XDDegIwPZzCJh+vnsNwP?= =?us-ascii?Q?GU6Cvre6rfwDZBCP3FOAQwsLPsRe7OTl4SMb95IQTZOwQb0TYxpngD7MmV0v?= =?us-ascii?Q?AivnmWe5n7Rugv/RVO9RQJDUImn44jxYGRO4FqUMm04ZVFszrKZLy4XUNFF2?= =?us-ascii?Q?WYTMyWvNVLagoC5XOaA/GfLtXn3b1XLu+HLW9dWOllrpWUZMb91tQdLgzA/z?= =?us-ascii?Q?HQk0wMjqABpWdUR7YFfdn5LIWBm4cw8AT+pMz24wtJqKFOcxnzU/vTXQCKuT?= =?us-ascii?Q?7w9JqzsC40He6/9R96cz78/1xl9EeLdy/Iul/aheUUgzxsZE2z7U+BVz10xa?= =?us-ascii?Q?U9oeBm0tELI4L/YS1jV/d1vgCeb1IGz08aAUT2TNdBCnqV3UwulgdMCfNgph?= =?us-ascii?Q?U57nZmxb4YWcaBNZBXdi+UqWxHIjSs8lOirvLlAiGvDS3Alw6cRivFXEN5hi?= =?us-ascii?Q?RZIqxKIFWo5bSFz0CIw7ImD0jMIn3rU13QYDb+6OKhvcDUqHi1pllUyqCdIt?= =?us-ascii?Q?zgppss2kVlNsKGkgslATXXmrFtgZvwj/3DW2JhYYi3+vrPtGzm/Vo43E97xw?= =?us-ascii?Q?8mTjFdFvL+17SANlzoEJRArlsRv5n2kppAQgCUrmOSNc3BgIn+N93SR8f1JT?= =?us-ascii?Q?W1LuVs7iWBXmt/IiJfNLA3tSRNcghs77HaC/GlyvIc7eFjwo81p0CMsaXRHV?= =?us-ascii?Q?rlnI6OJjO/LG5RqupHAg9f76N1NIcnUDwe/XLLrI5ULUPEnTWAfA+F88ILTn?= =?us-ascii?Q?zZNr1lB1mOYEjuKKoh8HozOASwuWxnhZlcyLYVS8JcNRQcTS9gCYbeuBPxCU?= =?us-ascii?Q?lkePzSSnc+yMa5W2J/wWkuefrxR35IbKXp7MVdDTZZ3NplRcc2Rykum8i6Ck?= =?us-ascii?Q?G53D4JTyUe+Pf6q6emZga4daBc28qkc0pfUgn5NdtMlopIaNq/B3XxjGI6ZH?= =?us-ascii?Q?sSbm8vTXc/Wxe+Ag05tZ8WJmjlEYW8nXG8/T57SvS5egFI1Uxzj95iuQtGIc?= =?us-ascii?Q?QS28f0Ky5VEdPjaNNSA=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8e6d772-2826-4cb1-d550-08db631dbece X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2023 03:59:20.9291 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +nCymTLPAwAHfRvq7E+mrtVGemfSIDDpx+8FObhFMDG7t/3MTsl/mFzUtUHpfUe+OuqYZhWdbmOt2+ekfShiNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7353 Return-Path: dun.tan@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sure, ConvertMemoryPageAttributes() can handle this. Will remove the "mXdSu= pported" check there in next version patch.=20 Thanks, Dun -----Original Message----- From: Ni, Ray =20 Sent: Friday, June 2, 2023 11:55 AM To: devel@edk2.groups.io; Tan, Dun Cc: Dong, Eric ; Kumar, Rahul R ; Gerd Hoffmann Subject: RE: [edk2-devel] [Patch V4 14/15] UefiCpuPkg: Refinement to smm ru= ntime InitPaging() code > + } else { > + MemoryAttrMask =3D EFI_MEMORY_XP; > + for (Index =3D 0; Index < mSmmCpuSmramRangeCount; Index++) { > + Base =3D mSmmCpuSmramRanges[Index].CpuStart; > + if ((Base > PreviousAddress) && mXdSupported) { Is "mXdSupported" check really needed? But you didn't add that check for th= e last remaining range. ConvertMemoryPageAttributes() can handle the case when XD is not supported = by CPU. =20