From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.48973.1681317668681204629 for ; Wed, 12 Apr 2023 09:41:09 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Dsz8/Skv; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681317668; x=1712853668; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=wN6rqmUr1Lvnp8Q8Kkyq0fqbtL7hTh5otmXJwTU8SkI=; b=Dsz8/SkvTWl5D9ZrdrQYCyGosnJPrVTh8hR/ZP5mGhz16iF+GoyQrJYr lUikN1a57vSy9ril9OUGYmOH+O8ZsyWydf5MuRDJtMzMeFOsLbho5ry8g EPE9FoO6Jszr1hW+PwO5MLCeuk4jfLQlojpCyFAfKDsvjLQEFGKC/qAoQ 1/pzrquz044MuIoHiwxl3vePcAYsBEuc+dx2BKh/T80t/lfcZ01/YCuf6 ABEbfijAeLc8Xfbn1h26OjKZa5cw1xTEKW9UxYwFUwGxwMM5iBazKPjua JHL/FRqqc0HDs3qTNHBtJNj/8UQ/1vzjwWpGWtb5ucmcd9/28pYmME39/ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10678"; a="346630702" X-IronPort-AV: E=Sophos;i="5.98,339,1673942400"; d="scan'208";a="346630702" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2023 09:41:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10678"; a="832752483" X-IronPort-AV: E=Sophos;i="5.98,339,1673942400"; d="scan'208";a="832752483" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 12 Apr 2023 09:41:06 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 12 Apr 2023 09:41:06 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 12 Apr 2023 09:41:06 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 12 Apr 2023 09:41:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WsOZFigUMK3mvVA2yptQ0OjnTSPwIK+vxo9h81tYYKFavBgZT43A1i6vUScYrwY7hNT6x2JF3tDD5/ei2ca2d0bKm33mRiM27ZGYLsNVB3plA40KclI0ccBT6Sm76uo6BqN98Q1gl3yy5a0xmyx5k1VW+MKwiiGsG4IKvJlhTwLyrMAICp/SP6znBOzTwoQYU62sLsCoUoqSiUvzFNG17BtfYc3sPHEc1qlEh2TElwGx2fRprV2deALAeAzwKjcEy4f+0fh/pJkOPrnrwL10wBKVXaYEvPiQXzWrvMgA7JXbq8awPL+IIpiChXdCTy/kJXSKuPkH4rI7KtuKXbplhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bX6lZqNrL7hzEjmoy9uRnl0gsAeFKmxQPOBNy+JjyOE=; b=b4ETcLUSNb1w+qyAuJAYjZdAOq3d3qAXJ4cZPa5pMG0Abo7EQ7SoWORI0I6UOjyxNyERtx+Re1vWAAwO7K85WJYXICf1cbXMl6uEPRcbG0RUt7Smu1lrq+7oEJqwwJ1z/MmrN3TJtZb77iMqmi2D4uRDJbd+XU0e11TkDHPqPOnwiU+2UWQ6mYzr6mET8QpQCQFpFOVuJmwPvXEBxCybK8oDtQ9DY7LTGhn0qCPbW/41IB+QWOS/xTck0zmYsu4j91d/swBRfx2gdoKQrCEpgC6dChrfpdXbxK7XFA49yXtZOWI4ajrNstrCMBkyjvAOz2ahgKIHejAI9LEYN97PUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by SN7PR11MB7592.namprd11.prod.outlook.com (2603:10b6:806:343::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Wed, 12 Apr 2023 16:40:59 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::1eb1:2222:1823:8e7a]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::1eb1:2222:1823:8e7a%6]) with mapi id 15.20.6277.038; Wed, 12 Apr 2023 16:40:58 +0000 From: "Chiu, Chasel" To: "Chen, Aryeh" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Oram, Isaac W" , "Gao, Liming" , "Dong, Eric" Subject: Re: [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package. Thread-Topic: [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from board package. Thread-Index: AQHZbVud9LTNbmX90kqVlXzhQysZrK8n4CsQ Date: Wed, 12 Apr 2023 16:40:58 +0000 Message-ID: References: <20230412162648.308-1-aryeh.chen@intel.com> In-Reply-To: <20230412162648.308-1-aryeh.chen@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|SN7PR11MB7592:EE_ x-ms-office365-filtering-correlation-id: 39e59a79-c460-40d9-aa36-08db3b74b18d x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fW7s1RPrcMTsRUTzfeUhsAiOv8FRkYs4XhadT7vGO9pEfRX45DGkKU3xP5cicNBDytBJU/GsBPZQX/fz+P7slqWaj03fHRhBbtIJqhTPmbOQbTNcKV8jUaLM0NRtdFdJXtsWoPrtOjpMrdGlEsyKq1urlpW/d5v43eb/7e3V3k0lSm6StNFh1N33qppkB4FoKBpwyBK7SMZzgw5rqSQf/DlXCizXuSSovfQbbkJAK6QWgW2u+PZksRQr5GR3honKrEEZlkGbxo53x5uLOb8a2iigpI9lFSHzcplge3x4c78egu021LoQXLZ4AXmiULxYnh2z1/GZCB+pmTa+ChYLkekdHnL/2Z0c/MKuW4PVjm/71VX9bHc3h3jLCH8ac+zHZcbBP9XbavrT8+6u+84NE+En2qosx+Z8Ymd2/Kre2l/8r2i+JeGkTN+HlXijH4BJQDLbEr9EsbPnCWm/8HyhOJ3TFw4V816Y7llDMEoEpPoocYLqS43AxLkzZu3Xaj4CeUARhT4Kxw5NgL2C3/iGH99UgSEcTXvMazL/ufMwBhxVGtRT6NlQ1z6N9hUk3D7kXbF/J2oqbQdvu694sdHmp5kfoVzJ38GkMUkdKan3/uw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(39860400002)(366004)(346002)(376002)(451199021)(478600001)(71200400001)(7696005)(52536014)(33656002)(55016003)(83380400001)(122000001)(38100700002)(82960400001)(38070700005)(86362001)(2906002)(53546011)(186003)(26005)(316002)(5660300002)(54906003)(9686003)(110136005)(6506007)(66446008)(8676002)(66476007)(41300700001)(64756008)(4326008)(107886003)(8936002)(76116006)(15650500001)(66946007)(66556008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?51VlbYmFHcvB5hm3hGZR5kgNlc1eJIpGcMuUYGcw0Fa31GYWn7h4BMyCsNuh?= =?us-ascii?Q?SUP32nXLql3xk/PtKy7Tj81y26qSfnRWySZnq3vHUOTm0/UaFs/SK3GVY9NL?= =?us-ascii?Q?EkJzzV1Qb4jRaYawIfI3jX64ngP8/mL3lAy/7JKJUIROzeZ7Q/PSysfI6cWt?= =?us-ascii?Q?nzFahpa9ObGS1wN47nSteyMuewqy3H0XZI+veL6eJ3Gq5Td6smBnXnZ7II1e?= =?us-ascii?Q?MH08Z6Fm6J048qeUDo6vVA5AkM5RcMj/WIYpIAivVqE180re2zB74CgXWdWl?= =?us-ascii?Q?0uyWjIRj9W0UZcaUoEWL7iwX219QOkL/EwmMkqv2xF+TXas/7RMEr3TVzlZv?= =?us-ascii?Q?+XRsXE+TB6aINGL/Sjegd7OVqDA/H9fgHvG+GZKcXxCHpLx8BW90sUY0xUpc?= =?us-ascii?Q?xah5oobxFtqccIRv2+cjpu97Auxd1ni7Gor9WmGn4+84jqDO2xduAaIXIvVc?= =?us-ascii?Q?Tyg0tpUsF/3TPS3RgtelZ+Nm+FB4cDL/5hfCLsIyKynMhPpHw44Ma1IlnqxC?= =?us-ascii?Q?SrVNG4NZSCdmffutaNoqsl2j4gPHkJ3AW3Q03i36xCdsMbG0OeFUyJlZaQT2?= =?us-ascii?Q?/ryfJf0cbRTuoNOtkbI0iDILGRiOHc+3q3AuEq95QRRH8uWCQOb5NX4QikIZ?= =?us-ascii?Q?fA4Ri0YQF+ldn9MZ4/sMK6pC3o/HGLySAtnPONx6GNavILZxLp6HKjEtZwK1?= =?us-ascii?Q?BTwTKqO+pjggHcGF+d4m8uNoLO+vO/bvJc3vg8gBcRqlenFtBAlQIcxnZpk+?= =?us-ascii?Q?/2/hFHG04g1zFAJR0rmbP8w6lW8sFx34labveqhfmVPGguzwMIZWBslzQ1P5?= =?us-ascii?Q?9YC0hu32ZUE/84HuvinPKUkEv+aDt/6XklJz0kXN2q56ZTKmQjBHCCIkMsxj?= =?us-ascii?Q?sPXH0Hzp+zjPONAMCriQVFeX6+NYyAV3T0LJdMO021UxGXOjGx4TL19WJlz9?= =?us-ascii?Q?4MR367dO0j+sJxUiNhb240JUEBBj04KvYr21VWDd3wDMEybitvqq0wVgy9Kw?= =?us-ascii?Q?aeHCTZ+oI8BH7JyMQ34p4kwGG18TL+sKZPFOjkp0z17QLTAMCOqRJ4IUbNro?= =?us-ascii?Q?vFDIhlyr+MlsRErLBnfBzTKzdlRPgsKAPjMfabMa7J7w4fzN2Ez6ngNMAPiv?= =?us-ascii?Q?/i7Ll9GQ04D9/jNiUObJHpDjCRM/vbKFYjIUmooZR4qlCx3W4g8YizOSzdEL?= =?us-ascii?Q?sjqy1NB+4LxUCiJsdwcCz227rWGumUKQItNuI0MqQ1E8KxWKJmhojGkqQiRI?= =?us-ascii?Q?e0xzgD53cnXV8VWpoCQpkwD433/xjeA/RcnDQLgk8RubwIemb4wOHodDxf4E?= =?us-ascii?Q?MRf2XE9VHoExzxTVE2GUv/o5zL45PcYu7iVonNmpXFynWeHtIhBP4i54ahsP?= =?us-ascii?Q?kOGZanouANndSY+R22F11T/eHCFdm4xoirJMPs+4m+Es2+ZRiizOyCOqqO1p?= =?us-ascii?Q?s5g3Z52ud3Hzeo7eXPWat7YS13RWKI9sY4SUzRWXL/L0tYdDD4L92tlYG0pk?= =?us-ascii?Q?osPWRCIJvmqpR30qwv57o/Vs/gbvtSjZ5uWuXzYWYa4LUo574bR/LOfpjOs9?= =?us-ascii?Q?1NrLgyB1VMu/Z6fXJB0kLPEIPBiFMOxgQENZdm+H?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39e59a79-c460-40d9-aa36-08db3b74b18d X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2023 16:40:58.4049 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s0UmA0CVo6WBk1rPB/IQ/xglH+0DSb3GLcFgtrO9zegTcjNv7kw5DP0YPUGZ6LMbe2EoywQAoxuvjqfBjxh/Vg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7592 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu Thanks, Chasel > -----Original Message----- > From: Chen, Aryeh > Sent: Wednesday, April 12, 2023 9:27 AM > To: devel@edk2.groups.io > Cc: Chen, Aryeh ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Oram, Isaac W ; > Gao, Liming ; Dong, Eric > Subject: [PATCH v2] MinPlatformPkg: Add Pcd for FADT REVISION and MINOR > REVISION to update FADT entries from board package. >=20 > From: Aryeh Chen >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4409 >=20 > Add Pcd for FADT REVISION and MINOR REVISION to update FADT entries from > board package. >=20 > Signed-off-by: Aryeh Chen > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Isaac Oram > Cc: Liming Gao > Cc: Eric Dong > --- > Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 2 ++ > Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 2 ++ > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 2 ++ > 3 files changed, 6 insertions(+) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > index 6e57b638e0..e967031a3b 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > @@ -1096,6 +1096,7 @@ PlatformUpdateTables ( > case EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE: > FadtHeader =3D (EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLE *) Table; + > FadtHeader->Header.Revision =3D PcdGet8 (PcdFadtMajorVe= rsion); > FadtHeader->PreferredPmProfile =3D PcdGet8 > (PcdFadtPreferredPmProfile); FadtHeader->IaPcBootArch = =3D > PcdGet16 (PcdFadtIaPcBootArch); FadtHeader->Flags = =3D > PcdGet32 (PcdFadtFlags);@@ -1113,6 +1114,7 @@ PlatformUpdateTables ( > FadtHeader->Gpe1Blk =3D PcdGet16 (PcdAcpiG= pe1BlockAddress); > FadtHeader->Gpe1BlkLen =3D PcdGet8 (PcdAcpiGpe1Blo= ckLength); > FadtHeader->Gpe1Base =3D PcdGet8 (PcdAcpiGpe1Bas= e);+ > FadtHeader->MinorVersion =3D PcdGet8 (PcdFadtMinorVe= rsion); > FadtHeader->XPm1aEvtBlk.Address =3D PcdGet16 > (PcdAcpiPm1AEventBlockAddress); FadtHeader->XPm1bEvtBlk.Address > =3D PcdGet16 (PcdAcpiPm1BEventBlockAddress);diff --git > a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > index 451034fb8a..694492112b 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf > @@ -67,6 +67,8 @@ > gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags > gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyOffset > gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyWidth+ > gMinPlatformPkgTokenSpaceGuid.PcdFadtMajorVersion+ > gMinPlatformPkgTokenSpaceGuid.PcdFadtMinorVersion > gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddressdiff --git > a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > index e6f714b181..784abb828e 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > @@ -346,6 +346,8 @@ >=20 > gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile|0x02|UINT8|0x9 > 0000025 > gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch|0x0001|UINT16|0x900 > 00026 > gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags|0x000086A5|UINT32|0x90000 > 027+ > gMinPlatformPkgTokenSpaceGuid.PcdFadtMajorVersion|0x06|UINT8|0x900000 > 30+ > gMinPlatformPkgTokenSpaceGuid.PcdFadtMinorVersion|0x03|UINT8|0x900000 > 31 [PcdsFixedAtBuild] -- > 2.26.2.windows.1