From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0B7BA740034 for ; Thu, 25 Jan 2024 15:47:59 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5AB5CUZ/dkH2YmlO4d0w33+gz16XHshTxGFqnPhJJ/s=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706197678; v=1; b=UpTc/mCadVltRWP/11MNooNLMeeOM+9h/7ThMeb90NK1IvRMpSFY4G7kb7TmCld0T9LqrJ7N Pg6qz++cP+p87Fl/ZslAv0ZEsC42YidCCUSo+0uSpu5SDBUgbWcIiFjb+RcRzy2NDYK61ufgM21 E73eoh4JS94IeIP2HcWiiXeA= X-Received: by 127.0.0.2 with SMTP id pAVEYY7687511xCvJqmCIXiE; Thu, 25 Jan 2024 07:47:58 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.21285.1706197677626083655 for ; Thu, 25 Jan 2024 07:47:57 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10964"; a="433351100" X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="433351100" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2024 07:47:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10964"; a="959887487" X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="959887487" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Jan 2024 07:47:55 -0800 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 25 Jan 2024 07:47:55 -0800 X-Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 25 Jan 2024 07:47:54 -0800 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 25 Jan 2024 07:47:54 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 25 Jan 2024 07:47:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FrJxlXwzO+1PysLbrz33+6kZQ22W5zMv27AhdQzO4CD0ly0iq4W6X/p0sIjRQRTKM35xLi/im0Bgz5AbLFNe0IQCEHYMCa+le6DAOO5E39/6I7Fj4lv6TyL8phly39ltGGnR63aA6VDGLKM6qy84R89xmcMEh4iJbY894KeJYzGz7M0vvVs1/3KrgKkhZppMMHploFpX4Fq139yvbJaehcteB4SL1Ges3SqtokIr4zsN8OhKoUfBm1d9Qbs8lSpKrf4AwJqdIsNcu85LVKPLwPDSIZF0ZXWX667qxwsNlyZr4jbIfBN9sJfGNG5zF31LP1zQbS2FNqX7tzeHI950HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dXG2Qcqn3K74kh+C43ivBDLrM4CwVpgyk1o9s86RU7w=; b=jXfVPNgFLhTES/9zzpbdGbcmjjwVAiEziaL8liHrhkeW9Dg2nWat8wQ69nixAWO2Ylf7hpFBmWJgKrUm01tIXwMiYCnRa6MglkVlkOZfseL7xkO4ZirQoC+JyRzJ4Vqga8gjWNAbgpuL6Dg1ePBvNC8uty4wkNH2WEjM8Ro7bjM9dkBuuaDd2x8W7T/KAFnhayN+z+d1uWHaUjCR3C8jzVBmJGQ0jKYpA+v0I0wVjgknMm0pqntTCiGA84tENAkmXcN/0qihYVtF6P9sw0ACCGQOWdoJozd6xnmi/fZ1muoB7IDp+GaBijiE0PZFl1v4CiiIouMhhcatQt/KupUmcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by SA1PR11MB6848.namprd11.prod.outlook.com (2603:10b6:806:29c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.26; Thu, 25 Jan 2024 15:47:51 +0000 X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::aced:fdb2:cf39:5641]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::aced:fdb2:cf39:5641%6]) with mapi id 15.20.7228.022; Thu, 25 Jan 2024 15:47:50 +0000 From: "Chiu, Chasel" To: "Guo, Gua" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Rhodes, Sean" , "Lu, James" Subject: Re: [edk2-devel] [PATCH v2] UefiPayloadPkg/Crypto: Support external Crypto drivers. Thread-Topic: [PATCH v2] UefiPayloadPkg/Crypto: Support external Crypto drivers. Thread-Index: AQHaT0ynaXnPWlr/M0yBFePEokEu87DqrNig Date: Thu, 25 Jan 2024 15:47:50 +0000 Message-ID: References: <20240125050857.561-1-gua.guo@intel.com> In-Reply-To: <20240125050857.561-1-gua.guo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|SA1PR11MB6848:EE_ x-ms-office365-filtering-correlation-id: e8f63da3-c13f-4443-2f7b-08dc1dbcfc74 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: AMA/j2210PuP8dLcvSs6pYimwSnzstzYay0WMHH44TrKWS9bkE5k4UP/BmLnyKFkyNH/DM6VEOUxZ0vDtDGNh+V4RQG8rgRcDsFVXjhBWh0k1rDi3MPmCmZtQWXaHeCwwHnQWF5XLsc6RS7IB8w3JfCh3WLSb83E/4+hDHa16ePa/8y6ehDpkl1hX5AtN/ADC2RBBUAn2PXCBteD/9ZGUuqrtxcwpVkkSUVgENoodv0FEqtfM5mL8MQ+W6bc4x3qE9IjB1xm/0ORMIQYHH4PIb1A0LFbnfJBSEvD8JFzUtFcELM6fqc0u4VA4xgkz+a2Lkd3GvdCyV/l6wAiSzjU+zI4fFp4Nj+J+lxgc9OoPsbbsZxOIwUG3eDvW23kmHDTiech52Zw46FUqBnSNLZkYierxthxKtXPhpMSUf3ZTplKrM9cTsfUSzvXXGACTKrwG/rEjnlm2IY4fd0Sx0BjUfXKDH0KcMT2LgLDYch2wVAmUL+RwAzdjeulsOing+FfB/hF8uUYE7WFqncOnyS1SZNtpkR6tMCHFRgAk4bhCxngT20QTFDloNZFCCGCtsCME8R/2KTrgo9xGizRxIUZzeC/veIsr/s3u7fPMhXxdexJkKWQHU8eRmjEQnjSFet3ooxb7qodgnIkMvn03qRP4u5PYyh8nOs4YInSQ5fGGl8= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CNwHnXwB4O+JTn1QaHr490SEDsi90mWDi7oIRqg3hl3gn3DmfRnwHE427yHq?= =?us-ascii?Q?bv9kAdNGkuyqCiMeNJgEiG1PxTqDoSdC0v5TDcqfWzyJLZydS7iO1acxR31M?= =?us-ascii?Q?jS3rA3YM88wx1EPKBTrStSUQ7EXfjjVvJxH9+Gpkvg+ER8DxFeAt8oXgqgMz?= =?us-ascii?Q?hdduGZF7fUzWwtOTPz7JwxMg2TwHrg5gLu8CyRhi3A4elsL4RI+OsAI6Tt6K?= =?us-ascii?Q?C/YTa5fr1Bki+qLEgLPVrsdDEqn0V95ANf4v3rNaTGYyVkZxZS3N78eoUcQe?= =?us-ascii?Q?aR2WmA/EL9RVf9+wl1Un/K77L6TQUrcsnjeu0ofpid6bYGrukqRduFe2rhCv?= =?us-ascii?Q?qzxMST7XLNzCUo6vRUbncYJNNNwhvz06BfjEbn85srIwhLqGnbvLiJn35Xtx?= =?us-ascii?Q?QII7uFjSdWa3RMMB0+ToI8jHwD4tt7RHPpbE6lSQCB84BhuI9Hg1dmh9JlzG?= =?us-ascii?Q?FOI9d24E8qpwoSW98bBXjZEtzd9hLiFxVfwaQTfZPde2ruB+aGmV0s2tenx8?= =?us-ascii?Q?0bc138CBzsOyvJf7d7O+nqINKEhn5Lis0fD8w6Bnp/zx5i9+sFBwEVOccWJ+?= =?us-ascii?Q?abdvUPqXcRjT/X3OEh0gknHiD7bYT7PUtezxI48BS1R6OOd2h78PDc6CYQVM?= =?us-ascii?Q?yKrl0hXjxp5NdKxDjiAKy+jhNPZTnX1K6g+IWGyAQWtzQxq75+warG5wjyGc?= =?us-ascii?Q?Yo9qpCrCgoDWA2Wr7b/tshKn3LMNy6QsVO4GUdrBouMCHpNMYVRPt8sNb+uK?= =?us-ascii?Q?tXkURE/sk202YwIYnnxa8gsvaz6pFmrNU9ZuavsUUMXKKuxQfp72JZkxmZCG?= =?us-ascii?Q?+gg/zkVebO3Hy9aY0zoPO3xm6qU+C1hmHIUqBq8Dv3tFdgRTZUPDPurFZkJY?= =?us-ascii?Q?0pAOCymVNDISgOGEJ00qM0+VqgJbKA3aDK/kwveN3RhSKqAeCWgyS7BIvXfi?= =?us-ascii?Q?v6Hl/NHhoHEOBfM6Bafh2kMv7P5NcvJwPr3gx2P0pEAVVhfNFtBqLuh9L4Xc?= =?us-ascii?Q?cslE/ii6FLHSXGeH+FsK8ah9zm4fQIq9bdhW+u3kwxG0PNZi3XM3Q0jbv8HQ?= =?us-ascii?Q?NsbiaAwD0U/1ZX9zPUogv7QLvqVcNalfrQjhBcYHkyHqzpxljsUfA8Jxqz+I?= =?us-ascii?Q?DIiu7rJiCoi3Q4IRUaroyDA4yE+SXRej+breqPTds2XfBJRl1LWAAaHkinOX?= =?us-ascii?Q?6vjf3q4k2QSAhWGO8/7gkzpTzQLpYGHZkXrZafJuxLeqO9HtCkAOvOr/5vly?= =?us-ascii?Q?rWxknDfoOocLOZ61PMh9aTKosZ6kaxCzUGwtQSIHtReyR139+Wun1qQM8z+R?= =?us-ascii?Q?UjuBtTV8EFi6w2ZpOWZiQH4yTtCDdkr6AGz8/1OySugfppvyEVYkwO2tL4gh?= =?us-ascii?Q?8jCzZkKbnKrzTGdmuZZl1568bgCTnZqBoFsthVvQ8MZeQHd47bgnwwhNrnyY?= =?us-ascii?Q?oQpE9lYlQvrAk3NLiBhzlroFp5EKF82noMDFjp2wUy1BlXOorUnESzjjPxNn?= =?us-ascii?Q?iGNXuoh53aoLRW7DmSvkyVQbJC8eeOYPycFMPAWcbnOGFGM9pa5XuzIOdbmD?= =?us-ascii?Q?9QC8F2z11Re1ozRiuXL5ilQo3qi3SiKVSjTdNvLf?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8f63da3-c13f-4443-2f7b-08dc1dbcfc74 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2024 15:47:50.5919 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YaWmxO5nQz8hBxngd3K6jWbScd27tQqWlnKl1HA6yzlxsh0fjQJPuN4m25mbemQOwHCMu2XYEMqUJHYnMHSnog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6848 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,chasel.chiu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: XmFFcbDpUBTJHeIkNVFPtN3fx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="UpTc/mCa"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Thanks Gua! Reviewed-by: Chasel Chiu > -----Original Message----- > From: Guo, Gua > Sent: Wednesday, January 24, 2024 9:09 PM > To: devel@edk2.groups.io > Cc: Guo, Gua ; Chiu, Chasel ; > Dong, Guo ; Rhodes, Sean ; Lu, > James > Subject: [PATCH v2] UefiPayloadPkg/Crypto: Support external Crypto driver= s. >=20 > From: Gua Guo >=20 >=20 > Crypto in serveral case will use old version or latest version, >=20 > Platform may choose to only update Crypto drivers without updating >=20 > whole UPL, in this case the Crypto driver will provide by platform >=20 > payload outside the common UPL binary. >=20 >=20 >=20 > Cc: Chasel Chiu >=20 > Cc: Guo Dong >=20 > Cc: Sean Rhodes >=20 > Cc: James Lu >=20 > Cc: Gua Guo >=20 > Signed-off-by: Gua Guo >=20 > --- >=20 > UefiPayloadPkg/UefiPayloadPkg.dsc | 10 +++++++++- >=20 > UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++ >=20 > 2 files changed, 11 insertions(+), 1 deletion(-) >=20 >=20 >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc > b/UefiPayloadPkg/UefiPayloadPkg.dsc >=20 > index 4f195c1e52..2c4013bd9d 100644 >=20 > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc >=20 > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc >=20 > @@ -37,12 +37,18 @@ >=20 > DEFINE ATA_ENABLE =3D TRUE >=20 > DEFINE SD_ENABLE =3D TRUE >=20 > DEFINE PS2_MOUSE_ENABLE =3D TRUE >=20 > - DEFINE CRYPTO_PROTOCOL_SUPPORT =3D FALSE >=20 > DEFINE SD_MMC_TIMEOUT =3D 1000000 >=20 > DEFINE USE_CBMEM_FOR_CONSOLE =3D FALSE >=20 > DEFINE BOOTSPLASH_IMAGE =3D FALSE >=20 > DEFINE NVME_ENABLE =3D TRUE >=20 > DEFINE CAPSULE_SUPPORT =3D FALSE >=20 > + >=20 > + # >=20 > + # Crypto Support >=20 > + # >=20 > + DEFINE CRYPTO_PROTOCOL_SUPPORT =3D FALSE >=20 > + DEFINE CRYPTO_DRIVER_EXTERNAL_SUPPORT =3D FALSE >=20 > + >=20 > # >=20 > # Setup Universal Payload >=20 > # >=20 > @@ -860,11 +866,13 @@ >=20 > # Misc >=20 > # >=20 > !if $(CRYPTO_PROTOCOL_SUPPORT) =3D=3D TRUE >=20 > +!if $(CRYPTO_DRIVER_EXTERNAL_SUPPORT) =3D=3D FALSE >=20 > CryptoPkg/Driver/CryptoDxe.inf { >=20 > >=20 > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf >=20 > TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf >=20 > } >=20 > +!endif >=20 > !endif >=20 >=20 >=20 > #------------------------------ >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf > b/UefiPayloadPkg/UefiPayloadPkg.fdf >=20 > index 7d04a8cffd..c1b1e35f32 100644 >=20 > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf >=20 > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf >=20 > @@ -154,8 +154,10 @@ INF > MdeModulePkg/Universal/ReportStatusCodeRouter/RuntimeDxe/ReportStatusCo > deRou >=20 > INF > MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerR > untimeDxe.inf >=20 >=20 >=20 > !if $(CRYPTO_PROTOCOL_SUPPORT) =3D=3D TRUE >=20 > +!if $(CRYPTO_DRIVER_EXTERNAL_SUPPORT) =3D=3D FALSE >=20 > INF CryptoPkg/Driver/CryptoDxe.inf >=20 > !endif >=20 > +!endif >=20 > !if $(SECURITY_STUB_ENABLE) =3D=3D TRUE >=20 > INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf >=20 > !endif >=20 > -- >=20 > 2.39.2.windows.1 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114428): https://edk2.groups.io/g/devel/message/114428 Mute This Topic: https://groups.io/mt/103948651/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-