From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: Benjamin Doron <benjamin.doron00@gmail.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
"Dong, Eric" <eric.dong@intel.com>
Subject: Re: [edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib: Correctly print memory map entry
Date: Thu, 29 Jul 2021 06:02:05 +0000 [thread overview]
Message-ID: <BN9PR11MB5483AB606F35B82163A52EC1E6EB9@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210726225603.303379-1-benjamin.doron00@gmail.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: Benjamin Doron <benjamin.doron00@gmail.com>
> Sent: Tuesday, July 27, 2021 6:56 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Dong, Eric <eric.dong@intel.com>
> Subject: [edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib:
> Correctly print memory map entry
>
> In the case that there are too many EfiRuntimeServicesData entries, this was
> incorrectly printing the number of EfiRuntimeServicesCode entries.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com>
> ---
>
> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMem
> oryMap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMe
> moryMap.c
> b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMe
> moryMap.c
> index fce44bf73e9d..b8ebac8fe304 100644
> ---
> a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMe
> moryMap.c
> +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCh
> +++ eckMemoryMap.c
> @@ -135,7 +135,7 @@ TestPointCheckUefiMemoryMapEntry (
> DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesCode entry - %d\n",
> EntryCount[EfiRuntimeServicesCode])); } if
> (EntryCount[EfiRuntimeServicesData] > 1) {- DEBUG ((DEBUG_ERROR,
> "EfiRuntimeServicesData entry - %d\n", EntryCount[EfiRuntimeServicesCode]));+
> DEBUG ((DEBUG_ERROR, "EfiRuntimeServicesData entry - %d\n",
> EntryCount[EfiRuntimeServicesData])); } if (EntryCount[EfiACPIMemoryNVS] >
> 1) { DEBUG ((DEBUG_ERROR, "EfiACPIMemoryNVS entry - %d\n",
> EntryCount[EfiACPIMemoryNVS]));@@ -300,4 +300,4 @@
> TestPointCheckUefiMemoryMap (
> Done: DEBUG ((DEBUG_INFO, "==== TestPointCheckUefiMemoryMap -
> Exit\n")); return Status;-}
> \ No newline at end of file
> +}--
> 2.31.1
next prev parent reply other threads:[~2021-07-29 6:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 22:56 [edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib: Correctly print memory map entry Benjamin Doron
2021-07-29 6:02 ` Chiu, Chasel [this message]
2021-08-13 5:24 ` Nate DeSimone
2021-08-13 5:28 ` Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB5483AB606F35B82163A52EC1E6EB9@BN9PR11MB5483.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox