From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E43F6941E02 for ; Wed, 27 Mar 2024 21:38:35 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=TsDdPHp+Pucy9Pbx9/BLtiUbQf707TCTYCmtHHUnPQo=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711575514; v=1; b=m/0vgi8DAuGq+YQY9vm+eWKVHHEwNa4tnnBOm3Z8P0X2wjhEL0GsD9KdxliUnJM77GRreQLj gCQrqqRHA3xAOW97Axf5Ygq/rDYmtfykaKYYBAxbDuMy9GmjRp0KLTSTp70alwtrgypz7gh83gJ T1o4RfbXrz41GZHK61/OwFN5lvwsWjVYT94Qvb5jdNWX9eNkKIX+COrHlZf00iBpXNn+cqIQ4d8 J7+ZnhTlqhMwwpdNAMqv6TiHoJTm7tNJ/94mnOZ9Sb8ceRmIHUI5GWwb6tYYLummgHl/iPBtg/f a40U+qdjLGYCL1qhyZCZoQYV90wwW03doQ/IlQ4S8kQSg== X-Received: by 127.0.0.2 with SMTP id szRnYY7687511xV4dXwPODn0; Wed, 27 Mar 2024 14:38:34 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mx.groups.io with SMTP id smtpd.web11.210.1711575513557005453 for ; Wed, 27 Mar 2024 14:38:33 -0700 X-CSE-ConnectionGUID: Zdk6mWzhS4qMlswZOyjgeQ== X-CSE-MsgGUID: 6due6D0US1CI9pcODIE5aA== X-IronPort-AV: E=McAfee;i="6600,9927,11026"; a="24159362" X-IronPort-AV: E=Sophos;i="6.07,160,1708416000"; d="scan'208";a="24159362" X-Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2024 14:38:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,160,1708416000"; d="scan'208";a="16445199" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 Mar 2024 14:38:32 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 27 Mar 2024 14:38:31 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 27 Mar 2024 14:38:31 -0700 X-Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.40) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 27 Mar 2024 14:38:31 -0700 X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by PH0PR11MB4919.namprd11.prod.outlook.com (2603:10b6:510:34::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.33; Wed, 27 Mar 2024 21:38:29 +0000 X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::5561:25ad:2b29:d5c]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::5561:25ad:2b29:d5c%7]) with mapi id 15.20.7409.031; Wed, 27 Mar 2024 21:38:29 +0000 From: "Chiu, Chasel" To: "Pabba, PhanindraX Babu" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-devel] [edk2-platforms: PATCH v2] MinPlatformPkg: Add missed call to FreePool Thread-Topic: [edk2-platforms: PATCH v2] MinPlatformPkg: Add missed call to FreePool Thread-Index: AQHagI3xBieIBQHuX06QL8C7bughjbFMHPPA Date: Wed, 27 Mar 2024 21:38:28 +0000 Message-ID: References: <20240327212720.5964-1-phanindrax.babu.pabba@intel.com> In-Reply-To: <20240327212720.5964-1-phanindrax.babu.pabba@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|PH0PR11MB4919:EE_ x-ms-office365-filtering-correlation-id: d2199247-b3f6-4e1a-fac0-08dc4ea63def x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: LWEpv5+c6aRqt9W/Avp94XFRcCRlynvhcYW+uiY2j2nvoIA8lw5TpJ+/ev622c7RYxmRrgQyZpGl774wsiP/wk+qKnYseVsd3+WgYOCGmJOr/gJDJFds/JnNGihRHM6LjZh39WDf0b9Su9qdQ3WlX/baREgG1BMaM4sq2sK04Xc/Qtiz5ufSngDdYWSTXeDRwrKeGVarRXBtPziJq29P0Fgx+6/RdKk9JGqXe5VbdWIZXUHr6QAC5LXzFG/+xHLbVR7Y5gIc/jLJWH8SsaLzLoifZXDb/F6EMVX59ruRiSyQd0Hr4SUEAnME7PLK87Zps5tv/Klac05tC3lNzWzN5PzL0KQRLRDkSfZ41Tzj/mu6V7I9UnW94tBBwjEsuLw7IvbC+lJb2qf7MK3DLokeGwaEtr2MWFHDH4tz15wWz/M2oBogghzVO59IPXECqFC4OmUsFVb8qDkOKMvw3iYYAiVaH+CDzfwj891jBfksKPnjN7sKdQm59SKQE7SJH5IBY58UMOZvzS/WyBMRMOGu4eCTNyt9FSwf7TSw4Wi7qv5FYsJ7yLjFEGFP344eX5dyKI03ee1kpgeYQVcVkNj6iQKbxODf/eUpO4KOi57lWHheL/rDxJv3BvYWUqwYRUOagv2tDvdA8MWatAaoxm5Gh/bS4Rf93XbscaN8+QoKVwMVHfMj3kRjZlZG9bZcHSXrd2zM3SnvaNKhuHXrPtSnIWhoCWziHWfFzInwiksmq1s= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?twbY+U1QfEoHvFO+SI3PTIEvWWlfk6koa9y2DR92NXRTzzKyiGYeHDlseJEn?= =?us-ascii?Q?gtBEJw1Yvbj0Jfm11AMCcFRmFsmthBE/GJDdaOUhzDaCKM4OgqWCHW97VTMO?= =?us-ascii?Q?t4DmLaICz94oJ5w76EKnyhnDt0vUqK7WAiKZ8CNzf/RRRT7fhrIiE3azNmKg?= =?us-ascii?Q?8KLvBdERUea7AfyAG38F9LLfspQAwxpY8sm2SziJiFCYFBcDBw8FviQyoTOQ?= =?us-ascii?Q?PEOfqt4EmI52JlX8tMGSo5cC3DWSWCsBflNVjWTAhI8iRd6n0QHYz69tTT0k?= =?us-ascii?Q?Rj4ge/gicZr2ThO/XAsxyYPVw0HFuXbi4VYRBEF4SIuxtVVYKgvgN5qc284K?= =?us-ascii?Q?INMpFir9kfYK92U/Cv3m4w33fDZUu4f8yQa1WVyU5xuVdGwC8L4sVjaboQYe?= =?us-ascii?Q?txTIn4gSE0WEGrct/vu4H9kpi2XwYlYYULM0MHrQKlMkWuYKO67r2gKoE7g0?= =?us-ascii?Q?GEp/5VIMJamanhjDlPz+x0OUt5tusiReNlV/YtLaHvpfo7/eJQDkrpKkOIjL?= =?us-ascii?Q?Bt+8ZTMviD57ZwZqjqjlYO7YUY5DAQPBrFA0tYpwabGSL7TKRm/Pmy0yMTMA?= =?us-ascii?Q?vSVNSoQgCmNg/qgpJijfEDu92pyMFSQJorEDN4eoYeqEYyVzbTmo/M/w8+f+?= =?us-ascii?Q?bPQK3um8nmZkHl5J6yYuG0Urt1dA55VrGuLfSo9lbL29FkS/BsD9sE4+EQEG?= =?us-ascii?Q?fvc0gL8iR9h9CAM6vXVS/PHr712UZpS/mygynzVaf1azibiI+a3iWHVTNWGQ?= =?us-ascii?Q?8NU5URJUSD8ZLzySyD1FgKiNtBhZ56OYK8+PILJpR93ZeI7/t975IiDa2dv1?= =?us-ascii?Q?X7XTdOZwZbIlF4mdWvJ3M29+4y913zRuJzMf1qETl+PanHVQ1RTnNMztTRNR?= =?us-ascii?Q?C1Usi8kkJtXWJjcgaCe5B14C/d3+CSoFldDDo6L353meUJg4s9F7E0duufra?= =?us-ascii?Q?L5+HzTHQ/CeTXee1xH+hxna7KFtBUICkhBtNxdNehLJomQBAflYvmwKd4Noi?= =?us-ascii?Q?a8LqakcfHelYEDepzrCHA7kAqIo2a6DEhidnqHnlryWwPyg957q5hFhAmbiP?= =?us-ascii?Q?lQAZCziZySTwgrQegJMGynWFOyRx5Y0B7Q65xlyrGc2Q/R6E9s+VooUrp4Eb?= =?us-ascii?Q?WrI538zwnR7bHFOVMNDGfE6pBGVX2625aOiWTBSnSaLgQwh3ASnjez4bWrug?= =?us-ascii?Q?vvHeTwK2HrFGkIn1HVMrJ/cz/leE/hKlltQSt2Fi/puQK6iPCuDRc2W7koP1?= =?us-ascii?Q?e+SISgsI8NX1BuSv6LzHYqsWeXQCFELqz61HeI7aK8/aRLp7baNKAdcjPJWQ?= =?us-ascii?Q?N+p6Kt9teg6KGH7NMTsICF3VQAOHHFfqhDoK4PcQwga2QLvISmLX1rxMSlVN?= =?us-ascii?Q?aCpPqspXItRESg1/IUuc7jWk75q5Mf+hZnTfELHDGEW+3iAKofcTXLjZvdDc?= =?us-ascii?Q?u88BGd8ow6WhyENm1sOlCzWQC3AyT4poLVRVs29c0V9woh7FsiSlpxYZ1DIP?= =?us-ascii?Q?hVwiYzvVwdcgXzZ4iRgD2Z97dKol+PyIHLpec8KQ+v0ndCnJSvFJjHEhrBka?= =?us-ascii?Q?1/3HoZN88FIPIG+FM/e/XO6+z44/E8KNgBzPRf2c?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2199247-b3f6-4e1a-fac0-08dc4ea63def X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2024 21:38:29.0016 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pk8+xXTldnAS3856X+k7ss0m2SZCtM95MPCNNapH5TpmvZNLwkb+kiGBe1FsDHAY4OrFqxFYiyeOZ1ejxf31hw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4919 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 27 Mar 2024 14:38:33 -0700 Reply-To: devel@edk2.groups.io,chasel.chiu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Pe4ZLTkquEctkkJwx9UAn5Sbx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="m/0vgi8D"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks Phanindra! Reviewed-by: Chasel Chiu > -----Original Message----- > From: Pabba, PhanindraX Babu > Sent: Wednesday, March 27, 2024 2:27 PM > To: devel@edk2.groups.io > Cc: Pabba, PhanindraX Babu ; Chiu, Chase= l > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [edk2-platforms: PATCH v2] MinPlatformPkg: Add missed call to Fr= eePool >=20 > From: PhanindraX Babu Pabba >=20 > Adding missed out call to FreePool API to free the allocated memory. >=20 > Signed-off-by: PhanindraX Babu Pabba > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > --- > Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 5 +++-- > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 1 + > 2 files changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > index 2a833ec9..9a91d131 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > @@ -975,7 +975,7 @@ InstallMcfgFromScratch ( > FixedPcdGet32 (PcdAcpiDefaultOemRevision) > ); > if (EFI_ERROR (Status)) { > - return Status; > + goto Done; > } >=20 > // > @@ -1002,7 +1002,8 @@ InstallMcfgFromScratch ( > McfgTable->Header.Length, > &TableHandle > ); > - > +Done: > + FreePool (McfgTable); > return Status; > } >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c > index 9bc22245..f5b1a71c 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c > @@ -195,6 +195,7 @@ PublishAcpiTablesFromFv ( > // Increment the instance > // > Instance++; > + FreePool (CurrentTable); > CurrentTable =3D NULL; > } > } > -- > 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117181): https://edk2.groups.io/g/devel/message/117181 Mute This Topic: https://groups.io/mt/105186400/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-