From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.97654.1682472482763682943 for ; Tue, 25 Apr 2023 18:28:02 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=htE/KaYY; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682472482; x=1714008482; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=nzC/LTR4F/atusHjom7o04UR1F5h3rkGcCkA+bCWPnQ=; b=htE/KaYYm18sn98gDxpmyEy5yqn5XMjilBxsbIoxBPRKVqUIlqQajSwn FhfIS7Ivd72tvZRyI5UXhjnL6kHI6cVrFkxtDQDYscwuVz1TuHOIMEb7/ hxWmcDFdePTr6V0OTO1KhiGhwdxfSy/ywJLAGS3oq/sEfsLWreM2jO7pO KpJ4xy7/4EZRZc/j11f2jz9F4s1IzKaacYgxmbYc/TD3fxNgVXIiiLGwF xPNYicoxm0FgxGYLDzE5d64vsK6bmyTPEcsQdQ0Od71Rwg2yePOH6ZJRs gtSscqHR3Ms+8qkn6X8zjhGCddjSDmy4N+FLsMAoZRpasGfNmybt+x3Hg A==; X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="433232164" X-IronPort-AV: E=Sophos;i="5.99,227,1677571200"; d="scan'208";a="433232164" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2023 18:28:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="758393163" X-IronPort-AV: E=Sophos;i="5.99,227,1677571200"; d="scan'208";a="758393163" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 25 Apr 2023 18:28:02 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 25 Apr 2023 18:28:02 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 25 Apr 2023 18:28:01 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 25 Apr 2023 18:28:01 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 25 Apr 2023 18:28:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O2WlZI0L44c7knIkyzydz1ieCaJl1ybHSjJxFGVIPUXgbs8CygbDUajEAvjlZOi4/+efUbDQzzkM5qiQYknPmwncciRWpsFVpPDX9skeySnJZGp6J64AiAlR7AYa8kp16z6P3+fAU1JRsKIzm5yIzJ6ObggXuboKoJoDiswvDEukwn721Dp5EZaUwGkV4vzZwxsH4LnTv86TL6Ez0wFIIoj7lMBcK0GcQqb2POXzcCeqeUOmv2vFSCPNJ3oGi88ddjVrecFRarOlYXsYw+HNw2XzdXjvObL6his8ZfMOoiI8BMmRHjMsEGa96NKtfAJEfFAbCg5Vdz14sWG+0vc2Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qK7ygheGxDpCJRwb149gQY3oo3zf38vWW3n+6UsAvWM=; b=AhOAwomweXrB8WQn+ojaCbwQ1/2SMt+SOYn4+n4MF/7rlJBpYAeHkoUS34fnjCceVwGQ6RzPy/Gfk9575ratz4lsr6T2EXbc7t4x0E077KFdfewkXPfOn2l2XaAD4+mMCB/Ovo3fl+f1HVclkG6YhDlPsSC8wu2cNUVqbaaaSOmHg+TTlpw7uVZK/vkoTyNRR/zg3FqSkUE/ng8JgDzpCxBh0NHtjZxr2K+1NCyLMos7AAcBNayiyH3IMAxHLU05gnDHNqFie82lrHOv/XZNFycASUZ8FADYJBTYHnfARpghOJn8jQX/XhFi/kbsAJbFEHL3yKhbWnv5TEr1qvMiwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by IA0PR11MB7403.namprd11.prod.outlook.com (2603:10b6:208:431::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.20; Wed, 26 Apr 2023 01:27:59 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::1eb1:2222:1823:8e7a]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::1eb1:2222:1823:8e7a%7]) with mapi id 15.20.6340.020; Wed, 26 Apr 2023 01:27:59 +0000 From: "duntan" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann , "Chen, Xiao X" Subject: Re: [Patch V2 2/2] UefiCpuPkg: Update PT code to support enable collect performance Thread-Topic: [Patch V2 2/2] UefiCpuPkg: Update PT code to support enable collect performance Thread-Index: AQHZd1UmkPYMzXleZUuUmCBHimyTQ688EKDggAC86fA= Date: Wed, 26 Apr 2023 01:27:58 +0000 Message-ID: References: <20230425090524.3027-1-dun.tan@intel.com> <20230425090524.3027-3-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|IA0PR11MB7403:EE_ x-ms-office365-filtering-correlation-id: 282ed4a7-590c-420b-f19e-08db45f577fc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mQ5xzAX6DZBylyfwqgXnbT94Wsf4PVodyIm/QDlTDLRFGEy9AIjcM33cS4PQq7SN3IeOWkNxhvlde51DXvdZKiWo19yFHJQhw85WQzW+I0ti/QH9AnpaXdTnHZN3j7qLXkDaCe9MSF0TxqQym4ZAmTGYPi2WkwSsqvcVA6PuPq6ef/kbPZW3T17JYDHDy9j6iRIdflBBXyz3uRX3IWsc3Wn/wZMLGHvqzGaY8qyfXnPoCofMVVpTVtA0P6jL+bPQvm8vwjl5qhZWzNLbJ39Kb8u04OUqaOraw3gVHPMPJFmP5ZKkLPxnNH5JJ5WL1ESAu4k7VzqyQ2iG2zbzD3Ac8gVi4zK8opazyq2+zM0zwOR//tvbgjnz2hTxDomcOGS1PoIpoI/pZwpEVVh7xU9q6896geesUR0foCC8CXh8TOxlLkukdjjT9hkTDTO1sqat28Te8CrSfcj+PlDgNSZ308a+9zEK7Vesz1mt5+MHD9Hrmn46si4GU+NkgM8dUoDu9Yg0f2GkH5NUcghjSKaVwR+i+FO5Asioq92FJnD++rBgE/dVbX7RTTNSQEx9E4u3StxiTVYDT8qaT+n9fZ7gAfjYWZP8H5c1MyehZHO/Vs1n+08lXcuyIm/gVYbDkJNI x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(136003)(376002)(346002)(396003)(366004)(451199021)(83380400001)(76116006)(7696005)(71200400001)(478600001)(110136005)(54906003)(6506007)(26005)(107886003)(186003)(9686003)(53546011)(52536014)(15650500001)(5660300002)(33656002)(122000001)(82960400001)(38100700002)(66556008)(66946007)(4326008)(64756008)(66446008)(66476007)(86362001)(41300700001)(8936002)(55016003)(38070700005)(316002)(2906002)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?x8qgiyV+Krb1seu9ZkIAYzlswhC0Bsj1nM8EuNzZzybdV6GYh07f8jimisAL?= =?us-ascii?Q?9BJabaszODtBGRsjO+qMdNSDBFfGBNHrpE7IcAizYiMWB2+y1/IU7yq+vxrv?= =?us-ascii?Q?AEZa6FaE19TgYTEQsW5XC/1CR5/WYhYB+SHE/M6/6nx73J6/zkatJvz7K/xE?= =?us-ascii?Q?gL1Y8LMvC24+2TCXVUrPaQV8GrwS80sei0lT1Bv0DTYQS9ccOoCyi1GiboHG?= =?us-ascii?Q?DATzWzA3Cicw8ITo5y+n7Axrz3fH+YbsBsGWPvFfQy4Ptx62Y69hJ6+CYCao?= =?us-ascii?Q?xAbU3usuifHPyIo/iJtLqinjPCYTfPJwFkPRwGkaj/PF8Vuf89+Rg1LeTgWl?= =?us-ascii?Q?7LGR+Il1eMWuDObuFL3gvSqewaAu6sOoZ+N1o53MR4m1DIl3CueulB1mR9tS?= =?us-ascii?Q?IhiEe2yfcYvaScmx7tWaNUFfzjtSshDgFWIX9bQU93HvEpA5OiAfzDwfZ12j?= =?us-ascii?Q?GRdHFlsxmpSn5mdtNPgX6t1cZuk/d4YHmOc6RGXMUXJzULOlCW0X7F7eJL08?= =?us-ascii?Q?Sf7v15YFPq+ErayD4rrOZJkTPZvv86pXcbfncubiOQQ7aJt3G6OLbL1jqNiG?= =?us-ascii?Q?VxUJGFgaIV7YrEPh1kXFLLbNU7BrEts0UEnsYj2n3GY0GvmRUW2ZulyIZ2hJ?= =?us-ascii?Q?Ucz3G631mM1eXYqLQBlvZiWVIZWIcxs3Nvm0Mdfg24yBYBN15VuqTs/VZkl6?= =?us-ascii?Q?gSd43pHIEF/IYHh1+ec5pMm20cBTlsnrO40KQPaHT+ZZwGPX924FwCS3rfTH?= =?us-ascii?Q?bPfydoHAXY5zlxfQXhnuuhUy/pSmqW7wdVDDwFglan4glhoZv2OMJwjtI1m2?= =?us-ascii?Q?zyBJtBeWvffIA3GqCrhg1d1zuQ4YlyYBtZ6sGL5dwq340XiaK/FpC+eHEJ6p?= =?us-ascii?Q?ohK3q7ptVZpWjknAPRJtXl/h5SitooC48C6Ny/qCqcg9gXi0LkI4OWh/KvrR?= =?us-ascii?Q?0fKCTf8WebW1M73lvLSa6G7hBFnD9gGC88U2PDqiDOHQRFqaVKrYubC5eArt?= =?us-ascii?Q?37JmvWZUCcW0BRc7vF5CtPuC4p4ESjqf3iEyn5gjnn8COTES3vqTSJMdlPTs?= =?us-ascii?Q?kbtEC4unFHZuBldOeoQdfVOokL4QIX3X29DPvcKJCkClpooEef4yPhXp/iPJ?= =?us-ascii?Q?PCl1RmIUXI0OxgCERcTX7AW/3DYS84Y9YFYKCHnGVB+cj63eMPlDVpXRcMjG?= =?us-ascii?Q?Mmh9Qhq4AFQqgbX3ib/ym5kovUmn3xmveekaZ3IWAAEelQsEhhr/+wb1MGUU?= =?us-ascii?Q?pn8QOTFlZzZtZekdbf3szS67gwpjtPHsZIFrqvE0HRwwJ+xogf7pCysrX8wx?= =?us-ascii?Q?xTxoGodYq1Q+21EtkmsFk1o0ouOlUs6F+M710HPE9kSPd2dh3qEmP3wDxj3D?= =?us-ascii?Q?SZLjXlL3KSEMFdKWRiP6BLx5/yQXBjNy56N0NuJ1ZsZdSbQe7FL+TbsfknHi?= =?us-ascii?Q?o+tbKHBJx7WAWRRbs27k4lV9Swk0Rx9v/sNcWURzytK9HJNDcp7dwRQUI8rT?= =?us-ascii?Q?9ZMTW2YBlsb9ccZNfPpPDF9ZHTf6Scm8VeUy7kOoelcbv/A33BeLeoxBSfxo?= =?us-ascii?Q?yJparjVy+zMs+YeOjRo=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 282ed4a7-590c-420b-f19e-08db45f577fc X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2023 01:27:58.4971 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HcxbnvJZYr2+cJMO0odarboRo61uGsyKcNj1puhunGD/9ngCA6KXuoMRjCFE93gzNrWJwozmp9bt/72Hf0iDiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7403 Return-Path: dun.tan@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the comments. I'll update the code in next version patch. Thanks, Dun -----Original Message----- From: Ni, Ray =20 Sent: Tuesday, April 25, 2023 10:14 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Dong, Eric ; Kumar, Rahul R ; Gerd Hoffmann ; Chen, Xiao X Subject: RE: [Patch V2 2/2] UefiCpuPkg: Update PT code to support enable co= llect performance > @@ -112,6 +115,7 @@ ProcTraceSupport ( > PROC_TRACE_DATA *ProcTraceData; > CPUID_STRUCTURED_EXTENDED_FEATURE_FLAGS_EBX Ebx; > CPUID_INTEL_PROCESSOR_TRACE_MAIN_LEAF_ECX Ecx; > + CPUID_INTEL_PROCESSOR_TRACE_MAIN_LEAF_EBX MainLeafEbx; 1. can you update the "Ecx" to "ProcTraceEcx", and "MainLeafEbx" to "ProcTr= aceEbx"? >=20 > // > // Check if ProcTraceMemorySize option is enabled (0xFF means=20 > disable by > user) > @@ -141,6 +145,12 @@ ProcTraceSupport ( > ProcTraceData->ProcessorData[ProcessorNumber].RtitCtrl.Uint64 = =3D > AsmReadMsr64 (MSR_IA32_RTIT_CTL); > =20 > ProcTraceData->ProcessorData[ProcessorNumber].RtitOutputBase.Uint64 > =3D AsmReadMsr64 (MSR_IA32_RTIT_OUTPUT_BASE); > ProcTraceData- > >ProcessorData[ProcessorNumber].RtitOutputMaskPtrs.Uint64 =3D > AsmReadMsr64 (MSR_IA32_RTIT_OUTPUT_MASK_PTRS); > + > + if (ProcTraceData->EnablePerformanceCollecting) { > + AsmCpuidEx (CPUID_INTEL_PROCESSOR_TRACE, > CPUID_INTEL_PROCESSOR_TRACE_MAIN_LEAF, NULL, &MainLeafEbx.Uint32,=20 > NULL, NULL); 2. There is an existing Cpuid call earlier. Can you get the "EBX" value in = the existing Cpuid call? And you don't even need to check "EnablePerformanceCollect= ing" here for the capability detection.