public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Kuo, Ted" <ted.kuo@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>,
	"S, Ashraf Ali" <ashraf.ali.s@intel.com>,
	"Duggapu, Chinni B" <chinni.b.duggapu@intel.com>
Subject: Re: [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in Fsp24ApiEntryM.nasm
Date: Thu, 15 Sep 2022 16:31:12 +0000	[thread overview]
Message-ID: <BN9PR11MB5483AC566C1954535ACF1FC9E6499@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <c09538bb18177a4a0c0c9a54262ed0dd5104b5c5.1663249160.git.ted.kuo@intel.com>


Thanks Ted!
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Kuo, Ted <ted.kuo@intel.com>
> Sent: Thursday, September 15, 2022 6:40 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>; S, Ashraf
> Ali <ashraf.ali.s@intel.com>; Duggapu, Chinni B <chinni.b.duggapu@intel.com>
> Subject: [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in
> Fsp24ApiEntryM.nasm
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4063
> Added NvsBufferPtr to FSPM_UPD_COMMON_FSP24 in Fsp24ApiEntryM.nasm
> to align with FSP 2.4 SPEC.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> Cc: Chinni B Duggapu <chinni.b.duggapu@intel.com>
> Signed-off-by: Ted Kuo <ted.kuo@intel.com>
> ---
>  IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm | 3 ++-
> IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm  | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
> b/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
> index 997b9c0bff..15f8ecea83 100644
> --- a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm
> @@ -40,12 +40,13 @@ struc FSPM_UPD_COMMON_FSP24
>      .Revision:                  resb  1     .Reserved:                  resb  3     .Length
> resd  1+    .NvsBufferPtr               resq  1     .StackBase:                 resq
> 1     .StackSize:                 resq  1     .BootLoaderTolumSize:       resd
> 1     .BootMode:                  resd  1     .FspEventHandler            resq  1-    .Reserved1:
> resb 24+    .Reserved1:                 resb 16     ; }     .size: endstrucdiff --git
> a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
> b/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
> index 8880721f29..a3b38e4585 100644
> --- a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
> +++ b/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm
> @@ -22,12 +22,13 @@ struc FSPM_UPD_COMMON_FSP24
>      .Revision:                  resb  1     .Reserved:                  resb  3     .Length
> resd  1+    .NvsBufferPtr               resq  1     .StackBase:                 resq
> 1     .StackSize:                 resq  1     .BootLoaderTolumSize:       resd
> 1     .BootMode:                  resd  1     .FspEventHandler            resq  1-    .Reserved1:
> resb 24+    .Reserved1:                 resb 16     ; }     .size: endstruc--
> 2.35.3.windows.1


  reply	other threads:[~2022-09-15 16:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 13:39 [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in Fsp24ApiEntryM.nasm Kuo, Ted
2022-09-15 16:31 ` Chiu, Chasel [this message]
2022-09-15 17:04 ` Chiu, Chasel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN9PR11MB5483AC566C1954535ACF1FC9E6499@BN9PR11MB5483.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox