From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.12493.1663259480062559929 for ; Thu, 15 Sep 2022 09:31:20 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=OPVTecgy; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663259480; x=1694795480; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=pcYWAR0D+r1LJn9zPqGreX6RTLYOvW2V81n0+8Z5128=; b=OPVTecgyqzMdpK2xJprf5DU4XxQKSEVeYyUjX2vn1tRgObmR6a943DWw 1+0W/c+SJ7KZMhiGNZoaYlv39MaQqZRrOg8qP0J+a7/E9j7wXYZg/kjiI TDUjdIJFLLqXwLEtdKObFxtK1gQjJjt0VcLpItFhy7gM9E3367W/6OjFd rs+9AHfJ8SvFyJadz9AovM537xwjtWAUIyC3lCjUCj9jt59Q/7GUPUA8X /D85u0HJXcAaIWRv898YXnk5iZfMNMllkmEGM9WvSBLaNgpITKOylSHHl uaF05Rwmhp8if343fqGyJPPQWcfitCL6HI79sdqwtu1KbgF8QpmmKHkzH w==; X-IronPort-AV: E=McAfee;i="6500,9779,10471"; a="298760902" X-IronPort-AV: E=Sophos;i="5.93,318,1654585200"; d="scan'208";a="298760902" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2022 09:31:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,318,1654585200"; d="scan'208";a="650541296" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 15 Sep 2022 09:31:19 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 15 Sep 2022 09:31:18 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 15 Sep 2022 09:31:18 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 15 Sep 2022 09:31:18 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 15 Sep 2022 09:31:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cnJJupNRETnx7ftvzAgxZZsyQGC4sXmV4P++wi2zejEwtbpP6TPixmowvRnaYugKr/+0LkA+WZ8pO79PRNp/70GswPmfWNucJmckgLp5rWzqUeJ7ZV1Ey/Ef7Ubwz5huINH4yiaoH8Th4ijGXJitn10NI3wd0xtOzfFXLT5dDRIHoZ0WUdVJwT1zonbp0++Tul5T68fIP/9QrggivYRcXscRgSOaJm2k9sG1pkJM0ek6GcS6f/JGveqnVUU6bBLXBLeq5WXABPTvj46y1+PN2MCKLM5S0h/DEpMV2UyQ0FIYnWU9aQDwttjmkrTzGpR5DAM/5tmAswcPSpNeE+xZDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dqAQQbwPox+uGPtBY1+Ea/+d0BD1qmPhzP81tytYl98=; b=nyptp9azyRG0DRKS4FEYWDHLJB7kZRvTwzeM2BieukSj1Uia8nOB06chHKq48dkvtOOL/eJv7wojVCunlQdSGC5XlHD1W8srl/+/3mFeCGyP261+W8+RJONSev98gGCf64HBBIW/EZEB99phv5GQb3ffrcOy4Kyq26nzRmG1VZugE/feOUr1n8afGaHSyMXNm83l6uRZEtDXnjs5B6DYWowwdQ0r4WlJ6Us65GiIMHGMsmBxljTp0X5LxjDtYhBb6ohO/ABUcy+4UxLMO/W64ThXuQLp8vU1hrlmUs90nageNTdAA0IS6R6Co7AAnj9GCQFvOMYUXQ32z2JL01W4Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by SJ1PR11MB6153.namprd11.prod.outlook.com (2603:10b6:a03:488::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Thu, 15 Sep 2022 16:31:13 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::2c62:61b:4030:8a3]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::2c62:61b:4030:8a3%3]) with mapi id 15.20.5632.015; Thu, 15 Sep 2022 16:31:13 +0000 From: "Chiu, Chasel" To: "Kuo, Ted" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Zeng, Star" , "S, Ashraf Ali" , "Duggapu, Chinni B" Subject: Re: [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in Fsp24ApiEntryM.nasm Thread-Topic: [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in Fsp24ApiEntryM.nasm Thread-Index: AQHYyQimP1QjWq0Wh0+GCpl5f6Xxta3grtoA Date: Thu, 15 Sep 2022 16:31:12 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|SJ1PR11MB6153:EE_ x-ms-office365-filtering-correlation-id: 69cb548f-11aa-4018-0b70-08da9737b44a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: t3GD+lR33WVP150IxlKsdNybrCDUoQVunXQwvWbCWsmAnXJtqbpmM2wVlc9kLJ28ivoAWqEBcQEo2QeDi651GWCBssiGioXdeKrCKltYGPlHIOcXdy5YUjgtym2e4ZNAIiBnrYJNO0LndN4DkZ/GX7gVTEP5AvBhazVWZaHHf7vo77DwUfA+9yK4MERfq2tDglng2dv3U33B5TQ3ha7hWCDyBrTq1nn5IRBtLRSUu7wHhyFNMjJJT7sf08o7OqaUHf762cx1vEV9RIYuPUrdzDUopSzudFWoQMEAxRs9Qzx1mBn+DZElf2CR7pNqVrdIgg5f072bJPUMhrVBC99IlIdgYCa2uNgm93mMklaUokeQNHyvYR/Eim97FUnNtJ8dKfB13rkeeRac41ldVn183jiNz+N6JzLToxZJJix45xl7ez1Jvp6L4KKrd6EV3a5x45xkJ+/eLW8VfN+1xQivhlcy/lltp1fs78VkK8VMz4c5Tlc3mhEXI2t9MvNkgWMr3IXTjgG8x21hKqd7OC6dXDIZNk2D8q1Sr/57l4RXpRIUJA34UwhKz/Hxx7KCIPsMiIprgDpqknbTcKtLGC3aVAi+hiDVUyPbdBVqGYa0h0CMCClZM2HvPqWBE9fNkCxtAIcfPqfqjuRyTQb7w/afCN2gwJ5hjX9eNXc61Qa2L35oixx46lmOl5OoLRDTdNZYZJGLIjOBRL1zRpFoW9Hp925el3CO/mn3qTz5FtIJ7Y8smUAP3tEhrESh7tyEmphi82umAinXh1rr7V9Wmbxr/E855zrjOgx8fqNBsrJ1VXA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(366004)(136003)(346002)(376002)(451199015)(26005)(66446008)(55016003)(66946007)(66476007)(8676002)(76116006)(66556008)(186003)(86362001)(38100700002)(64756008)(110136005)(82960400001)(5660300002)(7696005)(6506007)(9686003)(2906002)(8936002)(316002)(83380400001)(33656002)(107886003)(122000001)(4326008)(478600001)(54906003)(52536014)(53546011)(38070700005)(71200400001)(41300700001)(19627235002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7GTEutjd6QxasrgcJpDsUN3x1MM36SL6bSk9JG4vgLj0FDucrPG0C+iTXIx+?= =?us-ascii?Q?Sh2KPHyv4ph6sE8cB2WXh8O2wCERA4igp0Rh9ERdu2xCSJcL6toMPPGJPckM?= =?us-ascii?Q?gG0kUpjgEc4ZszQPP4cUq3AGdJcUVppN5IAozu5A50CYpvJSZ973E+3t1qcL?= =?us-ascii?Q?oQ/1pUoDsNaNa7ka79qqlxpCta4KTFbBCgDXPz54ZDMujCJhCufSKxxWd1w0?= =?us-ascii?Q?q+e1J//8G/e6OGuEQhhIHrcKMuuQyT469IB4wx092GYQGiq/84Ezgr1V7KVJ?= =?us-ascii?Q?6feju2WqFaHb1unyPMzQn5Jk4ICq7kgB5u7qkZJA0/vAG7XSizbRvEsuy6Dv?= =?us-ascii?Q?csqLx3lQ59IyZWfzgeIyc4gX4YijCAk02w66a6vhxG1VcCDukamxBl7sjefo?= =?us-ascii?Q?GiRjgXquJMiXA2rnQGy2MIBTJGvyJzfBFzETJelKLNbnNvFAZqvAvrdV/P6k?= =?us-ascii?Q?HHE61UFkWd/E8beKYUNMG35FhvfPihL2J0eAdjyBibnCuLsk3TqxGVKdQZL5?= =?us-ascii?Q?XwqK7DXtgUcYeHQzTd/+uTes3RcUyQWDhPWSDsub57iEVb3YuccYWiZdy5xE?= =?us-ascii?Q?ebd1YHaxG4LkQrlw7m7zvTyWjVzVR1n0fvkwYXM8gO/wSc9kOhb0KDwqPCFO?= =?us-ascii?Q?q/Lrlz+k0zcKjlNHAaFYr+t2BkDXBvxR/pmXaf7/eDP1DM3IfRV1K4rP/Cvo?= =?us-ascii?Q?akjbRTy9WNMUm/LGYwzPMwBTdSAqGqYCrNKg2t70iK6xAZ+9qU/r2ZHbVsDZ?= =?us-ascii?Q?6WMqI8G1YguBJupk7AlMuz04Q/rfJd7e++jWcXeAy2Ya9AH5GvwUEAVApv9+?= =?us-ascii?Q?o0JzE81WujbgLbd8UGeD4aoHJn9Ayf+3XmMtVRpAeSEZZOEKTV3xupFpYWXd?= =?us-ascii?Q?GqpEhbW5qCStV6JUWS3iVC6FO08kZW8b2DPBlI1fg4L23fabdNAqJRfJdGjz?= =?us-ascii?Q?5ukQC3z0yW5vB13uFNWllUJT+p6gefCe9mZ3NA96P/41T2qA267xzXvGq5qN?= =?us-ascii?Q?2GihXNnL0j/ASliBMfiiG7BajuzPRFuqB11s5LmbLW+DUnX3/0tYch0NsJZ5?= =?us-ascii?Q?5Jg53tcok7Ekz6/rSwqJC10ApfoamY0fOFC3PrdZClwTib4x4ePjVn/8HGVH?= =?us-ascii?Q?cTrlByc2CIGMtpATb/ejon7ygQzz+SXUvD6R5cmTT36dq9KLAvztB3iBqRBQ?= =?us-ascii?Q?EueeXoueHLuAijLcIDERflzOk2+02gTb6AOiPxpqTK5AvNujYAJZcdNSPXZD?= =?us-ascii?Q?od+Ov0n1cPogpg89gy6WPRPBkCZfQvV7TgFFUBIRgPQWBDeqeftCHzbvOHxS?= =?us-ascii?Q?3KBvWbas2uiHE0G6uh3sbesdpJOgR0wWTatEg+VTThsYpNSbs+a7Mh2XS9W6?= =?us-ascii?Q?40HKMUV/lNEA6iVD9moXqkcW+NRhe+6/h1kkfArQ28HHQ25ix20Exvdre96m?= =?us-ascii?Q?OUIgc831L9t08rDFORHkVKI87r9cmw78bWVZPNbuovlOIZSHAzf5d303Umqv?= =?us-ascii?Q?w7LMBS8lOpZt1xM0lgou7XZu00QBec7Oz7rG61y63fsfZqD5w7/hoSdaC2pH?= =?us-ascii?Q?B0D053afKC360Jt96T4K6jg+hCTbhXuuXaxbDl24?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69cb548f-11aa-4018-0b70-08da9737b44a X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2022 16:31:12.9624 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RY26uaav5HdAMSPoByLjUevjVaHLUnASDteNsAOB9/cjSTiLTmYq2527AmT2DmSJ/4IHxf5TW+ca8PwRD5tioQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6153 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Ted! Reviewed-by: Chasel Chiu > -----Original Message----- > From: Kuo, Ted > Sent: Thursday, September 15, 2022 6:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; S, As= hraf > Ali ; Duggapu, Chinni B > Subject: [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in > Fsp24ApiEntryM.nasm >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4063 > Added NvsBufferPtr to FSPM_UPD_COMMON_FSP24 in Fsp24ApiEntryM.nasm > to align with FSP 2.4 SPEC. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Ashraf Ali S > Cc: Chinni B Duggapu > Signed-off-by: Ted Kuo > --- > IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm | 3 ++- > IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm > b/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm > index 997b9c0bff..15f8ecea83 100644 > --- a/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm > +++ b/IntelFsp2Pkg/FspSecCore/Ia32/Fsp24ApiEntryM.nasm > @@ -40,12 +40,13 @@ struc FSPM_UPD_COMMON_FSP24 > .Revision: resb 1 .Reserved: = resb 3 .Length > resd 1+ .NvsBufferPtr resq 1 .StackBase: = resq > 1 .StackSize: resq 1 .BootLoaderTolumSize: = resd > 1 .BootMode: resd 1 .FspEventHandler = resq 1- .Reserved1: > resb 24+ .Reserved1: resb 16 ; } .size: endstr= ucdiff --git > a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm > b/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm > index 8880721f29..a3b38e4585 100644 > --- a/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm > +++ b/IntelFsp2Pkg/FspSecCore/X64/Fsp24ApiEntryM.nasm > @@ -22,12 +22,13 @@ struc FSPM_UPD_COMMON_FSP24 > .Revision: resb 1 .Reserved: = resb 3 .Length > resd 1+ .NvsBufferPtr resq 1 .StackBase: = resq > 1 .StackSize: resq 1 .BootLoaderTolumSize: = resd > 1 .BootMode: resd 1 .FspEventHandler = resq 1- .Reserved1: > resb 24+ .Reserved1: resb 16 ; } .size: endstr= uc-- > 2.35.3.windows.1