Re: [Patch V2 13/14] UefiCpuPkg: Fix IA32 build failure in CpuPageTableLib.inf

["duntan" <dun.tan@intel.com>]

I'll modify the comments and add a new patch to initialize MapMask to 0.
Thanks for the comment.

Thanks,
Dun

-----Original Message-----
From: Ni, Ray <ray.ni@intel.com> 
Sent: Wednesday, March 15, 2023 2:36 PM
To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io
Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Dong, Eric <eric.dong@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>
Subject: RE: [Patch V2 13/14] UefiCpuPkg: Fix IA32 build failure in CpuPageTableLib.inf

> +    UINT32    PageTableBaseAddressLow  : 19; // Page Table Base Address
> High

1. Comments say "High". Should be "Low".

> +
> 
> -  MapMask.Bits.PageTableBaseAddress = 1;
> -  MapMask.Bits.Present              = 1;
> -  MapMask.Bits.ReadWrite            = 1;
> +  MapMask.Bits.PageTableBaseAddressLow = 1;
> +  MapMask.Bits.Present                 = 1;
> +  MapMask.Bits.ReadWrite               = 1;

2. Can you please create a separate patch to initialize MapMask to 0?
Missing the initialization doesn't cause functionality issue but looks confusing.



> 
>    PageTable           = 0;
>    PageTableBufferSize = 0;
> --
> 2.31.1.windows.1