From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.3915.1678873800253219742 for ; Wed, 15 Mar 2023 02:50:00 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=EQ0ivN6v; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678873800; x=1710409800; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=U7qfRM6FUWmR419vpP81Yx3/d8KyXDt0+OJwoLsxL3k=; b=EQ0ivN6vcaXdBQPdQm+lSHfeZwN6stCcHFF9ECWP6CwkMbeIi9bAhIGN yYhHgAUAJxGXsWk0x77/7QfhaPoyv2fCYwyknncMzTYXQWj4iCvHnGlMt r2ne9uAyDhYOtFTCwomvRu4I8nZPXwj8XOi4pqZJhvbxRZoBTOEy0Kjlo iVWH/TYPZzc3xT0fCt5RML+zUA/d41ALJWdIASCKadavxeQhFu2nXxf0w N3Ade5ovwxQXlTuZaSStbTtPdIQwR5mVfDZMEsTBCiPKsuPv56wjw54Dz 8lU/4riOBFF3KnSpWo7NHkVZlrRoIQequM7zkCsuIAERZ3zK28NJDplEk w==; X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="317312416" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="317312416" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 02:50:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="629392316" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="629392316" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP; 15 Mar 2023 02:49:59 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 15 Mar 2023 02:49:59 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 15 Mar 2023 02:49:59 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Wed, 15 Mar 2023 02:49:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i7HXI8LN3iPnltmt+TdovTcx+TaMyI85jOfGoQexW+E829lMbTpWcJeQPRs5SGTVp47wAGNheMAeSmBMQ8wQJOSt/WP94ngC3j6e3j6HeAy3e6EZQV4oUw5czY9lgFdhiVA4Z/rVcK2QX86xGyP6pctcpnKxVDKV41iVYDw4U4kJkTHpDbgGwNQSqGOcZda7QgtD611cUSx2mVefsvNpslMu4T0QqByJjFjAVPGJNf6a0FJxTYyUHv7OqdsgiBqv5yQf3tBLu2AHNYGgr5G1yIDuglkSUKz1JoqlPmgIEGUxqCya72xg3j94Bx8dOGHSsaQqLPhRwACuOAdHBC19hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u9fiqwuTHFphtf+sDRXir6sGZDad5GpmSSbd22BCA0E=; b=EKGdu/w0gLoImADFR593rervrzKC8ka2LpPCI0H9BLvbfWbRNBBULsZlgx626SxnLLlctn1pgepjuX2efQ2LmQrvFFAvm399SBbns4zzoZf+8QVsVh+aodJ4F1CraU4oVAtkk+qQdHX4ticgA4MUKNuj3gxEnjM3dgL7xAUfn4/VSCWxEJcOsELsjvXnNTOwz3ffXq7uI/4oxIMUWTVhYkD6gLa8jJd4z1uxdhdNZNuQesky+ZYx17Dp4ulB9wEr21U9ycCTemoydUh9DLVcessTrde17E22KM8nGAxaY+GdqgQ3sbVvyae0AL4B/ZSKQN6GG3TgjQifm+RZxFrUaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by DM8PR11MB5574.namprd11.prod.outlook.com (2603:10b6:8:39::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.29; Wed, 15 Mar 2023 09:49:57 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::af70:de56:4a6f:b2cc]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::af70:de56:4a6f:b2cc%8]) with mapi id 15.20.6178.029; Wed, 15 Mar 2023 09:49:57 +0000 From: "duntan" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Liu, Zhiguang" , "Dong, Eric" , "Kumar, Rahul R" Subject: Re: [Patch V2 13/14] UefiCpuPkg: Fix IA32 build failure in CpuPageTableLib.inf Thread-Topic: [Patch V2 13/14] UefiCpuPkg: Fix IA32 build failure in CpuPageTableLib.inf Thread-Index: AQHZUaYWyuhE+44R+UiTSwj8YzD+L677a5cwgAA2nCA= Date: Wed, 15 Mar 2023 09:49:57 +0000 Message-ID: References: <20230308100758.669-1-dun.tan@intel.com> <20230308100758.669-14-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|DM8PR11MB5574:EE_ x-ms-office365-filtering-correlation-id: 168c0237-4874-416a-ef14-08db253aa2f8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4FLkqgYxywkousOxNPzD77XFlWENG50iQ5OW5fMmsRC0TVDI9rvvRf80p/e65aHvLr4lTkcDLgZogbYbvpxTXhoje1ajMi6+JPEDe2sSTCAs2//gbNIb3YY8yY7jK6QBW43pJKZBXJWwQVXCMqvyZe3vHssOueTe9xY454LN7IWzt7N4/b32SZvnNpyORXeqT2dfAdhiZ1RujryqbbdMS+ThdmJLngPzIPz6XA341K9Klv4GdTK8IJO4KSLTzYGLEwbEeJejL6z/uPyExScMmKcxAX+TkneN/nhS4L4PCNLjex14cB1Vy0V0OqaVotv6LXo7jYuM/2nmIqK5WmBUgO5auD/L06f7Z1NUau8o8Nh2VmsP2gKdZttpJrWc7ojakef/96j8JpT1nWLIak3joByqU8FedoPLa2udV0ol8XJCYjA6Ydl64zPHkMi5qBaZudjKT+p3wkXxfNKZYvbCP9PCmDeShGyrn2STK5QdlUIXYUvy7di0oOwfLVfDEf5qNjyueW8owLFucomzuo4lM1Hs7kP29C9q1teV0gGrYEiZCoaCWYuiUeR68TkA9I/pt2+yaVkWlO80r2XZlchil7vbV1aJ3AflCRRxxa3e0shn1GVgTytChyKTyvaohbW9+i3OVg3NxPG4Mo6PHvU16bvW/3UA6DX/vCx0ZKCIMS2thgmUUujvjspfBcZ1nZLzkgbnM+3s+9LxAAfRRztE0g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(396003)(39860400002)(136003)(346002)(451199018)(5660300002)(4744005)(83380400001)(107886003)(478600001)(7696005)(53546011)(71200400001)(9686003)(6506007)(26005)(186003)(66446008)(38070700005)(76116006)(66556008)(52536014)(66946007)(55016003)(64756008)(33656002)(41300700001)(4326008)(8936002)(66476007)(86362001)(54906003)(110136005)(316002)(38100700002)(82960400001)(122000001)(2906002)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gl26TxKveKd5cX07vHRep85aYxC02k5EL5gx4gPAnuauhchD4wgsouRzP3Nv?= =?us-ascii?Q?53o5G9UKM/cQLsLWVNXPSIYX7PG39g0rTWvYe/1PeDTnkVxzar7fk6+lG+1g?= =?us-ascii?Q?d8oT5vXZyJVjUGJb7FQVY0kggp+LCuBcxEUeOFz4QWk5R4iwqbVX2p2dNp43?= =?us-ascii?Q?yGiZplKtR2Da2Qqk2GYsAnqvbfQoezp0YmqB5XZ2t3JEU5kZqpRpTK6e91Zh?= =?us-ascii?Q?QbG9PLHdVq/JXl0xX32QqThH1fk/sSf0UwzXSf1ptRZsXM9DUh2xtLembnfx?= =?us-ascii?Q?cAqhU+DJuCk674waE6EnXSXIcjttSU72E6u5x0P5IKjmnsND+7O7tQdzZVQC?= =?us-ascii?Q?JUEg+gaez6N1wl2hDtF9g9KbJ3djMFY2TehulB2djFK5fccAbqfRHMSdYb9p?= =?us-ascii?Q?iQvWuxTj3h/AD6WxIqTMpzdRU20A49qnYlCEkElrxF1jzwShthsyitUS1dh8?= =?us-ascii?Q?rBZvvWbT45gYmnDoqCwrw3SBjAqqdnHkMjSQoLLJLdzYm7b02L/zCucLzzPe?= =?us-ascii?Q?lxhsSJCMM5g9uocS1kXkG2nJ8n/5YxT2ihN2OcrdRX6NrrsI6XFnCoFX8M9x?= =?us-ascii?Q?VdewIWT8xG4aHA0TJ1QQMIPTuSeODBU8w2Deh+Lz8+QlWJhsBDk3qdQhtIya?= =?us-ascii?Q?ZBpDF6pP52kdr/mdEC4ckNXZh4LLLpMCrFGMxEBtShEI5x8EdDvvXwnGSvIZ?= =?us-ascii?Q?dxHfiHDNxJW/HLPff9z1B5UjvYYwXkKCfRv70MUHk0SD0PA+HEIyLX4kod9T?= =?us-ascii?Q?GYvWyXEsoAlibTE9gXV/sAQUX1ALUBy2F+gB7lo2HEKm60IrZ28YdzKNyX9E?= =?us-ascii?Q?5mu260a2usFXfM++AH0L+zO08FqePKe0hQfEwwseq//Z+CHnAebsMGfD/f33?= =?us-ascii?Q?sgTmgCp4rJPWJQOs+Y0buFc75L2i6F8XF71IDHihQ+0zqu2jJ62LZtScDSNt?= =?us-ascii?Q?w8N9482P8APu2n6VHMAy7/+V8NwUhV1GnYfJv584sJSVC0qYELUUg2G06ebK?= =?us-ascii?Q?/kuiVssZ6Sfg4KqIHZxtdIOpjC+x32Kxq4I/uJ/kD2UxYnTYR1CIVpmH/Q5V?= =?us-ascii?Q?l/rMZv5jJBqT7bCJmGokLZPMOQI6m7K66nRyrjOxjvb+vcIRAddbm0l+uAYJ?= =?us-ascii?Q?jc3l9iV61O7M1pAdQbIn6cmC68UEPRbGac9UsLCb7H4PpGODPF1LVO8nzuuE?= =?us-ascii?Q?gAFaKNW1YiZmhaV0/f0URNg/kxo8to3aX+KPVo3KvsBBA9kMmILCbqwTq4wb?= =?us-ascii?Q?GQsA2AcQ57FeXMWJfR1IIv82p58OB4bGexlODDPzaPfyGcZWRV27BkdO7tay?= =?us-ascii?Q?CgqmRI7qiDsFfoFM1NRTF03sKVxMAWDj/aFpUUd37IHFdtWQ9yoyWl4QTqUM?= =?us-ascii?Q?hoJYx8hYkUUfzjkFSFZ3zHhser1T5CqxVO946IAXLm2hUjZ1TDPAqGMMes9E?= =?us-ascii?Q?UTL6WEFY7TM9YO5AjZv+0rrfBU0haF3Loz5AQGXesfI2Ev9V0CI4U4QkrzpA?= =?us-ascii?Q?FPIQZFR4N3WXMTXUza1EWa8g2IPrJx2KR4lf916pFatifB0OZ+0OFhp3Nrv6?= =?us-ascii?Q?/3/89dknQO+eZEuiJCR79sg7qAn1w5ILL9IGf38n?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 168c0237-4874-416a-ef14-08db253aa2f8 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2023 09:49:57.5143 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: V8CC0KMwp/3c+VAMWXVRf0Q42FkSek/+n00KMe5l4/VWfIyTqGWwDTmR7uX8o179XWCYUBaSpyBkXYdvxVfKzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5574 Return-Path: dun.tan@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I'll modify the comments and add a new patch to initialize MapMask to 0. Thanks for the comment. Thanks, Dun -----Original Message----- From: Ni, Ray =20 Sent: Wednesday, March 15, 2023 2:36 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Liu, Zhiguang ; Dong, Eric ; Kumar, Rahul R Subject: RE: [Patch V2 13/14] UefiCpuPkg: Fix IA32 build failure in CpuPage= TableLib.inf > + UINT32 PageTableBaseAddressLow : 19; // Page Table Base Address > High 1. Comments say "High". Should be "Low". > + >=20 > - MapMask.Bits.PageTableBaseAddress =3D 1; > - MapMask.Bits.Present =3D 1; > - MapMask.Bits.ReadWrite =3D 1; > + MapMask.Bits.PageTableBaseAddressLow =3D 1; > + MapMask.Bits.Present =3D 1; > + MapMask.Bits.ReadWrite =3D 1; 2. Can you please create a separate patch to initialize MapMask to 0? Missing the initialization doesn't cause functionality issue but looks conf= using. >=20 > PageTable =3D 0; > PageTableBufferSize =3D 0; > -- > 2.31.1.windows.1