From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Pabba, PhanindraX Babu" <phanindrax.babu.pabba@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
"Dong, Eric" <eric.dong@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms: PATCH v2] MinPlatformPkg: Add missed call to FreePool
Date: Tue, 2 Apr 2024 04:18:26 +0000 [thread overview]
Message-ID: <BN9PR11MB5483B36F990ED3BA6847E10BE63E2@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240327212720.5964-1-phanindrax.babu.pabba@intel.com>
Patch pushed:
https://github.com/tianocore/edk2-platforms/commit/ce4b8e394077f7f10ace2c6e96767f676c000355
Thanks,
Chasel
> -----Original Message-----
> From: Pabba, PhanindraX Babu <phanindrax.babu.pabba@intel.com>
> Sent: Wednesday, March 27, 2024 2:27 PM
> To: devel@edk2.groups.io
> Cc: Pabba, PhanindraX Babu <phanindrax.babu.pabba@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Dong, Eric <eric.dong@intel.com>
> Subject: [edk2-platforms: PATCH v2] MinPlatformPkg: Add missed call to FreePool
>
> From: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>
>
> Adding missed out call to FreePool API to free the allocated memory.
>
> Signed-off-by: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> ---
> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 5 +++--
> Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 1 +
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> index 2a833ec9..9a91d131 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> @@ -975,7 +975,7 @@ InstallMcfgFromScratch (
> FixedPcdGet32 (PcdAcpiDefaultOemRevision)
> );
> if (EFI_ERROR (Status)) {
> - return Status;
> + goto Done;
> }
>
> //
> @@ -1002,7 +1002,8 @@ InstallMcfgFromScratch (
> McfgTable->Header.Length,
> &TableHandle
> );
> -
> +Done:
> + FreePool (McfgTable);
> return Status;
> }
>
> diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
> b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
> index 9bc22245..f5b1a71c 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c
> @@ -195,6 +195,7 @@ PublishAcpiTablesFromFv (
> // Increment the instance
> //
> Instance++;
> + FreePool (CurrentTable);
> CurrentTable = NULL;
> }
> }
> --
> 2.39.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117316): https://edk2.groups.io/g/devel/message/117316
Mute This Topic: https://groups.io/mt/105186400/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2024-04-02 4:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 21:27 [edk2-devel] [edk2-platforms: PATCH v2] MinPlatformPkg: Add missed call to FreePool phanindrax.babu.pabba
2024-03-27 21:38 ` Chiu, Chasel
2024-04-02 4:18 ` Chiu, Chasel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB5483B36F990ED3BA6847E10BE63E2@BN9PR11MB5483.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox