From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 83F5DAC0B3D for ; Tue, 2 Apr 2024 04:18:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=0jXAedxMnhbG7nCfKOiQonSTDGMZkTNdVW2O+8g45kw=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1712031511; v=1; b=AfypmTluv07MATcsxQHS5pRmg0VpsIS9GibqfyspSKh7PDmV+0VnEjpUvtaRMQm1pQyidWzX DLC6CzwKpufHYgMrWVQk+1hU/euy6yEX8j1CegGqqHUkwizP1/KslhSQwDYbtKWpcIFIChxqiqx 8pHBCgQm/0dntpUoNODSmYyaQTpOEsQhyTDx/UQYuPzySJuovSG6rBZJTg8/tzl0DwIDeIpAjQ4 tC2zugg5kF7bspwiU4lncgL8NMX7pvu1yno2+4zPVt9YOjULxxWvPI2ZHopTu0Vxv+a9zggu1jQ yKMaxOjBdtRd/XQmvnQqrG7YaUCC6V3EbGfv84STR7WWQ== X-Received: by 127.0.0.2 with SMTP id UDTFYY7687511xxxlRVeDpza; Mon, 01 Apr 2024 21:18:31 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mx.groups.io with SMTP id smtpd.web11.4856.1712031510146746708 for ; Mon, 01 Apr 2024 21:18:30 -0700 X-CSE-ConnectionGUID: 8gTIRs6pSVe731IO9W90/A== X-CSE-MsgGUID: NRaacQt+RWi9MPZ8Jkjdbw== X-IronPort-AV: E=McAfee;i="6600,9927,11031"; a="10964314" X-IronPort-AV: E=Sophos;i="6.07,174,1708416000"; d="scan'208";a="10964314" X-Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2024 21:18:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,174,1708416000"; d="scan'208";a="18011620" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Apr 2024 21:18:29 -0700 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 1 Apr 2024 21:18:29 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 1 Apr 2024 21:18:29 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 1 Apr 2024 21:18:28 -0700 X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by SJ0PR11MB4895.namprd11.prod.outlook.com (2603:10b6:a03:2de::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.20; Tue, 2 Apr 2024 04:18:26 +0000 X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::5561:25ad:2b29:d5c]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::5561:25ad:2b29:d5c%7]) with mapi id 15.20.7452.019; Tue, 2 Apr 2024 04:18:26 +0000 From: "Chiu, Chasel" To: "Pabba, PhanindraX Babu" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-devel] [edk2-platforms: PATCH v2] MinPlatformPkg: Add missed call to FreePool Thread-Topic: [edk2-platforms: PATCH v2] MinPlatformPkg: Add missed call to FreePool Thread-Index: AQHagI3xBieIBQHuX06QL8C7bughjbFUaGnA Date: Tue, 2 Apr 2024 04:18:26 +0000 Message-ID: References: <20240327212720.5964-1-phanindrax.babu.pabba@intel.com> In-Reply-To: <20240327212720.5964-1-phanindrax.babu.pabba@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|SJ0PR11MB4895:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: q9NlR20ivpVP31WmvGGhpB09Y5IM9/mEbh9eLKa1PIZgC0/9z00qUx/2dLY+I5ZhB9Q/WG9Po/Ap8ZClryOFZ7qLQ2cM6wj4/20tnUmCxq93HC+ormAi/c3mhQj0OOf7O03+5J7WFSgvdr1XR7HM3kBqOMbb+HighKilbaimQGJKFSs0v04iLZwtsw8C1EkAUluz9pYi5lGG+8ydaX2NdhzEtQTkrSyf0FG+oQysf4ECB8Agc3UiQWAxUdBQEuQ3Qqkf3BojBDU8yMf+csse5HMfZYQycil1ZIjGOdj4tdZ1rDR0rwuo4PBIabjq1H6hh1R0HzvRCHa1RquafwQErCXgFC5grKRERnianxt2yeP2nqqjt7uJbHxagWjd9r7RyA/AKEJdzIdWy4xkEfTxvkYbaocWrM6I6l3Lv6Iitnbqea53LH9bqXXmkrEY+Vi0PfKcKTkMzudHqIYzaTIbVnN8OjWuIhV0/mD1q8bWpD9WxSW4vvZ/RDJN9qfRYxI55jZAAwSkzqCqPJep12e9SfwDoTParEg0AJuSQkGxDiy+xPo9jzc/lJBcOpj52Kcj+9UyUbHO/aRN2FKtq7ybiA7GR0HLWjZI+8JGDsweF5s= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MyJQmKOxhL9U1xC2tdNEpoIz6mXVym9KBOSuAcMNXerdOkQtBy96QEdq+RMw?= =?us-ascii?Q?hcbXxJIcgt80Aqtqpf6GV+JnVnkyjN5c6tE6zMSVx05+OHHpVSXJeohCb29C?= =?us-ascii?Q?gjr9JFaYLnmr/0vS24eO9E1i6OQgqtCciJ3Ybd6lEIT4PlQhyfElqO0Ju064?= =?us-ascii?Q?1e7JqAt23MGcTMwJkb50S3NJs1GaJn8xVHW2T+XyH52KYs1ILJqZBAMRbrYi?= =?us-ascii?Q?aINS3Koz7yEWmm8J+7GduG4aZ9ytP51W1U+6ntk7t2/6cLY29TmWbjpQSUGA?= =?us-ascii?Q?93ax3/bMSPRfnc9u6tdoCFTsfvmGqRhLhUyWxEl4QCi9Y+7g6iImctXPDhbY?= =?us-ascii?Q?+2TUsEElVpv9C4pLZuWB+TpKCiDujy8fSGg1Kngi5ezB6sN5Vie/X/GSKX4B?= =?us-ascii?Q?Cb39aRELHiJC/xfr6m27Kjnu/MkkoUcrljFbWpdL7x8UVDiUGyl7+9s32Sls?= =?us-ascii?Q?9XpKS5ae78iRGe44eeFXCOBTPy9Eu1lHW1i82M3t4qmAcsx6FT+sh47HbXIG?= =?us-ascii?Q?mrl2adh2PtOzl30A/OyWPeEXgxvKxUr+D88LQ/KJCbHWDia+HwgD4brwLzzd?= =?us-ascii?Q?CAbZrkpVjvBg5M0T5VWCAzLbzcKjhcGZrilr6AuPPVvRBkoqD2RkKBfiIBIn?= =?us-ascii?Q?BpLYmlSqB0CY99IoNJGYUb+YjWLqPgAuX+zAZzyO1W8/aDHZ2T5oWTvFXut8?= =?us-ascii?Q?wpZpV8A6ApIJvv6KY86eaZmkAl8y5QP/G/MO7rd0lD2pqWA6yOO/bRM9b489?= =?us-ascii?Q?k4OGrol+uLRUNObQcdtCWQZK0mPY6zxPAl8cQKKaKuW7T+CpGIl5V3cXfaMM?= =?us-ascii?Q?uOh3agJbdtsJ/jCQPEUQlDfZlqB6B8wTN4bGsUDS0xQjS7R44fHV+jRRcBIX?= =?us-ascii?Q?pxNlCU8gLSTUi/w8xfu6Sg+vP7sZanMWygb40pakNJQewDuVvInhlwJJgxNd?= =?us-ascii?Q?8ESGjMWLTxxn0YByvsRzmjM+rnP0tJnhn0pZnh4AGowcVmaidMqmExTwqXAC?= =?us-ascii?Q?xbXw8VNbgb66NUHEd/kvbK5hz//DuHAx2rOatM8k4oWpG81NzgTcRR4v7nrJ?= =?us-ascii?Q?Wq/2Kjw4JIlj8abPJ6rsm2wn+hRWCXA6lP1o8RZs320j7Kkm1Pbm/QqIFQ9G?= =?us-ascii?Q?XCKnokIj7qG76Fdd9ZJZmVMBYY1r4x23IviSBv9fR8ubUpUlyIMPHXFcL4Eb?= =?us-ascii?Q?mFaiL6gRDrSabuDU4LjJMc1OLMEoJuCA+/vYDuX0x8k+gk4OQgAe5kNPV1oN?= =?us-ascii?Q?MF6QpzhY//5bpdNOMQQ1HdLbZI9rjr2hJRMmeveeeAaRqFwQLxk6eXcbSC0h?= =?us-ascii?Q?TCDJ4InBOfvOR3X7rW85LfNK85L3RE6P8D438wv965KZLcrIPdSr5EByYvwU?= =?us-ascii?Q?NgC8G+Cs2wcLcxVT+YjP/ARsetGqtDqoWkfIsLd+d1E+Rq72RQnEj7IEXvBp?= =?us-ascii?Q?qEUYramnqjMZdN1C3Voub+A81cVEy3epTxuOISChIs/yZk4Kih24ea5SZvh5?= =?us-ascii?Q?DdcA0pT3WsUrwtqYTdRCCA91oB4ky3d0FjtbWtMwEUk/bv+hKS6Zq7WG5ZT/?= =?us-ascii?Q?5C0iLBGH1Zo9iFLO2ULY3lgAqlkwS220Ixks5V8r?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b37c0cf-8b65-4241-40f3-08dc52cbf1d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2024 04:18:26.8254 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MuSxu7rw/cnObwBIEWlU52Cqd1cnnar1IyegCq8bDCLVdl8CkBpAUdHICmtDZ8eMCAJnBKiWbHjs8WHkxFreYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4895 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 01 Apr 2024 21:18:30 -0700 Resent-From: chasel.chiu@intel.com Reply-To: devel@edk2.groups.io,chasel.chiu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: CybtLHBXVJm8SSaBuktamOISx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=AfypmTlu; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Patch pushed: https://github.com/tianocore/edk2-platforms/commit/ce4b8e394077f7f10ace2c6e= 96767f676c000355 Thanks, Chasel > -----Original Message----- > From: Pabba, PhanindraX Babu > Sent: Wednesday, March 27, 2024 2:27 PM > To: devel@edk2.groups.io > Cc: Pabba, PhanindraX Babu ; Chiu, Chase= l > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [edk2-platforms: PATCH v2] MinPlatformPkg: Add missed call to Fr= eePool >=20 > From: PhanindraX Babu Pabba >=20 > Adding missed out call to FreePool API to free the allocated memory. >=20 > Signed-off-by: PhanindraX Babu Pabba > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > --- > Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 5 +++-- > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c | 1 + > 2 files changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > index 2a833ec9..9a91d131 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > @@ -975,7 +975,7 @@ InstallMcfgFromScratch ( > FixedPcdGet32 (PcdAcpiDefaultOemRevision) > ); > if (EFI_ERROR (Status)) { > - return Status; > + goto Done; > } >=20 > // > @@ -1002,7 +1002,8 @@ InstallMcfgFromScratch ( > McfgTable->Header.Length, > &TableHandle > ); > - > +Done: > + FreePool (McfgTable); > return Status; > } >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c > index 9bc22245..f5b1a71c 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.c > @@ -195,6 +195,7 @@ PublishAcpiTablesFromFv ( > // Increment the instance > // > Instance++; > + FreePool (CurrentTable); > CurrentTable =3D NULL; > } > } > -- > 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117316): https://edk2.groups.io/g/devel/message/117316 Mute This Topic: https://groups.io/mt/105186400/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-