From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Ni, Ray" <ray.ni@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Oram, Isaac W" <isaac.w.oram@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Dong, Eric" <eric.dong@intel.com>
Subject: Re: [PATCH 4/6] MinPlatform/build_bios.py: Support performance enabled build
Date: Wed, 24 May 2023 23:07:10 +0000 [thread overview]
Message-ID: <BN9PR11MB5483B4C23634E331A068A858E6419@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230524122852.2047-5-ray.ni@intel.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
Thanks,
Chasel
> -----Original Message-----
> From: Ni, Ray <ray.ni@intel.com>
> Sent: Wednesday, May 24, 2023 5:29 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>;
> Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: [PATCH 4/6] MinPlatform/build_bios.py: Support performance enabled
> build
>
> build_bios.py supports caller to pass in "--performance" flag but the script
> implemnetation just ignores this flag.
>
> The patch adds the missing logic to invoke build.py with "--pcd
> gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable=True"
> when "--performance" is supplied.
>
> Signed-off-by: Ray Ni <ray.ni@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> ---
> Platform/Intel/build_bios.py | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py index
> da4097d5db..9c95cfff76 100755
> --- a/Platform/Intel/build_bios.py
> +++ b/Platform/Intel/build_bios.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python3
> +#!/usr/bin/env python3 # # @ build_bios.py # Builds BIOS using configuration
> files and dynamically@@ -421,6 +421,10 @@ def build(config):
> command.append("--pcd")
> command.append("gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection=1
> ") + if config.get("PERFORMANCE_BUILD", "FALSE") == "TRUE":+
> command.append("--pcd")+
> command.append("gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable=T
> rue")+ shell = True if os.name == "posix": shell = False--
> 2.39.1.windows.1
next prev parent reply other threads:[~2023-05-24 23:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 12:28 [PATCH 0/6] Fine tune SimicsOpenBoardPkg Ni, Ray
2023-05-24 12:28 ` [PATCH 1/6] SimicsOpenBoardPkg: Remove un-used PlatformBootManagerLib Ni, Ray
2023-05-24 12:28 ` [PATCH 2/6] SimicsOpenBoardPkg: Remove logic that loads variable from disk file Ni, Ray
2023-05-24 12:28 ` [PATCH 3/6] SimicsOpenBoardPkg: Enable serial terminal Ni, Ray
2023-05-24 12:28 ` [PATCH 4/6] MinPlatform/build_bios.py: Support performance enabled build Ni, Ray
2023-05-24 23:07 ` Chiu, Chasel [this message]
2023-05-25 0:44 ` Ni, Ray
2023-05-24 12:28 ` [PATCH 5/6] SimicsOpenBoardPkg: Add "dp" command in performance build Ni, Ray
2023-05-24 12:28 ` [PATCH 6/6] SimicsOpenBoardPkg: Disable DriverBindingSupport perf logging Ni, Ray
[not found] ` <17621420EF808DC9.12947@groups.io>
2023-05-25 2:10 ` [edk2-devel] [PATCH 1/6] SimicsOpenBoardPkg: Remove un-used PlatformBootManagerLib Ni, Ray
[not found] ` <17621421B6E6FB43.8048@groups.io>
2023-05-25 2:10 ` [edk2-devel] [PATCH 2/6] SimicsOpenBoardPkg: Remove logic that loads variable from disk file Ni, Ray
[not found] ` <17621422F0AEB994.8048@groups.io>
2023-05-25 2:11 ` [edk2-devel] [PATCH 6/6] SimicsOpenBoardPkg: Disable DriverBindingSupport perf logging Ni, Ray
[not found] ` <176214229D12BE31.8048@groups.io>
2023-05-25 2:11 ` [edk2-devel] [PATCH 5/6] SimicsOpenBoardPkg: Add "dp" command in performance build Ni, Ray
[not found] ` <17621421D3F4CA3E.12947@groups.io>
2023-05-25 2:11 ` [edk2-devel] [PATCH 3/6] SimicsOpenBoardPkg: Enable serial terminal Ni, Ray
2023-05-26 6:36 ` [edk2-devel] [PATCH 0/6] Fine tune SimicsOpenBoardPkg Zhiguang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB5483B4C23634E331A068A858E6419@BN9PR11MB5483.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox