From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.54.1684969635224876818 for ; Wed, 24 May 2023 16:07:15 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=WNbq2aNy; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684969635; x=1716505635; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=RwR97TOn8NYsrN8sxySPY42atKFE3fq0pJXRvXYUvmQ=; b=WNbq2aNyDH2PQmv4r1pWif1PkEAJ+S6KJ3YMPPWgaRCyCJyG4G3mxOWs NQ0qHZfQkb7kQTyTMA3rT8VrdAJHrOn79wELmGx0Pe6K/xQ0M10WlfiQP xUXZG3W/YWp+nTiU0aV6/430iduyEJDv/yivUSpqE0ZKbKEfBl+KrwC/5 1eBbxua6z5N5KU3ykMLEHH9/RAf9VOGgidw5m1L5izX865g065jCMUfK9 joNbnOimWOcbIxOi6rKwu6Xogh4OPTZCljLFR185TZYF/7zEjbX6W5dfs OsEppw6DaEWVcGdiCAJOomgYZ29e3VQuXIRG/ST0C73E/glSKfLbdGDxH g==; X-IronPort-AV: E=McAfee;i="6600,9927,10720"; a="334071611" X-IronPort-AV: E=Sophos;i="6.00,190,1681196400"; d="scan'208";a="334071611" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2023 16:07:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10720"; a="828801119" X-IronPort-AV: E=Sophos;i="6.00,190,1681196400"; d="scan'208";a="828801119" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 24 May 2023 16:07:13 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 24 May 2023 16:07:13 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 24 May 2023 16:07:13 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 24 May 2023 16:07:13 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 24 May 2023 16:07:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S2XVXmkFRO5vMxUXHyOp/Sp+JdbZLGXzD639WtRWgG3BYMw2mHCJkQQEeUaRBu7TCB1tFHLA7BKocUy25n55T564rUN55h3odyFlwRdLbROClkFZeZmV5qx9fObidNya9uORy0RnND75tnur7HUk38bVr1KeCc8I17+3M67Q9BX98/mVLU+Xuz40YxFV73Nj+yVuCJYxbnl353MveTCyGDOB9sN8NIRsn75RldXEZFqpRQhCkEpVLZYdb+6s/bCt8L89kef0rMtcCV6RacsKLNzRrQpQm4eLI9XttI/rfSd+RRTux1fs+P5zDFptF4ttJvFXvzd/Cg6fp40IDS2pog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CgqzIWyWGVdCnmZWXNyieieSlSMzbA9MublS2eWIqZ8=; b=k6PcQ1T+HYEhB1uDXI70Aa1AFT6X8Z0HKYIEjZVw3P8L1bZCnC8xO5Xfq146QbNvv9jypeZtiGugNOApYFaspYTNTF2qZ5/qhp1kJc7f/ivhjko9GmDALSM9zzMW2LZ0o4CbV0hCyf61BSMGs7TWExbL0ncbnG/0BNVfmqK31t2zgzKH67R447V3tkmfsTctEELhaNuR+7bUvBaUynrpYHe5JVr3UIPU1nQdZcTGLlECzxJMVVvuM+dlBSunO/ZiKDY3NL9w75Z4n4kvWmertnXUs058h26nZRqdn0giuxKmxNHYP4qA//LKHMxA160ZXlqhM1j72SKKItWBrBh8fQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by SJ2PR11MB7670.namprd11.prod.outlook.com (2603:10b6:a03:4c3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Wed, 24 May 2023 23:07:10 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::1eb1:2222:1823:8e7a]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::1eb1:2222:1823:8e7a%5]) with mapi id 15.20.6411.028; Wed, 24 May 2023 23:07:10 +0000 From: "Chiu, Chasel" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Oram, Isaac W" , "Gao, Liming" , "Dong, Eric" Subject: Re: [PATCH 4/6] MinPlatform/build_bios.py: Support performance enabled build Thread-Topic: [PATCH 4/6] MinPlatform/build_bios.py: Support performance enabled build Thread-Index: AQHZjjtgzhu4JqC/+UOv9cor1V3NXa9qDFDA Date: Wed, 24 May 2023 23:07:10 +0000 Message-ID: References: <20230524122852.2047-1-ray.ni@intel.com> <20230524122852.2047-5-ray.ni@intel.com> In-Reply-To: <20230524122852.2047-5-ray.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|SJ2PR11MB7670:EE_ x-ms-office365-filtering-correlation-id: c24b3eb8-4fed-47a3-1fe7-08db5cab9a51 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: P2yvEPd0OGdIYGhNZXA5TqbXjBL1v0T2vMLDHBrzvBR3IcCljI8ZjeAkmL+pgogCroqjGxpat9yVTlqCTONepg98pFjhiOwInXRKF00/dSJD2RVakkp+s6/vhIncZ3r92qPYWoWUL0rSdWkw2V34RV8TbeIW7hnOqZOV6qtPla9FSOLNeUNSbWDrsQJM1vZXptc2qHRrJuhnrCGxbRsoaJ2vGPhQ4/kxMcWaIc0Bqz5F/8fbOb6SpwGvZ7vld8QKIt2HsB8VJN03NuxwAicQI7pH06//z/pYESzzPUd4p1o2QBSYClhuXQnXcRZ+ln9pWttVeMMye7L23KxSt6j39TpQDvqtRdkV6X87xf7Wv0fkM/O/UpyjJFpSlK4ZclNTncMANuu2d3GsXR9NZaNKoXkx4dcHQLXCK11ClaoRRjPc2rr/6TayqL/wqpSNrpvJBOVJf1pZNtrUHB0otU8nPWpIcSvrXdrJTkZjf62LEkklH2T/1slJit7HCaeJ7eM+P6Tpy26Sp3VTik1g7oP/ZO6RFvoh4WVqzNXt525wZHPXzw9Snb2BDNRfVCbOU5Bat++L44WNhAZba6xqseymS/nSeBu+1MXLeF4lbydZItByj7e1mOqW2qRtO0ELiCfL x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(346002)(39860400002)(136003)(376002)(396003)(451199021)(186003)(2906002)(107886003)(55016003)(8676002)(6506007)(52536014)(9686003)(26005)(53546011)(5660300002)(478600001)(66946007)(66476007)(76116006)(66556008)(64756008)(66446008)(4326008)(86362001)(8936002)(38100700002)(38070700005)(54906003)(110136005)(122000001)(41300700001)(83380400001)(7696005)(71200400001)(316002)(82960400001)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IgEQAufDr/M041IU7CC+e8fOt4SaqtsTyrTzuXUkdDWQ7FaiZ8sMy4/7svSi?= =?us-ascii?Q?H1p7iBVUyJ+hynYxl5iaa9yYVyrSwqaOIWaaufpbnlAaHgzzJcHsHF8QA7Ig?= =?us-ascii?Q?HGe+cT0lyLY4HHsJPgTQk8454YwHhj0WV5P396bAiQO4bo1uVUt22tUOtQiX?= =?us-ascii?Q?kfYfGV3nN8EQ0mw6bL9fuf0Z8KwIBg8jsAiFsQQB9SNNTlwhep4FHTl+xBqO?= =?us-ascii?Q?MB73KeuwCPyXVTeKr+9ZZ8RsueuV5juySbBnZnMPlTRL9UbqeD2qJJhcRRA9?= =?us-ascii?Q?mggB15/f1nbRSM0MkzlIIl+LSoFv4d7iXhXgBV5Ds3wjem8oCfKhGc7aFMRi?= =?us-ascii?Q?eXO4mgO1MCOYkpaptQyXvGzxQ2zComYsyd7KQpU678mqqnXojZufNiCoYB6x?= =?us-ascii?Q?pEmte3CXMHTnrJWB8CxjCa0gr5S9m18kSaYOLR+haRiFkDmVflN945UCVH3u?= =?us-ascii?Q?oOuRRfce6YhxIbrm9oHO1vk4vW2Du0yIqwK+pVw6g6pRmmCiKYUB5w7lVkUe?= =?us-ascii?Q?Amm0xYBLkkY4peXQuSBQ5vNWqEhg3y4FrkNMpBPjn/8aKpElt0R9GjYLL8aH?= =?us-ascii?Q?eNpsZMkSCJgEmSCJShhu/8HZ67dNJdKunE5tQEZBrE/Mq3o4o926AL1yZjSb?= =?us-ascii?Q?zAhZjw8w2qcsarp9v9HuqcGX3XxxLXigvy6VV/M7NBNNAxm3iAh9sfWmrxuI?= =?us-ascii?Q?m6K0eTUVx3AroeamDFDNsd+wAA058etjyIUTxNGrVRx3MqEPV+TTZyob2NkB?= =?us-ascii?Q?o7J/FI0vRE1p1DYQX74spf5Fyb6idrxOgFI01I5PAO40SAfWkJ0NrhgQsD/3?= =?us-ascii?Q?JlIYBWPH1Q2oQURwktqOFtmvC1ddg56L3/OXdqg7AQr/CY6qS9OryhiY1fKO?= =?us-ascii?Q?0jqzjnwGRXzNmeFfe73Mp3+zta6Q6OksfIjRRlwwK7MCm7yWzr643YHivh2k?= =?us-ascii?Q?JBA2NEreS60QcPpnTbMW97T777rWJ4Re9npK1CKWGH/xNxeDHqpN1OKg363/?= =?us-ascii?Q?KnCg/NCefD4QbpO+78+aNHBAcyx/dJhLc4Hel/7PZ4+9M5E4vdajGbbmU86X?= =?us-ascii?Q?X3zQLzHOvUGcJoi0keZZUcXUnxpvZia14ifE8KMjfmaJRTHdJ+Ig8lDsBvRL?= =?us-ascii?Q?b7hhVOc5vghCHLe+xPA+yTW6bN55CD621zWk2c0FaEebmdgX83hb5sj/gmk/?= =?us-ascii?Q?POr6wAi4JNnKJD/TWG/3f6L85UIQMSlY5Q7ARxoL2zzbNVFisvQBK4/JDv8g?= =?us-ascii?Q?37cvzAAX/TUVt84/E6LxDc/pFP0ZUJ1neTxsVjw+0QfgD5oJe0XedW/77MYg?= =?us-ascii?Q?xCQdvcUfKAsFwQ+mAdshZoUVuBEX4Kezd7YWF6nx0GKML6FBh+SFUYw3owcn?= =?us-ascii?Q?Zy6yV84DyfGVJQHkpHEHjFbaKzm767wGHEp9pdjtXK7xj4cDiL3JrMSqnpSp?= =?us-ascii?Q?7yow3Lxvj2Yg2X/LTzsoI+SPy1V5aBR8zGBZLYRKcev8h4XqrDYJ+4HZJx04?= =?us-ascii?Q?Z6kzF0dHY7VX2SabYAaSu3xZE1k+AFFgvGCnRYf30bdB3TzGnrMvNucZa8N6?= =?us-ascii?Q?I4v7tgBMY63VnzOBgeD8+MNDSTeIMBwRIGyrkzHF?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c24b3eb8-4fed-47a3-1fe7-08db5cab9a51 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2023 23:07:10.1049 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /8djrFqCptpapxhmD1wNVYbtW1iYkEQ9emu/SuWXCm/YDRJkO0rH2yFVI1O5qHydl3dXDT05wWxBCXvLQ4PN7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7670 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu Thanks, Chasel > -----Original Message----- > From: Ni, Ray > Sent: Wednesday, May 24, 2023 5:29 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Oram, Isaac W ; > Gao, Liming ; Dong, Eric > Subject: [PATCH 4/6] MinPlatform/build_bios.py: Support performance enabl= ed > build >=20 > build_bios.py supports caller to pass in "--performance" flag but the scr= ipt > implemnetation just ignores this flag. >=20 > The patch adds the missing logic to invoke build.py with "--pcd > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable=3DTrue" > when "--performance" is supplied. >=20 > Signed-off-by: Ray Ni > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Isaac Oram > Cc: Liming Gao > Cc: Eric Dong > --- > Platform/Intel/build_bios.py | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py = index > da4097d5db..9c95cfff76 100755 > --- a/Platform/Intel/build_bios.py > +++ b/Platform/Intel/build_bios.py > @@ -1,4 +1,4 @@ > -#!/usr/bin/env python3 > +#!/usr/bin/env python3 # # @ build_bios.py # Builds BIOS using configura= tion > files and dynamically@@ -421,6 +421,10 @@ def build(config): > command.append("--pcd") > command.append("gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection=3D1 > ") + if config.get("PERFORMANCE_BUILD", "FALSE") =3D=3D "TRUE":+ > command.append("--pcd")+ > command.append("gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable=3DT > rue")+ shell =3D True if os.name =3D=3D "posix": shell = =3D False-- > 2.39.1.windows.1