From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web09.10771.1667418227612190189 for ; Wed, 02 Nov 2022 12:43:47 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=TfiMtDrB; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667418227; x=1698954227; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ggD79MHCR49RcUgIpg97HlQVVEtqXqipGI0l+kOX/U4=; b=TfiMtDrBUlgckgeC5D23IAP+/9Dc6zm4yqGzn1gdZlKlJOHb15c9U1IE m2W9YW10n76HAWrlM6WHYyjL1xF+qILjXn7yTMt3BQ7WWGF1uOhr+VSJY J7n0Krq+dHa7ljBMc8xLM33+idmR950+fG9SymmI4vHM6etB/rGYqJ1ml U/BxV/Gby1r/N1D7znvez+yGd0qh7G1SF+HjxGjvfVHWU0RpkEgm7UZuj 7TjcfvGdDF28279QiQKYtGJoYsavDs8x5BiHFwWPOqg2G0wPPnL4mkzK+ OqcW52uNCSa8AMAL1UjBN95bsWyanCZ+2Y2JWmrl9Dx/9/zGCq1O6zOis Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10519"; a="289217231" X-IronPort-AV: E=Sophos;i="5.95,234,1661842800"; d="scan'208";a="289217231" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2022 12:43:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10519"; a="809400174" X-IronPort-AV: E=Sophos;i="5.95,234,1661842800"; d="scan'208";a="809400174" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP; 02 Nov 2022 12:43:46 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 2 Nov 2022 12:43:45 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 2 Nov 2022 12:43:45 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 2 Nov 2022 12:43:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FEyUQc1kkfD+N9f2PCl8wARipvyXI8UjKALeHvJkWC5RS1z8lGx1RigQP/DuBIlLt9EGg0ykUQhvA/8PPz0XuHfbjSqBu7nyWJCISER4fmDk0I+Om7CJez4a9ub7ctsfCVrROBNc/TUjIFtaE2vJwCNBjCDyDCK0+D2pYHwZGhQfyYMdpTDLOzSe4Jt8ahi2NOLVt33tPFGcKRwbOj9CNylO+JGtUkhVcnW0aLuHMfRo7gW0h9og6Z7h5fCJ/cGd8aGSl2wBzw5Hy9v0QU1dd3O6iiHwN9fp4Wq5scHVi/vVK7MDitBdiTSLqchSSxQjoVNJsaxR9dVeoJalISjpuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N5SrSDvQ4BvzPpgPcpSdBjPo1Rl55Bk6yRouD5HrnOM=; b=VjXbVMiVIgwBvbnummT8mlqb5RwS27t8BhBdT79UGt+jiP6xKxKTFKAkHGdzkbfhEv6Ef98uTRfZswM8QREidZfbtq4kjAwiE+UohMQqvdwJzSH9CudgDQs+9fxYcMvaFiJHm1SjJAc0eCmJlDi+AJft1Gb5cl1zGKiQCvVe4juT0k5GfN53j+d6E6TwYwTPMeJEZ7bIk/NgzcMyf6Zqo06DLuZ/bfT7QZ5fJxd/8rKjLkPaqduc0fMFwn5OsNtIN/hCsQWWL0sdJ/y61xOIEh2hDcvIX+qFeBZi1cvtnu+ZVyQnPyYxkGU4bGVZVbGEiFvBgtSy0l2rYkCbcRzwOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by SJ1PR11MB6180.namprd11.prod.outlook.com (2603:10b6:a03:459::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Wed, 2 Nov 2022 19:43:43 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::3f62:3295:adf5:aaae]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::3f62:3295:adf5:aaae%6]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 19:43:43 +0000 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "Chiu, Chasel" CC: "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Update Function header to support IA32/X64. Thread-Topic: [edk2-devel] [PATCH] IntelFsp2Pkg: Update Function header to support IA32/X64. Thread-Index: AQHY6nk1X+K+fF/zo0C073487RpMQq4sEbGA Date: Wed, 2 Nov 2022 19:43:43 +0000 Message-ID: References: <17221C4B533793A5.17799@groups.io> In-Reply-To: <17221C4B533793A5.17799@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|SJ1PR11MB6180:EE_ x-ms-office365-filtering-correlation-id: 5bdfd7f4-7a22-4a95-c251-08dabd0a8c80 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: W3NSKtWtPXBvwCcJAFhjBYV6tz9BZJhIABKEugS2ttOFB0VcHHV6cx5C8jGMcWAyfxWS2nbMNY+YkpdV6ZDEeRhK9iM7T9gmys1uVHQR8jx7MVfvIn3hXzwI1ZW9lYhMRKm6e3yQxGP4/JfDx9OLwJ4IUnsx+aRvWFcTRci0vtLejxmcy5q32pXOdmuCBmtq3hp/1U/NAh/yx6EDE2JWA8CnP0n982RegByQPIBv3NKTA9uQj65oltk7xRXVPlueEEFD6ZIla3MTnUJHgBuOEVBN+VRTJqvcd8hna5rUSEuXmlEcBGeP7TvNOn5VcMsLX+MxSFZpfmg/CTX3qs1z7nD6icR1BHvFvo9OS+BfucdOiSKw49cxgAD0sPR5ZeKEqbVW1LjqyCTnGG4FdooSMp4OHJ/aOSMMXOTP/FT4L/RtIVa7EgR6ZeR7nwG03qttz9zZXaK4qoPAHFMghxV8Xyx2R8QMrf7Mm4lEheNVZwRXTDkv9MQi+9lcVCUQI+V8RQpSf1pbOHew+adDTDi5UpaboWDsmQvDQa7Rob5Ffc3AilowP0udk90rXuXB5eG6InO8+nDyvEkKdSWtIn6LVMbtw3FP4hLhFjafeUxYbWV7bpO+0q/yXQcTr86wJ3m7YO8q6RCc4f5nC8EFf4dWSMIKvW0IfZnqe2DcGWfktt5mU402HoX4SlVWoHvYN/k8TFdx+tgPktqxAoM2XCRB9BvqYr1Ipl+Dy7qeqK7fdR1gtA/TKrdVD8QxH0gIzMNqD2qcZdnv8vSayD6Wq/aWDPjV86/09I3V0LTrM4HE7Tq+SVExPfeJ3W4zxcAmOOZwxlmll7GcWcxAZIncty0A8g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(366004)(39860400002)(396003)(346002)(451199015)(26005)(66476007)(66556008)(64756008)(66446008)(76116006)(33656002)(66946007)(8676002)(83380400001)(4326008)(54906003)(110136005)(15650500001)(316002)(8936002)(52536014)(19627235002)(107886003)(5660300002)(186003)(2906002)(9686003)(86362001)(82960400001)(38070700005)(41300700001)(38100700002)(66899015)(966005)(7696005)(478600001)(55016003)(6506007)(122000001)(71200400001)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?v7wn2Emt1fDKhetB3IncjnLwrB6nzZD+hbLcsqb1VM68OwVdWE6W0c0l5nj5?= =?us-ascii?Q?wTIUEOOF5HaK8O13CD8lopXD8CRK2wuZvpQavxaOBVQoe2cEa8EDrQa856/6?= =?us-ascii?Q?5OanR6mCR4YK+dTsN1q7NreInWU/sNKLErBWy13BEHfupbM2ObFrJkA5GKOQ?= =?us-ascii?Q?79DyS5n6JFdLe+0k8pve5Pp6BmsAE7x5vIKowvXBpUqwgZXrirJOrx1t6ouC?= =?us-ascii?Q?7au87lX0WQ9sHAdgkummnhkwB3nmXLAQFj0sQCsiFeCXzTgxz4anlz8GhSp7?= =?us-ascii?Q?eYeHhs2o3P6lhqoG8OyI7lS2HYRYjLjac5q8+ZT399XKw7sgtqg2Iwekku6T?= =?us-ascii?Q?BoiYYRZMjugLyS7OJQEWd9cxMqigDS+sXFHQ12U1DAqDfhiWH3niwaQmt828?= =?us-ascii?Q?Fbe9jC7pF1wGW16ElNiYnHHSuCzp0Y5o9knoZ9Me+mg2R+TZXN/RhgVH7bCk?= =?us-ascii?Q?F6mqwwHXdKg8dcWOAMIUG/xY0XIgA+HNUj2dCz+Lyh+PmmmbJuje2h/TA77Q?= =?us-ascii?Q?jtzUIqBxAOBu09lHo62+65mp8ed1Ss2r35834C5lzu5pD7Y7kv5EVcIc8neX?= =?us-ascii?Q?PoptCB63mW6Qu3ognMzrUBb7MNYWwgtxUAQOMVjzGoj3JOZbzGjN0TV8OL9S?= =?us-ascii?Q?wSqoK7y9Xainwq5sE0tlHd2CUKzUgHfeq7GxiwfQluHf3mXHW932w3NkYzCu?= =?us-ascii?Q?JqRcgG/hmUeeKMPAoWaZ3lHp97W3NUb+cKeGc2RNOGNNeiOpBH1r6Mwmc8IM?= =?us-ascii?Q?TMGXl4pf2c/hx6r1FiLf5fznJ0DzF9hWPxwLES2k3qCDxC26lrmHuc4dFiaU?= =?us-ascii?Q?iNBCHB6HLprIheaPrU950wJ8JkErWtzXvrug6CSfa9FrWqRJdZEuuFEzg0x0?= =?us-ascii?Q?AKD1+dgSGswWsQKd+kcme/b3e+m5YdbOkpF96kdM69U9N4V2L7yPuuYiSd78?= =?us-ascii?Q?RkPB46dkyzOWq/p81XjxMScfuq7fd/KhMgPOhDdB7O8mgdb4Mno4N5zWJHLY?= =?us-ascii?Q?aoSdp660CGchvk9M3IoefamkNq7aB01vxy0nlJHz50ouYwI5CqsKdzXT5tVO?= =?us-ascii?Q?p0vAjxs2KUgRDj+01JVYzhg9SSqbwYIu2peOHh7QgmwG9oXmLsWeY5eN/w3j?= =?us-ascii?Q?ZTjWOORpzLam+MfGB/U22Q00GkNekY6NHfL3gJWa1d6MelOD69YvJas9oI4y?= =?us-ascii?Q?U3aeGUHe4gA80dLTkUYoobzOxuy6ERom67tSyWLD5vpzvYmJduY3cauMqvnh?= =?us-ascii?Q?GBkmueqQc7gWssjssuMChaGDtVaAW86MteWyRoTsu6TaLVNygTLLjt1BbvdB?= =?us-ascii?Q?7tF06245Ubo4zu8N2kVy4g1w4MFn+SGDybMLR7gpMFOJmR2egT0fqs9ymTW2?= =?us-ascii?Q?hXlNlwM4vckd8il2WCniszaaoYPSCStCs5wFCW0JA+VH5XQeBtSjF3gHQvHI?= =?us-ascii?Q?k2E+0z66cAcdnhU0Gf3ktRku1Ib1CB2OACr7zzUI5fiXrNSseTQwA8Pm6CBY?= =?us-ascii?Q?XxqG2p5WgDELTTbqK2LO336HcFqf39XL1hfA9Ciy81zmx1nd4yBJTgXvbvcD?= =?us-ascii?Q?47yxUbDXa26F5qre+CQe0iWKwM40bNLqPGGy6m77?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bdfd7f4-7a22-4a95-c251-08dabd0a8c80 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 19:43:43.0605 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AVEYOKHXkWKs9gwD0Bfyfa6uOCcZvSp3PMLGSpjbpDRGpfL5tg6qRFkSMIFu/ivC6cP4c0YddZz4Qo9dtcqpzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6180 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Patch merged: https://github.com/tianocore/edk2/commit/c46204e25f5b929fae2b= 336c03c73fada632d4f4 Thanks, Chasel > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chiu, > Chasel > Sent: Thursday, October 27, 2022 7:58 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [edk2-devel] [PATCH] IntelFsp2Pkg: Update Function header to > support IA32/X64. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4126 >=20 > Common functions will have either 32bit or 64bit instances which having > different return code size. Function header should support both scenarios= . >=20 > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Chasel Chiu > --- > IntelFsp2Pkg/FspSecCore/SecFsp.h | 4 ++-- > IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h | 12 ++++++------ > 2 files changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/FspSecCore/SecFsp.h > b/IntelFsp2Pkg/FspSecCore/SecFsp.h > index e84528b378..d7a5976c12 100644 > --- a/IntelFsp2Pkg/FspSecCore/SecFsp.h > +++ b/IntelFsp2Pkg/FspSecCore/SecFsp.h > @@ -70,7 +70,7 @@ FspDataPointerFixUp ( > @return FSP binary base address. **/-UINT32+UINTN EFIAPI > AsmGetFspBaseAddress ( VOID@@ -82,7 +82,7 @@ > AsmGetFspBaseAddress ( > @return FSP binary base address. **/-UINT32+UINTN EFIAPI > AsmGetFspInfoHeader ( VOIDdiff --git > a/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h > b/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h > index c91ea4a78f..598fdb9ec5 100644 > --- a/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h > +++ b/IntelFsp2Pkg/Include/Library/FspSecPlatformLib.h > @@ -17,10 +17,10 @@ > The callee should not use XMM6/XMM7. The return address is saved in > MM7. - @retval in saved in EAX - 0 means platform initialization success= .+ > @retval in saved in EAX/RAX - 0 means platform initialization success. > other means platform initialization fail. **/-UINT32+UINTN EFIAPI > SecPlatformInit ( VOID@@ -37,10 +37,10 @@ SecPlatformInit ( > @param[in] FsptUpdDataPtr Address pointer to the FSPT_UPD data > structure. It is saved in ESP. - @retval in saved in EAX - 0 means Micro= code > is loaded successfully.+ @retval in saved in EAX/RAX - 0 means Microcode > is loaded successfully. other means Microcode= is not loaded > successfully. **/-UINT32+UINTN EFIAPI LoadMicrocode ( IN VOID > *FsptUpdDataPtr@@ -56,10 +56,10 @@ LoadMicrocode ( > @param[in] FsptUpdDataPtr Address pointer to the FSPT_UPD data > structure. It is saved in ESP. - @retval in saved in EAX - 0 means CAR > initialization success.+ @retval in saved in EAX/RAX - 0 means CAR > initialization success. other means CAR initi= alization fail. > **/-UINT32+UINTN EFIAPI SecCarInit ( IN VOID *FsptUpdDataPtr-- > 2.35.0.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#95662): > https://edk2.groups.io/g/devel/message/95662 > Mute This Topic: https://groups.io/mt/94619463/1777047 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.chiu@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20