public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix Build
Date: Wed, 29 Sep 2021 01:12:49 +0000	[thread overview]
Message-ID: <BN9PR11MB5483BA92B9424DA87D64135FE6A99@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210929010323.2653-2-nathaniel.l.desimone@intel.com>


Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Wednesday, September 29, 2021 9:03 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix Build
> 
> Commit d281e9e broke the build for KabylakeOpenBoardPkg due to
> DxeMultiBoardAcpiSupportLib having a dependency on BoardAcpiTableLib that
> was never declared. This change adds a correct declaration of the library
> dependency and fixes the build.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  .../Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf       | 3 ++-
>  .../Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf       | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/Dx
> eMultiBoardAcpiSupportLib.inf
> b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/Dx
> eMultiBoardAcpiSupportLib.inf
> index 9fe27f9fda..dc597c4808 100644
> ---
> a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/Dx
> eMultiBoardAcpiSupportLib.inf
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLi
> +++ b/DxeMultiBoardAcpiSupportLib.inf
> @@ -1,7 +1,7 @@
>  ### @file
>  # System 76 GalagoPro3 board multi-board DXE ACPI table support functionality.
>  #
> -# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2019 - 2021, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -26,6 +26,7 @@
>    BaseLib
>    IoLib
>    PciLib
> +  BoardAcpiTableLib
>    AslUpdateLib
> 
>  [Packages]
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/D
> xeMultiBoardAcpiSupportLib.inf
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/D
> xeMultiBoardAcpiSupportLib.inf
> index e5de9268e7..8438b16a6e 100644
> ---
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/D
> xeMultiBoardAcpiSupportLib.inf
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi
> +++ Lib/DxeMultiBoardAcpiSupportLib.inf
> @@ -1,7 +1,7 @@
>  ### @file
>  # Kaby Lake RVP 3 Multi-Board ACPI Support library  # -# Copyright (c) 2017 -
> 2019, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2021, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -26,6 +26,7 @@
>    BaseLib
>    IoLib
>    PciLib
> +  BoardAcpiTableLib
>    AslUpdateLib
> 
>  [Packages]
> --
> 2.27.0.windows.1


  reply	other threads:[~2021-09-29  1:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29  1:03 [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/AspireVn7Dash572G: Fix Visual Studio Build Nate DeSimone
2021-09-29  1:03 ` [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix Build Nate DeSimone
2021-09-29  1:12   ` Chiu, Chasel [this message]
2021-09-29  1:11 ` [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/AspireVn7Dash572G: Fix Visual Studio Build Chiu, Chasel
     [not found] ` <16A9255C60D9E335.27626@groups.io>
2021-09-29  1:49   ` [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix Build Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN9PR11MB5483BA92B9424DA87D64135FE6A99@BN9PR11MB5483.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox