From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web12.3015.1632877972882495668 for ; Tue, 28 Sep 2021 18:12:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=FUkkBoMy; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: chasel.chiu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10121"; a="224905872" X-IronPort-AV: E=Sophos;i="5.85,330,1624345200"; d="scan'208";a="224905872" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2021 18:12:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,330,1624345200"; d="scan'208";a="479015711" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga007.fm.intel.com with ESMTP; 28 Sep 2021 18:12:51 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 28 Sep 2021 18:12:51 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 28 Sep 2021 18:12:50 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 28 Sep 2021 18:12:50 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 28 Sep 2021 18:12:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bRzJmoK4BH+cHpHYhunxKfHsLkl0KMwZJOXI3jq6IyZ3XSjesWu7fqWvtmdUvi2iifO6BuxFMZpb4Bld8vmEeje+5se10oV9dLjFln80V68Tg9CAfb/41IB4RO9N3kQqKZxiHSdkIoGGTcPcgdhWB+RydHLPPQ6PqfLBHzZX/Q9J8Lxpy6nGQY60VZ3LsukUTD2IVOeQXauMrT7t8WW5TbTcIbv1hvKKhYytBchIRz9vNNV4mlBDHUBKlHlfGpcVGzjz+ljc0OJtBGOvsw1FNtVFUk+DRlbpf5JgX0QV0Ldd7hP+ZjCBREdbSG1rdmn85I/pYrDHCfQuIbnkvr3TGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=n5Yqr1RbFUCybvaexegvw+XkR0P6sgq9fLIH2uLiH9w=; b=eK+heTQQG23RRPpxtOrgsdVNH/2g6K/UbNUmUU9RKBUoSkXff0eiO35hrPxscPYsafcGHlD/5WeOIQv60YAPTUJuqRbqSkF4o+zF3lcH91jrOFu3l83cv3zurTuU5lfEn+4nJMbMf/VJUPl5yagRmgalEc2n26w65nOBbBEUYCaatumXb2LAFB8/HGS8kwBLdcEyoWLBIkZcShawajZ0aOb38Z4aHvAOxz9NnPV0+MbYoCP9w7j5RPFemUPvgYrMvp0L11UP3RxjkTRVmWayHqKpjqEsPINNHbHqxd4iuYmrxE0tQS/tokkUTi6dkjoBpI97dOlFPWag2tbeTS/bAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n5Yqr1RbFUCybvaexegvw+XkR0P6sgq9fLIH2uLiH9w=; b=FUkkBoMyYN0vSFoSohaiXrNJo9cT5iZyihjUTMsnnnIgDSJR3QSgAKpRPjayK4azyV1i12rhfoNgq5d4xeeYZOqmeGDyby+8+39Z5S5fFyh17ugO1jhDTvc62AcIO7XY0l9UBuYMGTPsH7e+dwYnLe1Kfn4UfX6jH57c7yiMceY= Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN8PR11MB3649.namprd11.prod.outlook.com (2603:10b6:408:84::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Wed, 29 Sep 2021 01:12:49 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::882:4e40:b0e4:239e]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::882:4e40:b0e4:239e%7]) with mapi id 15.20.4544.022; Wed, 29 Sep 2021 01:12:49 +0000 From: "Chiu, Chasel" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" Subject: Re: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix Build Thread-Topic: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix Build Thread-Index: AQHXtM3Wt7+U9/18o0mqECfTg3WTXqu6NJGg Date: Wed, 29 Sep 2021 01:12:49 +0000 Message-ID: References: <20210929010323.2653-1-nathaniel.l.desimone@intel.com> <20210929010323.2653-2-nathaniel.l.desimone@intel.com> In-Reply-To: <20210929010323.2653-2-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9939fa5c-9766-48cc-3614-08d982e640e8 x-ms-traffictypediagnostic: BN8PR11MB3649: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6r02pOLJ3QFhOihfmToTq8E/zXKzO82n9m9ikHN9yLnKtBOUGf5f6KrVB2o2pt/x2wuDwoTqleElq3BSV3/mcqjcZ8kJGbZ6K7dj0FdRwlqxrjAahKCvO/udCa9p8HxBkwENPhipZDR9TNjbb/d7uDfj6t9050QEnL4+la8yQuj+6bIi1Bo//Z0kXStdak8DevtRp6w+lFEcX+vTsXbICs0K/41oLEogPK3w5kCC7MGj610ZJmMRz09bx9VtNSdS9SGUs2fu3SKyIA2rlT1sZ4ExyVK4ziz9etPz9SZsz44GRqokYi8X9uVUMKSBgwBouAvHoZo3cIgQiDPTM0gg4fyg+cpfzfNhclVX/rimBQRIihUEM7XAI4VFcCtAhJiAafSxAapJkNcNexBsK4lKRmP/P/sDbej5GyM7XFOGSuwiM3TK3AOeMly8v4mc+w5WAWtzGPMm/vOakaHS2R5z+7TEU77nC9OUplZqLtfpzrTdbzdKmAUW7tOJiY2Zbb5Rrtn/7sVGKzkpQgOol/+iiHkHvHh/tIvnV511yf1hhN1sHQLy88V/hcsZSYYCXv7j50OSzhREiMuAd371/J8nSj4jYC2tdoaswgaHNapx8eZfZcJNJv/IfTaAmmhBiePrkHJRw6r/kTe5P23zcFV54OZ2LZiihiI0xCRLdAxKzKT/bk1+Z/7z/Sm9KleOopBR/LjJRxzHZGpXxdUEfQBovn6g5nVIqaP9nr1oQV4oyA7RBnMNI5bqFmcSfOGpQVpx x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6506007)(71200400001)(9686003)(33656002)(8676002)(26005)(8936002)(55016002)(186003)(5660300002)(7696005)(508600001)(53546011)(52536014)(110136005)(76116006)(66946007)(83380400001)(122000001)(66476007)(66556008)(38100700002)(38070700005)(316002)(86362001)(2906002)(66446008)(64756008)(14943795004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RqNR1rBvf81KUJXehSPxrFBwProVVy3AuUpOtPxQ4TRyyl//jf5n0EHDFoD7?= =?us-ascii?Q?YyaamKCBLuDcs64sN2ZERIU2NrsGxQBLW43lYj5L9ewlG1RFMmhPcd4ELx2C?= =?us-ascii?Q?0X8eQ2qQnLUAk8SbHBjehWwm0+6wXwUogKXF4RzfeQCr+n00WnFEBT4czwkl?= =?us-ascii?Q?qkgDlOwHrhsiakoxPMrIDAug78VmGnWypy2DotuKF2uuA9D9SzyaNxSr7Qgz?= =?us-ascii?Q?1pXAdkoKmWhVo0I8RMNGomRau+HU33zRpOldI9FVsyMZ17/Id4ynMWLiFt3T?= =?us-ascii?Q?e5NFyp/ihALQPvf2MRvMFPrqiZ9gx0N0SjmX4+tVPC1mvv3Docl1rxPCIcco?= =?us-ascii?Q?eH3chZeBbUOXs5jsvlcicr7SphBSGlXnfYOrjPs+w9NNiKEjsE1h5eHxvfUk?= =?us-ascii?Q?zdrVl9jJtACdKmkh33mMpYQXHhE1RHCW86dc3DNTUWA40g5uVDzNQAyhu68K?= =?us-ascii?Q?LTtYTrQvcDMdq13DmTHG2I2OSc8rw3wqFHkvuQn9oKiikXcAZQl2YG8DSLb9?= =?us-ascii?Q?OaV+L210zDjOqiMD+z4D+gTj6miCSMfzecfCx2NPhZCNhqD/d+i1EXtNXLkx?= =?us-ascii?Q?N5pgSNHCizrzok7UIFWRe98Y9NoBIzEgylRrb2G2YesiaPWru+55H7ijLhiC?= =?us-ascii?Q?XVapjoPcuLPRZWROkSHQjH9xWCN6JScGKw9aH94/fHnHlfHWjtwNYNifmL2R?= =?us-ascii?Q?lnP+rD7Blvh4q4JiZGoeuIE3iKzaWwpwIk0sCKAt8iPz2NGxmptsjFA7jH1Q?= =?us-ascii?Q?b1Z+FSaNj8YvpeM8dNo1+qpPdff2hPXwXy74+DCfzQ3necLbe9R1NMBWtj0T?= =?us-ascii?Q?CjAQZ3siQ35rmIhXMbz76p4AdBg5bTTASOcc8dwM7PHYSnhZXrM9Dhpgchxk?= =?us-ascii?Q?TXgMUnhREsT9QZdpWZegV9Y3LTg7wlaZKseZzey5VFSc0Z52eOd+y55wtQI/?= =?us-ascii?Q?B/NIiDbMbzhUbYWrS36uaO1Poax1awo7wLFv+n8jIDv5IP4B7fcXn/22PKyG?= =?us-ascii?Q?7WQv7fsM4PJ2XxdOFMYc9aoXsgGCg6tKzyjwbZXlFGCX/u0UkVtwqudMTMG1?= =?us-ascii?Q?gkFibyrwowLARlufr5Y9AObU9db5T/8ki2aTCjr6vxt9Ua9qM9rzNCK77Wwv?= =?us-ascii?Q?tCh8EcND4TBmOLn0SCvrSOsnxsdAAvPmGFsfsx3xSl80u5zUY0e+OdTCst3c?= =?us-ascii?Q?12zCG4cfqrOGnrgTQF6fuq78K4whOw/i/SUyuj8CPq0ioyJ55pBpSrhfzWvY?= =?us-ascii?Q?FV8icFST7L16ZrG0YckYXU0dD0qYA1B0yD03OGEnr67QvnOMXUg0ifWWErjT?= =?us-ascii?Q?NMAqQA81ZXwQLTeq3w/fk1rv?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9939fa5c-9766-48cc-3614-08d982e640e8 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2021 01:12:49.1370 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q/s1azK+JKFoF84nAlGtioBC0iR/pxYUTAACDlNhrGCEZnrqne4W3RbCJnOwbStCTEvewUG/N/TkiNtD0ymxVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3649 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Wednesday, September 29, 2021 9:03 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel > Subject: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Fix Build >=20 > Commit d281e9e broke the build for KabylakeOpenBoardPkg due to > DxeMultiBoardAcpiSupportLib having a dependency on BoardAcpiTableLib that > was never declared. This change adds a correct declaration of the library > dependency and fixes the build. >=20 > Cc: Chasel Chiu > Signed-off-by: Nate DeSimone > --- > .../Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf | 3 ++- > .../Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/Dx > eMultiBoardAcpiSupportLib.inf > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/Dx > eMultiBoardAcpiSupportLib.inf > index 9fe27f9fda..dc597c4808 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/Dx > eMultiBoardAcpiSupportLib.inf > +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLi > +++ b/DxeMultiBoardAcpiSupportLib.inf > @@ -1,7 +1,7 @@ > ### @file > # System 76 GalagoPro3 board multi-board DXE ACPI table support function= ality. > # > -# Copyright (c) 2019, Intel Corporation. All rights reserved.
> +# Copyright (c) 2019 - 2021, Intel Corporation. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -26,6 +26,7 @@ > BaseLib > IoLib > PciLib > + BoardAcpiTableLib > AslUpdateLib >=20 > [Packages] > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/D > xeMultiBoardAcpiSupportLib.inf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/D > xeMultiBoardAcpiSupportLib.inf > index e5de9268e7..8438b16a6e 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/D > xeMultiBoardAcpiSupportLib.inf > +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/DxeMultiBoardAcpiSupportLib.inf > @@ -1,7 +1,7 @@ > ### @file > # Kaby Lake RVP 3 Multi-Board ACPI Support library # -# Copyright (c) 2= 017 - > 2019, Intel Corporation. All rights reserved.
> +# Copyright (c) 2017 - 2021, Intel Corporation. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -26,6 +26,7 @@ > BaseLib > IoLib > PciLib > + BoardAcpiTableLib > AslUpdateLib >=20 > [Packages] > -- > 2.27.0.windows.1