From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Pabba, PhanindraX Babu" <phanindrax.babu.pabba@intel.com>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool
Date: Tue, 26 Mar 2024 03:19:16 +0000 [thread overview]
Message-ID: <BN9PR11MB5483BC5D1C1EC6CF04516D68E6352@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <de8a732f7c23f270e1fd4cc4f5350bcee24176c7.1708671087.git.phanindrax.babu.pabba@intel.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
Thanks,
Chasel
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> phanindrax.babu.pabba@intel.com
> Sent: Thursday, February 22, 2024 10:52 PM
> To: devel@edk2.groups.io
> Cc: Pabba, PhanindraX Babu <phanindrax.babu.pabba@intel.com>; Desimone,
> Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool
>
> From: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>
>
> Adding missed out call to FreePool API to free the allocated memory.
>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>
> ---
> .../Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c
> b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c
> index 990b4b9e..070a3452 100644
> ---
> a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c
> +++
> b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.
> +++ c
> @@ -250,6 +250,7 @@ BmcAcpiEntryPoint (
> // Increment the instance // Instance++;+ FreePool
> (CurrentTable); } } --
> 2.39.1.windows.1
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#115876): https://edk2.groups.io/g/devel/message/115876
> Mute This Topic: https://groups.io/mt/104524860/1777047
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.chiu@intel.com] -=-
> =-=-=-=-=
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117101): https://edk2.groups.io/g/devel/message/117101
Mute This Topic: https://groups.io/mt/104524860/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2024-03-26 3:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 6:52 [edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool phanindrax.babu.pabba
2024-03-25 22:31 ` Nate DeSimone
2024-03-25 22:33 ` Nate DeSimone
2024-03-26 3:19 ` Chiu, Chasel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB5483BC5D1C1EC6CF04516D68E6352@BN9PR11MB5483.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox