From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5441AD80808 for ; Tue, 28 May 2024 06:35:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=I6ZfFHMfO9fqMpudb3QkhGDO0Z5vHGZUrdGgrjiH/Eo=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1716878152; v=1; b=H1GxhDj+SAsjpcmJdqeMgtBWV1L7zWMcBm6oIWfk+0rtrk4qj1vVLDiDCaFJih1Wi+EKOwYV 0j2kgfKYQnuAOAQqFkS1h3nVPTNKO0smE6PmYq5RzkGqEvYpyRTdUtAaIAyO4Z+5cVfMIc3yL2s 8+Vd1Gs89Esgfs/3NJD0EHZq9+2vnHCaOk4LuL5BNrMTF8WfcqW7GYjBL2cProq+xQlPxg8gtLM Yv+KCISSUkL22Ya765KXtBEv9p1wCG+jFYtX+dmPJPC0asFmjMF31b3hdcnBnDLdIu1i78RlhjG ts5tTwYjtjljLKDShkcuiISYAUD6yh/G8zJ4D4ZWQ0fqg== X-Received: by 127.0.0.2 with SMTP id grB8YY7687511xQSxX6Igeh3; Mon, 27 May 2024 23:35:50 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by mx.groups.io with SMTP id smtpd.web10.15913.1716878149881350461 for ; Mon, 27 May 2024 23:35:50 -0700 X-CSE-ConnectionGUID: ACzGgxuLRym/sr5FR2QHdA== X-CSE-MsgGUID: CJGNokt1Sh+O0acrheNNhw== X-IronPort-AV: E=McAfee;i="6600,9927,11085"; a="13425030" X-IronPort-AV: E=Sophos;i="6.08,194,1712646000"; d="scan'208";a="13425030" X-Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2024 23:35:32 -0700 X-CSE-ConnectionGUID: LzSmMFP0Qbi1S2/8tAXhNw== X-CSE-MsgGUID: MwmZn68mThOoVK5l5pS7rw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,194,1712646000"; d="scan'208";a="34946195" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 May 2024 23:35:32 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 27 May 2024 23:35:31 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 27 May 2024 23:35:31 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 27 May 2024 23:35:30 -0700 X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by PH0PR11MB7423.namprd11.prod.outlook.com (2603:10b6:510:282::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.29; Tue, 28 May 2024 06:35:28 +0000 X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::3baa:3852:4315:38f7]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::3baa:3852:4315:38f7%7]) with mapi id 15.20.7611.016; Tue, 28 May 2024 06:35:28 +0000 From: "duntan" To: "devel@edk2.groups.io" , "Tan, Dun" , Liming Gao CC: "Ni, Ray" , "Wang, Jian J" Subject: Re: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE Thread-Topic: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE Thread-Index: AQHaqD94BXL9CUnSfEWAz4IeSojN9LGsQPPQ Date: Tue, 28 May 2024 06:35:28 +0000 Message-ID: References: <20240517094610.533-1-dun.tan@intel.com> <17D03DA5161A67E3.17823@groups.io> In-Reply-To: <17D03DA5161A67E3.17823@groups.io> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|PH0PR11MB7423:EE_ x-ms-office365-filtering-correlation-id: dac28036-1fd8-4e06-519e-08dc7ee05d9c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?7lu4p+S8bW40jsge1uKxZM1TQnxNyT9UPuuTg7pOUIgyWigs4wvlm6kvKtR4?= =?us-ascii?Q?nsRA9pnUgf3hHZ1tJJ44z/ywMiqWje2P6bFoEX16XVfhxcC9CeKALbixlATz?= =?us-ascii?Q?swQo/ZqSNNHsqbyfCF/lcmYA8GSnIgrOW+bydT6mYS9Q5oP86cse0FdwRyZo?= =?us-ascii?Q?+ETus1emgeN/67T8eH2dbCT1Sl6+2fuzlJGX2o+c0MOnZ0bMYbwyJquuj9GO?= =?us-ascii?Q?Jt/tQR3m9qmhauoXe/zvxNFGukZwrKgMg+U3qOPInRYqdbIpMXP1d/E2EArd?= =?us-ascii?Q?B6On65i6+rcIB/3GbPZuUhdriKz+SQeFq7nEh9qx3ssD22UIx6aQkpmudSOZ?= =?us-ascii?Q?7sucAPYJ9VsaxHy1/BOZJRJdvSKSjIU2wiE0k6y3P3ZCXi76XgTUohMs2o5n?= =?us-ascii?Q?bjYk+/KKb/yU2SMRfo9n0NglRgulMEP0WWUKSK2A7y7Whh1NSDJBaZXeHpu/?= =?us-ascii?Q?TW5MPEdAOTTTius0mxn7shYMYpIZ1q13LyH0OVaDUbtOmDfMDhINz2mknefd?= =?us-ascii?Q?8PoYLG5mbuEMygbs4sTU6C7qeUkW3tLVd02j/n0lAB53bqaobGwagsRV/YNP?= =?us-ascii?Q?R1xOliVWW71ChS53U9ia7ja02Tak1Pmnt2GOKSw/kYvIjBhTgSXq1Kp15641?= =?us-ascii?Q?zot+5G4dZzjMsaVB7YxVSkyRhr9ic+Jlx3B+YgwXLSemnYR6CKJvlZvDxiUH?= =?us-ascii?Q?tCXtSl87LrPCKg4EK+zXZgFEolUs84ZQbxINVnnUBrhijM6c5XL52eZRrW/t?= =?us-ascii?Q?0yk3Yhr7Dd2B7ysbNvXWZ5Fam2M5m9ofbTBsNlWVLchoSiAanOYL/gzlZ53H?= =?us-ascii?Q?9lYlHeIeShoGSTNL+2Ncb7PPlwdqMWSa0tfAvv1+4Jl4EV0hEtUy0qLC16mz?= =?us-ascii?Q?/+0fBXcw9sZi5kUXShxIrmBVhx5eDTDsI3Qj41abNlsQuuRiM/1NPs856jxw?= =?us-ascii?Q?dyIoOna1AK4NLJseTTwt9z//wDuPB44nqRM6ezotvnCDwBaG17hhT9UBtQYR?= =?us-ascii?Q?JZh3jdLCMPKQugBcAt8nFP3zrLNl7lSU/2nHTd5LF3nDVtnHBghPrIYvDVyp?= =?us-ascii?Q?LqezjI13ekFFuVjIe0mXvnqGQZKb39E9Nep4Boko+bgXZLQcAPRUARrPh8OI?= =?us-ascii?Q?Xjyon/vMsOpcLM0OzD4IC0E18D8oxzJjjqt84isiY8LOwYwB1CI3PIFRNrwN?= =?us-ascii?Q?A7R7mi7fCmjSjI8pEtS22bp1eMHv3V4JQFjntxOzvGc6UEOZvgkkaq0nkC/G?= =?us-ascii?Q?DNCNZsDB4Yd53d416ZSe8UhY/zCIY+nYcYIg/Kns3GalZrU0BsZS70XHFUAP?= =?us-ascii?Q?1O0=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?g6JlGrSXu7bqCeuxeuk6eqsUhvlSBt2HWgJ7GrsTsoLPFaXBl128+3EiPrw0?= =?us-ascii?Q?iyVQLb2+bFJnGjw4FSv5nBRziTW7dxcogYm2teVsngVQuugFNJ7XgTgw7ibz?= =?us-ascii?Q?yR4WK2ZTIGEYbTQwFI8wF/S1qOPwXqil0Ibs7xzT6W0tNGAT/k2KyZcFxRir?= =?us-ascii?Q?bHoEfj9GYG38tm5xCFKYvrNTnRYEQUlKiIa6vjl8xCmCMTgVDuVeQXuQCg4W?= =?us-ascii?Q?e5HWjRO2BKajQERirTVW+YSgUIZwGCi2gX7DPh9LqPM1eIqcEQrpU7zACT4m?= =?us-ascii?Q?mtnOJ8yixCNDoJyQDlXRck/b+3+bnJuDUKeB06sDCHnNz7PtB2SRqEn8Ki61?= =?us-ascii?Q?XbNlDo5OaCxK3A2JW96g1ZzyvvBpaZpwPS0ogcC2mDA2wp2rf7ByXPMVupgJ?= =?us-ascii?Q?BUwm2GB7agHHIPRdJa1JvP4w69fWwCdTQGW2YfYUTtvnp7opEF/8/xYlxZoj?= =?us-ascii?Q?ghkJt0vql9wqWgUsMLQg6TSLfOpPXxG2EKpxu3iEYlIbVQ1OeC5l4nkrNA24?= =?us-ascii?Q?18FRWgzuf6QqrdzZ2Hp6k8R9t3cf4vH0A8uqFiKHIzNGZ93MF1gu0uEfFvOC?= =?us-ascii?Q?3KhFieWgPodSaUFBhS/5RaZH20M3dh4vDRGcmmpI9uDb/yVSGX5tuV8TcN+y?= =?us-ascii?Q?LqvtoWDqjLqwtNPnEl1W0meDeAMEnb6WtkCOiYWAPXwQOEDkbgUGBhNpsl4h?= =?us-ascii?Q?IQpZZeZ8E98hZEuhpSAacrp6eLmLQwbLxwH1aBTMBiPKPZZuIhxvV/S9m2FI?= =?us-ascii?Q?EIIJw0kKrhfaWhatNFHW+AS9Q1e/UT0N7qHOJQbAGQGP4kB6eJx/Ob0Hr9pJ?= =?us-ascii?Q?1ajciKAHuN+fPtIFehKFbkaogbf+HpHlABa+GyM31WziO5MHU+Z5+l+C37od?= =?us-ascii?Q?Kjw92vKpMtjNEkg7zvFtqdO8wL/OqGF4n3lH3zYnKX0wUSk3UPy7XKlp5Aox?= =?us-ascii?Q?/DjkOyVwHIC1u4fuDgAILfS3KI+YPv9ay8zwIGis59UrERTdYiRWHiM2Q5y6?= =?us-ascii?Q?kGOCvO1LR5YYLF/KRFNsycYWr464/IXraPLbT3zwctRs/L93dSrD87/6FHKQ?= =?us-ascii?Q?SwbJthwbIXNhGI+GXU0ors8zc4sbKstF8FPD9r7X+l6v9l0HIcJD3elWSEIm?= =?us-ascii?Q?rCsALpl2pOXCujM8vaEfO/ombdIJ2zs1vWKPPYZji+HEBpnPiTf/BRHrmZmp?= =?us-ascii?Q?qT6XNbeHfIePEr2r1DF98siiSUHeEmuK2KMHiWDntR3RVUQUD0DpX1yaUfXl?= =?us-ascii?Q?996cDnOylkVtDvaItRGgusN5mP4caeIf1m+MzD0B5Wa5IsFkULdjd10uaYDb?= =?us-ascii?Q?GJ+t+nFCzHuswNO1z5bctpNkRSDaXS8ZmmAzm/s4yr0FdjIaXxRWfjYYHd5X?= =?us-ascii?Q?MwYiy/LsMeWPXg7Q+AosIAHOo/e3zZQ3TDNoZcVH8oa5TAj/27+7+AaXPknr?= =?us-ascii?Q?AqMCbuGaORgnQiQ0+4ikhMGk9eu2hRODj52XhMZ5qPIWn1H0LeKlXbnEGHM7?= =?us-ascii?Q?8YU1ePBkJaWxuXofzj0Htobs47oL158mFIyVrt3kYQ2uy272mv+UHaHhYrnL?= =?us-ascii?Q?mzYMOFBMLCVtKkvuDrk=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dac28036-1fd8-4e06-519e-08dc7ee05d9c X-MS-Exchange-CrossTenant-originalarrivaltime: 28 May 2024 06:35:28.7678 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Bh+wb2WrzTTDOnwCL8vIh+zMCSv8AoEQ6fcXwRKdqN5grov1m9/OZc3tjllrB+ozRyoYdmtkqputa6LkHoNqQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7423 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 27 May 2024 23:35:50 -0700 Resent-From: dun.tan@intel.com Reply-To: devel@edk2.groups.io,dun.tan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: pIPrd9OHHnqyxsyjH3aBCZvrx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=H1GxhDj+; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) Hi Liming, Could you please help to review this patch? This patch set is to simplify the X86 CPU SMM driver by removing most of S3= related logics and we want to merge it as soon as possible. Thanks, Dun -----Original Message----- From: devel@edk2.groups.io On Behalf Of duntan Sent: Friday, May 17, 2024 5:46 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Wang, Jian J ; Limin= g Gao Subject: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi fi= eld in SMM_S3_RESUME_STATE This MpService2Ppi field in SMM_S3_RESUME_STATE is used to wakeup AP to do = the CPU initialization during smm s3 boot when the execution mode of PEI an= d DXE are the same. Currently, in CpuS3.c of smm cpu driver, BSP doesn't need to wakeup AP anym= ore. The initialization for AP will be done in S3Resume.c before transfer t= o CpuS3.c of smm cpu driver. So we can remove the MpService2Ppi field in SMM_S3_RESUME_STATE. Signed-off-by: Dun Tan Reviewed-by: Ray Ni Cc: Jian J Wang Cc: Liming Gao --- MdeModulePkg/Include/Guid/AcpiS3Context.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MdeModulePkg/Include/Guid/AcpiS3Context.h b/MdeModulePkg/Inclu= de/Guid/AcpiS3Context.h index 72d173c4fd..6c7237727e 100644 --- a/MdeModulePkg/Include/Guid/AcpiS3Context.h +++ b/MdeModulePkg/Include/Guid/AcpiS3Context.h @@ -1,7 +1,7 @@ /** @file Definitions for data structures used in S3 resume. =20 -Copyright (c) 2011 - 2023, Intel Corporation. All rights reserved.
+Copyright (c) 2011 - 2024, Intel Corporation. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -30,7 +30,6 @@ typedef struct { EFI_PHYSICAL_ADDRESS ReturnContext1; EFI_PHYSICAL_ADDRESS ReturnContext2; EFI_PHYSICAL_ADDRESS ReturnStackPointer; - EFI_PHYSICAL_ADDRESS MpService2Ppi; EFI_PHYSICAL_ADDRESS Smst; } SMM_S3_RESUME_STATE; =20 -- 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119292): https://edk2.groups.io/g/devel/message/119292 Mute This Topic: https://groups.io/mt/106344380/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-