From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Oram, Isaac W" <isaac.w.oram@intel.com>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Luo, Heng" <heng.luo@intel.com>,
"Jeremy Soller" <jeremy@system76.com>,
Benjamin Doron <benjamin.doron00@gmail.com>,
"Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>,
"Kethi Reddy, Deepika" <deepika.kethi.reddy@intel.com>,
"Esakkithevar, Kathappan" <kathappan.esakkithevar@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
"Dong, Eric" <eric.dong@intel.com>
Subject: Re: [edk2-platforms: PATCH v5 0/9] MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.
Date: Fri, 15 Oct 2021 02:51:38 +0000 [thread overview]
Message-ID: <BN9PR11MB5483BF8BAE791A943FF12EAEE6B99@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211014091622.2168-1-chasel.chiu@intel.com>
Patch series pushed:
https://github.com/tianocore/edk2-platforms/commit/6b4a1eb461a87811627ee3bfdd847b1117aa155b
https://github.com/tianocore/edk2-platforms/commit/59dc66e86afad34293a124b5facecd193ada26c8
https://github.com/tianocore/edk2-platforms/commit/df697c2230f8a0ff6a82bf12164e285c54e27a43
https://github.com/tianocore/edk2-platforms/commit/71af84858edad6a69291e4d6a825b4dbdcb4528b
https://github.com/tianocore/edk2-platforms/commit/547fe50eff072fe05f4043924c24696ce2a58f40
https://github.com/tianocore/edk2-platforms/commit/6f543cdde0031571b6a1d64a9e899b5c19a5a52f
https://github.com/tianocore/edk2-platforms/commit/33d556c6c6387e92e24daff0e9b8f5c8029b997d
https://github.com/tianocore/edk2-platforms/commit/e8a64852af49b91473d3e3cdecabf83f2184d8c2
https://github.com/tianocore/edk2-platforms/commit/c24188b81fa9d286dbb4070cca774066f39d4bb7
Thanks,
Chasel
> -----Original Message-----
> From: Chiu, Chasel <chasel.chiu@intel.com>
> Sent: Thursday, October 14, 2021 5:16 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Oram, Isaac W
> <isaac.w.oram@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Luo, Heng <heng.luo@intel.com>; Jeremy
> Soller <jeremy@system76.com>; Benjamin Doron
> <benjamin.doron00@gmail.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Kethi Reddy, Deepika
> <deepika.kethi.reddy@intel.com>; Esakkithevar, Kathappan
> <kathappan.esakkithevar@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: [edk2-platforms: PATCH v5 0/9] MinPlatformPkg: Support FSP 2.3
> FSP_NON_VOLATILE_STORAGE_HOB2.
>
> V5:
> Fix GCC build failure in LargeVariableWriteLib.c
>
> V4:
> . Switched to LargeVariableRead(Write)Lib in SaveMemoryConfig driver
> . Fixed tailing white space issue in PeiLib.c/.h
> . Updated function descriptions for PeiGetVariable() and PeiGetLargeVariable()
> . Added VariableReadLib to CorePeiLib.dsc for all platforms
> . Fixed white space issue in GalagoPro3/.../PeiFspMiscUpdUpdateLib.c
>
> V3:
> Fix another GCC build failure.
>
> V2:
> Fix GCC build failures.
>
> V1:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678
>
> Implementation should search FSP_NON_VOLATILE_STORAGE_HOB2 firstly and
> only search FSP_NON_VOLATILE_STORAGE_HOB when former one is not found.
>
> Also added PeiGetLargeVariable () to support the scenarios where the variable
> data size is bigger than a single variable size limit.
>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Heng Luo <heng.luo@intel.com>
> Cc: Jeremy Soller <jeremy@system76.com>
> Cc: Benjamin Doron <benjamin.doron00@gmail.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
>
> Chasel Chiu (9):
> MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.
> CometlakeOpenBoardPkg: Use same variable name for FspNvsHob.
> KabylakeOpenBoardPkg/AspireVn7Dash572G:Use same variable name for
> FspNvsHob
> KabylakeOpenBoardPkg/GalagoPro3: Use same variable name for FspNvsHob.
> KabylakeOpenBoardPkg/KabylakeRvp3: Use same variable name for
> FspNvsHob.
> TigerlakeOpenBoardPkg: Use same variable name for FspNvsHob.
> WhiskeylakeOpenBoardPkg: Use same variable name for FspNvsHob.
> WhitleyOpenBoardPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.
> WhitleySiliconPkg: Use same variable name for FspNvsHob.
>
>
> Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicyU
> pdateLibFsp/PeiFspMiscUpdUpdateLib.c | 63 ++++++++++++++----
> ---------------------------------------------
>
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Librar
> y/PeiSiliconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c | 24
> ++++++++++--------------
>
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/PeiSi
> liconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.c | 23 +++++++++---------
> -----
>
> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/FspWrapper/Library/PeiSilic
> onPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c | 25 +++++++++++---
> -----------
>
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/PeiSi
> liconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c | 25 ++++++++++---
> ------------
>
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/PeiSiliconP
> olicyUpdateLib/PeiSiliconPolicyUpdateLib.c | 23 +++++++++-------------
> -
>
> Platform/Intel/MinPlatformPkg/FspWrapper/SaveMemoryConfig/SaveMemoryC
> onfig.c | 109
> ++++++++++++++++++++++++++++++++++++++++++++++++--------------------------
> -----------------------------------
>
> Platform/Intel/MinPlatformPkg/Library/BaseLargeVariableLib/LargeVariableWri
> teLib.c | 2 +-
> Platform/Intel/MinPlatformPkg/Library/PeiLib/PeiLib.c
> | 89
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++----------
>
> Platform/Intel/MinPlatformPkg/Library/PeiVariableReadLib/PeiVariableReadLib.
> c | 4 ++--
>
> Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyInitLib/
> PeiFspPolicyInitLib.c | 21 ++++++++++++++++++---
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicy
> UpdateLibFsp/PeiFspMiscUpdUpdateLib.c | 63 ++++++++++++-------
> --------------------------------------------
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library/PeiSi
> liconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c | 63
> ++++++++++++---------------------------------------------------
>
> Platform/Intel/WhitleyOpenBoardPkg/Platform/Dxe/S3NvramSave/S3NvramSav
> e.c | 29 +++++++++++++++++++++++------
>
> Silicon/Intel/WhitleySiliconPkg/Library/FspWrapperPlatformLib/FspWrapperPlat
> formLib.c | 35 +++++++++--------------------------
>
> Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicyU
> pdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf | 5 ++---
>
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Librar
> y/PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf | 7 ++++---
>
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/PeiSi
> liconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf | 2 +-
>
> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/FspWrapper/Library/PeiSilic
> onPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf | 5 ++---
>
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/PeiSi
> liconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf | 5 ++---
>
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/PeiSiliconP
> olicyUpdateLib/PeiSiliconPolicyUpdateLib.inf | 2 +-
>
> Platform/Intel/MinPlatformPkg/FspWrapper/SaveMemoryConfig/SaveMemoryC
> onfig.inf | 8 ++++++--
> Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
> | 1 +
> Platform/Intel/MinPlatformPkg/Include/Library/PeiLib.h
> | 40 +++++++++++++++++++++++++++++++++++-----
> Platform/Intel/MinPlatformPkg/Library/PeiLib/PeiLib.inf
> | 4 +++-
> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> | 1 +
>
> Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyInitLib/
> PeiFspPolicyInitLib.inf | 1 +
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicy
> UpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf | 5 ++---
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library/PeiSi
> liconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf | 4 ++--
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Fdf/FlashMapIncl
> ude.fdf | 18 +++++++++---------
>
> Platform/Intel/WhitleyOpenBoardPkg/Platform/Dxe/S3NvramSave/S3NvramSav
> e.inf | 4 +++-
> Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc
> | 1 +
>
> Silicon/Intel/WhitleySiliconPkg/Library/FspWrapperPlatformLib/FspWrapperPlat
> formLib.inf | 3 ++-
> 33 files changed, 345 insertions(+), 369 deletions(-)
>
> --
> 2.28.0.windows.1
prev parent reply other threads:[~2021-10-15 2:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 9:16 [edk2-platforms: PATCH v5 0/9] MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2 Chiu, Chasel
2021-10-14 9:16 ` [edk2-platforms: PATCH v5 1/9] " Chiu, Chasel
2021-10-14 9:16 ` [edk2-platforms: PATCH v5 2/9] CometlakeOpenBoardPkg: Use same variable name for FspNvsHob Chiu, Chasel
2021-10-14 9:16 ` [edk2-platforms: PATCH v5 3/9] KabylakeOpenBoardPkg/AspireVn7Dash572G:Use " Chiu, Chasel
2021-10-14 9:16 ` [edk2-platforms: PATCH v5 4/9] KabylakeOpenBoardPkg/GalagoPro3: Use " Chiu, Chasel
2021-10-14 9:16 ` [edk2-platforms: PATCH v5 5/9] KabylakeOpenBoardPkg/KabylakeRvp3: " Chiu, Chasel
2021-10-14 9:16 ` [edk2-platforms: PATCH v5 6/9] TigerlakeOpenBoardPkg: " Chiu, Chasel
2021-10-14 9:16 ` [edk2-platforms: PATCH v5 7/9] WhiskeylakeOpenBoardPkg: " Chiu, Chasel
2021-10-14 9:16 ` [edk2-platforms: PATCH v5 8/9] WhitleyOpenBoardPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2 Chiu, Chasel
2021-10-14 9:16 ` [edk2-platforms: PATCH v5 9/9] WhitleySiliconPkg: Use same variable name for FspNvsHob Chiu, Chasel
2021-10-14 14:21 ` [edk2-platforms: PATCH v5 0/9] MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2 Oram, Isaac W
2021-10-15 0:45 ` Nate DeSimone
2021-10-15 2:51 ` Chiu, Chasel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB5483BF8BAE791A943FF12EAEE6B99@BN9PR11MB5483.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox