From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Ni, Ray" <ray.ni@intel.com>,
"S, Ashraf Ali" <ashraf.ali.s@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Zeng, Star" <star.zeng@intel.com>,
"Kuo, Ted" <ted.kuo@intel.com>,
"Duggapu, Chinni B" <chinni.b.duggapu@intel.com>,
"Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>,
"Solanki, Digant H" <digant.h.solanki@intel.com>,
"V, Sangeetha" <sangeetha.v@intel.com>
Subject: Re: [PATCH v8] IntelFsp2WrapperPkg : FSPM/S UPD data address based on Build Type
Date: Tue, 21 Dec 2021 00:41:09 +0000 [thread overview]
Message-ID: <BN9PR11MB5483C00CF2C658A865A026F3E67C9@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MWHPR11MB16310441B88171048AFE6B668C7B9@MWHPR11MB1631.namprd11.prod.outlook.com>
Thanks Ray! I have sent a code review for removing EFIAPI, please help to review.
Thanks,
Chasel
> -----Original Message-----
> From: Ni, Ray <ray.ni@intel.com>
> Sent: Monday, December 20, 2021 1:15 PM
> To: S, Ashraf Ali <ashraf.ali.s@intel.com>; devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>; Kuo, Ted
> <ted.kuo@intel.com>; Duggapu, Chinni B <chinni.b.duggapu@intel.com>;
> Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Solanki, Digant H
> <digant.h.solanki@intel.com>; V, Sangeetha <sangeetha.v@intel.com>
> Subject: RE: [PATCH v8] IntelFsp2WrapperPkg : FSPM/S UPD data address based
> on Build Type
>
>
> +UINTN
> +EFIAPI
> +GetFspmUpdDataAddress (
> + VOID
> + )
>
> This is internal function. Please remove "EFIAPI".
prev parent reply other threads:[~2021-12-21 0:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 8:10 [PATCH v8] IntelFsp2WrapperPkg : FSPM/S UPD data address based on Build Type Ashraf Ali S
2021-12-16 10:46 ` ted.kuo
2021-12-17 1:53 ` Chiu, Chasel
2021-12-17 3:47 ` Chiu, Chasel
2021-12-17 4:02 ` Zeng, Star
2021-12-20 3:45 ` Chiu, Chasel
2021-12-20 5:15 ` Ni, Ray
2021-12-21 0:41 ` Chiu, Chasel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB5483C00CF2C658A865A026F3E67C9@BN9PR11MB5483.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox