From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.247.1640047272605770766 for ; Mon, 20 Dec 2021 16:41:12 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=RfJUrFo5; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640047272; x=1671583272; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=YQGgba8issIK9USQHFGqQGIClF1/HksbGaVezrBvxuM=; b=RfJUrFo5okQ3pGMGz4iDmzkk1wPF323Lbf+Pu+bkyzu/JgAHH5kNTGHT zVQZai5HxLUqgXCsFraxLMfME4cuIH9maa67f6alvL1nr0m0SY8OlY8RT eFZjkhgkzgvtXPLiU3T9DuH2Qbr/WnoJITLT1Z3bzLRQvcssXzVgntiVL XIMBThRK/naWWBX+iKfZmr7f32PZNpcx2qt2/MNm4la/nhIgJPjzv4BVj Gjb8eQpFquCEc5+c1CwsXzg2sQtrzQPnzS0dEQF/+2ccjVN9QShabOkku WkUukm/Ltz6Mhusk72eRRK+GSiYi1lVZp4Bx6rJ98xfa+9xMy1EWCbP0P w==; X-IronPort-AV: E=McAfee;i="6200,9189,10204"; a="326594341" X-IronPort-AV: E=Sophos;i="5.88,221,1635231600"; d="scan'208";a="326594341" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2021 16:41:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,221,1635231600"; d="scan'208";a="521030630" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP; 20 Dec 2021 16:41:11 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 20 Dec 2021 16:41:10 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 20 Dec 2021 16:41:10 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 20 Dec 2021 16:41:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=irEv/EY6O0laL42U+qQtzKnFwlmlBenzIqo88tBGKfyeSqDUOOYqtCY9NOIijoKIg5w9Mz4h5DApJQwJyiPY2GX9Ypa8XzSM1fXKOVwweBepz51SG4VUhkCZBBhGyfnByqI4/0wNfbmEDttaviEG0n08Xr07nMiEgLAE2xuEiyl7YaHiMIekjeX4DMajoW8xPR0yscbg/H8xsdGKeh8ZcgUaSoDckJUEwhbFvXQREz41xWXq1SxhQanz1UHwU+thTkQYr0u8VLREP+NBMAc/ULSbtPflS/8Jscoc/zTwiz56Th6wXiNjpDdZhBCXJidAosycsX8qFRFczFU+9LbDKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YKFVyDD5t/DH/zpQRGVox37fXICXMvt4A9094TQmezo=; b=L+yAwZvv46CFE0djA9591U+NfgxZFsgvr6v5om0LX2MLBWC/wktQxOHfy0u51XYNpS63lON8P5WJHSupCeVCY+lUHdXSgvu0szfRA7hwXKVBnWf2iWjiZ2JEU8UH4JiMHpjYt/8wHxjpwKPqaxMuuoF5uznCItz+OB44SebVI2FnQWDQ3cOjJ60FsCmWIlBuuwN4+OoYoYUybwJuxVTLjf/W/UzrYrod1hGQLTFXH8jPrupFVr6pPMFmRjn9UYx9kZYAIXV0672QwCpRjQLRFGgs95jf0/bG/+NZqU6xAOYcJgFWIrEJwVeZFrRovT48A7efw7k5Ypy5M6A/f6ieOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN8PR11MB3716.namprd11.prod.outlook.com (2603:10b6:408:8a::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Tue, 21 Dec 2021 00:41:09 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::408a:d875:74aa:9dc0]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::408a:d875:74aa:9dc0%4]) with mapi id 15.20.4801.020; Tue, 21 Dec 2021 00:41:09 +0000 From: "Chiu, Chasel" To: "Ni, Ray" , "S, Ashraf Ali" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Zeng, Star" , "Kuo, Ted" , "Duggapu, Chinni B" , "Chaganty, Rangasai V" , "Solanki, Digant H" , "V, Sangeetha" Subject: Re: [PATCH v8] IntelFsp2WrapperPkg : FSPM/S UPD data address based on Build Type Thread-Topic: [PATCH v8] IntelFsp2WrapperPkg : FSPM/S UPD data address based on Build Type Thread-Index: AQHX8lRzM2XzMUEop02HiCM2dO8rnaw63HAAgAFFnIA= Date: Tue, 21 Dec 2021 00:41:09 +0000 Message-ID: References: <7886ad065bf2cb1b513300da04db32a698d4b590.1639642126.git.ashraf.ali.s@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d0ce8989-9173-40cc-2559-08d9c41a94fd x-ms-traffictypediagnostic: BN8PR11MB3716:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vpiuGfJsm0BuV5YBBhLjnSZBeB3TJvqvnk/NlHFItkNEFDiFyj4FYQZJHRfKVIfgGfom+2CKJVG7BIGuDmv93fyEsIjLQOitJNo646UjFwLVnzapwciHq9E3CEjK1j4hIKuAFxPmMK819HgE4Pf/bd19eGlEmvRxO+AMS+OumJWfm+8iRotkpCiEZimhJksv4C4DglD7fJRKXrRbAWCa7nBr+qHOmh5FeO3L9IRJlnLdxxS2APDDlHLSWR8oZRjWdQzqmUXFU9pMuIGwqnka0879YOKq4m/1hpzVz3QRIh3loYnqWEzfAD6/bMdJ9PKFUazsjSHeAVvPGIwmHw3+j8Oe29fQ7HE3iuVr/Omxi7z/H+ZKijYK0cL2SVDLZmeBk1ZBCuUgEUIQFXNO6V9sfvgIFguJlXOiv4z6avjXko/G2+jAd6uzUXSvzlRHlZesFv0lrcTvHqy+749zNsuzAIP89bHEfJmSgISY+9Y1lGzyn2P6ko5WwAJs9Fg4qLccQbPr1w4RfeF4A481s4Z6Eidjk7SmyzyRM7DFzfWCj4e6T/ga5aKKa2+eApmCT4/nWCsvErmW8IFqQVoTsGMAd3ClOZ5ysAzNlQ457lLpypHJqeDc8p2aSVohXY8BBSHRj452kc+4QQGvkz4+/f+jffjCE8jhuEbjQH0KARH/QmX8BSuvErJdbR2wEpU+QcjfxZuGtez8Q0r3BlPRYbmNMw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(71200400001)(53546011)(26005)(6506007)(52536014)(186003)(7696005)(4744005)(86362001)(33656002)(19627235002)(5660300002)(8936002)(82960400001)(316002)(54906003)(508600001)(4326008)(110136005)(122000001)(2906002)(8676002)(38100700002)(38070700005)(66446008)(66946007)(55016003)(76116006)(83380400001)(66476007)(64756008)(9686003)(107886003)(66556008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gVCg/iqKzdIm1HWWlqUd/AYuutrxLrmQRwFIhAjp4g6/mUYQ9x5FkmY/mIvh?= =?us-ascii?Q?QJQmwIo6cawvGI/ha01jcwgiPDsmlyksKTDDaJo2WHlpJVIpooS08SnxktFW?= =?us-ascii?Q?7PQxCo6hcB74q9sHH0UhZkNWSakmjBjANX6iC4x7GTdaVUVkPNLHYKLLnc3P?= =?us-ascii?Q?x2mUTPogExiSqUcBAViskR8L6bbnIrCnqw6mjClgSFZFIG8gpYVUhB1MrnBk?= =?us-ascii?Q?iF+nXRB3268qDCkz+GvMV593qYl0vbH2oDiK72BWgoZZ2uoYajC6PxC5eGbX?= =?us-ascii?Q?UQuUeCqMjY8niikqV3ERyRMo/T3Meu6hrIxuPj0jMgjHIVNTxwXiJn+g9bQm?= =?us-ascii?Q?FSKmPlFk8Q5NSaSJ3uPsjE4ttuiVI3KQOtyd7QjzRuFDysW+YtEzusOqiddn?= =?us-ascii?Q?LAjup3/07iD2cv/DUzLTugnNBujQmHCpotiCmq7amvKK8o5tTwdWsPyEMQkA?= =?us-ascii?Q?7B+3jobz9oYxVQoUX/dI8esfttIgnQB0NqYo4GochWwhCt+KhXX1vZ+zHQt2?= =?us-ascii?Q?8Q7weghlyQXzonTUgOCEgNjmMC3oSFyGxkUptr3UosGCoxVmztXeLemFMKSk?= =?us-ascii?Q?wdbXfBVu1Q3rh2lIIThaVra1ClkwXqMqVsJ+u8HH3VQtAFMTdKpVxYsi7MU7?= =?us-ascii?Q?GftdM6VfzfSw48S9s8MaXe3kDhtSJfYeN4FRabtqkKmmwaQuvYWrzSHJZH+o?= =?us-ascii?Q?UOo8WNaSiqLoC++0eu1ipqXwyBPI1T1DNeFtd68V+Qfz/3A4L3ojyHvGez7V?= =?us-ascii?Q?cVyGfLx9t1hVfoExJgGv2QD4y/ae2FqXZHDPk7srosHOCmgzw/CY76MDdCzg?= =?us-ascii?Q?O4XzE4L+PWzyTujl/MGfloZg/Nu649sw26IHazj1LIxhE4nIZ5P//vJPYfY2?= =?us-ascii?Q?GygYi5Bax3j157DoHOVPVsmxclG812wvIO+AB2lmGei1fPyXJ07U9c6UeCk6?= =?us-ascii?Q?z19XpTM0ivWI8c43yBrqmTSeZ9aPOmTIDQCCaUtztz9kXc71/4NnVgb45WLb?= =?us-ascii?Q?/HrtDOJzUg9l8HiKgkbgVflU0UT4FFGxd6orvGwoAVc5PiTryrV2k7ml+XSP?= =?us-ascii?Q?jQK9YgpvUX1skEa2M9X10HZFEkR1mfOYrqrE3cNEqoKhT3SBNbiIerkzpHr/?= =?us-ascii?Q?bi0BRGcDY70AMArN6kxaTHrNbacIkj7DSSG9JluaedPbCqmnRSulmCcwP1Us?= =?us-ascii?Q?7Awywf/BYyV2Bsu6A+s4Jr/wHpNYpkF8yaWHmaHC8PgyzCom9ysmk7Ulwbua?= =?us-ascii?Q?pGztTwDZ+XLPB/eLzjV1Xn+qBt9yTTvBU5YUPi6Q+VXRYRphlZQRGLGDVMBA?= =?us-ascii?Q?4WoER6oU0Rc7/FUgHubWmM/qkQxAqnNHbcw9bxRTHxUMHtTdQd2aea6XaQdE?= =?us-ascii?Q?DC3IUQlVNBUL4uC5I17woT5QvSLgEdBbO7ZVdm2UVz+9l4iIXocIZk2+aajy?= =?us-ascii?Q?34hfE61NY8LJYT2FQY0LWpkgdv+YZm6jMF5N69OG4fKalcHeyQUAqEKGzO3f?= =?us-ascii?Q?fr3B5zPHBv9ue02q8FqhlyUABQNc6XcIhofTPeIy2aGMDb6+2uJnfCPPvJZt?= =?us-ascii?Q?l2OIgXPcF300vCIET4YDPHSLNa84+c8UzK1kk1JuwEsjQoaCLOJ+TQzMNuUE?= =?us-ascii?Q?AxBLQHAWxKB7Naap5Z+jqvg=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0ce8989-9173-40cc-2559-08d9c41a94fd X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2021 00:41:09.5729 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XbYyaZeLjhDVM7ljUzulYuLymLsOTpoQn5+96knYzq2BNvxpE6nHWbw+3G90lflQYXzUtQR8ZJwvzLxZbzXCUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3716 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Ray! I have sent a code review for removing EFIAPI, please help to r= eview. Thanks, Chasel > -----Original Message----- > From: Ni, Ray > Sent: Monday, December 20, 2021 1:15 PM > To: S, Ashraf Ali ; devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; Kuo, = Ted > ; Duggapu, Chinni B ; > Chaganty, Rangasai V ; Solanki, Digant H > ; V, Sangeetha > Subject: RE: [PATCH v8] IntelFsp2WrapperPkg : FSPM/S UPD data address bas= ed > on Build Type >=20 >=20 > +UINTN > +EFIAPI > +GetFspmUpdDataAddress ( > + VOID > + ) >=20 > This is internal function. Please remove "EFIAPI".