From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5F4EE74003B for ; Thu, 7 Dec 2023 00:21:59 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=or6mRojAa5A0JspDH1YPDklH5SI1FMZeT6PisAoCmHE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701908518; v=1; b=hehNqCftdN6JcgteWIzLUMTKArne/o44Y24p3omwmWHWJuY8jR0AsMqBOJbJg/r+u3A/Io0G CEoC4m8xQKNbGF/rlRzQblY90LNeU6gr/CVFVEQ7q4sxbaOZ2gvd1wx9oPZ6HSuWK9aAZTB7QFT v01ToEEbOx4ChB4SIRnXImAk= X-Received: by 127.0.0.2 with SMTP id rcomYY7687511xEGuN11O0Uv; Wed, 06 Dec 2023 16:21:58 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.66795.1701908511975802335 for ; Wed, 06 Dec 2023 16:21:52 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="379168727" X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="379168727" X-Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2023 16:21:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="12904336" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Dec 2023 16:21:51 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 6 Dec 2023 16:21:50 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 6 Dec 2023 16:21:50 -0800 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 6 Dec 2023 16:21:50 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 6 Dec 2023 16:21:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ctdiaJO/eS5+UaQQGhbuF3oVU+bQp9COTTZaFy3v1MmdpMdamoLxyn2LMqUqTbi2Esjv4jJFxARbBgQgjiOH5vSla+w+0gdTipJsXJurkPU+ag46QtxUWDeRKlMUBVCI7VU2bZ1HnxaDxCvsacnjQnUR++B3Clj3NHnvDK1VAf7XZIxSoESjSE2zzLZdrzg8qMeM8lDXmqWH9tmzMaRJKYNRm3KaUajFZuksf2XdBUA+Euc8vOLnJ4U7yzKEdpKTtaXqkFkF9WM3h1I/Eqwa3mOIcgawvop6vtNNKIXhQ9PNErWIiTnhDdh+127G12m1acdf6TJWe9F3xMjeQFnfDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pFGE+bxA7OtC2bEUuUnTnUs+BCkPBV9qq0RwwRVDGlU=; b=Z16qMS3X3xH+joaQUVEJ6mNSK72cHSwlbgULg8pzyaXZGwoV532HF4/EVfAXEQI6XEYiQsH4wwVT0BqE+iMg6U4LsOmo3Css2ASKhj1hOJamZgPGcEJ6gchmiYft3QGF5HssnaXtqU0TX8yz0BcMjh41YBxtEw4vXxeHHfNPEoW7X4qjOjoEhhsMqiPlaG3MUF+zRXlBYJqwTgxhLWPCqRO+NLRFNIMHhQ9TYRABAeA3nd9Z4oPH3EXEcH7TO1msu0AmTA8t0IcGHXRIMM93Vm85jkFXWp3qx2x/hrTG8CXDpPiSrpsdg2xZ9l1fUkpVmfZeno+dLTLQECS0GFjjCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by PH8PR11MB7965.namprd11.prod.outlook.com (2603:10b6:510:25c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34; Thu, 7 Dec 2023 00:21:48 +0000 X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::6da1:a4b7:4771:14e1]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::6da1:a4b7:4771:14e1%5]) with mapi id 15.20.7068.025; Thu, 7 Dec 2023 00:21:48 +0000 From: "duntan" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH 2/6] UefiCpuPkg: Build MpInfo2HOB in CpuMpPei Thread-Topic: [PATCH 2/6] UefiCpuPkg: Build MpInfo2HOB in CpuMpPei Thread-Index: AQHaJz7RNc+0rX0Tk0aZw04YP0tuzLCb+bQAgAD+UxA= Date: Thu, 7 Dec 2023 00:21:48 +0000 Message-ID: References: <20231205054900.926-1-dun.tan@intel.com> <20231205054900.926-3-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|PH8PR11MB7965:EE_ x-ms-office365-filtering-correlation-id: 847c7f8f-5940-48b4-d552-08dbf6ba809b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: m1qoh87sQUoitPsjHaEsottBz0kJ9bXniGYsxRivfEOYd7IDEF2owE/c0cyEfnw5UXYU8S4YWoj0IdP7rUCusDKFTA4aG4EgEMEEvYC2KjNNfpRYXZ2Ua79Xx91kbesnsquDAZZxJ6SoSZQTBLMAkKRHncIFLs1uPJTzrg0F97YqlFavetzhT875OS+TRUd1OTUseXoj6825sb2vRZHqTvWLGE4I2npEx9dpJX9Z3fzRIBZ5MyNNGq7jKY5JvJkNhZHyU9sm7YiU3h1TVjrZ0RRpEvfA3QZmekFBhejIdx2rIhG630czslw21XJRWK2c57pj/zeYG0Hgk5kE3O2w+0dLnqj/stBYTVExBgpK6GN5/0WfpSv16kinpWIQIMEuD2DWDQyLoBvBczHMUTKl1cdGQg3Z8V9AOqhROoy+0TWyKa8uqsWKhRhPaDy9pgW6x+8OyWqcamzgW+dqsM5a427jmiSRwwc5IDpl7kX4jwyDb44rKT9bNh3b0l9p1rwdohZ3w2eQk6vuz+twSDwiTU2YypHutiVtX27fimlUL/+KS53In612QGO/n6Q7xtYWu+LTsoL01EdDqfocjUj7FJ8LIRGZxd4JgntrtgHNPEcmJg6BEXuHM1wRkHZnY9gS x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xIe2P1Mptnsvr6MRtNix01O5hQfNWWhmAUwCyaQ2PjqGJ6mmqrKK+bMvohe0?= =?us-ascii?Q?3m6i4Rea2yFugDRDOYRz0FyauEXiSHVT4PIOBg0yunpoDNIYNefKaS07ooaH?= =?us-ascii?Q?iyAn+Ono10s+PJ8GAgovt5u3ucvMou1tEjiEoXJwFTNKWrQhEt/aNXCrnf95?= =?us-ascii?Q?x1RZHAceDDBKRlyuGauok7W2xHrTyveQs+o0LphuwNV1sXumrm97HbGCS3ui?= =?us-ascii?Q?/4Bk0VZ8YRKIld8s7qQBYWNYR5A30FH9qpEnk/2GhtKTQED/tZe++ts/YSmu?= =?us-ascii?Q?prBl++cVS5MpVw+2JUAABsUvMo0Pu2W1tX0ttIq7eE9FojTStfEO8/T3xQ1L?= =?us-ascii?Q?ECY3C3676RDbRL4THallcVr9OGoBURt/ucXF2xU0BOS2kE9nfCRBFT/DsRCx?= =?us-ascii?Q?RfDSGqTrB3e/lv0U7LY4zNfF0QcROOMnEHQaU2XmVyiJAPjfvn9nvP7mbibT?= =?us-ascii?Q?L7JZ3B7+Q5rXI0GXMdfgh9mY3HGX4ATVQMkIZAtOCfYpnhryFcxtNrYsN9Rg?= =?us-ascii?Q?eoPfuVjgMHRv0nclJ5Fzj3O65/CjMsE/9qXseOjF2oc8xiKPJEab+4TecJyH?= =?us-ascii?Q?2lmUJogZB0o3TA57d1kr2KxbV5kxw/rJgXG8Xs1Jjc51vSa6/Ei/JElPEoRn?= =?us-ascii?Q?ac5Y2OIxbsftSl2Uym8H16MsJ0oLjdCmpFmBgFDWTjXuUAHo/aFCKs7OSBr0?= =?us-ascii?Q?wayGlsIl8mzTOdfxzC0k12GDwiP+wIu5+VIddnhJo0HFXgwgrVSP/R/CCOB6?= =?us-ascii?Q?0aRdO30sIaDWxcCccSgZUfCck+4B36p8YM9L4QV0XrgKQ0ESlt8d/BYa0z8e?= =?us-ascii?Q?J2DAE2tov7Ykr+5fCOrB8W/uckXvuJmUERrNTMG8KUxgDP3G060YfO5hLdvG?= =?us-ascii?Q?wtxYo6d/qHDdSKUNTy7swbQDOUJUMBMnKjmsUkcoFXg/uW8qdsWQ8lGGRBV6?= =?us-ascii?Q?dJ3LRjLGKBJBVo5CZyZA83wyVS6sS0NcnGuhHwVhHqNJhoxO84/+NDrSHobY?= =?us-ascii?Q?44zNvGc5TDPIJmmiuqAvezDOUwGgyVMghFJNQzHXxA9g7Ly255FMocJ0l4T/?= =?us-ascii?Q?IXyX9W7+ym61LzM1Hx2dcV8Vu/ufvSVDFDr9Xp8O0VtkcoOl4m7x5L0flxfz?= =?us-ascii?Q?X1UkTHOKkm+KyWFM8cl89BWSyZtzPd+Kf3iJJxFOtm3zn1hpzmWXEcJhz0su?= =?us-ascii?Q?S8N4Nq/1f/GQOLrXDdDIVwFdNuSdKMlN+72T6tj4xRlN04sgzEkyL7pfAcY0?= =?us-ascii?Q?bvG9fOv2a3o6iC95CZPQD8MM62LwBC0YC+w+8Rjpe0XAMsJMnjXD7NXDlWRz?= =?us-ascii?Q?zepqyaVmmbEB66KEK3oBRPANzPXuKClACpwquHX7kmh3UtOt8r0WTRFadRRy?= =?us-ascii?Q?iUVZFGt+Ml5/UNVA+F2L0uPLPRm1rcBaRIHfoW6lfAGVOAhNxet9joo8h+cB?= =?us-ascii?Q?wE2S/Q2HFoyA/6UPwVG/qkJlXh6rm6+Mh3jDYoEFSc5QbM9Q6jKg/YS7ZsuJ?= =?us-ascii?Q?X43j/xRCTtf4FsTbEo0osv8rI4bwBICpiF0Hv47Iq5VNgIzRtyoAQvfIyOUv?= =?us-ascii?Q?zmoIzdg3r5UkuO34WIU=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 847c7f8f-5940-48b4-d552-08dbf6ba809b X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2023 00:21:48.4630 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5Hv9aiAEC/wDIEfvA4weBfxc1xX3/+gx4PsqJTrunrku+Wp9tg2Ir/eGMyOmWoSMRZx/XOIjWpz1sgSuWS0KEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7965 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dun.tan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: x7q3OSJCBYaXhDxARs8y9ktex7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=hehNqCft; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Will change the commit based on the comments. Thanks, Dun -----Original Message----- From: Ni, Ray =20 Sent: Wednesday, December 6, 2023 5:24 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Dong, Eric ; Kumar, Rahul R ; Gerd Hoffmann Subject: RE: [PATCH 2/6] UefiCpuPkg: Build MpInfo2HOB in CpuMpPei 4 minor comments: > + DEBUG ((DEBUG_INFO, "BuildMpInformationHob\n")); 1. DEBUG ("Creating MpInformation2 HOB...\n") > + > + for (Index =3D 0; Index < NumberOfProcessorsInHob; Index++) { > + MpInformation2Entry =3D GET_MP_INFORMATION_ENTRY > (MpInformation2HobData, Index); 2. Since EntrySize equals to sizeof (MP_INFORMATION2_ENTRY), is it ok to ju= st use MpInformation2HobData->Entry[Index]? 3. Do you think "Entry[0]" is more proper than "MpInformation[0]"? > + DEBUG (( > + DEBUG_INFO, > + "ProcessorIndex =3D %x, ProcessorId =3D %lx, StatusFlag =3D %x\n= ", > + Index + ProcessorIndex, > + MpInformation2Entry->ProcessorInfo.ProcessorId, > + MpInformation2Entry->ProcessorInfo.StatusFlag > + )); 4. How about the debug messages are as follows: Processor[0000]: ProcessorId =3D 0x00000000, StatusFlag =3D 0= x00000001\n Location =3D Package:0 Core:0 Threa= d:0\n Location2 =3D Package:0 Die:0 Tile:0 Module:0 C= ore:0 Thread:0\n If a number has "0x" prefix, it uses hex format, otherwise= it uses dec format. The debug message should clearly tell what format the = number follows. Extra 2 spaces in Location/Location2 are to tell that these are extra info = for the processor #0. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112144): https://edk2.groups.io/g/devel/message/112144 Mute This Topic: https://groups.io/mt/102987138/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-