From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.1287.1631319832712159089 for ; Fri, 10 Sep 2021 17:23:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=U0j8ZCsF; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: chasel.chiu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10103"; a="208444573" X-IronPort-AV: E=Sophos;i="5.85,284,1624345200"; d="scan'208";a="208444573" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2021 17:23:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,284,1624345200"; d="scan'208";a="695245564" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga006.fm.intel.com with ESMTP; 10 Sep 2021 17:23:50 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 10 Sep 2021 17:23:49 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 10 Sep 2021 17:23:49 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 10 Sep 2021 17:23:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oN+WqIQErGQaJMNAREQ0AlomfJmld+og6200N1+X+bMQGERq6QPHfK+Gda9WwvVWrqbGb3ziBz6+yvRPDtj7mjbMcblBPB2BALM9P6LrFExX+w6fArr7GCyzfmvtfKGiRt7vmOvpkYC3Yvs5q5Evt7a03TuirMIb819OwZ60NnEf8e8g2vJbLXcNYUahCK7qAqZ+AiH7udfbQwXdfEO95Z3qD2CiPoIPqNn6S6K0mFQMYJLLfRuJzhT3QQjvDVQ3bumnVFO/1seFdcqOVUB7Pj2CCZeodUGdYeV9dUpN1QsCbUyOkZgsRWo6tPrN2yrRJUAx6XhVqjbGb1b3B8Gapg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5BpKoqctRR7Kg9OKT/gf0E/JCQpOm+xsCNeNUs3z/9E=; b=ZRny+fOywhqgCT/NbHefxhdlQpMvJe8eGWZ/MfRoo5b0rTLLmYhpVuGnXl65EcReNboqFj8+ZbO0/Mb1LoZ2JgDBN9ePyqmY9pMrYhATDD0OJS4sHyUMda8hCzoYbI6JSlxNQLSO/VpR07KrV4c2BtqVqAw+ui6NcO2AAwWXW01KP5rzLlhY2SPBtSKOfMs4QxBaJUS6H+x4DHIMh8JL2QuLYqZFpp0kvhTxstmFU8wP3uobndDt/8+3rY0Fq/EvJ4EvXZwwdyYIE9pvT5uuWoKiaggJEkogykZfWRK18ZEFDesaFCoUCLy48hadLLLihDJ4uFqXrTl9T1juebA9mQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5BpKoqctRR7Kg9OKT/gf0E/JCQpOm+xsCNeNUs3z/9E=; b=U0j8ZCsFjJ4Cl/pLeBYKsDMmHVP3/C7jOX6TuZYBOYf3qKwssLu7L3iTnS1mgK8AmBE66i5J+KkgyB0RTUiaBc0j1ceHcTjITJ3uYEk/Qb8m3sJ8AaRYtDTod1zKN6xcFA69HdpiPm7Wz12++uz9hGOTxsWAmqSAiQMpJX7iWqE= Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN6PR11MB1569.namprd11.prod.outlook.com (2603:10b6:405:11::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Sat, 11 Sep 2021 00:23:48 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::882:4e40:b0e4:239e]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::882:4e40:b0e4:239e%6]) with mapi id 15.20.4500.017; Sat, 11 Sep 2021 00:23:48 +0000 From: "Chiu, Chasel" To: Benjamin Doron , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" Subject: Re: [edk2-platforms][PATCH v4 1/2] KabylakeOpenBoardPkg/AspireVn7Dash572G/BoardEcLib: Check for NULL Thread-Topic: [edk2-platforms][PATCH v4 1/2] KabylakeOpenBoardPkg/AspireVn7Dash572G/BoardEcLib: Check for NULL Thread-Index: AQHXosrDneVdLEaHWkmzNcFc2GcrO6ueANeg Date: Sat, 11 Sep 2021 00:23:48 +0000 Message-ID: References: <20210906025530.279219-1-benjamin.doron00@gmail.com> In-Reply-To: <20210906025530.279219-1-benjamin.doron00@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ba1e351b-1f1e-429c-b18b-08d974ba6c82 x-ms-traffictypediagnostic: BN6PR11MB1569: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:514; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 00AcPQSdV+U8lEHeyh9Xw/vynYDaq3nkoJZc24v0zDnKb/C2319JkArfxXkJXDBIT/K0+uc0SmSHPlyggGVM7qKpput8ESm+sjBrwjBukMk8UEcfeljQiJI4TJis4NHm10wGkfUiHt9K4w0xb6K8YiTppes4KhyIIA1yG7i8JXV7H4W8Z1w2I2PXj6IOQDLj9DMSswRyKZDGiChjXRYu8KsuNAG2pxohA8B0QEpVvP15Atfm+EP8iK5xMdOlMYi2C4FNIm35qkMS7aEC7UZqHaCxoDs0Xia9GKCTZMTwhav/WCrKL78eHW6RWrnq7rqJVY5vxN7eeslevS7fe21bpVoIY4bu7biz/0tz0MzJOLUesUhJL98fh641QjQOCH9gydYiJL7d7BvwIFii/QN9MZhiQ4Ny4QZItgQYvjOxnOPVmWIdbl7Kq5yQeAlEa/WS+UaA5/bJ8CUqAn+b2R48U+2QcEnMqo9jC7Pp6ItwJ0pzPGgbdZ8nJDT722XLLolMvvWYjEtFX4VSTxgI89IxBMncL2rGI85/bNIChlYsgW7RtLj9JKcQxouZ2PkeSPanlLjnQsLbgpsm6D09JZJiZ9Y6CVAkkHTj0akrRbLn4eMWy4HV3UD9zEvEKYhjpPJRFHrlHPcb46Wglex5g8xo3iZSOYy7Hd+Tn8/ZJI5hc2I9/Tbw0AqciSLBU5VEmfaNo5mPToSsUbSxzV3r55mrqok0pbj2xAqlVR00bLDbbNmxcUc1UyC269xTx4YO91QyQRvixdEtvSOE07jM/PybMr93ZgFxVNjURbi+bFdNItI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(107886003)(53546011)(64756008)(8676002)(66946007)(83380400001)(38100700002)(4326008)(5660300002)(66476007)(52536014)(71200400001)(86362001)(966005)(9686003)(110136005)(316002)(33656002)(7696005)(26005)(38070700005)(122000001)(66556008)(186003)(76116006)(55016002)(6506007)(8936002)(2906002)(508600001)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0di/pyZAmAasx+TZnAtr7uHRNsncEB91b+x86ShPy4klazKvgb9acc8Lyvph?= =?us-ascii?Q?I/SU22cE55CZvpRcDA3HmKlPXrdIpBckmjYjmAhvUVaaEkO8JxY6h82qJ2Fj?= =?us-ascii?Q?uGoJUVbfqyd2713FbySs9WVGXHBCcSzUhXs6+5vIxK7BPpO1CYY0wEN7SIGO?= =?us-ascii?Q?iG0Vgk5LnwjGiA4MsiRvmoJ9sDGHsAgP0Z3e9E4H3PcGQWd4HZbOUhVQyIB4?= =?us-ascii?Q?zIGspcGYa9BqmOpQq3DTELZsukMoBF4R3gHM1gzf6YKy4PMkRu28HScql1Ie?= =?us-ascii?Q?vT7BQAQXeh+1eiUjyRlrKXtFy+HGSq6WKTaDoWMExVfsKB82phnLvTErVbd8?= =?us-ascii?Q?SVUJgQxYrzU15TSs5U/n4SRub0qBvJUIMBEOVtLGUEQotdKJpFXohpIZMuZJ?= =?us-ascii?Q?hwtie5olrElSuCc6zVB1DrrzAIE2yeopKoctF/FyzyFBmaR9Qzae1qQY0VXD?= =?us-ascii?Q?AJsBQ+TdB3M69GB3alVNtouJlrB1Rclz+uuzGw/Z0CGXlxr23d5gpXO44tei?= =?us-ascii?Q?ztWQ6bKJ7oDElbVkqEQwPsPImX17RUlFcfj7xoqoIeJoS/lJQR6kccj+5XLg?= =?us-ascii?Q?SHL2klJyiRYVcNDLAi0dTVt/Bv136ns5xK09oy0D2ZZKtraDGbRj7YO7bmMi?= =?us-ascii?Q?JWMD821SraCFXeUEJLFFQe5CYFpcFxAoiLIsOWN7LjiuvlzA6FCSWjkoVX3z?= =?us-ascii?Q?sOgIwrd2uIloD6BbAZ8tnhacdE3VYwbYM2KldWj9N9MumYrUvyG/TYAle27K?= =?us-ascii?Q?SJNwl6j/Wa46LQUj+l6acxgamjIEMxuGUw+FuomzGXrNKctR87z8XewFgXzM?= =?us-ascii?Q?SFHfpgGrfvnk2LQLqHWREOLB2sA1mzxG+Q/EeY4GkV+d0pJWABU2i2L6YirR?= =?us-ascii?Q?a7fGCAqO1l+ODlZ5WiWdyqUp5s1ncadgDapg08XoxZXui9m8tViFkMVgF3OA?= =?us-ascii?Q?L8z7U3izyLwzywKMY4KGv2OPSseh7i5mYRICaGqRRgqE8U7rFw5xtGzMfzif?= =?us-ascii?Q?tNGN9Q8/UZ3ZyM2MGTP5/pl8lk8A8+Ivd2yz5sUAxaDt2SEAYJza4San4zNN?= =?us-ascii?Q?94od9vZ1iYryiz5yJgGHg8H8Jcg474rX0j1PRUZI8JCNDt8cxzR4G+R56fuu?= =?us-ascii?Q?4VH1PmsyvYVRTyxZQN2hhY4mOHJyqdORvbGkfI7avtxB/27Fc4HWYcu6m58W?= =?us-ascii?Q?4dljpJ9PFVQXB8Kh7g29R5X3sNfpF32x+66TobHMHqf6+bGFIFFZwiK4lHPE?= =?us-ascii?Q?2usd3iRTDvW7x1eipv/bioqz/NS1qMaQxNu7RcPsynaIFkTlyzDzeGymTER9?= =?us-ascii?Q?DE88fwxeYrhdYiDRkJo1O1MR?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba1e351b-1f1e-429c-b18b-08d974ba6c82 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Sep 2021 00:23:48.2003 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rEzzYAODeU/8PsZc+CKMBZY+1aGWA4h7Kc+piUzzNlP75DvKK/Gjnh1VMadqLzpHpjFe35rU+xS6i44+/w2UPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1569 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Push: https://github.com/tianocore/edk2-platforms/commit/f1add54453dddb2028= c87445c234e746b62d7a12 Thanks, Chasel > -----Original Message----- > From: Benjamin Doron > Sent: Monday, September 6, 2021 10:55 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH v4 1/2] > KabylakeOpenBoardPkg/AspireVn7Dash572G/BoardEcLib: Check for NULL >=20 > Check that data pointers are not NULL and update the documented return > values. Also update some notes on this library. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Signed-off-by: Benjamin Doron > --- >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Library/Bo > ardEcLib.h | 40 +++++------ >=20 > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardEcLib > /EcCommands.c | 70 ++++++++++++-------- > 2 files changed, 58 insertions(+), 52 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Library/ > BoardEcLib.h > b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Library/ > BoardEcLib.h > index 2e7e0573900a..8bb4cccb8f19 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Library/ > BoardEcLib.h > +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Libr > +++ ary/BoardEcLib.h > @@ -12,12 +12,13 @@ > /** Reads a byte of EC RAM. - @param[in] Address Address to= read- > @param[out] Data Data received+ @param[in] Address = Address > to read+ @param[out] Data Data received - @retval E= FI_SUCCESS > Command success- @retval EFI_DEVICE_ERROR Command error- @retval > EFI_TIMEOUT Command timeout+ @retval EFI_SUCCESS Com= mand > success+ @retval EFI_INVALID_PARAMETER Data is NULL+ @retval > EFI_DEVICE_ERROR Command error+ @retval EFI_TIMEOUT > Command timeout **/ EFI_STATUS EcCmd90Read (@@ -44,11 +45,12 @@ > EcCmd91Write ( > /** Query the EC status. - @param[out] Status EC status byt= e+ > @param[out] Status EC status byte - @retval EFI_SUCCES= S > Command success- @retval EFI_DEVICE_ERROR Command error- @retval > EFI_TIMEOUT Command timeout+ @retval EFI_SUCCESS Com= mand > success+ @retval EFI_INVALID_PARAMETER Data is NULL+ @retval > EFI_DEVICE_ERROR Command error+ @retval EFI_TIMEOUT > Command timeout **/ EFI_STATUS EcCmd94Query (@@ -58,12 +60,8 @@ > EcCmd94Query ( > /** Reads a byte of EC (index) RAM. - @param[in] Address Ad= dress to > read- @param[out] Data Data received-- @retval EFI_SUCCE= SS > Command success- @retval EFI_DEVICE_ERROR Command error- @retval > EFI_TIMEOUT Command timeout+ @param[in] Address Add= ress to > read+ @param[out] Data Data received **/ VOID EcIdxRead= (@@ - > 74,12 +72,8 @@ EcIdxRead ( > /** Writes a byte of EC (index) RAM. - @param[in] Address A= ddress to > read- @param[out] Data Data received-- @retval EFI_SUCCE= SS > Command success- @retval EFI_DEVICE_ERROR Command error- @retval > EFI_TIMEOUT Command timeout+ @param[in] Address Address t= o > read+ @param[in] Data Data received **/ VOID EcIdxWrite (@@ = -91,10 > +85,8 @@ EcIdxWrite ( > Read EC analog-digital converter. TODO: Check if ADC is valid. + @p= aram[in] > Adc @param[out] DataBuffer-- @retval EFI_SUCCESS Command suc= cess- > @retval EFI_DEVICE_ERROR Command error **/ VOID ReadEcAdcConverter > (diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardEcL > ib/EcCommands.c > b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardEcL > ib/EcCommands.c > index 09b2b5ee9180..ea8a8ae11e4d 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardEcL > ib/EcCommands.c > +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/Boar > +++ dEcLib/EcCommands.c > @@ -12,18 +12,22 @@ > #include #include -/* TODO - Impleme= nt:+/* > Notes:+ * - ACPI "CMDB": Writing to this offset is equivalent to sending > commands.+ * The CMDx bytes contain the command parameters.+ *+ * TODO > - Implement: * - Commands: 0x58, 0xE1 and 0xE2 * - 0x51, 0x52: EC= flash > write? * - ACPI CMDB: 0x63 and 0x64, 0xC7 * - 0x0B: Flash write (= Boolean > argument? Set in offset 0x0B?) *- * NB: Consider that if a vendor's UEFI= driver > consumes- * unimplemented PPI/protocol, the driver is dead code.+ * > Reversing vendor's protocols:+ * - Only read and write are used.+ * - Que= ry, > ACPI "CMDB" processing and command 58 are unused.+ * - Equivalent KbcPeim > is an unused PPI. *- * NOTE: Check protocol use.- * - Commands deliver= ed > across vendor's modules- * - EC writes also control behaviour+ * NB: Al= so look > for potential EC library */ #define EC_INDEX_IO_PORT 0x1200@= @ - > 34,12 +38,13 @@ > /** Reads a byte of EC RAM. - @param[in] Address Address to= read- > @param[out] Data Data received+ @param[in] Address = Address > to read+ @param[out] Data Data received - @retval E= FI_SUCCESS > Command success- @retval EFI_DEVICE_ERROR Command error- @retval > EFI_TIMEOUT Command timeout+ @retval EFI_SUCCESS Com= mand > success+ @retval EFI_INVALID_PARAMETER Data is NULL+ @retval > EFI_DEVICE_ERROR Command error+ @retval EFI_TIMEOUT > Command timeout **/ EFI_STATUS EcCmd90Read (@@ -49,6 +54,10 @@ > EcCmd90Read ( > { EFI_STATUS Status; + if (Data =3D=3D NULL) {+ re= turn > EFI_INVALID_PARAMETER;+ }+ Status =3D SendEcCommand (0x90); if > (EFI_ERROR (Status)) { DEBUG((DEBUG_ERROR, "%a(): SendEcCommand(0x90) > failed!\n", __FUNCTION__));@@ -110,11 +119,12 @@ EcCmd91Write ( > /** Query the EC status. - @param[out] Status EC status byt= e+ > @param[out] Status EC status byte - @retval EFI_SUCCES= S > Command success- @retval EFI_DEVICE_ERROR Command error- @retval > EFI_TIMEOUT Command timeout+ @retval EFI_SUCCESS Com= mand > success+ @retval EFI_INVALID_PARAMETER Data is NULL+ @retval > EFI_DEVICE_ERROR Command error+ @retval EFI_TIMEOUT > Command timeout **/ EFI_STATUS EcCmd94Query (@@ -123,6 +133,10 @@ > EcCmd94Query ( > { EFI_STATUS Status; + if (Data =3D=3D NULL) {+ re= turn > EFI_INVALID_PARAMETER;+ }+ Status =3D SendEcCommand (0x94); if > (EFI_ERROR (Status)) { DEBUG((DEBUG_ERROR, "%a(): SendEcCommand(0x94) > failed!\n", __FUNCTION__));@@ -140,11 +154,8 @@ EcCmd94Query ( > /** Reads a byte of EC (index) RAM. - @param[in] Address Ad= dress to > read- @param[out] Data Data received-- @retval EFI_SUCCE= SS > Command success- @retval EFI_DEVICE_ERROR Command error+ > @param[in] Address Address to read+ @param[out] Data > Data received **/ VOID EcIdxRead (@@ -152,6 +163,10 @@ EcIdxRead ( > OUT UINT8 *Data ) {+ if (Data =3D=3D NULL) {+ r= eturn;+ }+ IoWrite8 > (EC_INDEX_IO_HIGH_ADDR_PORT, Address >> 8); IoWrite8 > (EC_INDEX_IO_LOW_ADDR_PORT, Address); *Data =3D IoRead8 > (EC_INDEX_IO_DATA_PORT);@@ -160,11 +175,8 @@ EcIdxRead ( > /** Writes a byte of EC (index) RAM. - @param[in] Address A= ddress to > read- @param[out] Data Data received-- @retval EFI_SUCCE= SS > Command success- @retval EFI_DEVICE_ERROR Command error+ > @param[in] Address Address to read+ @param[in] Data = Data > received **/ VOID EcIdxWrite (@@ -181,10 +193,8 @@ EcIdxWrite ( > Read EC analog-digital converter. TODO: Check if ADC is valid. + @p= aram[in] > Adc @param[out] DataBuffer-- @retval EFI_SUCCESS Command suc= cess- > @retval EFI_DEVICE_ERROR Command error **/ VOID ReadEcAdcConverter > (@@ -195,6 +205,10 @@ ReadEcAdcConverter ( > UINT8 AdcConvertersEnabled; // Contains some ADCs and some= DACs > UINT8 IdxData; + if (DataBuffer =3D=3D NULL) {+ return;+ = }+ // Backup > enabled ADCs EcIdxRead (0xff15, &AdcConvertersEnabled); // ADDAEN -- > 2.31.1