From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.17126.1686326298789989947 for ; Fri, 09 Jun 2023 08:58:19 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Q5MeMboh; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686326298; x=1717862298; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=cqAYvVRy/GEDikn/Cafz5OslZ5esnSn5OVOp0qvTfz4=; b=Q5MeMbohEIWBmEt1iUEOUGcAxTMoysxjO14F7RXXcCsZpt4m4bxwMjOR 3wOQRM8kKix7zBFvgGUsKexhnQ+BvV19foRQ8duS7jxbYXlSKhywl6ayZ 8o0lsepKPo4d/GxJOKv4RO1ReCxKQdkJuH8IYN+eRkdGfQ3sXPBoEx6wm HA6BJ3TiiWJtsGmylIZMxfUmjjmPuupsGGYPpirB5yR03D+OeMCsefIY8 zXzHszQcul5dOZe72r6cu2BnOblOXHp//BXKF2Gmc2/eABnRvL5/z60V0 z2IvK6FyBjRNNo8gL0VqyT8sytagyavScR/dKPafD0eT1mTcR1D4upQc9 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10736"; a="423506729" X-IronPort-AV: E=Sophos;i="6.00,229,1681196400"; d="scan'208";a="423506729" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2023 08:58:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10736"; a="854787432" X-IronPort-AV: E=Sophos;i="6.00,229,1681196400"; d="scan'208";a="854787432" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 09 Jun 2023 08:58:17 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 9 Jun 2023 08:58:16 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 9 Jun 2023 08:58:16 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Fri, 9 Jun 2023 08:58:16 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Fri, 9 Jun 2023 08:58:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lAlvAd/5g2u35LoFz8GJxFCbkV4jHyEZvqcq3XOlu8oYTHSG7eG/IIx/53UKtN/KazcdbazCzTIpuOS3PWYXulyZz7Srh7JCsanEeFtSCzP83Tkik+tXhjE4zEjLkjShTfcrZpTa4TipKB8r03HlhFqHIHR6rxZWdyxIPaPTsjs5AOyxUG2/QyYAqG8vV4s+eBBBtPWaih0WOFmlpBeTmI7+OzAuA62w2ANnQ7f3UIuJtGkrwDARYSdlIA/jAv0BQHd8nh8S0FKQxevyITj10YIs9cq0QjCXVYA4RFo/4aSWdnx6G22PNidchlEaMX13C3Hg9MVQKPYBNNXcL+KREQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FiD00SHiNMtcrG0grh9+3WDLAurIXjcLE4cXt41mk3I=; b=JEI3mu/rn1ZxgWy9BdSo5+WIGC2RaSbUW9qzb02jzS6bR0lE7xAr12+TmBVh+s8Y1SrEBNq9MHmvwHW5Pr4mtihc9bpoIEMRqB63meeWtQ6Xsa3wuo/XTlsTiW80t4QyQbiw1BsuwuPKqeIQKlLsqcVNSMGidwZqE0BCZaZowXOswPZ41QJV2GqN/ZOF/A9CKqeHFxFMAYvHZTv28CEM1v+J0LTUU0ozT/2OUgyxlKjSjsWfQyZuC3r3qntN3Gz4uL0+DZuIPDtfCXIs8rWE+RI4U5ZiDOL5isxC2hOG/0EBy5rwU8h2P3/IeBAj83CvwFpEPlDusts4UsGtzy0o3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by CH3PR11MB7913.namprd11.prod.outlook.com (2603:10b6:610:12e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.36; Fri, 9 Jun 2023 15:58:16 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::3023:34d3:bd4e:7901]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::3023:34d3:bd4e:7901%3]) with mapi id 15.20.6455.030; Fri, 9 Jun 2023 15:58:15 +0000 From: "Chiu, Chasel" To: "Aishwarya, KurugoduMelmatamX" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Duggapu, Chinni B" , "Chen, Gang C" , "Zeng, Star" , "Kuo, Ted" , "S, Ashraf Ali" , "Mohapatra, Susovan" Subject: Re: [PATCH] Get HobListPtr before calling the Multiphase FSPS Thread-Topic: [PATCH] Get HobListPtr before calling the Multiphase FSPS Thread-Index: AQHZmtfgNMcI0tRA9EOCV39YrHUWG6+Cn3dw Date: Fri, 9 Jun 2023 15:58:15 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|CH3PR11MB7913:EE_ x-ms-office365-filtering-correlation-id: f455fd61-8970-4de8-9932-08db69025604 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: u8Io3ffyEHgPU2G+iBiPrTLBgop5HRWBZcBB6JzxipXoHMmLbk5TFdsQvYtFKhidc1n8E3mhSZTCG8ritNSDtzzLMkWIMwqJ0BG7XSNLc0EgrWOvKJoG7S23q9M7/SyeUCXiqhAqMaK9+gxeNm32R3pWz2YTgLluA+fAe5u8kJ2rDHbqtDqZ5yVLwgmClXfAxrTT0gbyIJFWSyWeNx44PJylQ6LPsLlQW/4BSSc0jTPsSniWWreV/xj/ugVTWuNYAWzdPf+jhUQqluKUjLUniWOfYC47eSUX/tgPxx143uhjH5S7iB2RmRzCtl3GxIYX1gKZLhxz5qBOFmYOd8wjI1nyuXluxJpyFseQCrnXlq/i4Ra/hXR9/AJ4MVK+Pf8l1RfwXd2/kYjW0QWj3m0e16IhgcpvB8WxRQSmj2Neim2ShzY6iKMq/K/ax/x26Eblz9hkFJbQar/2UCZVWq1FhaJ9p0F56zzoi3a7ZMBr2zDp+6jj9CuzS2R3uPNpz6LJVS0++E13+Ud3yIn8zzaQ47mobNFgBz7SeubRIdJmuZ+LA/k161Rfpu70Chwgzi4jqSlZqC75ZzqOdPZ9i2D0zD7O4iVsHnQr+9k+Ho1VmHE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(346002)(396003)(136003)(366004)(376002)(451199021)(64756008)(966005)(7696005)(316002)(41300700001)(83380400001)(86362001)(9686003)(38070700005)(6506007)(26005)(186003)(2906002)(107886003)(33656002)(53546011)(82960400001)(122000001)(38100700002)(55016003)(5660300002)(52536014)(8676002)(8936002)(76116006)(66946007)(54906003)(110136005)(478600001)(71200400001)(66556008)(66446008)(66476007)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OmzN3RtPfsxvYdkzxWk7rptm9U3futDSSTxLJNVopaC7PFC+LpxQVuwuO2Q1?= =?us-ascii?Q?iFaeG606Ck2hZXaKFeo0XmJ1Phxp8qsK2DB9A5DnMp9uL9RUOClFT2MGbMC0?= =?us-ascii?Q?JYqP3x9DFtwr+h5JeERcOh3Ab2i5h0M34ACaqVYsWZVMpbk/6dR6MDZq7Vjl?= =?us-ascii?Q?U70YpL0AXyRXRzfdCZ7e/unRqBVQkIbFnhOghvSPYZJKhew8B3F2s9UVvbFe?= =?us-ascii?Q?e8JqAdSVheeLIxxJynxjIB9++iHzG8xVGTJyPnAA0FpN1yWjQ6KV9ihKws/V?= =?us-ascii?Q?38/RUkJMWfWsxJQdhYZ2WYbKx6dyWv1aHpMdnlUPQVg9NPeKjjDpWpUsrHHn?= =?us-ascii?Q?xZ+MS8kZ6StwkBxPBNgqD/2nVKKOZECNwDW1gw1CfRiWtZFKGyGXLKPpeGFY?= =?us-ascii?Q?LuMT/flggKOEuGTxL7bm0sy8Z3rfKFxGkkUmUtLbtrlP1VkrJDY+z1rV5f+E?= =?us-ascii?Q?EIzz5A4FAI8Wcr19u2YxItgUkURH8Zdbx1HCnODReEboUCBPigfLJabvHWlb?= =?us-ascii?Q?IYsUB+WEjukLGh4ML4S2J959bRaJPLFvl6sx9e6aNRo4NsMSCzDwXjabrAog?= =?us-ascii?Q?LODfG3bA+eUJLMcclaEylAEh2hs7LKkeNYK5FCOjbf+iTTdFbRxTiloshRMp?= =?us-ascii?Q?AtxZ0ujizXNH7hWKAzPgf64cVfpqu1RqBZFZDhAE8zero6ncWEWNFQboDbbp?= =?us-ascii?Q?fkbFx4MVZ4gW9mWdCfcCpL7SNeC0pDIQSyL6ktycdPaLhJ8AowehJEQtu+hM?= =?us-ascii?Q?EDf2eR8vAuQe4bSEwHVkIxUMRL4Y1O551kSLcoBrOo3kjCQkH1ka9s+yyklS?= =?us-ascii?Q?BFv+t18mwlQ78QvfADl28hGVoxzZXrGADVKDQluDFdGzwbVQYhh0/ICDCQwF?= =?us-ascii?Q?gD2ABr0xQ258FWDw9q+TETg3CSBFHu42QrvMFS9Ppu58WLwqbwYn1VTgUDrs?= =?us-ascii?Q?9U2DAFmEI9oy3ynrywRyt94idpouPxtMgqu3XFQF/NDeyOStIR3sLvzUvXn8?= =?us-ascii?Q?5JM5bM+OAwO6YXXqw1lbClKdtYH37V/gJpF7m0a5fVqFFf64k/O/1y275Rfi?= =?us-ascii?Q?ZW39tiFCv9v+9pVuP5vbyfcQBo0G5SgRbdYC1eB3deDG/slmDhM8V4nyokO9?= =?us-ascii?Q?mjydldwyh14+xH5mMErbG547YmNsmFwQ+0UuVpR8t56dOj2oKQqTQEvtKMd3?= =?us-ascii?Q?ZQSZGO8pjMyEeI6bled00YT9zTpSKm5svfD1Y0TWnDxQViOqGRK0mG+gFk+o?= =?us-ascii?Q?HtM2gq1hP9Vb9cylPOIB5O9I1LXkAT3uQDmNBbBNTb0yy3DUH8h6gg4hgKVc?= =?us-ascii?Q?LmcaNoCmmz3Y8KHJEzdtwdbYButbru5NPZegS37/Jcip0c6OLVeOLBNHmsuc?= =?us-ascii?Q?DQS1/t37Zrf9B+HJWIAjFdAAIaYcFXI2mSsW2LzQt7HmRbwUmtkGxvHv/hwR?= =?us-ascii?Q?oXFebHiysb1WfnP1nWges5UprevY3eeXTjRMrsvor48kCOotoNzyMyW2tuYC?= =?us-ascii?Q?kk44DIHoYBVb8VG3BJ/oC16LBYCt1CpL53FJGZiLF0ufoq9DLYYtss0K0qbE?= =?us-ascii?Q?3N8yCkpD6AKAb53uN8jLOJQEBCx7OjqKvPyk93Sj?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f455fd61-8970-4de8-9932-08db69025604 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2023 15:58:15.6835 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jt86YxY5wZGrmU5HOGdjtXucdmrR59m9+ut/Unyu/TB8A+Jw4u91YycU1xobN40dxOCJ274cd3GBqnZ53FHTNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7913 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please update the subject per format requirement - PackageName: title With this update, Reviewed-by: Chasel Chiu Thanks, Chasel > -----Original Message----- > From: Aishwarya, KurugoduMelmatamX > > Sent: Friday, June 9, 2023 6:40 AM > To: devel@edk2.groups.io > Cc: Aishwarya, KurugoduMelmatamX > ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Duggapu, Chinni B > ; Chen, Gang C ; Zeng, > Star ; Kuo, Ted ; S, Ashraf Ali > ; Mohapatra, Susovan > > Subject: [PATCH] Get HobListPtr before calling the Multiphase FSPS >=20 > REF : https://bugzilla.tianocore.org/show_bug.cgi?id=3D4480 >=20 > In the FspsWrapperPeim, before calling FspWrapperVariableRequestHandler a= nd > FspWrapperMultiPhaseHandler ,FspHobListPtr should be available so that BL= will > be able to get the correct FspHobListPtr value >=20 > Signed-off-by: kurugodx > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Duggapu Chinni B > Cc: Chen Gang C > Cc: Star Zeng > Cc: Ted Kuo > Cc: Ashraf Ali S > Cc: Susovan Mohapatra > --- > .../FspsWrapperPeim/FspsWrapperPeim.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) >=20 > diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c > b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c > index 08fe0fdb7e..1d4dd60577 100644 > --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c > +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c > @@ -336,6 +336,14 @@ PeiMemoryDiscoveredNotify ( >=20 > DEBUG ((DEBUG_INFO, "FspSiliconInit status: %r\n", Status)); >=20 > + // > + // Get FspHobList > + // > + GuidHob =3D GetFirstGuidHob (&gFspHobGuid); ASSERT (GuidHob !=3D NULL= ); > + FspHobListPtr =3D *(VOID **)GET_GUID_HOB_DATA (GuidHob); DEBUG > + ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr)); > + > if (Status =3D=3D FSP_STATUS_VARIABLE_REQUEST) { > // > // call to Variable request handler @@ -356,13 +364,6 @@ > PeiMemoryDiscoveredNotify ( > DEBUG ((DEBUG_ERROR, "ERROR - TestFspSiliconInitApiOutput () fail, S= tatus > =3D %r\n", Status)); > } >=20 > - // > - // Now FspHobList complete, process it > - // > - GuidHob =3D GetFirstGuidHob (&gFspHobGuid); > - ASSERT (GuidHob !=3D NULL); > - FspHobListPtr =3D *(VOID **)GET_GUID_HOB_DATA (GuidHob); > - DEBUG ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr)); > PostFspsHobProcess (FspHobListPtr); >=20 > // > -- > 2.41.0.windows.1