From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1AEA09411E6 for ; Tue, 2 Apr 2024 06:49:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YH6wwTWRGbbdUqXRqJV+iQFLH5TXSnq3ljo0r0ALOus=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1712040565; v=1; b=oLS1p2CkHBHiakillOp57r5zz/5VohChtiWVrra2/Xx+cb8FgFBOtAEVN7J6uNPtmo4+6WuW qSkJ3DmizYdQTpVDtYZK+oswbRawz5H6YWkCe1A8+NquNfhJnOPXuQvo2acAxOlkowcsn5IHe8k sHSxN4MKEubyIFK7DSvdwzUrQ6JfdTZ45WEaUYYZkB5rdEn0Caw27v6T6PvIWPUN1XkwZvHnNP9 VAlX5N7XhGsaqr5KFydi3y6rY3dVWDFmSSx24dBMKQm4F05cTGjxy3ffoBWRXgwYBJtKhWJGGu5 Z7bPe2kcNAybG/L95OH9KumUe5a5K18oGuP+qoHSvpYRA== X-Received: by 127.0.0.2 with SMTP id BJd3YY7687511xff7IwdjxuT; Mon, 01 Apr 2024 23:49:25 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mx.groups.io with SMTP id smtpd.web10.6305.1712040565075481343 for ; Mon, 01 Apr 2024 23:49:25 -0700 X-CSE-ConnectionGUID: jXdXtpIIQnahtc8DhZXRQA== X-CSE-MsgGUID: N/1JmHUoR++FaRZ3wRsfcA== X-IronPort-AV: E=McAfee;i="6600,9927,11031"; a="18641551" X-IronPort-AV: E=Sophos;i="6.07,174,1708416000"; d="scan'208";a="18641551" X-Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2024 23:49:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,174,1708416000"; d="scan'208";a="49183827" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Apr 2024 23:49:24 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 1 Apr 2024 23:49:23 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 1 Apr 2024 23:49:23 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 1 Apr 2024 23:49:23 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 1 Apr 2024 23:49:22 -0700 X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by SN7PR11MB6921.namprd11.prod.outlook.com (2603:10b6:806:2a8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.21; Tue, 2 Apr 2024 06:49:21 +0000 X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::5561:25ad:2b29:d5c]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::5561:25ad:2b29:d5c%7]) with mapi id 15.20.7452.019; Tue, 2 Apr 2024 06:49:21 +0000 From: "Chiu, Chasel" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Lou, Yun" , "Desimone, Nathaniel L" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-devel] [edk2-platforms V2] MinPlatformPkg: Corret AcpiProcessorUid in MADT Thread-Topic: [edk2-platforms V2] MinPlatformPkg: Corret AcpiProcessorUid in MADT Thread-Index: AQHag/nS+5nzYEgnj0mnozgUvS8kWLFUi7TA Date: Tue, 2 Apr 2024 06:49:20 +0000 Message-ID: References: <20240401055934.1704-1-dun.tan@intel.com> In-Reply-To: <20240401055934.1704-1-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|SN7PR11MB6921:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: jUSCf+uIiR24AYNXtKdNic0dydH0JwohLxAQ0S9UR49rCuxHxEHSfOG9RbxNQ0B6yfIqNTGNr4FKF/9pT/K88PCPky/Kco5nzQDGxZQ1hMcy8SY0KZMDhsEcKfdSzRwODR5o5gEKPnFH+9VfrppRhX5JLgcZ3sjGQ0HQTrlMB1R2TqimwjI+JIp7+84HWr8UiH1+1lnqwMhe6iU0oFhIMIrayQ0tK7OyBIkbNLB9bOnJTkgPtxscxm+zm9j2H3nTwn37ADMLGYImGC/EHjXT2QN3vlSIiKFyZs4ATiOStyex3u3R4LGoIyfsQqPlowGoJjk7sv/L6SVGJZFZ7uC/lwvEdjh+fXRUCqXk69tSV8+XKWq0Y1iCRsKLoWZ/e7bIByrXFHS8mAvPDYSn8lt9VTlzbbh770PYc/rLD3YwSOQcmLc9aywmUANB+7UtS1Yne38YM4ZN+3K8hfegTQN9QC4Vu06czEex9BX2b59v3pbVbdC1v0FOHFtIgwiyeO2AnCXDz/GspXHyP0x/TxkrSu9LOMschQmLFopiEJO3AfLzlowIviCELcBX8MngFbnxyVUPzvJtIbU9kehLyw1ajWenMElsBjXkS5S/qcOEkjeqDarO8U2gPE/1HLoc/IF6izNNOxzukb48o6AvU2XYycy8kYa8EZer8ZhGgYz1Suc= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Lbx2gaXlD/aw8bGlxoo71ztLiws6XMnQBEtYaRJ0T3e16+PPC/Oa45Ypa6H0?= =?us-ascii?Q?DXTTT1j8vF7FBnICecaYLoSQbxPe7/8N74Cv/B53d6EWcVttIcGqxxKeAsip?= =?us-ascii?Q?xUrAuNrW05tBgy0RJAmmZkLaWzUWwPp2vYLq1AHj5gaiXE8kaGgrW77Oc5Jg?= =?us-ascii?Q?JDFATPn8Yjk58uHWAiHnRFYfdgq6KMu50vCob+crb8RDYUNLQPWlrTfXX3e7?= =?us-ascii?Q?H/e28FiqKuZX0vMDKyxlO+jIpnCWmC1fh2+w2j1saGKVHFvtH1rphYbWtz2c?= =?us-ascii?Q?0tMBwArUtfatRrCyuZPQpA0kuhBfaHOBe+fHMQjOSFsOEjaIzQ1J4GuXxIj6?= =?us-ascii?Q?6KalSLbDEuOudOD5saV/VC2JXzFcj4az+FtuFdX7LRdqcNoHzs+xF3CLWP2L?= =?us-ascii?Q?3vmpBgVmUDSf+4Xhs4Fppryh35UbONzNUoYdZRCKKmltk6P/VWWGcyBMiGsE?= =?us-ascii?Q?uZka7ZKDzs9/S3l6xfTArgCNO+zAg5EJI+rMHcTbcJGLsdyqolv/3ojrREzL?= =?us-ascii?Q?Lgppehl0HejiCaLH48u6A31AYe6UWgYZhi2h4Y8Ri4Cw2Xk5Z8+UdZ6e0Li/?= =?us-ascii?Q?CxpUY9y6a9aUdUQeoR4t7d+o2JA2L4ZVeNclfGAoqllEptqqFl6S3lvZokWA?= =?us-ascii?Q?VLou/hjWVhkMe+rAXYnZrFB3oCF9VmzXMltNln+8ut1uR685STQUGm2YvytF?= =?us-ascii?Q?mXb4xrFCiV2OtF4WaSvWpnahqb2E75lGrH6aQUf22RPYafRox84iGqHdvYRq?= =?us-ascii?Q?Gsdf/yd9NWBLMYadhf/f9ecQb12WqzD6rQEpy6VMnzlAMPKu+HAYoOB9MDQ7?= =?us-ascii?Q?jxp6oCkecsQJdmxlp4G7X7IRywCDxvk7M2Pc8Sgx4tO6VQtq+wL6Z7SPrwhR?= =?us-ascii?Q?WUo/T25aaivUmDFs4Sz26UebZX6pLm+zExpFGZ51s3LbSkyxdv3mlkoMk3bn?= =?us-ascii?Q?buq6yvrdrF3aNsm0TEzth+xR1SnQLYEYpc2IsJujvls9/VQRKMR+4qEtercF?= =?us-ascii?Q?NRCWrrVFfCL3WUmRPTfueG85wgi5vP2nIV0xlew4PxR2nlg4LYV4OaH7UKqI?= =?us-ascii?Q?wq9BX7Oz2GxEV6XDiIoOkNa1rDpKtbmnYmrAZQGRiM9aM8N7dtBOps7IP3dy?= =?us-ascii?Q?9IfOo/13z6hndT5WsSRrOGhLeWezOwj6cUkNoV00fGhedAV9+RgS0WPTXmRN?= =?us-ascii?Q?zXBfn5pVpEOfVW6R8Czg/dxgNe4jpx5qCP5aqMhmyjxOyxnBmOkNz+JRNOxJ?= =?us-ascii?Q?XaSwM5AHmQZ/8E4EJI+Y3JFIeF3PfsfUXZMl9saA7pbR/8Rl+bvacRF1xxls?= =?us-ascii?Q?QWAaaq+W0zmRVCNwgyfNhZRr5l9iSeMktO7Qrn+VHdpGV/Yoft1vztVWrvXc?= =?us-ascii?Q?kt4oknYCy5GyK63dndJfGm2vSKZULxmX9QAnaq6Oq40sWQ30aEL2OUvfj805?= =?us-ascii?Q?fMF19cHKDRwTlK2wdd3rVv0C4J7LC1qT99pd47CDzq2zY5S6DaoX70IY3cWI?= =?us-ascii?Q?2fso3xhqaa3AUHMvebxBgdTV6pSW9x8v4kWsfuzXH7edrJiCDcR2FtX9kLVN?= =?us-ascii?Q?Bj2JpXfjAw8rwzUStYs1HsHNe7oYS8AhI/XJsurL?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30247b8f-b433-42fe-e0fd-08dc52e10684 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2024 06:49:20.9854 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MBF3wJvEbRgHWIOxTZVqZKv2/5Tp0b9RmCu/TQ/q/73NAMcka5FPOWSTLyNu+xvfEq4ujtk/Vm7ZCt6l6xpzYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6921 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 01 Apr 2024 23:49:25 -0700 Resent-From: chasel.chiu@intel.com Reply-To: devel@edk2.groups.io,chasel.chiu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: RrdVZjMEv1jHU0F7IyNNTuhsx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=oLS1p2Ck; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Chasel Chiu Thanks, Chasel > -----Original Message----- > From: Tan, Dun > Sent: Sunday, March 31, 2024 11:00 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Lou, Yun ; Chiu, Chase= l > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [edk2-platforms V2] MinPlatformPkg: Corret AcpiProcessorUid in M= ADT >=20 > Change AcpiProcessorUid in CpuApicIdOrderTable to the index in MpService > regardless of disabled core. >=20 > Let's take a simple example: > There are 2 enabled cores and 1 disabled core. > APICID Index in MpService > 0x0000_0000 0 > 0x0000_0010(disbaled) 1 > 0x0000_0040 2 >=20 > With current implementation, the results of the x2apic structure entries = in MADT > are: > MADT Entry APICID AcpiProcessorUid > 0 0x0000_0000 0 > 1 0x0000_0040 1 >=20 > The AcpiProcessorUid will be associated with the processor device defined= in > DSDT/SSDT. To make sure the x2apic structure entries in MADT can be mappe= d to > the right processor devices in DSDT, the AcpiProcessorUid of the second x= 2apic > structure entry in MADT should be kept as 2, which is the core index in > MpService. >=20 > Signed-off-by: Dun Tan > Cc: Ray Ni > Cc: Jason Lou > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > --- > Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > index 2a833ec99c..f6ea7454d3 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > @@ -190,7 +190,7 @@ CreateCpuLocalApicInTable ( > // > for (Socket =3D 0; Socket < FixedPcdGet32 (PcdMaxCpuSocketCount); Sock= et++) { > for (CurrProcessor =3D 0, Index =3D 0; CurrProcessor < mNumberOfCpus= ; > CurrProcessor++) { > - if (CpuApicIdOrderTable[CurrProcessor].Flags && > (CpuApicIdOrderTable[CurrProcessor].SocketNum =3D=3D Socket)) { > + if (CpuApicIdOrderTable[CurrProcessor].SocketNum =3D=3D Socket) { > CpuApicIdOrderTable[CurrProcessor].AcpiProcessorUid =3D > (CpuApicIdOrderTable[CurrProcessor].SocketNum << mNumOfBitShift) + Index; > Index++; > } > -- > 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117326): https://edk2.groups.io/g/devel/message/117326 Mute This Topic: https://groups.io/mt/105259071/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-