From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Chiu, Chasel" <chasel.chiu@intel.com>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Fix FspSecCoreI build failure.
Date: Thu, 15 Sep 2022 17:32:13 +0000 [thread overview]
Message-ID: <BN9PR11MB5483C7573A5987201CA595ECE6499@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1712AB873B2E7A3C.29804@groups.io>
Patch merged:
https://github.com/tianocore/edk2/commit/f46c7d1e36c901e72cc0daee8429275bcb319eb9
Thanks,
Chasel
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chiu, Chasel
> Sent: Wednesday, September 7, 2022 12:43 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [edk2-devel] [PATCH] IntelFsp2Pkg: Fix FspSecCoreI build failure.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4049
>
> Link error occurred in certain compiling environment when building
> FspSecCoreI: unresolved external symbol _TempRamInitApi.
>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> ---
> IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryI.nasm | 11 +++++++++++
> IntelFsp2Pkg/FspSecCore/X64/FspApiEntryI.nasm | 11 +++++++++++
> 2 files changed, 22 insertions(+)
>
> diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryI.nasm
> b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryI.nasm
> index e9365d6832..e392ebed58 100644
> --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryI.nasm
> +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryI.nasm
> @@ -22,6 +22,17 @@ global ASM_PFX(FspApiCommonContinue)
> ASM_PFX(FspApiCommonContinue): jmp $ +;-----------------------------------------
> -----------------------------------+; TempRamInit API+;+; Empty function for
> WHOLEARCHIVE build option+;+;----------------------------------------------------------
> ------------------+global ASM_PFX(TempRamInitApi)+ASM_PFX(TempRamInitApi):+
> jmp $+ ret+ ;---------------------------------------------------------------------------- ;
> FspSmmInit API ;diff --git a/IntelFsp2Pkg/FspSecCore/X64/FspApiEntryI.nasm
> b/IntelFsp2Pkg/FspSecCore/X64/FspApiEntryI.nasm
> index e74bf0a26b..5c9ffbd569 100644
> --- a/IntelFsp2Pkg/FspSecCore/X64/FspApiEntryI.nasm
> +++ b/IntelFsp2Pkg/FspSecCore/X64/FspApiEntryI.nasm
> @@ -22,6 +22,17 @@ global ASM_PFX(FspApiCommonContinue)
> ASM_PFX(FspApiCommonContinue): jmp $ +;-----------------------------------------
> -----------------------------------+; TempRamInit API+;+; Empty function for
> WHOLEARCHIVE build option+;+;----------------------------------------------------------
> ------------------+global ASM_PFX(TempRamInitApi)+ASM_PFX(TempRamInitApi):+
> jmp $+ ret+ ;---------------------------------------------------------------------------- ;
> FspSmmInit API ;--
> 2.35.0.windows.1
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#93455): https://edk2.groups.io/g/devel/message/93455
> Mute This Topic: https://groups.io/mt/93532998/1777047
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.chiu@intel.com] -=-
> =-=-=-=-=
>
parent reply other threads:[~2022-09-15 17:34 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1712AB873B2E7A3C.29804@groups.io>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB5483C7573A5987201CA595ECE6499@BN9PR11MB5483.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox