From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.3931.1678873858287688038 for ; Wed, 15 Mar 2023 02:50:58 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=APmx17s2; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678873858; x=1710409858; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=RMYmJim0c7YPa2mWPcWb3uX98RMuNgXy4vytH33iIEc=; b=APmx17s21Bqa+Iot6AYPELdaKP3V742CNkf7SA6r/8nY2frBiCzhNA/4 SSOl2GmHlc3Ipa4cE8JpGItXeIQuLc21gMw8Kmlvj7xpFVG5BeNc0lUfY 0MK1y+Vzvi6jU9GBB1X5nelkOUQGHzrYNCjqlqtiRUO00OwW3yZUZQtMY iycHD6ZoDaB7eERPJquoGf/ZV9+4zohGRrEV/thWZ/gkev5bLcXgjzjGW zLGzxIED0Ilc2FSilffHa4Pkmg9Sv3UapJnMiNfaOZgeL9dUTrTlxMA15 0N5eRe9coThSDiv67PXso3Hyu3pPapId2QqTzZZmGNh4CnfI77WrcC4Mm w==; X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="326018961" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="326018961" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 02:49:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="768431568" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="768431568" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 15 Mar 2023 02:49:49 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 15 Mar 2023 02:49:49 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 15 Mar 2023 02:49:48 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 15 Mar 2023 02:49:48 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Wed, 15 Mar 2023 02:49:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eobEMQxfCZTd36e4bmI+Y7kGvxJDsFSViU6edYfmHH1BFXRpJyT32mSlGzgqZWhXdJodhS2KrGoibpcoBmvSUSorB3kE7Kod83EaLJ2MfF/Ne4UMk3kuFArKEvuFpdfUsbgtzNFYahlNJk8+170sJllUjDeWJIrA8pFktMO2QjNrWnSSBvFzfHbvIL+EsE+hr79j/PrEJF2kTlyzVs6lJXa3atijB9G+QXbR1HhlovsfPMSYkFYQt++1NaZskDroctgH4U29azZlAzozQ2CRCAd1B3McxXbsP4HiBDQbD+RyKMUTCHYgk+fifSoNzAKg4ZL/gX2Y+ORSmu9F2KRG4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nF/Q6WJGVSFTj9NMDxHcXAMXhrKVzvVQBezMoiVAMg4=; b=dnEx2/zUe/KdCBWhy9akSaZkoj3anZwEP1bWcxWhW0icRRoX9FeCJ0hdiFbYBexuDLTf28wziQtC+0w3rMXs9ZwzQx5rL1/KLYhDo+x/g9nPkufZD3U4XIZmnnQN2+YYFbNeulJgBofN9CMr4PAteTNro2CxFkJpRsG+W0r4uW6mvVqif5H5Pe8jd61TZ8U6zq1lLBegBjWjAbIJcsfJwnQvXQ4udWpefRG75ezG+SW6M/riPHp4C3dg9zYWy0FdJaFsJ1eq60CEGkkrKP4naTyWrsRtFH4ilD32Mk7S1r+8zk1FxZng2Po/xw5lDi7BpG1VKpCNb7iAux61SKAhQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by DM8PR11MB5574.namprd11.prod.outlook.com (2603:10b6:8:39::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.29; Wed, 15 Mar 2023 09:49:47 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::af70:de56:4a6f:b2cc]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::af70:de56:4a6f:b2cc%8]) with mapi id 15.20.6178.029; Wed, 15 Mar 2023 09:49:47 +0000 From: "duntan" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [Patch V2 11/14] UefiCpuPkg/CpuPageTableLib: Enable PAE paging Thread-Topic: [Patch V2 11/14] UefiCpuPkg/CpuPageTableLib: Enable PAE paging Thread-Index: AQHZUaYV4ahg0LtspkqjsgpKqL1oFq77ZwsQgAA6naA= Date: Wed, 15 Mar 2023 09:49:47 +0000 Message-ID: References: <20230308100758.669-1-dun.tan@intel.com> <20230308100758.669-12-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|DM8PR11MB5574:EE_ x-ms-office365-filtering-correlation-id: 14137b25-6a1c-41cb-0980-08db253a9cc0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JFWclCx1mPpeic17VQgkfpruXzed4J+648p/233lmiAnZZixp6/b6I9mUUSvJBHNId7IrwnCaV6NMF4vFrzU+AmcN2s43otD7zqyPGdMN66/X3IdRGeEm0kxKb9FauocJZZ9oaUdUZ57yTjaHhaKmhf4kSS1dAX0xpvTMTKIC7a4P4YBTwdOXgnMFr44/93TObj66/kVs51J1LNnaruYvX3dlTJalkJ/lY5m9IMycueEfg4q0i/dxjnT6wikdsVbkOuXuTkzG7sgbhAYrYYv9wjPXzEYGaeMvj9trUtLK8dfMFnJEFx8+gXCkHSC11+7Vyd1ui3bi+Uu/uLQWnBhpkkp3Li2C9Liog9raqkzh9JwGAM4QUZeXOySsLLN5p0milwqGB57HHRWvjD5EGUJFOWIqLoBEiJt48uwGhLBJKEnMk3Vj/pC7Tqrxivf/zEC5AoEBlBxctpRjrtBIlaEZTPEGjMRZUKnrFSPPkjOFyi+Ilypmq6cHlub5VlvCQI/xCAhztDS0Ywwhc+Vx6NLBH339/3RxS+nD3knZBwnjeZQ0ihO9Pk5WKLrNbTDVcrEik8LMtOUgf278TbnysqmF0yx1GZ3C86kqxe1OJBXfMxwp1W00B/2St4NuOZn4XNbFmcWw1VSzIY0hGh31mm4tNCwLyOrpZhG94x4kkk0ZyCZH30HrLTZcwUSQYtj7UHt9v4O1kVYLcvOd92CPQKPfQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(396003)(39860400002)(136003)(346002)(451199018)(5660300002)(4744005)(83380400001)(478600001)(7696005)(53546011)(71200400001)(9686003)(6506007)(26005)(186003)(66446008)(38070700005)(76116006)(66556008)(52536014)(66946007)(55016003)(64756008)(33656002)(41300700001)(4326008)(8936002)(66476007)(86362001)(54906003)(110136005)(316002)(38100700002)(19627235002)(82960400001)(122000001)(2906002)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?M1RLwvmK/dWzpGrwnpqwLSr0UB3oYMyhFd2eRwWXJLb8CxopPz+fRvYJZmQf?= =?us-ascii?Q?E2ZUdHK/VDu00VsZpjIHsDP8xCHHivjmTSwzifsfyT66b4eLQHBaeqkYLtHp?= =?us-ascii?Q?HKjVVA/PZ0dDAvi29RnIhwFW0PQAxDDmSf13MkIVqMNs81mfd2bdDREOWYOA?= =?us-ascii?Q?RDGyPT5KMYS/06gIuexMyz/IVvkXxHawOYoti90LTX9I7wJ7qRUsWXjr/QE0?= =?us-ascii?Q?u1MpQFcpHGevYZMifP7AGXQSG+/wDV+qftwtCTTqVqtGJZPv5BNdEHT/1od2?= =?us-ascii?Q?b9OTpBHBzmUyVzdm5U1fnmpZLXyHUw1eIV4Xxkhs+g2tdJuBRuX3vKXr3h9+?= =?us-ascii?Q?WqrvVT3Hsi3EN05hkAYJHvsRQwm81nYGEdFZ3siRHNPa2gmBsDGu1jz9OczP?= =?us-ascii?Q?AhUSvlIb8Ac0ctOz62efX5ya6zG6+lgQeOB/svp809JDtR62UrqnIvMeRF2S?= =?us-ascii?Q?g14alcM6kxt3YzH0TWHLreAGCh+jCI0pDy278fFKFM9uT/lzsloKHF4MnRnb?= =?us-ascii?Q?O0T1FwL8bnEdNxlNj1vXYF4YldifEJxg7KiILKavTQIsqfCAe6hovP31sr3a?= =?us-ascii?Q?nsZgn8Q7uTZWjFgt1d8qynUms+iGiw3YknoBfBFU8mnC13dAzSoCq2uc47D1?= =?us-ascii?Q?KVphfm5FdyYJo/54Q6gS+p3vEykJtt8a+xReOJWarxK28WfCLKGn8g7FLlD1?= =?us-ascii?Q?+gwQdMLlph+TYY7Pb1qNl0uencdyWw68islUU8wguCO9pqMeoPLpm0BySLmi?= =?us-ascii?Q?QVAv36jsEV+hFk4KqgmaWRzPM3KtnTZdnDA4XBxDxYywJEyoJCpIANkWaciB?= =?us-ascii?Q?dvHzErB9yUIlVu3Im9ONu+E6ta5CoNCWhyypudzcPLO0h3tqBIFSsODGWZuX?= =?us-ascii?Q?ujws/kyQqYgjKLyKKnDrn0ps49P5zGfTDNS89cWY5nQdU651LtynTECTTEwr?= =?us-ascii?Q?e4GZptlgxY5YN+sFSkwrCwc01uhK2GEZ3xqO5v1YAr1bfONrGFQwdcG7HbPA?= =?us-ascii?Q?somG6E8FO01/1rELr8scWUiiQOcTdqJFntP9cNVOeyaVnP4vC+ePCY1/2ej/?= =?us-ascii?Q?cTcgoVj0sLRodrL3NhRWia/UegXQR2NjQhpRSdCxECK9gCLad4TYLwDTFenZ?= =?us-ascii?Q?anGajTyen9UuEi0LWPazRx2WDROEGz2opYdgPDV54i6Sh2RrDUBrjE5WquX4?= =?us-ascii?Q?Kp5nULdSd9WW4glQ68GRnHtyu/K1njHcF7UVCbPTNIXHcq/GMj7q2ADfZoZU?= =?us-ascii?Q?TzamLdf3s0fF9hO/qi1uB+KoajynYC4grdHpTz/aNQg3pHZmozL969qLmDoB?= =?us-ascii?Q?N6+nUvw7FGyPrAjf92tSELwlYHqO/No3iQoMaZRKQ5IEb3v4vnoK4GYFp5pW?= =?us-ascii?Q?0xVcUMJ3/Az2wLGyp2gBdrGkFFCT6p7/TifPbxTf80LcCdntRSUG8h9VGepc?= =?us-ascii?Q?dXlhl+oBrQxyrZxJk+Bq396Yn64qKeFMD0zkEDyZBi2dFixODdBR5qWx/cxW?= =?us-ascii?Q?su7949cqOMcg9WYr6WTAuLpC5DW+29fAebJx/iXPKqEUHx9/Q+EYq+XmccdJ?= =?us-ascii?Q?e26qOZWmF0g2EnhJvk35Uaig0Fh2un/YzcSKHabl?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14137b25-6a1c-41cb-0980-08db253a9cc0 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2023 09:49:47.0594 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gECN/w6bHJU+nd1XvzKWKI4v2a5l3neVPGnAYZk3tZiSGOx6ZDTxVtyXuO9+LT+ukGqoCTZ0tCSittmmKRj4yg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5574 Return-Path: dun.tan@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I'll add more comments and modify the code to set 4 PDPTE entries. Also wil= l add unit test code check the MustBeZero fields for PAE paging. Thanks for the comments. Thanks, Dun -----Original Message----- From: Ni, Ray =20 Sent: Wednesday, March 15, 2023 2:24 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Dong, Eric ; Kumar, Rahul R ; Gerd Hoffmann Subject: RE: [Patch V2 11/14] UefiCpuPkg/CpuPageTableLib: Enable PAE paging > + if (PagingMode =3D=3D PagingPae) { > + // > + // These fields of PAE paging PDPTE should be 0 according to SDM. > + // 1. can you update comments to explain such as: "These fields are treated as ReadWrite, .... by the common map logic. So th= ey might be set to 1." > + TopPagingEntry.PdptePae.Bits.MustBeZero =3D 0; > + TopPagingEntry.PdptePae.Bits.MustBeZero2 =3D 0; 2. Above code sets the CR3 value. You should update the 4 PDPTE entries.