From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web08.14594.1664909270544647706 for ; Tue, 04 Oct 2022 11:47:51 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=OqgjgIRz; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: chasel.chiu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664909270; x=1696445270; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=JJH3x9/tm5zuOXm6VJVvAZq+SDUk2hdUXbahHCrEUmA=; b=OqgjgIRzaGc1RH3Ch17S6LeZ9b7Et1d9DhCwhhaUQAU0S/+SKIj/+fcN 1rypQ6MerdVY//M/Prs2UjOL3V/Pbsg0Fy1xQQUpUo9uB6QaBeOPXER5T TtJMoL1tYX0EhVkh3ViAmKbZmMxpHiwtR1x0iECl6NH/xwnO/ril4jXiG ohxtRU7qQLxGpMOJ0O10hju33cQTFpU7JQk8YAArnUaZbhG8r//ta1UrU EQOWtktySLloHIF0VNUWtXSst3pG22Z9dwitXkhwXu41tpIDpOiBAnl34 c2kysXP67FDkgWsfRgqx3YJAhdcJZv8NgQb5kNpZiS+NCNvoasl8TzSOb g==; X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="304565756" X-IronPort-AV: E=Sophos;i="5.95,158,1661842800"; d="scan'208";a="304565756" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 11:47:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="952888025" X-IronPort-AV: E=Sophos;i="5.95,158,1661842800"; d="scan'208";a="952888025" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 04 Oct 2022 11:47:49 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 4 Oct 2022 11:47:48 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 4 Oct 2022 11:47:48 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.42) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 4 Oct 2022 11:47:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q5dbsuG0D3O6zwYbc8v5jfc/5rdpaMb56OayK9qIQe25QFQrKaUOLtZLf9TiO+fDuPIZdyEh0WqTchCOb08OdMF602Crtr7uWNNFvjqms/cmdKmu882WH7/IlkpF9my8ETyvzuGPnfHtZdEhLO8acCzuLInAbHICu0cLD+sWyWW6xWZJp64iBiffbrsRyf4wa2Pk2xG/KrQ6iViv9dvFcwzcpw54RqlV4ROzwFFO2q9o2BtGVeW+YrPxVKEYNAkFpTVrF9XtnwGO5MGl0lHR8CG41vyAEFtoUH+vALwJPkxyvB8ezwCymHRNIfwaG/QRKrSgncCBIQ+zQfQGHYELqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bJ4o2DqXX1QLS8P2Nk38PjF2txzvlojpOxlsGK7I5ck=; b=D/bi8rhfQ1VXUpfeaKmODEhgHbSubJhkBPUHVSaThnRnBYm4r/vgNnP+4oKIzDJgLDyEDCiqMJP2GK/Uw0UEMFn/Gj26LB13PxDAEprBjS/nJqp+VaguMeeA0dDYWPx0iFPISysb/xeoHDlOkaUzjiDc8BVzZq4mnS6GWCZTBaMUxNpnVylXSYsc6fZc5qTqeSYAChJGc/AfYsTfXQaknQYtredA49V+jSdo4zC8zBVMTjvs/Itn98+/LLAfap8A+2pFW2OZ/29gxP6ETtE/k/WepUalhCGCs7H8H3hSzwfXjUTG3AWMRShcjpSCVFwqBCLo5MLtvmnGXDu//Hfh1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by MW4PR11MB6862.namprd11.prod.outlook.com (2603:10b6:303:220::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Tue, 4 Oct 2022 18:47:44 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::74ca:2692:fcb:1664]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::74ca:2692:fcb:1664%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022 18:47:44 +0000 From: "Chiu, Chasel" To: "Chen, Aryeh" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Oram, Isaac W" , "Sinha, Ankit" , "Gao, Liming" , "Dong, Eric" Subject: Re: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl Thread-Topic: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl Thread-Index: AQHYxmcFHEAGragviEuH1CLT+nwJ5a3+tqpQ Date: Tue, 4 Oct 2022 18:47:43 +0000 Message-ID: References: <20220912051745.1539-1-aryeh.chen@intel.com> In-Reply-To: <20220912051745.1539-1-aryeh.chen@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|MW4PR11MB6862:EE_ x-ms-office365-filtering-correlation-id: 10137b01-5026-40ad-6a5c-08daa638ec5f x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 35OwaM+R3y3VxzvH/v2HEzPaEsY+beG8hHz7kYrHjq1SBg1VRqkmch9EIXBD0lwdFooLkf6sIMEq9Il9jlckXH/xg1UpoPX0v4JEJd7ZJmV3Qu8iMjLaTUAjM8dcmxxFx76vMc9i/XQ6DBJk9sU3fPJM14VgStDALMpHeaCK/WDTWE9p0bFtWxdIOJe3s4KQT0R0mXXSGMvHJXHIjNyPdI0XKijXMR4glc6PQhxN2zRVHpZmQpjQpdZHHjRcm76/h+xF3Dleb19tPl9AbN4EiB607by40ISlOpFWs0DPp7McOmtlOVyWkutIQI3O1ws2VgYYrUZ5OJiwQducZMql/ovndRmAcqwhVsH7G/rlHELtYBIodSTcGg0pa6w1uAJPWLXOajJRkmKEpBDiPhnkJQCwZF3UXqhwmUVOBGnRqq37ctRWkWVsce1b4+dc9PLeel3fC4rMaqTrz71TOGczvFPKsdlEtxsa4St9WXCCjekb4+VeAc00+BCNFN/KYsVqdXfCWYCguxsmx21ArYhvnl0n4+gtsrLRiTGXEpdYAWqHrwVT+sBrrVOuK0UwkSwS5o18uc3BvjsHuLUl7uHis9jeH7eOUNHKH8TI7oZ3elScPqNBhhN2/0u8N6Kv8ZPACVkDBu4fvyCV2F83ORA42A2ppip95wotAFTGsLvOIRPC5pqJBGKkP9PYNwrtBahamJmJuKL1aH8mLxlE/svv2+eT7Pin52Pq6qJzuS1awyBlqPlzSoJnUu+D6If9ZBAhJPG2RlcRQ1yI/+UdW7je1fAw7G0OVVfjSdC3d9jYspn6RuOzi4SVa5DUse4DZXMsQ1eFM9TueYc1lDeQIYIfgw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(376002)(366004)(136003)(39860400002)(346002)(451199015)(7696005)(33656002)(82960400001)(55016003)(316002)(38070700005)(76116006)(86362001)(54906003)(4326008)(110136005)(122000001)(71200400001)(38100700002)(8676002)(66946007)(52536014)(66556008)(66446008)(66476007)(2906002)(64756008)(41300700001)(5660300002)(8936002)(186003)(107886003)(966005)(83380400001)(6506007)(9686003)(53546011)(26005)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?l8FNMtWuXk38CREWHGX1w2L3hQ6KNSmaTVYgkGcmuLVNmmm5mCQbTxoe8J3V?= =?us-ascii?Q?OYc/27NWKuJue/ZsGtnx31qjTZkTdGU/DYuhEC0pk7BCfpoMqYSjBA7K+kkV?= =?us-ascii?Q?8Ges9xgfSX6OivyVmoYLaNAS+J7SV2RN8mGLVE4XTGOTKQOw/edqui2mUIoA?= =?us-ascii?Q?xFDYiyByLlOEA3VX3zhyp4rpIWAUTmobKbYttnnoIy85nsEddk3x2C8HiZ7Z?= =?us-ascii?Q?fpz1DeonxdS7iy++9iFJk0Sk1jZXveEFzdelZ/euZimL6qtLB3+vhq85GRg2?= =?us-ascii?Q?gdqW1vIt9NEfAmLC160ITHag7FSLMpKdX5epS/0OlrmObEM5L4cjEmRqluKo?= =?us-ascii?Q?XSlgdrosM2PcuD9b9sKFA25uet3SxdTdFI5YZeKDE5QCoJ9rAdyrqxqNX2sG?= =?us-ascii?Q?XnZjekFsLwy0hA18VSPU+97D3xNVRsGpJsGXhS4sthRXgOkPCZYIrOVsbR6h?= =?us-ascii?Q?NmYzeHdew7R5Te0tmZ6ULUxQ13tAXbdg7yR/saxJnNMVrBb8I9oa8yHI/xav?= =?us-ascii?Q?W2hvrxAnb34ikSapaWDJMswSnrpif8wXLIZio5Dlz9jE0tY8Ff9FX705rcBw?= =?us-ascii?Q?tKnMOJINQfVCxQBO22GuchnisclZb0OhtFVJiXhaFI80rperR2EnxikKt2YD?= =?us-ascii?Q?IgRQmXLaPvVk2T9AREB8O6WQl04r+9AaZ2MfuMMp+aKCdP73MpwR7wlQtZ6B?= =?us-ascii?Q?w/+t9Oihe4rsOuDnBdh0XmELbWDY7qFXYVfC6XERyFEr7uy72FadMiGy3bxr?= =?us-ascii?Q?1869PbuMK4PaSXk8CeHkaWnYmPH30Vt/lPR2uE/NJ5wZ60Sygmihv/SR1VJP?= =?us-ascii?Q?ePGX0k7YYEY4woSEshYRHdWYMtFYXrvhFdOPbeG5kYsUL8hHxr+zX91lkR9V?= =?us-ascii?Q?HexmPtSIoUziFoKy4MW/QN//CElrBYjSk1Sr2Cq0sDb3q4NolAZYqvBelJRU?= =?us-ascii?Q?IePqoxnGAUmDe/wa80bfeSzSYx380pY6fPS/o67DOLF5bIYH+xW5yEEQloVd?= =?us-ascii?Q?/Cn21Q2/RriNN2/lspxVE5Z1N24nvtclL9vWOUB8MwGJFa6kR7i2kuNu0noW?= =?us-ascii?Q?7Y49S1HOZQFjikaQX2nq1POhZp/lgPF6x2ozGxGC54vJASZxM0nVjOmV8KKH?= =?us-ascii?Q?PgOjEwI/Uu0tAT4yHSCi75zq2yeq3eE6rRmpI5Ls44caM/wXpXTDQ9VRAeEF?= =?us-ascii?Q?5+Tu4ou6fGA8rDrZEOeqcMbasKrSZu2xloAfpjQncBUYWms8sccsh3hO9Tuq?= =?us-ascii?Q?AwsjrhoPzjUpUHypvcrWbefgC9sMaJG8IyNEDojfeSeQgHyUEPYhIwVfuLUd?= =?us-ascii?Q?xiZueu/0P+AlNJGwSRRewXi54pnzaR/aZc//IcJD3Je73EHWW1eyB2HCLzZf?= =?us-ascii?Q?j/8TmU2d4bMaMKD9YIauUah/+UKiJafFLjAr5QX+kZVUaqd3JodoX0ls/ktU?= =?us-ascii?Q?yHi+9s/cQO/YogKryQeTg9UEhuHTKzx/YlIV5+sLQtbWZlvlRNxcYsobYEsw?= =?us-ascii?Q?zMOJIgNR1FQSK5qdtuNoS208cU4ByJzYbtzYPXwPcKXVKVxztFIdP06iserA?= =?us-ascii?Q?kT47+WlQFvIBC+NVv6tCovc+otkKayp8iwLeC7op?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10137b01-5026-40ad-6a5c-08daa638ec5f X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2022 18:47:43.9776 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yDpUp7vTO/CUaAqFVST8dUkAlsZave+i8kcUx5PZUcuvO2KeYnYhRpefnMcQ6ccoeAg6jS7aDe3iRibRSgNhjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6862 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Patch has been merged: https://github.com/tianocore/edk2-platforms/commit/ae75c51f27e21036b6ee021a= 2d5b9f365f951413 Thanks, Chasel > -----Original Message----- > From: Chen, Aryeh > Sent: Sunday, September 11, 2022 10:18 PM > To: devel@edk2.groups.io > Cc: Chen, Aryeh ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Oram, Isaac W ; > Sinha, Ankit ; Gao, Liming > ; Dong, Eric > Subject: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl >=20 > From: Aryeh Chen >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4057 >=20 > According to ASL Coding Guidelines - Device Identifiers "A Device should = contain > either an _ADR or a _HID object, never both." > , so remove _ADR due to _HID exist. >=20 > Signed-off-by: Aryeh Chen > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Isaac Oram > Cc: Ankit Sinha > Cc: Liming Gao > Cc: Eric Dong > --- > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > index 0d94472450..4efb8709ac 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl > @@ -27,7 +27,6 @@ DefinitionBlock ( > Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2= host > hierarchy Name(_CID, EISAID("PNP0A03")) // To support legacy OS tha= t > doesn't understand the new HID Name(_SEG, 0)- Name(_ADR, 0x000= 00000) > Method(^BN00, 0){ return(0x0000) } // Returns default Bus number for Pee= r PCI > busses. Name can be overriden with control method placed directly under > Device scope Method(_BBN, 0){ return(BN00()) } // Bus number, optio= nal for > the Root PCI Bus Name(_UID, 0x0000) // Unique Bus ID, optional-- > 2.26.2.windows.1