From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.2285.1678844718209696485 for ; Tue, 14 Mar 2023 18:45:18 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=BhA9jLQf; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678844718; x=1710380718; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=lRz8qtYuF58rmYgB5etOkAsQoCmPAkkeNeGpjZB/7WI=; b=BhA9jLQfseNasXUrBfu/zrRNWJT0yfDszqxw6uFV+QKVsU7+fsw4U6pX uhPV23ZcMMmJ6H7CzFx64BUdX/19bYs5JOyIbF8fuxf1RuK9p3IA4QJsO Ed7v7TXK3YfiWTHDg3Pqm2gUiqi9upF7oLJLK7CbicuRHSi9KsY2pSx/4 O/5icxe0SNOfHJZ0cievoWxMQ4ZDvLy3Fxw/evpPtbbZeMUkQ3wYHamhT YD4b4bj63Fog6U0OUxi34uUneVYKm5/19qFftFCpnf2eDEBOsxkAgjagG ZD+uVrh6TSbL2ekJHo3ikUR/p+riVkw8OoaozoEVV74IG69FaqprX/4xG w==; X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="339127716" X-IronPort-AV: E=Sophos;i="5.98,261,1673942400"; d="scan'208";a="339127716" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2023 18:45:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="709507673" X-IronPort-AV: E=Sophos;i="5.98,261,1673942400"; d="scan'208";a="709507673" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP; 14 Mar 2023 18:45:17 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 14 Mar 2023 18:45:17 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 14 Mar 2023 18:45:17 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 14 Mar 2023 18:45:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iEE4QAYTi6UQqzRDsyAIaOdkugFEBlNkiHjZ/TQ1GWQiwlyVr0YFk/dQwdKjvJrifDdVK/H5EnRm5SN/LGsNDerOYPJs4OqQSbQlPz+XUyrLGpfwQTrC3XLFdS10IkWP/DPAHgQTggeJp8g7Oehc+d6BTRe+h4H9qdXbfFwwYitll9o/NOuVWSIfN/LpdTKFjlvgJnayc+utsj6Ob9G1GB5jD9RqI34pS3EwcknULa2Mp54AXv4DXJKeyJcYE8xkkfSO108yNoOZqmrwh4nVlpkGKEHs1Ojjp3DSiZDufZkSJE84T7AxpYCdq4Csrw8xrBvpwddqcaUpyXDBN5iP7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1+jAJLa3TUJQTvRYpLncS0/7igLh4osSFI+3EdbOPZQ=; b=V30Fr3zSahMfM5hGeDaY90smRBLBCWSGvGttOWUAafv0v2lUb1iRg+t5zIVh7IrAe1O7dvojhJMbbbSLDHnmsi/2GSiZFbTqAQp9UbiryD8FUP8wwd17dtASFOWPhGSlac1JEIg1KMZmTW46kXCFrHotWDhhj2Y+K1HQGAM5jrfju6PCuAmdy5SuEAB0AaxHUYS8xwRRbaej/9KuIdvOOGznoX6LAi39AymWHWL88c3NEKtKAaEQB+TUosaH3w3RkKNfSpHNj/kvfQQ0UC5m8+st4GT6GjcDOEktE+tXd2aWUP0u9bHZBASuBmQCe/c7Wo7Rqv+CEyA1RlQeqQGvXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by DM4PR11MB5421.namprd11.prod.outlook.com (2603:10b6:5:398::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.26; Wed, 15 Mar 2023 01:45:11 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::af70:de56:4a6f:b2cc]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::af70:de56:4a6f:b2cc%8]) with mapi id 15.20.6178.029; Wed, 15 Mar 2023 01:45:11 +0000 From: "duntan" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [Patch V2 01/14] UefiCpuPkg/CpuPageTableLib: Remove unneeded 'if' condition Thread-Topic: [Patch V2 01/14] UefiCpuPkg/CpuPageTableLib: Remove unneeded 'if' condition Thread-Index: AQHZUaXz29B2S55VIUW1qsjLO7egQa77FkCwgAAF0PA= Date: Wed, 15 Mar 2023 01:45:10 +0000 Message-ID: References: <20230308100758.669-1-dun.tan@intel.com> <20230308100758.669-2-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|DM4PR11MB5421:EE_ x-ms-office365-filtering-correlation-id: 5bec2183-936f-48cb-4f23-08db24f6ea00 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nWPhawb/T+wMM+sPFXoOCpy5U3styiGQp/arjlCE6SX2DbjfJqhRUTrG4wuVTIB6erKOhORFRPROBmhWqzaYir+sZt3aZ0mR66yY9rx9lppxQwUCsAwNbkVN/KYy7v2VjoMW6jjN+a0I6SyvWcGkA0f+/QMil7RCgZ9CJ8Xmq9PJlvBosh1NraVr+loYVCPgSR9U01HVVLKqcHIwwzag6VNJl1nJgSuDcp6RoI8TEXpNLha9M+0GlN9gQSB1VC4c9T1LLW6j0ADo2t9GkN/jgcrYw2Vej7bDG7+io1+gb21ssewYE0S3JYt6YCREI/3Yatnc7Cw8f2vNvjq6Wm5V4d+gT2ZG0aH0lIVlqJLmr5AkF78ZdveNPBnm0YZsjzaKvP4dpt0NTl4EF7qtQDEnwdXCUmjOiCGyx9vPwNYmbjyQvJmp6H97VjjkYnCdZOQc908Ty+qnRXtgWT73zgrsYF/TTrwNFbQ0e9BS/SHAqkXZ0aP7tg0vM7B/PNxtnGDVyroP5rFrNwXEwA1yymP207LyNbPzgKGXkVrwosO5JzwgTv2W54QVnXyfNBjHxgUkV4GurTrvzGQJC+vWFtTlpVLpTpcNVGfGbm269GRI9IDzkwF7WS18qHhuPqLH4qYqKGElNuMMbaqI5snhvLNZQrUU/VJ4kQ88mdxolmSjphtfWoqWc4pCX7pUBH/UaqCFYXT2GuD1GrNUCOyKO0GefQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(376002)(346002)(366004)(39860400002)(136003)(451199018)(38100700002)(82960400001)(122000001)(66446008)(64756008)(4326008)(41300700001)(316002)(83380400001)(66556008)(66946007)(54906003)(110136005)(76116006)(8676002)(66476007)(38070700005)(52536014)(8936002)(5660300002)(71200400001)(7696005)(478600001)(86362001)(53546011)(6506007)(9686003)(26005)(55016003)(2906002)(186003)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?m4kHnfygxfuBmy5CL1pvEeaqvGu2jRk/bvetkjzHhmWH8YoFto9pc6fYaM18?= =?us-ascii?Q?pGAx7lwHAYsALZ/pbVzS/jm5G+Zi5oLhwoftKvuBws7/hFM2Erv+kaYBMeeR?= =?us-ascii?Q?SsEEW6kj3d3m9jyfEwwohlPM7rrXoD3HsjQFyapy0MfJ5nQTa56ne8s5Jhmb?= =?us-ascii?Q?LWAQ6fp3rjurkWL49MFLxK0FxpVc3kWH68ER+Kz+mkELDmCFWjXOlhhUv0T0?= =?us-ascii?Q?MV/03K+OVeBtm8mKULm5odYBm1FI39Lwvgd62q2sGe3rNQd6FAhbuz5kfqif?= =?us-ascii?Q?srHn7kT+aHy/KFNx7qoYKYA2U/jb0ZKo4hkIO1FU/f3dGuMppXyDAzRZK9vU?= =?us-ascii?Q?6vShc5fnnknoPuUtcC7pN+ncQDEdG+0EHIijBJQtTHG/hgCe3spNyXCmSyzO?= =?us-ascii?Q?q4muq62oMTvpP914fikoBVgyXfGCmmypY/SPRgB5H2SiodIJ5kEyGGdFG5bl?= =?us-ascii?Q?4HkX4wCfDg3/jkGIl+bk756KIPcWhX9iZeh7mgGPNIWRvmoJp3ni62Oe0kgX?= =?us-ascii?Q?L71VsgpvUrSTujPmWzEl4EI0OqIR4BQBqd4/DaZr3W1o2D3iwDJ7z0L5ocvN?= =?us-ascii?Q?GnjyKhNBV7Oin11Qx8gaiP8IMAedtHfu6WIkUf97KAarcFaLBO6TuTuSi00Q?= =?us-ascii?Q?5NqjjBhs8Lewz2NB4zNZPQ/3wm/RhmTvXEYL7qJVvD7oBxo1BYMYlu6tnb8V?= =?us-ascii?Q?aBx3wM7uDDNIn2W1oaTwP02qQhE71L6wkFeV0I9LGNf/NtSgJOZJgUnsr0re?= =?us-ascii?Q?Xg0EJ1lhjl5muprKV7UDj/aXcrIl4Fg5vTW/TwZXpcd2qr/XDLvuLKbHH8j5?= =?us-ascii?Q?trYVFHDCyhC+GBmqlbfVvRd5mlvTKQS1yiV0Huxu6Nzhe3rtl33ZN02+SsmX?= =?us-ascii?Q?AuG/FHsBedEWTKPw6raijhaLZ4FrOYbJMo5W+iNk94s1p2WeLqeMceBXGB0R?= =?us-ascii?Q?z3I22rXDjS+Y6j85jE+CCCBn7s+Ei1MFtbkvIfAwtvVXkI503Nr0nAZT47RE?= =?us-ascii?Q?HzYaWTVGbUmgPo/PD/UmKayb1uw2XBZskNqMB00o3mbWI1TFNl0MyGEGiJlL?= =?us-ascii?Q?nVRFyJfHPNbB+YaWmPcS39NQQt8ko8LQzuUUvyUzZ5QhGJgUx8lf2gKJnqKr?= =?us-ascii?Q?YPTwJ2ArihXmK0Zjk3odVz6uRNHxvrkr5wZPmqj/DoZMycClqQVIhTpvCs2F?= =?us-ascii?Q?yjpl7PLSZAKPRMV4fELwuhlRD0oNsoAFsH8ylAn2My2U88ubdzfImOgQAifz?= =?us-ascii?Q?mEPQNfaDSjy/EIhase90JxpUAuM4P3AoeHhY6ydKQQ7fuTAWN+XvI8MtKsBZ?= =?us-ascii?Q?XK3vwGXQ1rYZs2ns1lN1fBg91M9GlPU8N9b8cj4Elgz1Kc2LUCuDjEkh5kfC?= =?us-ascii?Q?7E1+NNhv2TdoP959okK/MuMisnReDZO/Tv0kPwm5E+Sfu59o3tbcx5kHA1L5?= =?us-ascii?Q?ehuDswNhzug7X4n59i3RHGOelLmyQ/CCCZVX3uem1EN8Y+hc6K/FfGDEA7KW?= =?us-ascii?Q?sAX4N78oJNSyU/pNYsCFPAG/+dMZ6OwGOnFQg3vfsgGdmAMjOnKVelDtBC/T?= =?us-ascii?Q?Mogso4QHLVGuV+VjtH2Ek/Z3o11b3Co5KoVCC7FM?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bec2183-936f-48cb-4f23-08db24f6ea00 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2023 01:45:10.9188 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M/Ycuj3sQY8wMsw8V7b+gtAuxpEwgnP0h7ZMLlW2IcFozF+QFNDqTFHhPpl5TQEb4xBO2VlHm/xeJScUNT97DA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5421 Return-Path: dun.tan@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Ray. Will update the copy right year in next version patch. Thanks, Dun -----Original Message----- From: Ni, Ray =20 Sent: Wednesday, March 15, 2023 9:24 AM To: Tan, Dun ; devel@edk2.groups.io Cc: Dong, Eric ; Kumar, Rahul R ; Gerd Hoffmann Subject: RE: [Patch V2 01/14] UefiCpuPkg/CpuPageTableLib: Remove unneeded '= if' condition You can carry my Reviewed-by in next version if you add the copy right year= change. > -----Original Message----- > From: Tan, Dun > Sent: Wednesday, March 8, 2023 6:08 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ;=20 > Kumar, Rahul R ; Gerd Hoffmann=20 > > Subject: [Patch V2 01/14] UefiCpuPkg/CpuPageTableLib: Remove unneeded=20 > 'if' condition >=20 > Remove unneeded 'if' condition in CpuPageTableLib code. > The deleted code is in the code branch for present non-leaf parent=20 > entry. So the 'if' check for (ParentPagingEntry->Pnle.Bits.Present > =3D=3D 0) is always FALSE. >=20 > Signed-off-by: Dun Tan > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > --- > UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c | 9 --------- > 1 file changed, 9 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > index 37713ec659..47027917d9 100644 > --- a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > +++ b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > @@ -375,15 +375,6 @@ PageTableLibMapInLevel ( > // we need to change PDPTE[0].ReadWrite =3D 1 and let all= PDE[0- > 255].ReadWrite =3D 0 in this step. > // when PDPTE[0].Nx =3D 1 but caller wants to map [0-2MB] as N= x =3D 0 > (PDT[0].Nx =3D 0) > // we need to change PDPTE[0].Nx =3D 0 and let all PDE[0-= 255].Nx =3D 1 in > this step. > - if ((ParentPagingEntry->Pnle.Bits.Present =3D=3D 0) && (Mask->Bits.P= resent > =3D=3D 1) && (Attribute->Bits.Present =3D=3D 1)) { > - if (Modify) { > - ParentPagingEntry->Pnle.Bits.Present =3D 1; > - } > - > - ChildAttribute.Bits.Present =3D 0; > - ChildMask.Bits.Present =3D 1; > - } > - > if ((ParentPagingEntry->Pnle.Bits.ReadWrite =3D=3D 0) && (Mask- > >Bits.ReadWrite =3D=3D 1) && (Attribute->Bits.ReadWrite =3D=3D 1)) { > if (Modify) { > ParentPagingEntry->Pnle.Bits.ReadWrite =3D 1; > -- > 2.31.1.windows.1