From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.4666.1685677389215613339 for ; Thu, 01 Jun 2023 20:43:09 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=buLq4rbU; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685677389; x=1717213389; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=TgDalPkaT1HqCqDyyAejIM6nyb6b3ASpSLaMPIHKTr4=; b=buLq4rbUHJiA2NiMT77C9KRkKcCGx8N1fJeMd3ozQjOzi1F88nVymDbe MBC7PLN/Aq0s7CFnXAlnXRT7RVA96dzkUrqAlwIc8V4SS9IbqMrmzvawp jSNa+X4wDi4SG8hJGLcTLnINUyVEYFakBrWwUTIdMdE8JbY/EwUN8C3nC CCDi3h6PKU9xprMsFsF3Nq5vn1GC9fNTCWw4xtD9MbO8YVhYLnwgG6nv0 3SGq1gzvWq29p6OKHb/YC8Q7BB3ZUGFt8a+YNvQGx0vDxR1zooCdS5y7o 88UrJoyEkaZfABmXsD07f7A+UcsTrsfLDvDcvDcWQ83Y6OEmRULbphrc2 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10728"; a="345332055" X-IronPort-AV: E=Sophos;i="6.00,211,1681196400"; d="scan'208";a="345332055" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2023 20:43:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10728"; a="772711960" X-IronPort-AV: E=Sophos;i="6.00,211,1681196400"; d="scan'208";a="772711960" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 01 Jun 2023 20:43:08 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 1 Jun 2023 20:43:07 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 1 Jun 2023 20:43:07 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 1 Jun 2023 20:43:07 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 1 Jun 2023 20:43:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NJzfRAPTsQgJqpNHSvquKnvSSFGeK8tAheiWO428PU/RlN4h+GwolBpNQ19OM6zeFxd3EmfGuosq5iInfuzu6p08sVysx+r+PnuFcclqOwwV8+mW1zHHZH4NpCfRwROG0r5RcKgj8r9gcf+l6Q+sdKoVh9M4l7jRxzXWQncsCTue0ZZnzglxLSL2DITbvQZ6MSvOvVf5A75Z23qbuynqV0XxjkjRl4ypnhE6pSa/NvowWzovWHJp9J6ggj6qwcYt1HPv8mxv09TcDYRenoz7kzTe8alDryupXCENAGC6as0F5noTWOWsQ4sdrU95n93X+flOIVnpX5nnORzyvYR/3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZIJU+AzWX5VF+oHgf3pO718zAKevzEbKIfsg8Q1dkxk=; b=WrksDjWf0ogHrZ6NcDwOmvXgJ7q7eWkmtmMmqBgo08xDZaQBz8L4jQ0OSYaHTeM2CCcZ1u02wdxftP29TuDHgNVjaqviO3lAybzSg8l70KXKl5fwvzHH3exgEgP+lFm036clPF/4vDrK5HGYZXMGferxHvBpJ+HLo8CzkH75JRSRWx1nJSjxWyLUU7Bm6L/92CV10HLP+RPseZo18kQ7o+AuCCnzwRDpim30nE7X4CcJVPQRfl6XhWh6u9QVZOMKNHI9ReMFlnOA4vYosEy5crCO6HY/JXXUVB4EeaMyfLNjFunq+ipQI8lKK3FHpdQwqLITzZh3jetevJzVi/Egcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by IA1PR11MB7679.namprd11.prod.outlook.com (2603:10b6:208:3f1::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.24; Fri, 2 Jun 2023 03:43:05 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::3023:34d3:bd4e:7901]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::3023:34d3:bd4e:7901%3]) with mapi id 15.20.6455.024; Fri, 2 Jun 2023 03:43:05 +0000 From: "duntan" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [edk2-devel] [Patch V4 12/15] UefiCpuPkg: Sort mSmmCpuSmramRanges in FindSmramInfo Thread-Topic: [edk2-devel] [Patch V4 12/15] UefiCpuPkg: Sort mSmmCpuSmramRanges in FindSmramInfo Thread-Index: AQHZlQMA68f1CPyQSEqlH9usk1U3pq923n/A Date: Fri, 2 Jun 2023 03:43:05 +0000 Message-ID: References: <20230516095932.1525-1-dun.tan@intel.com> <20230516095932.1525-13-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|IA1PR11MB7679:EE_ x-ms-office365-filtering-correlation-id: 2a2a09ec-2c34-4035-8401-08db631b796a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZzyqMnA/kJK3GmvxqTsktCTt+aY5CceU3Q/7EbfI6seNc5+hRMVB6j0Gm5MSv4RXD/RP6TvBW5+QnvSHdN+z6uE9K0ye7LwQ25bhKpG2HyWqGwgWSIgLZM7Mte4ezXQ/cH/1V8yQphqwuXV9lqW85pd299RkrTLi8H6RXFy82kY+sMNUv5oQgbX2HyDwl0hqg0/hzt5AEYUSjjORNoVs6GxGH4lydCa9xEf3oByOOzuhE3QNETBANvOqW3FEgqKk9xfLflHTSVTshX72W1ZHJnCWlTOfbHfkDN1TBlqqEo4jsf2LTi1z1tkPOziw/ONsiTOVHHRNtDjWqIXDQhJwQvlnBTmHz/qPOVvSbWlPpmTuezlNIW/n5unUtZ5D7XMur9jo3WbDAXCeXj6YuXYLrqAK/YOCECpemLXq7d26tTX8U8pZw521VhseCY2f8ixl12bOvmEzvr6krEHrdinFhhozXfhZgEOu8k3X3TNFE8QzsOK0m+UBlSx5Bf5+sE/241Yjpu4bGrJgG6jCadr2s3bb0lmU3vxEkKRoTpNjn7sdVt7v+ww4Lv0Vtr247oCeg1vV+7gaEfJuJLXxjjjMbomC/tBf7qQAeXbeSQ9ZxoCJMVw48n+atHQflqUz7BUwnlMRduO38shXAw5CVZHTUA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(396003)(366004)(346002)(136003)(39860400002)(451199021)(52536014)(4744005)(66446008)(2906002)(41300700001)(316002)(76116006)(4326008)(8676002)(66556008)(66946007)(66476007)(54906003)(110136005)(64756008)(8936002)(5660300002)(7696005)(55016003)(186003)(83380400001)(6506007)(53546011)(26005)(9686003)(86362001)(38070700005)(478600001)(71200400001)(33656002)(122000001)(38100700002)(82960400001)(145543001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WpWchNPdZBY0ccYZXcfrtELYE4b+9GW4ZTnsBC+njgvjY2+SlCiNz8PwDK8m?= =?us-ascii?Q?fZy6F0cDRxj2fHPHXe8SUNd/QsuvzIjErB0UI8TwvETypcAP5FYoyfjFf8yy?= =?us-ascii?Q?oYtwx/pwpwjpWtjne8Tadvz6l4wUKii1YIc5+vl5Mlo7HHO1/bHxadcWCpXH?= =?us-ascii?Q?Mq/EAWQHS1uJgTHioq4h2WrLs+whin2mu/aFNLGcBZ5TeCHmXgd6nF7fA1Ka?= =?us-ascii?Q?3JavmgKhpju8JBj/QxtymimjF5y+CZFC5ME9DdZLwiQI5jpepV1BiiIxlPA5?= =?us-ascii?Q?rcq5BudwziWpcjynzh2EmTmi2VTObPP1GvXyNxD1TU+xJ8BqWJWOy7aukx7n?= =?us-ascii?Q?kuU2JbJry77q+YQePxbL+AhmarszRC/dF0aIS2zdv9Pss10lxqCgI7BHHUWX?= =?us-ascii?Q?Alblbdq52VdZ6OSpsGNVrgX5CH72d6GWOvA2Ovb1gDNwCSnd/pPMdBXo95OQ?= =?us-ascii?Q?dWxikewfLNr+6+Tw3lBYNxLntO+2xzZkkaiOzYJtxUL3k4I+g5nXUUqvyEt3?= =?us-ascii?Q?2bHGkR9wWHnP6H67eLAd2ZzwbOEfy5xrC/yziozplc8FT6/LNwqHQaAM9hux?= =?us-ascii?Q?NpKiXlNLgXXxGbo5oFJe63fqB0YsY9S56oQSMk8mG9/SMiQRh49HgIKW3HZx?= =?us-ascii?Q?77KwCv5Bs3mODHfxN77ShR+WBtZx9rlmsHEChlc1pMbIVkDAVZfFtYGaU92I?= =?us-ascii?Q?66ozCyBh6V7xN/ElX0vbwNrQMc974QifR8UBgEC9A83qphOsfmPyAk6YTCef?= =?us-ascii?Q?I6aK9DbCAPI9W39RlWwyfU86yqWMWnSs/WjBJepdYFaa+UksJ2DsLvEe7vr5?= =?us-ascii?Q?z7SRQz42BZEnbfy/m9MhHQ9a9K2MNuh9no1r8q7Cte5wnvMbpXKYi6JBEzD4?= =?us-ascii?Q?9/G1aUSs/Bs7FFCmt7AULVkjt4Eov6XUT8Mf3cbVHoU1NSkcyxoMCnGKUft5?= =?us-ascii?Q?fVXx+v6IsVsbVs/gVLdeaBt35RMXiLFpaDJ0eMop0K164QOeRWHQitK0vpfN?= =?us-ascii?Q?PPbO0E0KZoO03AeHBcBdjMhTTmCY/WZzurDyC5X57g6r/7ZiOD1iaNUlHl2S?= =?us-ascii?Q?5c+3tXusZyWFtCxfULbekD+hgJiTo7k2RySGpbx67peLI1yPMeguRXVbAIZW?= =?us-ascii?Q?mSzRjv6zOFrqrUa0JYEvD9QBrrzcn30NHOPWKgXOq5wKe9HQ9q9KiP8fHzAd?= =?us-ascii?Q?SolxcJqWiXzn8DCBetvk6HWvViaxD/oYC3F0TB5EjdLIlnK+RfHT+cPKkuUJ?= =?us-ascii?Q?7wAdFF/XunaeFWin+SRvr6w08AxHkPEorgbc72hQrcN1+GyKDJIMUeX0LPIO?= =?us-ascii?Q?VtB391rVCs5/OTn5d+T8xPvJxk2goplop3odBBReZPRruHFrgbYg6inYyIlo?= =?us-ascii?Q?Qe94akBSWxV4/nZaM2KjbhnQ0QyF9XdOlFDvKohpLc5W0qe3/+VMpph06Xcl?= =?us-ascii?Q?zUh+PxRD8vSszzg3gAuI55PXQS7zPt0q5R8JWCl1KJ3XxNbHXVvreu+KeAiX?= =?us-ascii?Q?/iHFBVa7BdjGS9IWhRJvb6LFmCjq0T6GHz/CPR0ecqyWLJ3qoAcn9d8OAnOZ?= =?us-ascii?Q?WLDSPmhn/ixDR3kShlc=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a2a09ec-2c34-4035-8401-08db631b796a X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2023 03:43:05.4980 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Hgr+Ezrdo+V07hPmAaY48nx+Q7SN/gMzFIkGWNdloRa3ak7cjEt8e1UG8/+pPgFv1QWsr/ThklE8vb4E5alaYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7679 Return-Path: dun.tan@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the comments. Will update the code in next version patch.=20 Thanks, Dun -----Original Message----- From: Ni, Ray =20 Sent: Friday, June 2, 2023 11:34 AM To: devel@edk2.groups.io; Tan, Dun Cc: Dong, Eric ; Kumar, Rahul R ; Gerd Hoffmann Subject: RE: [edk2-devel] [Patch V4 12/15] UefiCpuPkg: Sort mSmmCpuSmramRan= ges in FindSmramInfo > + Buffer =3D AllocateZeroPool (sizeof (EFI_SMRAM_DESCRIPTOR)); ASSERT=20 > + (Buffer !=3D NULL); You can define a local variable "EFI_SMRAM_DESCRIPTOR OneSmramDescriptor" = to avoid pool allocation.=20