From: "duntan" <dun.tan@intel.com>
To: "Ni, Ray" <ray.ni@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Eric" <eric.dong@intel.com>,
"Kumar, Rahul R" <rahul.r.kumar@intel.com>
Subject: Re: [Patch V2 2/3] UefiCpuPkg: Add Unit tests for PeiCpuExceptionHandlerLib
Date: Fri, 14 Oct 2022 06:16:55 +0000 [thread overview]
Message-ID: <BN9PR11MB5483DD4CC367D146AB5C4668E5249@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MWHPR11MB1631F1697061CE5D375765468C249@MWHPR11MB1631.namprd11.prod.outlook.com>
Yes, the commit message in PEIM patch is the same as the last patch.
I'll simply the commit message in this patch and rename the IA32 global variable.
Thanks,
Dun
-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Friday, October 14, 2022 1:54 PM
To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io
Cc: Dong, Eric <eric.dong@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>
Subject: RE: [Patch V2 2/3] UefiCpuPkg: Add Unit tests for PeiCpuExceptionHandlerLib
The commit message is the same as the last patch, right?
Maybe you could say:
The previous change adds unit test for DxeCpuExeptionHandlerLib in 64bit mode.
This change adds unit test for PeiCpuExceptionHandlerLib based on previous change.
It can run in both 32bit and 64bit modes.
> +extern GENERAL_REGISTER_IA32 mIa32ExpectedContextInHandler; extern
> +GENERAL_REGISTER_IA32 mIa32ActualContextAfterException;
Can you use the same variable name for IA32?
The variable name is the same but the structure definitions are different.
next prev parent reply other threads:[~2022-10-14 6:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 1:53 [Patch V2 0/3] Add Unit tests for Pei/DxeCpuExceptionHandlerLib duntan
2022-10-14 1:53 ` [Patch V2 1/3] UefiCpuPkg: Add Unit tests for DxeCpuExceptionHandlerLib duntan
2022-10-14 5:48 ` Ni, Ray
2022-10-14 6:17 ` duntan
2022-10-14 1:53 ` [Patch V2 2/3] UefiCpuPkg: Add Unit tests for PeiCpuExceptionHandlerLib duntan
2022-10-14 5:54 ` Ni, Ray
2022-10-14 6:16 ` duntan [this message]
2022-10-14 1:54 ` [Patch V2 3/3] UefiCpuPkg: Add Pei/DxeCpuExceptionHandlerLibUnitTest in dsc duntan
2022-10-14 5:54 ` Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB5483DD4CC367D146AB5C4668E5249@BN9PR11MB5483.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox