From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.4357.1665728222391728557 for ; Thu, 13 Oct 2022 23:17:04 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=NtpLUdsQ; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665728222; x=1697264222; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=kT1fKZAxV/Z+qxq+XXyBJrRuDCUeOtmIs//mNpv6oe0=; b=NtpLUdsQaAMMThgTas2NG7lI9arWRiqVMcTXImbm4IvJsCtBCd97yVz9 RAjrby9XNCb3J2AFEugUhvid2nobGYxUJ+js1Fn53MDJIavlErIb43MXO uC8KlJEu4yihVc8mt9XUrsDCvkSg1ypBdQ2kFLnJ2FAIY9L3EXkLnocyJ y6P28N5NPokb42jQF11I/n2cxlBIiIt9KKIpIf8D0Wq3Drh2n5mEEnvcF KNO7KtUhJ/49IJrRNj/ayIJuVL8nQmV28sMM1MQ9kPSUrjwxNY/3nbTTy pCxGNsEJ0zCUtJlZg+39cVMNeaBOcPnrVIX4WbZp3910E4uOz9Ccmw/J7 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="306373036" X-IronPort-AV: E=Sophos;i="5.95,182,1661842800"; d="scan'208";a="306373036" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2022 23:17:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="872624130" X-IronPort-AV: E=Sophos;i="5.95,182,1661842800"; d="scan'208";a="872624130" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga006.fm.intel.com with ESMTP; 13 Oct 2022 23:17:01 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 13 Oct 2022 23:17:01 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 13 Oct 2022 23:17:01 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 13 Oct 2022 23:16:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J8x4bkPL29NWkctDHVZSxe7tMdJ9iImJf4ELJu+Bn/JANqd+0HLyQ3UFOo+h2H0VC0+OjUi7j/txZV+pmrZah3JBb+7iKfJAHkpyCVoBnZF9YtKiGBEfKw6feA6SKg5alLn2eyWf1Q4dcX641NXPDT3xv63nMKujAJedxRj2/IJFJxleTa4Q7xBaJEWQIhAc1Nx3jF3hhJ6HhvdUE6LNfccHUDSeNgGIC76h9aL+ha9Dqt1JsyX32I3AxnqvLlv//tT+5GZPOEw6HaifzViHVJaKH7P3QH354Eq1I8LTxtYymgwmNZM6HAFV/SIeRaRDc+Gw1/Q6OoKMtyfrQy+wJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XnfhicEdqWaFe6AMnljtuI3G48SEHvTkr8jJP72HJGw=; b=oODPJkrbfgiHBSqzIcWwYZ3xSMvFlOQ7wV8DyAOMXhBjdnAt0fTviSUaVuWwzT2eTNc4waxvTHKn6eI15WU7rIO2nBGXOOI0iU3ziK6LEltSh/GxIulCnxeD1u3usyKTCzpYoRgJF4nzKphZTgfEPEMMlUfhixxJBWSZuT3e0xJRwe38PR760m9roGodJp8tQXeoBoiBITmdKnKPPQjnDiHq1nw7qUm6kt04/FAeoDNZ30j8P/5YOS+XhBRFMHAjudsXpXnc6um0ksZXzR5x9uA2CDnIueP6Fk8jtoSJXJKm9gZgQuZgyKf+/6Xv7lyvlC9YmuG9lQPKjpf+ppbsvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by SJ0PR11MB6766.namprd11.prod.outlook.com (2603:10b6:a03:47c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct 2022 06:16:56 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::74ca:2692:fcb:1664]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::74ca:2692:fcb:1664%7]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022 06:16:55 +0000 From: "duntan" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" Subject: Re: [Patch V2 2/3] UefiCpuPkg: Add Unit tests for PeiCpuExceptionHandlerLib Thread-Topic: [Patch V2 2/3] UefiCpuPkg: Add Unit tests for PeiCpuExceptionHandlerLib Thread-Index: AQHY33DLt+GBCX56SUyoSmPYqRwTYa4NYmoQgAAFl3A= Date: Fri, 14 Oct 2022 06:16:55 +0000 Message-ID: References: <20221014015400.440-1-dun.tan@intel.com> <20221014015400.440-3-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|SJ0PR11MB6766:EE_ x-ms-office365-filtering-correlation-id: 1f644004-4518-4a30-a544-08daadabb192 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: x41twjEZYx4IOIK9Kctn4DRJi0vz8704BvcdiGSnvhxd4+xAQREVdkl7OahXgWM9RGmj3VCan9jL6jafwdqBVFlDznL3dlvnxz+2pEzL1CfG7Owt+9lhGa5zTCIMnzAyM++w6SIB5bdPJJFHrJ4JurJR4pY9su1ztwte6sGwpvBAGjMCDNVkIDVOSLv/j/+LpjYo8FbZSH7GHACKsgJrWjGuxZN8wuV4gCrz52yFlBHkHgCqlQv+BTBt+dnNvlIdOJ46XJGh0UD9Bf6ev1XzNuHj+VFsYN1B3jHPHQHgO0vHe6dnIWPyeGBA6UEYePTltjrt7rjqJAVsDCix11PNqMCSl+oOMYEk8tCxroOX5wyDQIPS6dzgGQMzMRZeZaw6cDWGEkGXabfgNjvUzwrf8ev49j52MVnLrbCt+f6LxVVcA6nRNvOx5PLzW7e6npOczrm75vo7jddRJOnMe72splx8pwN9NbX2ERBIu1zw2NXXTVEIraZmYsdG786Yu9b+E79zaxShJ9Afv6U8d0or3sjpPll3nJ7azBMyrJpl9K0m1BZ8fQv6pL5mY6Yxv565Ei2oGxBbJHV0BxhIUx6iycSmhrAyoknSu9McveRfkS1nfhMnzOVXbTW5TS1L4qztHaHrXCRJZWsy1y8wasGjqUD1QLd/qyikdaT/Rhd0upd9WXyR7Y3eXsEyPCs37WeOrAj7jGHEVrJiK4c76UeQX+Tn20tROi+NJEWOn53ac1+P+DIVRp8YmfmyJrPPEVBUFUjDC5/OhXbSSqq6rn/0U1AfdWE0sf28jIy/V1SeRPE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(366004)(396003)(346002)(39860400002)(451199015)(478600001)(71200400001)(122000001)(86362001)(54906003)(107886003)(6506007)(5660300002)(7696005)(66446008)(4326008)(8676002)(4744005)(64756008)(8936002)(76116006)(66946007)(83380400001)(66476007)(66556008)(38100700002)(52536014)(33656002)(2906002)(55016003)(82960400001)(186003)(110136005)(26005)(9686003)(41300700001)(53546011)(316002)(38070700005)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KOBiN3MVZE9X6lfUHyo4CAMlVXyUcZPGw9IzfvcBIjr9atOd/2ZZ8sz0+us0?= =?us-ascii?Q?rcocU65J/1MX4lBSuhtr5ZDle9WUeTT9ciH38srMRS5NT6NVNXheyKIIcmUJ?= =?us-ascii?Q?hCDP/3YqMEFpF2AuCQBDz1ZZxS2Y4vbG6jyKVjF16quJq8iymjw85SKkqM8p?= =?us-ascii?Q?s2S1R3fq5MCe9j2wr6uxR7MTEu3ug6p97XTw90u9hU237QYj336P1If4Lcuf?= =?us-ascii?Q?0JKT0ZQB+N5aLe5xdECt6APV4RJECptDcd0xB4A9HG6CQ/E1+5ORJrEgqH0U?= =?us-ascii?Q?o6PLJUSNApexi2wC1ij4SSU3UfIB4EtdbKJLb0EnNHQ8Csw5VpIx3fhZL24t?= =?us-ascii?Q?nzPRLBAtPr53HhH73Lk65lV6zaYr6J69IHZrA7ruFvj4lJCcFjzhkuDUVpoX?= =?us-ascii?Q?klzUsZcIb9ww0BGHAHrhAJtJ5+FEUavvoXhD7GtY+idhsLc73Qc6p1nob2eq?= =?us-ascii?Q?IitEk7xjkaJkxDVgTld31dNGAHSAvq5VRbhuimmJl1qrc5N7aa0Cj+qkD6eC?= =?us-ascii?Q?vKDgdNLBQXOkltt6sIxivg98w3i1EfHR95N7LM9F3S8EYXAH3tw0rsL2izDO?= =?us-ascii?Q?usQgSg7Puf7DfuL6Cqn/TbrO9MQQ2X8PEiw1ERfsanAXL3Hn+mCthobhcTAW?= =?us-ascii?Q?Wq+le/hu1hIASyEIGACnSTCK7HKIWFpVZAh6IOVSP1lzXybRrFfYu6jg97Rr?= =?us-ascii?Q?+apZKsKG1px4PBTAzQ7J6m6jqwfnJjxD3ZHTQSV1MpA0x9mHWg8BCUekixBT?= =?us-ascii?Q?iaCgljGHHoSWYNiel34V3LQSEsvrUdpVwCTWhU3d1EKCaurnAxnTx9sYzfHT?= =?us-ascii?Q?jkp980CqMfOw8da8M3ilzDP9O/asvOS0XdngMnzghyt24fZZd7GjbsI5urwm?= =?us-ascii?Q?7283ijQA2H6P/s+ZNbOdBXv3TYG7NiObRsEZ2ge/i0cg35zWS6zkcC7XGH0i?= =?us-ascii?Q?TwpSTo5atB05BcECkqVb/TIdS3uiEKe9G+xjyHy5rS8zFXORbGmBeoXrt9pl?= =?us-ascii?Q?7oekY1Lr78dBbbbsTx6oebqcSSbaZaLkdh1DB/rDJthsWvvx1s8cyCySRXQq?= =?us-ascii?Q?k5itNf3ZugUvMOSgAk2jCozeD10mIs+PO12vqv6MdRoNmbo/THBIbOUC/16J?= =?us-ascii?Q?T8Fv4S6giO0tWnK5Gr3dtUqHFhrk3CiNg4LYQRk3BSWGavMn2pGb0DN4xh5C?= =?us-ascii?Q?C1K0kg2NzykTdnivWgXrI4jZzzWjE11UWCGhgpftJ3syv77KVRoM2UeFIvNM?= =?us-ascii?Q?lTOBA9mGh62WwYlTmbFbEZk1Lwjd/59ge6+ceNFOKGEYwnggH76mcz2I1Iyb?= =?us-ascii?Q?Gf0yYm0g+PitmB+izYFMSZw8Insjjqn+DN0GkzcebCbw8SJtj4719f4hKeh3?= =?us-ascii?Q?UZ57tHotz4cZ4C5oi4EBhkD4Yfj+bfPY719x6ucNSSpvg2DgWKW5V19boCaO?= =?us-ascii?Q?wdR2M+g9sA9LSCEG1Z83xQ37kSQjBK4P4gmJZbkvx+J1bPwOGBEn5nwV/vwW?= =?us-ascii?Q?r/b+UyO42cWUySpJd3CQhsn+1IMyZePEk6g2DIDWzCQmr2xaERt0MNJidi6Q?= =?us-ascii?Q?RdwLDEJjHXFMSCf6/sMmRmecZ9+hM6SESV6kmbuA?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f644004-4518-4a30-a544-08daadabb192 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2022 06:16:55.5912 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uXlHaL9Rd3RhbnKcJi4JLYx9Ako9kMxw9Qdh45JMG8A9YPWYrPCjgPCGqNcksiLoJMEtmjI3niQfsg1ZUWY9sw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6766 Return-Path: dun.tan@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes, the commit message in PEIM patch is the same as the last patch. I'll simply the commit message in this patch and rename the IA32 global var= iable. Thanks, Dun -----Original Message----- From: Ni, Ray =20 Sent: Friday, October 14, 2022 1:54 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Dong, Eric ; Kumar, Rahul R Subject: RE: [Patch V2 2/3] UefiCpuPkg: Add Unit tests for PeiCpuExceptionH= andlerLib The commit message is the same as the last patch, right? Maybe you could say: The previous change adds unit test for DxeCpuExeptionHandlerLib in 64bit mo= de. This change adds unit test for PeiCpuExceptionHandlerLib based on previous = change. It can run in both 32bit and 64bit modes. > +extern GENERAL_REGISTER_IA32 mIa32ExpectedContextInHandler; extern=20 > +GENERAL_REGISTER_IA32 mIa32ActualContextAfterException; Can you use the same variable name for IA32? The variable name is the same but the structure definitions are different.