From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 060D0740032 for ; Fri, 24 May 2024 03:18:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YBc3bw0yTLQYzNLAdAG02ct8fUrd9YkqsAT7Iioisiw=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1716520730; v=1; b=ipTdi8C1CT6k/UIT1n/fSZyIQuJ1DXveAb2kr2tlIKfPFd0wXjZ8dkKL7WwY0IWWHy2vwVQM LGToVd3YSkugMB9CJHkOLGTgeZ6WHdSwYIZTF8sFXeUCN7ruZ9AZVzrtTOLFoWaQ0jjRXHXph1a w4oZ0RbiOuS3Tm0ZB9JpdOIDRpe0OQawV1xxdrVDbfd9hADG45qxNwrNvtn3Ak0fU76gNl/i/r3 nwJ28F3xc63ZHXOkJ84hJwKrLPQ0xoCSP+s4VJkpmzyPUQse08nHBCYAhg4qbBtS8bCklguzWLf 6/JlkztQxN2PZv1nW5uUOnWZ9csCaF45mLSDgj1pIjAyQ== X-Received: by 127.0.0.2 with SMTP id 4QRkYY7687511xgmauzM5w3P; Thu, 23 May 2024 20:18:50 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mx.groups.io with SMTP id smtpd.web11.7827.1716520726779949796 for ; Thu, 23 May 2024 20:18:46 -0700 X-CSE-ConnectionGUID: 8BCPoxVaTmGiwIJb9FRpDQ== X-CSE-MsgGUID: F3WQklRVR6mDfcKyNdJVWA== X-IronPort-AV: E=McAfee;i="6600,9927,11081"; a="23549382" X-IronPort-AV: E=Sophos;i="6.08,184,1712646000"; d="scan'208,217";a="23549382" X-Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2024 20:18:46 -0700 X-CSE-ConnectionGUID: 0OvVaN0sRrS4nHNj+Mp4lg== X-CSE-MsgGUID: HCRXkH76SAOTkS+1sKWdNg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,184,1712646000"; d="scan'208,217";a="38293155" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 May 2024 20:18:46 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 23 May 2024 20:18:45 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 23 May 2024 20:18:45 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 23 May 2024 20:18:45 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 23 May 2024 20:18:45 -0700 X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by DM3PR11MB8734.namprd11.prod.outlook.com (2603:10b6:8:1af::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.20; Fri, 24 May 2024 03:18:43 +0000 X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::3baa:3852:4315:38f7]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::3baa:3852:4315:38f7%7]) with mapi id 15.20.7611.016; Fri, 24 May 2024 03:18:42 +0000 From: "duntan" To: Liming Gao , "devel@edk2.groups.io" CC: "Wu, Jiaxin" , Ard Biesheuvel , "Yao, Jiewen" , "Gerd Hoffmann" , "Kumar, Rahul R" , "Ni, Ray" Subject: Re: [edk2-devel] [Patch V2 00/18] Remove some S3 related code in CpuS3.c of smm cpu driver Thread-Topic: [Patch V2 00/18] Remove some S3 related code in CpuS3.c of smm cpu driver Thread-Index: AQHaqD8laERs8LjmtU6V/zkQKilvArGfto5OgAYKgzA= Date: Fri, 24 May 2024 03:18:42 +0000 Message-ID: References: <20240517094610.533-1-dun.tan@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|DM3PR11MB8734:EE_ x-ms-office365-filtering-correlation-id: ced08f0b-e911-457f-b4ed-08dc7ba03714 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?JPNadER/b+pcUkuGy9of+LyboeHJD/HVKQOnCDQk3i44jVSgJocuXDvOE3PG?= =?us-ascii?Q?NL+QuPrrCg36eDXdM/W1udNNF+UVVklcFjtCgdi7M5HctoIddBGPiIlFTOwr?= =?us-ascii?Q?PUhJ+ifqWZNwwO+DH4ExJBs3Q+cle3W39iBhg1Q0uIwB8ZQNQ2kWI3Cvx9xF?= =?us-ascii?Q?CMY+paKUeV2i3yi1U9ztamYlqeWbdvk5XjlsCa7s+c+hCeXTfPYX6cQ1lmuN?= =?us-ascii?Q?Vb1zYqbv06ctZNX8kzTT8Xo+U38JxtpYZQRx3XKifl5ex0GrQ9M8Ctpcc5JM?= =?us-ascii?Q?3L47Z+LYg1DKbjTZx0k/Q/8kIDsE1J0+HMXX62MHHb7op2PqwdCPnbFxuwlW?= =?us-ascii?Q?9/Y2pHmXbcRf4wgHlFkXPZCuuaUQAVSXATXtwhfTcMuJHYXaVDST7gB5v0RF?= =?us-ascii?Q?SYGEJ+megVdPNx3IDwmqIIUNXCxtnEAqxWGpRuaCto+4DcbUlGVpi1Fn89yM?= =?us-ascii?Q?o1kGDK1CZOWSsAGH+U0c1PYa4h6SQHvXI1u6i/IS4s7i7X7H6ukbvR/HONAw?= =?us-ascii?Q?j1GmyagTeHeelsDCzMMPp9YQAWGr7uZrVyj1I7unXfabEZ/V9upowGNRd4MJ?= =?us-ascii?Q?89ylID/QL0WOPHDIGJeMQJ1tYTDF0DZgrKuRd3kM8xZY5VPtzF0+/Cly+I+v?= =?us-ascii?Q?LYsPQFBLKjjKwT8Ykgcq9Z3uHAxgyptGXcpzlmnz90FBQcwuCICOXHvRNv7d?= =?us-ascii?Q?sEHjJN/Te52K3zvcTR8v+p4EIT6QhjWytB75sYUdIbpEXdm7CAGK/i9Vje+X?= =?us-ascii?Q?AOStomlRBEXFFzz3npU62rhLdtDlmtMbmW0bEVVw3UI5Ae4l9SSviUIAqZE4?= =?us-ascii?Q?Ga+ZoP4KOKA9WZ3xq8BAZGyVTrnkw78obO3MlFGtsdulfktqLQ42Zhcx/HSi?= =?us-ascii?Q?XoPUxtiYEK0MU5mpDY5WkASBvNRsCSisoAehRWhrQCG257TsrA6LlRE3GHUY?= =?us-ascii?Q?OoW+9pl3SsMgP8Rs4PrFXQVdUgmhfkatAwbCb8+huEANWPlMlqNSZBL5MLck?= =?us-ascii?Q?O5XE/Bj110hKjTiPu0CFoZOa3aUZUg42o8B1lPIw4esfU7kD/n+0U2r6wWFR?= =?us-ascii?Q?R5PV6lXjyOHzQJl6yypd1iHau6uMPEhUjVez+KUFIWb9ZFVuMXZJP3MVVVYN?= =?us-ascii?Q?D1tIg3FYvs/0da4N5j/ZC46Ol/tUvpHOem53//QWkqCRaUhl+K95lp5G1FUw?= =?us-ascii?Q?IIsjUE1m7z7huZOUCi4bxsbrlHKaALgNto9E914sk8V0SURok7tRerdKndzH?= =?us-ascii?Q?fRVv5OhwlBl46wxRsETVwFLdIRDvvo47x8Ez7a5vbw=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tyrQbBI0vGEE+LIyB/UR3whjGEUxZZZWh2AQ9xvc+WN1O5aUI4aBKC8wXNAA?= =?us-ascii?Q?D9x/M8PoA8DoB7y26YBQKICkgqIyRXK8p2z/Pum7PwTlZfbYZhDw8TdbaEgj?= =?us-ascii?Q?9UW1IRE74/9rTyuOAs6K6Ez4LAcPV8mN40mJW2UxUhHMsloWO64rPacUEJ3R?= =?us-ascii?Q?fu9xihC3Qv8vi1c+BdhMUAvOnM/ZyqeMf3xudP0U5v3Ug9UF/46DYuRNTyFc?= =?us-ascii?Q?CkO6RJla/DPI9aNHD3hMwdkQb/y3hAWHp8JaRmgvFV2A9QZ/CGe5cUN6Sj8j?= =?us-ascii?Q?48hVPsvkFfxigfgMVQ9gpeTzE4gNdAXophieARNUle48vubuH1uEkcZb0xm/?= =?us-ascii?Q?K97C2GcVBJ1r0Qv3fZNr9TBdQI5wwxXGyQyUDURvs48cKfMzLPZIHmrQxVXi?= =?us-ascii?Q?/QLVBRYpKWobHdS+yh1Gp0DM5E1vFHqijPSIso7GWeicfQD5FGMi8EP9ey5s?= =?us-ascii?Q?Wn4cyOyCoZmOc4K3iQPCmFfEE+Ei7qpWkCdndsFdFmH15yDF+88lwEENwfWd?= =?us-ascii?Q?iKYSWTVI5QhB0b9dt0ZcTJ80cnAI6+2oIRo8ERjHswwDwp5y5rSvq1T0/yEH?= =?us-ascii?Q?Cif6kUs+LXnqto/qts/XdtQRbpZMUK36EaJOhDP3atlCwpZPurg/Of6wwKpp?= =?us-ascii?Q?825uVFv2yUGdB6UQvunii8Ob6ALaQktoSkMOVYhvsy/ddAjZhqkgZWDmCIdp?= =?us-ascii?Q?qX/w1oRl/ZJpuNYQPRyZuNpq1eQZPQvRDVQvFgo0VJYTBqFYwgJC0bu4HdC/?= =?us-ascii?Q?qUM1LuV/hRqaXC6zm/VFFkBr/Mnh7whAYpMzq4D6TZloYPljKMj6XHrcm3K3?= =?us-ascii?Q?5XqcfL3PlDyMF87rKs9pKCDBinprcagBiBHt001RV75zyd0tdfK7HWeCu0j8?= =?us-ascii?Q?JhdqOedu+lhyjQSjxUo/xshqwC7n1aNdhfPzhCiYAnBRQVaRk4ggqkUuj8S5?= =?us-ascii?Q?vUHSvVzOY1CKKNsbK3o4CQrXosZriiuuHhYRZAqWq8Tpd1gBWQGXJ1r1jE4D?= =?us-ascii?Q?Z3LXlxATU0WtP/bttfb5dK0np5TUk81Wb9p6AtL9Btjeb6Hu8uAtHlBbO+1J?= =?us-ascii?Q?v1E39WDIUWtF4oIw1zPg/V+5s/dXU0zMIUs0NHMzRCxs+3LnUayaY+JYvaCe?= =?us-ascii?Q?K6XG91k15NciHRGe+SZFhN67XPDTzK9Sp/tn2S6tD4U4nTwh1zBNLie1Hbkt?= =?us-ascii?Q?VWK+DkNQIf8abLsm1f1kRJeJYS3OrpXlKhCrpkVtFrq0lB/Q3pJfG4RXXp9u?= =?us-ascii?Q?IYqLvYXbeDrjl50scAwrsrYCxgYP7LqnCTBZtbYINIG/zaRuM2+gkVFVdxtG?= =?us-ascii?Q?zbmL8BtCjBVVwS1Dr5ZIgKnI/vfWNc6ujVnUUegY4XrrjB+B2aoUdsCZpVnP?= =?us-ascii?Q?qMBFHga4fRXQOmSAPVkm7f6Y/v4vDtuCCS825YLmKEC4GsxPD1EE49TnsZ5o?= =?us-ascii?Q?52jqdynN+K7bbgYiMsEMu3fI0R2+L5wf7eIXrTgY7WhIz7GKgBEqAJbhBdPP?= =?us-ascii?Q?KqMzEauq4PGxfBY8y0ib4vVPhdDsV1L3yUTRCT2NY6+FSpIg5qIRRdEEZ2II?= =?us-ascii?Q?pJtlWxVp9tSUxjULTtI=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ced08f0b-e911-457f-b4ed-08dc7ba03714 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2024 03:18:42.8393 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: D1fACm8JnUgTH5UKnmLkr/RC00j/1Qdn0SKWAcqthmfnW3y/DvgaynRtHIWujQmSnAnHweP5qnQ9kVPQzFnZhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR11MB8734 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 23 May 2024 20:18:46 -0700 Resent-From: dun.tan@intel.com Reply-To: devel@edk2.groups.io,dun.tan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: pfcnd8yKr3e15tYhDDO3b0Spx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BN9PR11MB5483DF79B64DCA8851935900E5F52BN9PR11MB5483namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=ipTdi8C1; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_BN9PR11MB5483DF79B64DCA8851935900E5F52BN9PR11MB5483namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming, Could you please help to review the following 2 patches in the patch series= ? [Patch V2 01/18] MdeModulePkg: Add gEdkiiS3MtrrSettingGuid [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi field in S= MM_S3_RESUME_STATE Thanks, Dun From: Ni, Ray Sent: Monday, May 20, 2024 3:05 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Liming Gao ; Wu, Jiaxin = ; Ard Biesheuvel ; Yao, Jiewen ; Gerd Hoffmann ; Kumar, Rahul R Subject: Re: [Patch V2 00/18] Remove some S3 related code in CpuS3.c of smm= cpu driver Following 3 patches still require the Reviewed-by from package maintainers = of MdeModulePkg and OvmfPkg. MdeModulePkg: Add gEdkiiS3MtrrSettingGuid OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE The patch set is a good move to simplify the X86 CPU SMM driver by removing= most of S3 related logics. I hope it can be merged next week when the stable tag freeze ends in the en= d of this week. Thanks, Ray ________________________________ From: Tan, Dun > Sent: Friday, May 17, 2024 17:45 To: devel@edk2.groups.io > Cc: Liming Gao >;= Wu, Jiaxin >; Ni, Ray >; Ard Biesheuvel >; Yao, Jiewen >; Gerd Hoffmann >; Kumar, Rahul R > Subject: [Patch V2 00/18] Remove some S3 related code in CpuS3.c of smm cpu= driver Comparing to V1 patchs set, the V2 patch set only adjusts the commits order= ing and modifies copy right year in some files. This patch set is to remove some S3 related code in CpuS3.c of smm cpu driv= er. It contain commits to: 1) S3 MTRRs operation: > MdeModulePkg: Add gEdkiiS3MtrrSettingGuid > OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe > UefiCpuPkg: Add locbox lib instance in DSC > UefiCpuPkg: Save MTRR by lockbox in CpuS3DataDxe > UefiCpuPkg: LoadMtrrData for all cpu in S3Resume > UefiCpuPkg: Remove code to load mtrr setting 2) AP page table unavailiable issue fix: > UefiCpuPkg: Disable PG in IA32 ApLoopCode 3) Register table cleanup: > UefiCpuPkg:Set PcdCpuFeaturesInitOnS3Resume to TRUE > UefiCpuPkg: Remove code to set register table 4) S3 ApHltLoopCode Operation: > UefiCpuPkg:Abstract some DxeMpLib code to function > UefiCpuPkg:Move some code in DxeMpLib to common place > UefiCpuPkg: Install gEdkiiEndOfS3ResumeGuid in S3Resume > UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib > UefiCpuPkg:Remove code to handle APIC setting and Interrupt > UefiCpuPkg:Rremove code to wakeup AP and relocate ap > UefiCpuPkg: Remove the duplicated mpservice locate > MdeModulePkg: remove MpService2Ppi field in SMM_S3_RESUME_STATE 5) Remove code to get AcpiCpuData: > UefiCpuPkg: Remove GetAcpiCpuData() in CpuS3.c With this patch set, CpuS3.c in smm CPU driver can be simplified. The whole patch set has been reviewed-by Ray. PR for review: https://github.com/tianocore/edk2/pull/5606 Cc: Liming Gao > Cc: Jiaxin Wu > Cc: Ray Ni > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Gerd Hoffmann > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Dun Tan (18): MdeModulePkg: Add gEdkiiS3MtrrSettingGuid OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe UefiCpuPkg: Add locbox lib instance in DSC UefiCpuPkg: Save MTRR by lockbox in CpuS3DataDxe UefiCpuPkg: LoadMtrrData for all cpu in S3Resume UefiCpuPkg: Remove code to load mtrr setting UefiCpuPkg:Set PcdCpuFeaturesInitOnS3Resume to TRUE UefiCpuPkg: Remove code to set register table UefiCpuPkg: Disable PG in IA32 ApLoopCode UefiCpuPkg:Abstract some DxeMpLib code to function UefiCpuPkg:Move some code in DxeMpLib to common place UefiCpuPkg: Install gEdkiiEndOfS3ResumeGuid in S3Resume UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib UefiCpuPkg:Remove code to handle APIC setting and Interrupt UefiCpuPkg:Remove code to wakeup AP and relocate ap UefiCpuPkg: Remove unneeded MpService2Ppi assignment MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE UefiCpuPkg: Remove GetAcpiCpuData() in CpuS3.c MdeModulePkg/Include/Guid/AcpiS3Context.h | 3 +-- MdeModulePkg/MdeModulePkg.dec | 5 ++++- OvmfPkg/CpuS3DataDxe/CpuS3Data.c | 13 ++++++++++++= - OvmfPkg/CpuS3DataDxe/CpuS3DataDxe.inf | 4 +++- UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c | 13 ++++++++++++= - UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf | 4 +++- UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 183 ++++++++++++= ++++++++++++++++++++++++++++++++++++---------------------------------------= ---------------------------------------------------------------------------= ----------- UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm | 6 +++++- UefiCpuPkg/Library/MpInitLib/MpLib.c | 144 ++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++++++++++++++++++++- UefiCpuPkg/Library/MpInitLib/MpLib.h | 56 ++++++++++++= +++++++++++++++++++++++++++++++++++++++-- UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 6 +++++- UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 154 ++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 993 +++++++++---= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ------------- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.nasm | 153 ------------= ---------------------------------------------------------------------------= ---------------------------------------------------------- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c | 29 +-----------= ---------------- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 8 +++----- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 26 +-----------= ------------- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 5 +---- UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.nasm | 189 ------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c | 30 +-----------= ----------------- UefiCpuPkg/UefiCpuPkg.dec | 4 ++-- UefiCpuPkg/UefiCpuPkg.dsc | 3 ++- UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 78 ++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++--------------- UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf | 4 +++- 24 files changed, 531 insertions(+), 1582 deletions(-) delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.nasm delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.nasm -- 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119184): https://edk2.groups.io/g/devel/message/119184 Mute This Topic: https://groups.io/mt/106150757/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_BN9PR11MB5483DF79B64DCA8851935900E5F52BN9PR11MB5483namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Liming,

 

Could you please help to review the following 2 p= atches in the patch series?

        &= nbsp;     [Patch V2 01/18] MdeModulePkg: Add gEdkiiS3Mt= rrSettingGuid

        &= nbsp;     [Patch V2 17/18] MdeModulePkg:Remove MpServic= e2Ppi field in SMM_S3_RESUME_STATE

 

Thanks,

Dun

 

From: Ni, Ray <ray.ni@intel.com>
Sent: Monday, May 20, 2024 3:05 PM
To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io
Cc: Liming Gao <gaoliming@byosoft.com.cn>; Wu, Jiaxin <jiax= in.wu@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao,= Jiewen <jiewen.yao@intel.com>; Gerd Hoffmann <kraxel@redhat.com&g= t;; Kumar, Rahul R <rahul.r.kumar@intel.com>
Subject: Re: [Patch V2 00/18] Remove some S3 related code in CpuS3.c= of smm cpu driver

 

Following 3 patches still require the Reviewed-by from pac= kage maintainers of MdeModulePkg and OvmfPkg.

  MdeModulePkg: Add gEdkiiS3MtrrSettingGuid
  OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe
  MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE

The patch set is a good move to simplify the X86 CPU SMM driver by removing= most of S3 related logics.

I hope it can be merged next week when the stable tag free= ze ends in the end of this week.

 

Thanks,

Ray

From: Tan, Dun <d= un.tan@intel.com>
Sent: Friday, May 17, 2024 17:45
To: devel@edk2.groups.io= <devel@edk2.groups.io> Cc: Liming Gao <gaoli= ming@byosoft.com.cn>; Wu, Jiaxin <jiaxin.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.c= om>; Gerd Hoffmann <kraxel@r= edhat.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>
Subject: [Patch V2 00/18] Remove some S3 related code in CpuS3.c of = smm cpu driver

 

Comparing to V1 patch= s set, the V2 patch set only adjusts the commits ordering and modifies copy= right year in some files.
This patch set is to remove some S3 related code in CpuS3.c of smm cpu driv= er. It contain commits to:
1) S3 MTRRs operation:
>   MdeModulePkg: Add gEdkiiS3MtrrSettingGuid
>   OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe
>   UefiCpuPkg: Add locbox lib instance in DSC
>   UefiCpuPkg: Save MTRR by lockbox in CpuS3DataDxe
>   UefiCpuPkg: LoadMtrrData for all cpu in S3Resume
>   UefiCpuPkg: Remove code to load mtrr setting

2) AP page table unavailiable issue fix:
>   UefiCpuPkg: Disable PG in IA32 ApLoopCode

3) Register table cleanup:
>   UefiCpuPkg:Set PcdCpuFeaturesInitOnS3Resume to TRUE
>   UefiCpuPkg: Remove code to set register table

4)  S3 ApHltLoopCode Operation:
>   UefiCpuPkg:Abstract some DxeMpLib code to function
>   UefiCpuPkg:Move some code in DxeMpLib to common place
>   UefiCpuPkg: Install gEdkiiEndOfS3ResumeGuid in S3Resume >   UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib
>   UefiCpuPkg:Remove code to handle APIC setting and Interrup= t
>   UefiCpuPkg:Rremove code to wakeup AP and relocate ap
>   UefiCpuPkg: Remove the duplicated mpservice locate
>   MdeModulePkg: remove MpService2Ppi field in SMM_S3_RESUME_= STATE

5)  Remove code to get AcpiCpuData:
>   UefiCpuPkg: Remove GetAcpiCpuData() in CpuS3.c

With this patch set, CpuS3.c in smm CPU driver can be simplified.
The whole patch set has been reviewed-by Ray.
PR for review: http= s://github.com/tianocore/edk2/pull/5606

Cc: Liming Gao <gaoliming@by= osoft.com.cn>
Cc: Jiaxin Wu <jiaxin.wu@intel.co= m>
Cc: Ray Ni <ray.ni@intel.com>=
Cc: Ard Biesheuvel <ardb+ti= anocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel= .com>
Cc: Gerd Hoffmann <kraxel@redhat.co= m>
Cc: Rahul Kumar <rahul1.kumar@= intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.co= m>

Dun Tan (18):
  MdeModulePkg: Add gEdkiiS3MtrrSettingGuid
  OvmfPkg: Save MTRR by lockbox in CpuS3DataDxe
  UefiCpuPkg: Add locbox lib instance in DSC
  UefiCpuPkg: Save MTRR by lockbox in CpuS3DataDxe
  UefiCpuPkg: LoadMtrrData for all cpu in S3Resume
  UefiCpuPkg: Remove code to load mtrr setting
  UefiCpuPkg:Set PcdCpuFeaturesInitOnS3Resume to TRUE
  UefiCpuPkg: Remove code to set register table
  UefiCpuPkg: Disable PG in IA32 ApLoopCode
  UefiCpuPkg:Abstract some DxeMpLib code to function
  UefiCpuPkg:Move some code in DxeMpLib to common place
  UefiCpuPkg: Install gEdkiiEndOfS3ResumeGuid in S3Resume
  UefiCpuPkg:Relocate AP to new safe buffer in PeiMpLib
  UefiCpuPkg:Remove code to handle APIC setting and Interrupt
  UefiCpuPkg:Remove code to wakeup AP and relocate ap
  UefiCpuPkg: Remove unneeded MpService2Ppi assignment
  MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE
  UefiCpuPkg: Remove GetAcpiCpuData() in CpuS3.c

 MdeModulePkg/Include/Guid/AcpiS3Context.h    &nbs= p;          |   3 +-= -
 MdeModulePkg/MdeModulePkg.dec      &nbs= p;            &= nbsp;       |   5 ++++-
 OvmfPkg/CpuS3DataDxe/CpuS3Data.c      &= nbsp;           &nbs= p;     |  13 ++++++++++++-
 OvmfPkg/CpuS3DataDxe/CpuS3DataDxe.inf     &n= bsp;            = ; |   4 +++-
 UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c     &nbs= p;            &= nbsp;  |  13 ++++++++++++-
 UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf     = ;           |  = 4 +++-
 UefiCpuPkg/Library/MpInitLib/DxeMpLib.c     =             | 183 ++= ++++++++++++++++++++++++++++++++++++++++++++++-----------------------------= ---------------------------------------------------------------------------= ---------------------
 UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm    = ;      |   6 +++++-
 UefiCpuPkg/Library/MpInitLib/MpLib.c     &nb= sp;            =   | 144 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-<= br>  UefiCpuPkg/Library/MpInitLib/MpLib.h     &nb= sp;            =   |  56 +++++++++++++++++++++++++++++++++++++++++++++++++++--
 UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf    =        |   6 +++++-
 UefiCpuPkg/Library/MpInitLib/PeiMpLib.c     =             | 154 ++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c      =             &nb= sp;    | 993 +++++++++--------------------------------------= ---------------------------------------------------------------------------= -----------------------------------------------------
 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.nasm    &n= bsp;        | 153 ----------------------= ---------------------------------------------------------------------------= ------------------------------------------------
 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c    =        |  29 +--------------------------= -
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c    &nb= sp;         |   8 +++----= -
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h    &nb= sp;         |  26 +-----------= -------------
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf    &= nbsp;       |   5 +----
 UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.nasm    &nb= sp;         | 189 -----------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= -----------
 UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c    &= nbsp;       |  30 +---------------------= -------
 UefiCpuPkg/UefiCpuPkg.dec       &n= bsp;            = ;           |  = 4 ++--
 UefiCpuPkg/UefiCpuPkg.dsc       &n= bsp;            = ;           |  = 3 ++-
 UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c   &n= bsp;   |  78 +++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++---------------
 UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf |  = 4 +++-
 24 files changed, 531 insertions(+), 1582 deletions(-)
 delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.nasm
 delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.nasm

--
2.31.1.windows.1

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#119184) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_BN9PR11MB5483DF79B64DCA8851935900E5F52BN9PR11MB5483namp_--