From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "S, Ashraf Ali" <ashraf.ali.s@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH] [IntelFsp2Pkg]: Fix GCC Compiler warning
Date: Thu, 9 Mar 2023 17:06:08 +0000 [thread overview]
Message-ID: <BN9PR11MB5483DF92477C3266E9C02EBCE6B59@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <3828e699ee683093c89d1ea9fa81e6710062e65c.1678377799.git.ashraf.ali.s@intel.com>
Thanks for fixing this bug!
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: S, Ashraf Ali <ashraf.ali.s@intel.com>
> Sent: Thursday, March 9, 2023 8:06 AM
> To: devel@edk2.groups.io
> Cc: S, Ashraf Ali <ashraf.ali.s@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chaganty, Rangasai
> V <rangasai.v.chaganty@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH] [IntelFsp2Pkg]: Fix GCC Compiler warning
>
> Function defination should match with declaration.
> [-Wlto-type-mismatch]
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
>
> Signed-off-by: Ashraf Ali S <ashraf.ali.s@intel.com>
> ---
> IntelFsp2Pkg/Library/BaseFspPlatformLib/FspPlatformNotify.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/IntelFsp2Pkg/Library/BaseFspPlatformLib/FspPlatformNotify.c
> b/IntelFsp2Pkg/Library/BaseFspPlatformLib/FspPlatformNotify.c
> index 795bb28c0f..a5a51c804c 100644
> --- a/IntelFsp2Pkg/Library/BaseFspPlatformLib/FspPlatformNotify.c
> +++ b/IntelFsp2Pkg/Library/BaseFspPlatformLib/FspPlatformNotify.c
> @@ -296,6 +296,7 @@ FspTempRamExitDone2 (
>
> **/
> VOID
> +EFIAPI
> FspWaitForNotify (
> VOID
> )
> --
> 2.38.1.windows.1
next prev parent reply other threads:[~2023-03-09 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 16:05 [PATCH] [IntelFsp2Pkg]: Fix GCC Compiler warning Ashraf Ali S
2023-03-09 17:06 ` Chiu, Chasel [this message]
2023-03-10 0:21 ` Nate DeSimone
2023-03-10 0:27 ` Chaganty, Rangasai V
2023-03-10 1:30 ` Zeng, Star
2023-03-10 3:20 ` Chiu, Chasel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB5483DF92477C3266E9C02EBCE6B59@BN9PR11MB5483.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox