From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web09.4873.1631696127622569380 for ; Wed, 15 Sep 2021 01:55:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ntoNT3I+; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: dun.tan@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10107"; a="222319160" X-IronPort-AV: E=Sophos;i="5.85,294,1624345200"; d="scan'208";a="222319160" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 01:55:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,294,1624345200"; d="scan'208";a="610080647" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 15 Sep 2021 01:55:26 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 01:55:25 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 15 Sep 2021 01:55:25 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 15 Sep 2021 01:55:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h4jy/O9l5AQ4ztdwCnOcwhbhcTwsfz2ojByeGi1vR8KeGc3CNNgUd/+kBZHNO0sCjhiEfv4NmJ71/Ke446H8danrUx3+eSpwyVxWdlZp4hG2rgWpR81QU5AFRR8DB7Y4mqzf3coK0OTzkUiHojelbzzOMn5rdpUuQgIUk9NUupb//EncH/41tBCGaNjaDxYYzG0oicocWXbuAv7AseCmWvVz1u/hf0jCptJtHCRHBdN9ELOszvgY9hQgexrux0JGaOEUOkFZWi9hUt0Ms6Oqxmn8I8I9GMJ2MyQR4deHkvV5Nli/JutCZjoHyqArc+gObl1rx1vZTo9UyoFoj3MzQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8953KSzYv2RUkFXOSsumHV/IeRnDvmzNFZhpSNVIbT4=; b=AQH3Sogn6LCrsbP2P+QF0fHRfkTcG00sLHxR8f3MpEi5fsPx2IPHRZ3mdSnbjiDkHsr2MoovKcAD6yvpuUhOH0keG2rNp9so8SGgN5FMu4lOktUvGc9lcsHrcNylT9ASdK2tZGkvoNol3mcyEyZ/Ej69d5cJKBOatQrgX90vAcTI/skh9iXifb+fjADpy8WrdSPyivxrZTRwE5V6/2s6npAcZ9y2+EGVBu6lUXh4PEMdIHamldnoHFF1df7VOyfB72WI+cr7qGu1cXNnvHjn2PSSLySzyCuJ+X2DU4z4ts37ia9ujosyM5uQ2aXS/junEFWs/iGwrcGUifCBbu/+kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8953KSzYv2RUkFXOSsumHV/IeRnDvmzNFZhpSNVIbT4=; b=ntoNT3I+lYlXid3nNax8alOC3MO2rsiEkee32EgkzQ1hYKVk3NKT9xb9O7eMR/mn/9OX+WJLERBzUgVQi+olFuwXhxUgQrTmzdoJXmjPT0SF5rr/X2QdLNL7CEMYK57xuGCyh8zx+oG83yYWcOHpnGJ1PXvXkOHqU8ZHMEgg+5w= Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN8PR11MB3652.namprd11.prod.outlook.com (2603:10b6:408:87::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Wed, 15 Sep 2021 08:54:45 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::882:4e40:b0e4:239e]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::882:4e40:b0e4:239e%6]) with mapi id 15.20.4523.014; Wed, 15 Sep 2021 08:54:45 +0000 From: "duntan" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Ma, Maurice" , "You, Benjamin" Subject: Re: [PATCH] UefiPayloadPkg: Fix the warning when building UefiPayloadPkg with IA32+X64 Thread-Topic: [PATCH] UefiPayloadPkg: Fix the warning when building UefiPayloadPkg with IA32+X64 Thread-Index: AQHXqTutLpwFG+l3I06yr91KZ7Fjl6ujKH5wgAGX4/A= Date: Wed, 15 Sep 2021 08:54:45 +0000 Message-ID: References: <20210914073907.1243-1-dun.tan@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ebd03aa3-fc27-45e0-b773-08d97826772c x-ms-traffictypediagnostic: BN8PR11MB3652: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:128; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XO8Om4wuoorEDLT3Wswc5YrjU6DKenYiAXcWXqO3x+kLYGhlLhtlbVtj7G2jsQRRi24DaBdPso2V0OKiAtXwadSRYb5YbF5VAlM4fbMWfdU+jT0dswDrNZAT7+TxYvaQK9Wdnm9bcVWjxVn2NNj1CHYo89b5oxfpqhXlDtjLvFgWoKvLVQieFWCHfySi1t2pKnGP3FP4t0UaRJ/FKktJtdu2l6QGc8Cv4a53Gl8O0NKYDoKFNNLWntfAJH19CgVjTYUr0dmu5qvOhcwOBac6Wm/8Yxxw+aVpV5lrzvpUlttuj54ThTR0lGjWSYmOAOSsKhq9H07adW+DyxG49EPaO/C1mSAZ1vOkkvFe0sYG5wUJeZDQ8t5VX/G6OarlnTw3Q/tnrbpKYPgzvLivM5cLHvbH8ytv3j3UHHQeU6AUlIwnFObbohHWR7P3B5kMfh7BymZ55QoZF3QFGQ5U29HWh71wUIUTP7dZX7h7qisXPxLI9MzzcIOa8et4HhhQGjmrvaOCoVOoCJjbhQV3HxbqjKaBbN0BHRWimXHKZ9spulWyMMutHV5FZWhxa6f7iGMXqcXMepuydslqJOMKe2wiE/Bs4E7E6tlr8DxR0XE2FJgzMSNYvzoAiq5T8hCJmJEjjSrkZvfvp5HpkAV/7zIFgnpoYIc9ow2l9QSH6d+7t7xH+fE3YwIu9HOnvSdNCAc4n0W2i7Xe1kkBuYjH5iucY4BL9ckgAxKJwk0q69L7ofKGuAk4vnssoj7InZyc8eBqss7CC/L1Kx5OGrMGE5fjfByGTslHhi8f01vaWj0YNp0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(39860400002)(376002)(396003)(136003)(6506007)(2906002)(7696005)(186003)(66946007)(64756008)(66556008)(66476007)(86362001)(26005)(8676002)(38070700005)(110136005)(316002)(54906003)(38100700002)(76116006)(66446008)(55016002)(9686003)(5660300002)(107886003)(122000001)(83380400001)(52536014)(8936002)(478600001)(71200400001)(53546011)(33656002)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XlX/q54jkAsR8/8uS9PSz/osiXjR0oJR+Y/fLsSh9fH5+6OzyWpbPduSWxnr?= =?us-ascii?Q?pTJy0O1jQX96jmTxE1dUZB9+q8ql1ZibuCQrvchno5DNC+tOVWjoQQRQXqDW?= =?us-ascii?Q?htYvnenG17DWfQqG8V2M61sn6u49vpMdPS4FF8uWvtyMqurQrfJHv1GOIBmt?= =?us-ascii?Q?HZsi4XsOdOnbChYo2gflNg4+yUA4/xfuPr9/UhgHOudmRn8B7B+hp4z28sgx?= =?us-ascii?Q?nTaP97bHzyUbpffgycjVwLbAwyam1/JkrVM/DPiWpxbdM8x8Y/Dp3924UPFE?= =?us-ascii?Q?kaxbJTi/PWKg9wVnswiKFv8UaXUvi8IRnJF/Xz8OS83L/xDjM4BN/Hd7d0pT?= =?us-ascii?Q?XI+LCE7KTKvEkX64Y5Yu0Ct5Ez+dyQSM6FWCbgHJFZA1XSn2fsHSZvHJoihD?= =?us-ascii?Q?MiaAM2LBrOIomTA3YLlM/HZkUd1YjyLM5NBNoGqdAFklZZ74YKor+zu6UWOH?= =?us-ascii?Q?viTMs55++OaChwlxIj75+Ez6FdwqrJk3mvqHVIFRrk8OMW4QlQfDdD0XQ8UV?= =?us-ascii?Q?NWzWXndHOHWct7pOExYIqGbqst6DtJyYcVwx1vl4rWfViybf5/DdK9UbRrVi?= =?us-ascii?Q?bBYFii172R0E7WDP8BxXECZzbznSgJFNzX0Tqcflp0WW0FdAYwh7hz3BTakn?= =?us-ascii?Q?46YnFQVhtrFOxfyO95v9BPvyWNZZll9dvv01j6Qgi0+Tqrixnr0FQGTHHcZe?= =?us-ascii?Q?u29FLr1PdW0AcptJnTFf+HhgFrM5N1IGHGP5k9CQ4XUCLa+91a4vSTVw2IJu?= =?us-ascii?Q?v1E9ZeHvO8BVI3uWWiuinxv2kQfF8yMJeGZ0TzOmOXe9KQ6fYKBj5nkt9XFm?= =?us-ascii?Q?iwuijJL85ePWI4yQy1DTFHpsgQcxfVoMdlih/pOQ6uFcgPf3cLXqLXHDWiWu?= =?us-ascii?Q?TWXzoaeWKTGCQlDRcdxl1Reyh4MHaa2zTub5t18aPNGiOjAUwur7jB9cnWjn?= =?us-ascii?Q?arhydf2sX/te+rr5ctubHzueMdsySH/pEtzUsGUFs1cJ9ZQqMr3nCMfUVqtZ?= =?us-ascii?Q?NxUI2brubijbBiy1FBdWSoodMJLYCqbg8IKps6HbQEB+E9gJ8X+3XxU3e5rh?= =?us-ascii?Q?O/fYRBMIAIm5pR7sE8fLY0AKri45bkpnuNMbDmbFpY4HDfjT7hgMDu2dWQ+g?= =?us-ascii?Q?xe+kqDWg9xfphIG1Jy6KsmWHEsshajtSmqROBnN7i/OrteI1b/SnuYdAeUq4?= =?us-ascii?Q?aB/NcXlmXLL//ubVE2QObPQKnu78dKAR/LHwzukTb86rhc78AX1kB6AmOJhK?= =?us-ascii?Q?MGDxp7iBZAugpAwrhcAWuBhf2EzVmrMHUIaaN8PJ8nQSI2rVK663UgKgeyMK?= =?us-ascii?Q?gLpZdrSTAxa72MKGTgced5y1?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebd03aa3-fc27-45e0-b773-08d97826772c X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2021 08:54:45.1960 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WQB7oP+8lKXhZZyOJG0nrrNN3rvP7GIgVM8FwF+28pBQCPUb2Ge2lplIHdLh6PT9jEyMHnW9atUOhBM0hnTDsw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3652 Return-Path: dun.tan@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, There are only "UniversalPayloadEntry.inf" and "UefiPayloadEntry.inf" under= [Components.IA32] in UefiPayloadPkg.dsc. The [Packages] sections in these = two .inf file only contain MdePkg, MdeModulePkg, UefiCpuPkg and UefiPayload= Pkg. So the PCDs in .dec files of these four pkgs used in UefiPayloadPkg.ds= c will not be treated as unspecified PCDs when building with IA32. In order= to avoid warnings when building under IA32, the PCDs in the dec files othe= r than these four pkgs needs to be placed in the PCD section with the 'X64'= suffix in UefiPayloadPkg.dsc. The ' gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport' is in 'MdeModulePkg.dec= '. So it won't be regarded as an unspecified PCD. Thanks, Dun -----Original Message----- From: Ni, Ray =20 Sent: Tuesday, September 14, 2021 3:54 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Dong, Guo ; Ma, Maurice ; You= , Benjamin Subject: RE: [PATCH] UefiPayloadPkg: Fix the warning when building UefiPayl= oadPkg with IA32+X64 Dun, I am curious, why ' gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport' doesn't c= ause build warning? It is referenced by "MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf" under "[= Components.X64]". Thanks, Ray > -----Original Message----- > From: Tan, Dun > Sent: Tuesday, September 14, 2021 3:39 PM > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Ma,=20 > Maurice ; You, Benjamin > Subject: [PATCH] UefiPayloadPkg: Fix the warning when building=20 > UefiPayloadPkg with IA32+X64 >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3603 >=20 > Move the unspecified PCDs from .common section. to .X64 section in .dsc f= ile. > The corresponding PCDs are not used in IA32. >=20 > Cc: Guo Dong > Cc: Ray Ni > Cc: Maurice Ma > Cc: Benjamin You >=20 > Signed-off-by: Dun Tan > --- > UefiPayloadPkg/UefiPayloadPkg.dsc | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc=20 > b/UefiPayloadPkg/UefiPayloadPkg.dsc > index 9912f2a20f..9d7f311343 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > @@ -327,6 +327,11 @@ > gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x2 > !endif >=20 > +[PcdsPatchableInModule.X64] > + =20 > +gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTE > +R) > + =20 > +gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGIS > +TER) > + gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE > + > [PcdsPatchableInModule.common] > gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa,=20 > 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0= x23, 0x31 } > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x7 > @@ -337,8 +342,6 @@ > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2F > !endif > =20 > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxSizeNonPopulateCapsule|$(MAX_SIZE > _NON_POPULATE_CAPSULE) > - =20 > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER > ) > - gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGIST= ER) > # > # The following parameters are set by Library/PlatformHookLib > # > @@ -361,7 +364,6 @@ >=20 > gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber|$(MAX_LOGICA= L_PROCESSORS) > gUefiCpuPkgTokenSpaceGuid.PcdCpuNumberOfReservedVariableMtrrs|0 > - gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE >=20 > =20 > ###################################################################### > ########## > # > -- > 2.31.1.windows.1