From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BF870740045 for ; Tue, 2 Apr 2024 06:49:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7noJHawiI5XQ0ucRf7AhwW+RT2BSt/odxRkRcBM1zdc=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1712040593; v=1; b=AF6CWFb61zhZuXQG4C4qWqhnERfUDFdL+q1CiK3V9ySzjdcYUMMWLM6fiK4NGpx0HgAi+CKy eD9o4dsd8Yu2oQu/xOTIA/PDFzLx276Cf8rZQu49Q4SoeqC2RbMG0sOIQPZSlCo4s5zC0XITNpH Evibzvyz4P7OLXOuhZP3cfqxS9hUN/z4FodmEFT5tenNE8eaUuQhpNP2crmZsNgW1I75RG3705O bWYUvxWZ96Ym+wVx6TqXkym8HgxYQu3pQ93dA9mYqC8cryoO/klYMhHHZ81GZdmOxBC//HpjenC ED4JgFjbu49i+tKCiP4phN/jyCIr4KfZ8PIV9TEYRFUiQ== X-Received: by 127.0.0.2 with SMTP id bKjuYY7687511xytlpPy4Odi; Mon, 01 Apr 2024 23:49:53 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mx.groups.io with SMTP id smtpd.web10.6314.1712040592818319136 for ; Mon, 01 Apr 2024 23:49:52 -0700 X-CSE-ConnectionGUID: Hgs8bsKuRSiap4b9gAARqQ== X-CSE-MsgGUID: CwIh2a9YRGOuIHm/FpqXEQ== X-IronPort-AV: E=McAfee;i="6600,9927,11031"; a="10976275" X-IronPort-AV: E=Sophos;i="6.07,174,1708416000"; d="scan'208";a="10976275" X-Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2024 23:49:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,174,1708416000"; d="scan'208";a="48965947" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Apr 2024 23:49:53 -0700 X-Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 1 Apr 2024 23:49:51 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 1 Apr 2024 23:49:51 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 1 Apr 2024 23:49:48 -0700 X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by SN7PR11MB6921.namprd11.prod.outlook.com (2603:10b6:806:2a8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.21; Tue, 2 Apr 2024 06:49:41 +0000 X-Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::5561:25ad:2b29:d5c]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::5561:25ad:2b29:d5c%7]) with mapi id 15.20.7452.019; Tue, 2 Apr 2024 06:49:41 +0000 From: "Chiu, Chasel" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Lou, Yun" , "Desimone, Nathaniel L" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-devel] [edk2-platforms V2 1/3] MinPlatformPkg: Remove the global variable mForceX2ApicId Thread-Topic: [edk2-platforms V2 1/3] MinPlatformPkg: Remove the global variable mForceX2ApicId Thread-Index: AQHag/p7BYqWWT2vCUGIEYVtmBt/EbFUi+Tw Date: Tue, 2 Apr 2024 06:49:41 +0000 Message-ID: References: <20240401060411.899-1-dun.tan@intel.com> <20240401060411.899-2-dun.tan@intel.com> In-Reply-To: <20240401060411.899-2-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|SN7PR11MB6921:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: x1JTRRIep53ztyqx0m/DejP2Uf1l0VH4JEdbfqF+vUfCYCXeAUH873R/keukoj/56mIEunzkl9kVwNrwpw5zUuXkxosMhFDf5XeH328LNLuo079Q1ZqCxE+L6piLNSgj7T/6c0FGizIDsdFFu3lUtKdKvu66vqjnK3zYoVCm66p4631KpVBBp93LAJ+OmH1FN8RMBGunNDCuFu2jn14w61tclmXaQlsPLCNQF6ZLI8XrFnobB7BbQAjgVqWkkNP7rvxGoflxUs+fm2kTJA2cHmIC5InfUnf6EeImGeqxH/Gti2JNfrcXvmtJwevUg3t9yvWyj30ukH3aIe0IjPzsP2QQk7FCm4QAbGhJd0iB0XlvQllQreX4OUJz5sR6PSoD+tKH3m07A0zCexJIiXlEq9LgYomdzUlz3Uk0SFs9DKN0N2oatBKge/dyZ5qujV9ryRjeZmXzLxeytDmmAw/ZBJhVYET8Q9PN8HXDwil2Gx2g1i0rNqX6vCSDnShIBh7ueRUwO46s1PnAnHydrLAGLEHM42SxBckKioMopKjCSZqC3fdSYX1u0n3fb30eoOx6QELGGqI5zOAt6VFd1eO+hzqU+L4yXQ3/DO7WCHBIFZJJWiI1CMNGW2MDF+kV2mNH38adMzGpOjemeWfp06BXFizdL6W31QC4GmQNuOqKMvA= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lbswZmLoA1DPoIXP47FeHJJbE1ZAh3QL0qA4rOmEMhMncEQnYKtnVlJyNVNT?= =?us-ascii?Q?4+PfDEU+6V/EifSjRj6AQVjM1bQo+/XcoSaLu9n4tchHhGu5wg2u9vFnuvMW?= =?us-ascii?Q?7TEJK1VgoNVMvOsn68i5taWg0gNf2B4G2d2pmgm3B5aCXThP2odA1QWgsPxM?= =?us-ascii?Q?pjJROHEky7QOfmYpRTRZtsfEkDk8fjXOJPmxyh2VmozezPiKoGUW7j2ZCeqE?= =?us-ascii?Q?KF3NFKSp9O/FCzJi1C8ONQB6DYIerBtkSmjFuNnB7HTdrgr/bst9I7kpTSEO?= =?us-ascii?Q?hc7/R1T0RtiMjwyFAbSykTkNaB3Go5z+Q/qjdgpXFs0FuoFT0vQtzzxUrJUN?= =?us-ascii?Q?Uw5jI5VKuqAFp2jggtkR1Ctamj8Bm7VNR8rvgywwhyt/gSSsPKzyPBag1nh0?= =?us-ascii?Q?pa2WH0PmYvDlKa/FjsFUeJJVb/7lnSEbS29jR0AgmG7PqTL5QU4nvG6zOv1N?= =?us-ascii?Q?f71+fCcNvws9hYrlu+/UYtCFlONvG6IOgMbL/I48ACU0F+OfA847Cl99ILpx?= =?us-ascii?Q?VaWcfIqVGCxf5ekUukeAhy+0Bv0GS0OuMY2QH2wiwiZhjdFAiH6fQ55Mf3eG?= =?us-ascii?Q?EGobce/t+s14GBEuI5dN8BwdC1mdLblJ7rJxsXmYZm8OgEha6E+S9+UsTLVK?= =?us-ascii?Q?KzePzYZuoKrewZzNmjuz3YuDGAx4DGPVVRejIdZdh8oxn23HDYIqdoNvsTEP?= =?us-ascii?Q?HGFw+SuXJXk1biRTMd/x/I/7KPHay9jQd1xbM6utkdwG2J06CskEQahw2j5n?= =?us-ascii?Q?RqQw/78U8WtIJTbF8bK9AvYHIXtPCrUhTGXRawV3g29WRhL5cJ/dIX0sdMvH?= =?us-ascii?Q?DDF439HmBaa2hAiqdP/2GaEPn5jpycMmdAC1q8TDRWxWj1VF0UZ8Fnf+aIma?= =?us-ascii?Q?QZyC8QhQBF1sOeURenfmKDLxee3R7XhX4bXxEaHFMrOZpKHa85qoW74Dho6K?= =?us-ascii?Q?NJsZX74i5B1oWZLkSfaqGoJEsxOd74f38PtGHck7+3MZyr60Ay8xL+TBwJ6K?= =?us-ascii?Q?ssazL0J7/X73TdeyNHvn1LlipuXbnszGJYHuZEn+y8zyT15jzONn08Yr3gaa?= =?us-ascii?Q?ecO9fxHsQ6PnD8J3EboWCinTs2l3mzbksEFo6Y7NIQHZdWr6dL2qMMSjo3Ma?= =?us-ascii?Q?87OAoe/vlQoUWRvteylR47/QwuCchPLdQLilaWSK/JILnAmYOGll4y/OUERf?= =?us-ascii?Q?naSxNpOxcRIFFHPSyD5pUEtVtkSqw6oYFh6H5wZaYWzLBPvPiVpXS8bgOTKV?= =?us-ascii?Q?FXDjpIdg5rNVgOuHA+EE9pxba83JPbv3PrYgGage0RJikyESIaC/azgYN9nr?= =?us-ascii?Q?Cxl0tMgYWOCQvRfYZvP4Zr6gsDeM08NYf4WfXaexgwWV5uvQvk05qzDVWYpM?= =?us-ascii?Q?0HkZUow9qFTJsd3BRKUNthmGrJyzGr5Hnb3ijtU5ydSSQdR06ZidBiQBnrnw?= =?us-ascii?Q?8EwmLvtvWTSez8oGqiKjZ67g0txvHZIHa/cRYr0N2p/8jIF5G69zYY7weCCy?= =?us-ascii?Q?8q/E1+YytcO2VweAfIK13nBAZiYTOlPMeTkJbgCdxs04Qcstk1XfN2HUIcn4?= =?us-ascii?Q?/PC9X4Q6kKdbYUok+dk73dsS/GLRTQLguMcI95iO?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b7709d1-d362-4651-cd81-08dc52e112b5 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2024 06:49:41.4410 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MBJu18Nqmw/TMtK+N5EzGqF8dexZb7VjVbWvtQJyOX7nxTDwIU1a4RHCxcPHg2OI/8wfzncqN/ymGAJnjdGJRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6921 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 01 Apr 2024 23:49:52 -0700 Resent-From: chasel.chiu@intel.com Reply-To: devel@edk2.groups.io,chasel.chiu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: HnrWUBj7Ml2aHtwuJP4S5kjUx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=AF6CWFb6; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Chasel Chiu Thanks, Chasel > -----Original Message----- > From: Tan, Dun > Sent: Sunday, March 31, 2024 11:04 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Lou, Yun ; Chiu, Chase= l > ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric > Subject: [edk2-platforms V2 1/3] MinPlatformPkg: Remove the global variab= le > mForceX2ApicId >=20 > This global variable mForceX2ApicId is not assigned to any value in code = and will > be initialized to 0 when the driver is loaded. So remove the global varia= ble and > related code that will not be executed. >=20 > Signed-off-by: Dun Tan > Cc: Ray Ni > Cc: Jason Lou > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > --- > Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 10 ------= ---- > 1 file changed, 10 deletions(-) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > index 2a833ec99c..62a7da290a 100644 > --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c > @@ -53,7 +53,6 @@ VOID *mLocalTable[] =3D { > EFI_ACPI_TABLE_PROTOCOL *mAcpiTable; >=20 > UINT32 mNumOfBitShift =3D 6; > -BOOLEAN mForceX2ApicId; > BOOLEAN mX2ApicEnabled; >=20 > EFI_MP_SERVICES_PROTOCOL *mMpService; > @@ -163,14 +162,6 @@ CreateCpuLocalApicInTable ( > CpuIdMapPtr->Thread =3D ProcessorInfoBuffer.Location.Thread; > CpuIdMapPtr->Flags =3D ((ProcessorInfoBuffer.StatusFlag & > PROCESSOR_ENABLED_BIT) !=3D 0); > CpuIdMapPtr->SocketNum =3D ProcessorInfoBuffer.Location.Package; > - > - //update processorbitMask > - if (CpuIdMapPtr->Flags =3D=3D 1) { > - if (mForceX2ApicId) { > - CpuIdMapPtr->SocketNum &=3D 0x7; > - CpuIdMapPtr->AcpiProcessorUid &=3D 0xFF; //keep lower 8bit due= to use > Proc obj in dsdt > - } > - } > } else { //not enabled > CpuIdMapPtr->ApicId =3D (UINT32)-1; > CpuIdMapPtr->Thread =3D (UINT32)-1; > @@ -1537,7 +1528,6 @@ InstallAcpiPlatform ( > } >=20 > DEBUG ((DEBUG_INFO, "mX2ApicEnabled - 0x%x\n", mX2ApicEnabled)); > - DEBUG ((DEBUG_INFO, "mForceX2ApicId - 0x%x\n", mForceX2ApicId)); >=20 > // support up to 64 threads/socket > AsmCpuidEx (CPUID_EXTENDED_TOPOLOGY, 1, &mNumOfBitShift, NULL, NULL, > NULL); > -- > 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117327): https://edk2.groups.io/g/devel/message/117327 Mute This Topic: https://groups.io/mt/105259123/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-