From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.6993.1670212642967130171 for ; Sun, 04 Dec 2022 19:57:27 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=h2pNYA8r; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: dun.tan@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670212646; x=1701748646; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=iNnIuKCjivunAn2GoQ4bQFCmnDMPcOuaTN0WpIip4A8=; b=h2pNYA8reu4lVcUTahoF1E0WMYNf6PADuDi/K40X8Dvu1LsxZznuItMx UzS8uP8AnYSx/oFz5USSUx74w6I2edblVuXX3/OCJj1Nf0cQTFe7HOeaC EPBSeaWkel4oXPYI2UJW9MDAyrzjmhUEzGfJwz1AHkq+seivXBRsuckxK udCKORd/OXWvbdxXSobk/mPdD3yiPcCXfKJLu7os19T3Psw+igSsFMtAE 3R8cnc3iv0qfeYP1z/iJbph1E4O/yAM2VGxTLd72z+W2jAdAFvp12URJL eaH9KHAj0+AAtS5tmrPjigbGFFpoa9+1PKeejiBI0GxjzFkirz862nPNg Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10551"; a="402533990" X-IronPort-AV: E=Sophos;i="5.96,218,1665471600"; d="scan'208";a="402533990" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2022 19:57:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10551"; a="647794990" X-IronPort-AV: E=Sophos;i="5.96,218,1665471600"; d="scan'208";a="647794990" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 04 Dec 2022 19:57:26 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 4 Dec 2022 19:57:25 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 4 Dec 2022 19:57:25 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 4 Dec 2022 19:57:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c+fJZIksGymovsr973xaV2xCrGT7NBfZrPPkGqnC1ImceTZE43/gkP1hU7SWZeDF3WWvIC4rg9vBfPMsgUz2dHtLg7LeZiHk0aqYrOc/j9Yvp6aOE3szMC4oiWOJimloobg79rC4i0+BoJQLOuAi4lhe7LzZYee/6kCIQCXZucuu76UEniXX4zLEflSN/s3pn5iqzTlEpMXHZkNRpaUdVoM+RMYmvfdFqOflpUbxCfXk4F4LRCkhKK4xY8hgJys/0n/6v74h4++vy6aEnaE9jkDjKavT+VtexWGV/NFfsqMee9GzkU/MfOsy+dw/Zw0C1BJIEly81iDf8Sj8PbU93g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e5HOfnZqLw8J2nenqnEjp48T+0q16SikZIaFrzBq3Ec=; b=eUvLF3dA1NNHJAUL5Gw9RzEhibRgMaz26Cz8FY/7hlRkhWvmZ8U1QmICEFfkmMQR0rm9/LFlmPUWV/aqLcLPJyUaoEDdV3738bABDPBNTM3jKnHoZ8GfGeMxH6tzhOpEY0F72YpZnBsjrv9sEmoRWMYZoPnJ7YPzU3LsHwTxMVWR9ZirK16wbSaCynupMNTqV3ix6QJRt2M092/V699R6+JlaqvxUtXPBdgX4smIcwLpwrbLoXGaiy9/VJtdhgLhucmn5g/VgUD2pg5d2ifyz65Wam4AjrtKo+H7y49cgNFVyFiM/wweaYjkF8oWTyGKQkPIe41BwaxTG3SSI1HSTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN9PR11MB5466.namprd11.prod.outlook.com (2603:10b6:408:11f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Mon, 5 Dec 2022 03:57:23 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::c945:6fc3:ca84:dd9b]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::c945:6fc3:ca84:dd9b%9]) with mapi id 15.20.5880.014; Mon, 5 Dec 2022 03:57:23 +0000 From: "duntan" To: "devel@edk2.groups.io" CC: Sean Brogan , Michael Kubacki , "Kinney, Michael D" , "Gao, Liming" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand PlatformCI template for Shell UnitTest Thread-Topic: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand PlatformCI template for Shell UnitTest Thread-Index: AQHY/mhQafQCh/tB5USXUEAXEUkBHq5UG2DAgAqgsFA= Date: Mon, 5 Dec 2022 03:57:23 +0000 Message-ID: References: <20221122114737.393-1-dun.tan@intel.com> <1729E5B1AD6A86B6.31464@groups.io> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5483:EE_|BN9PR11MB5466:EE_ x-ms-office365-filtering-correlation-id: f79ec52d-1a6a-4b20-3e32-08dad674d0cf x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SLpvkD7PHEj0VgfUBGrokGo3MrY235WecNk5S2Pi6x7EPQ9GACdTYbNDVQJwIWJJMf4Y+bMmr2+5mbucRd7MpFhylWpzBCfLVYVcf0Q3+1hFRGNwv80Yp72dg5HVqj2axaQgqXKsEeby0RKlK/qsRXNpDj6YnkZz4GaBXu/AG6xeQe+Xg78xgJhuxpWT5nAjG0tyqQYrCfqanNaIFKj+NsaRNgeX8zAATFxrsHV2Q8UVd7CiCFr6ZmHKSSzm+6nARFRf7uftoUjIHXjQgmKZ46X8N5fVOtZY3oUZkPv3xmDkk+hCN/uk2mhN/0MoPQ8IYKsLlgfGJUINFGAx0hujd0stIrTQ/dQJxE6ZifTAPC3ut+boy+E8Gm0Q/lhY252cAYJsIWP2gnd9/UrZOJSyO95vjKLJUXsEtabAdzumnpF5K+5h2OCQ+f08EvW+icBnbCUkAEhQitH5P22coAAcS5jFGo3EGBBezRY8yDQis2K/l5tdXH6xBTXVg7uamP/IkuUbfII+UGiD0/wyTbYVH0ugqJRTxxtv3NlD+WNz9NQlDXcjUmUTny1XMBEa8A375Ma0HSUUR3UPsQQdf9KKSQj2+4gcHVTEDGRt6KYN+jT/8zlsVO12rrNR8rTPkFcu/qijy4jjwHNTegnRoOf7NcOQKJN6APZFWbNcOvutkq1NUXpU3+o8StaEt4psAFb4pnCflGZJ1bJlrhsznrjrhGuCtaDbHsCCGpPg1J5hNjqehcrhvp/qJ6GqIvs4piyj9JX5rGb8CVELbhElmBhIpQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5483.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(346002)(39860400002)(136003)(376002)(451199015)(4326008)(966005)(38100700002)(82960400001)(122000001)(66476007)(66556008)(66946007)(76116006)(8676002)(64756008)(66446008)(107886003)(478600001)(86362001)(53546011)(6506007)(33656002)(55016003)(7696005)(38070700005)(71200400001)(6916009)(26005)(9686003)(54906003)(316002)(2906002)(83380400001)(66899015)(52536014)(8936002)(41300700001)(5660300002)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2jm+z/L39/VliDyWVtyiuDwL+EsWKs2HDuam4M6+Jj17rKVx9Q2U56LcSS0S?= =?us-ascii?Q?47LMyCbisVDnKavsSyNBri4QbbB7XEaAEVpW1bBUJHVpHaYe3kONsTa4SdeV?= =?us-ascii?Q?PnK7kV1ElIUmTT3Rjd/FmBH7vW3s7Cz3dod+Q1Y8x+cRv83O6P3ugcu+mJ8A?= =?us-ascii?Q?UKd8eFopHv60sSgJfwxa52IHY65Barhwco/mqD+CUJOLmvBUfH5gAOnMxfhW?= =?us-ascii?Q?Cp5+qNUYWz3XwIUk34lldiBhdMYBs2EkRP3iQ2yVmUisGapY7W4J7t6vHsyO?= =?us-ascii?Q?bxxOLm2olyKXOjcCQhWErU+iG1/kN1aqz5XN2vkHqi5Fml/HBPH13otG1GyF?= =?us-ascii?Q?jYOtxCoGg6eyu6bPyuZDJoiZWSDBJT8ViIgTDW4UhnNDfVHw2Rd4VFrFOMSJ?= =?us-ascii?Q?yYn8zzv4HSUF/02d7HsxEynvKce7NSV+SIWgLx2ktM3YZ+Qx7guT5IIH6syB?= =?us-ascii?Q?G9spvQIB+l6XrRxtxOYR10WrMvGk89TTlQUCUtZ1TdWnLmQUjsdanTh2rBLq?= =?us-ascii?Q?9qzweA4v3WXIrmusRN/4DAlcYUPJpJg70HHGjdnn7dOQC5yfOag8TSeXzEIs?= =?us-ascii?Q?ZVU9LFlJNDsrjOEHByTm6+Uq39Gynelom7QWNldFH7L9FsxAG4HS2xxKJL8e?= =?us-ascii?Q?VoSnoLpBbzLixPpoNcAfpJ0k1955C9ueLN/BjR16axMT8FlICR9m4hb322nB?= =?us-ascii?Q?JczXxs/8fWfw6HmLh5cVLspQKtXimIxFZvgBG/l4VjuCI4+veFkMVbh0qLKN?= =?us-ascii?Q?nOfQPxbnfnxmMvkF6ujIbb/+CpwAAsi3u3zJq8XWANt+LSNTdw6DJeXEsPtV?= =?us-ascii?Q?iBexche6NvKwirzLHhxxtqE5EyN1sbfPwIBA8OGregN0L9GQpSjUM4wu8JSY?= =?us-ascii?Q?M+vS8zwb5COZ2gelxs1nlRy9LKCGGcOoWzOnczJc2XFMlpukB1c0GZncqDjk?= =?us-ascii?Q?76LyBcH1nOjycfHEvwSMV8SfwFY4iT1KOZogm8bFLWSYYHxSqAqlmcVoOCJz?= =?us-ascii?Q?Ne6IfQTgesPUHjSBca0wNR/IH0oTc0YU7yHsN/g71bQmAjlLmR/IQu4XL0uz?= =?us-ascii?Q?AoeA5y8d1CHxtDAPybmKU+vr7gp1if7sArovOD6BR5TbFUunsJrVrQMlUHe6?= =?us-ascii?Q?I3UqifK+jK85knBg3xlRG6gw1LsCYMq72P0yCNEAV7NOuSetnpln8hXB1drN?= =?us-ascii?Q?Jq/h5xEUv6+3PFHy38JIVsJ8ZYhmB8VsHs2PitG+JU5FIzsfM46JfkzgrnNc?= =?us-ascii?Q?lbaDvJNruWWQsEcVHmpiquPUjeaF7IzMPx/J3bQ9CyenMtQBDH/tMHJSAa90?= =?us-ascii?Q?IaGSQqr1Omwz2f4z85OwdpA+G+kk3KOxcgL+dfueOYdLysl5y8WjCGkqkE7J?= =?us-ascii?Q?ms1BFbCtM2Y0t+o6amB0vm4QDEjQXlbp2RzcpZJa081NfKIJ6GZ5Heo5PeVl?= =?us-ascii?Q?QBaXTxDSnyiu/QKl1xncmtJ9XhB2e6dXX8hrmvYbaAJwRDe3+madb+h07NHq?= =?us-ascii?Q?pUyyGv9J7pI+rwtEQUZm7m9+8XjCYFjQ1AnMhGUweuuSktkdZxArhzP6PwR7?= =?us-ascii?Q?8FrKKPUy5p0dLeYIiK0=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f79ec52d-1a6a-4b20-3e32-08dad674d0cf X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2022 03:57:23.3827 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YzZ7qxNnRqp4UiVgJ6nSh5sz3sq23OmdfnA3P8Jbwjn/Y+OCzgGFJrS4VN5t9ZPmnV+nVGOP9ypvIX7Vtx/SjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5466 Return-Path: dun.tan@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi all, Is there anything else I can do to speed up the review process for this pat= ch set? Looking forward to your reply. Thanks, Dun -----Original Message----- From: Tan, Dun=20 Sent: Monday, November 28, 2022 5:34 PM To: devel@edk2.groups.io; Tan, Dun Cc: Sean Brogan ; Michael Kubacki ; Kinney, Michael D ; Gao, Limi= ng ; Ni, Ray Subject: RE: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand PlatformCI te= mplate for Shell UnitTest Hi all, Could you please help to review this patch? Thanks a lot! Thanks, Dun -----Original Message----- From: devel@edk2.groups.io On Behalf Of duntan Sent: Tuesday, November 22, 2022 7:48 PM To: devel@edk2.groups.io Cc: Sean Brogan ; Michael Kubacki ; Kinney, Michael D ; Gao, Limi= ng ; Ni, Ray Subject: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand PlatformCI templa= te for Shell UnitTest Expand PlatformCI build and run steps template for Shell UnitTest. Add a ne= w parameter unit_test_list to support building and running specific Shell U= nitTest modules. In stuart_pr_eval step, if the unit_test_list passed from platform yml file= is not null, it will select some packages from the packages which contain = the module in unit_test_list and set them into a new variable pkgs_to_build= base on its evaluation rule. In stuart_build step, if unit_test_list is not null, '${{ parameters.unit_t= est_list}} -p $(pkgs_to_build)' will be added into the arguments to build s= pecific UnitTest modules in pkgs_to_build. In 'Run to shell' step, if unit_test_list is not null, all the UnitTest mod= ules built in stuart_build step will runs in shell. Signed-off-by: Dun Tan Cc: Sean Brogan Cc: Michael Kubacki Cc: Michael D Kinney Cc: Liming Gao Cc: Ray Ni --- .azurepipelines/templates/platform-build-run-steps.yml | 21 ++++++++++++++= +++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/.azurepipelines/templates/platform-build-run-steps.yml b/.azur= epipelines/templates/platform-build-run-steps.yml index 40a31a509f..51503287c4 100644 --- a/.azurepipelines/templates/platform-build-run-steps.yml +++ b/.azurepipelines/templates/platform-build-run-steps.yml @@ -30,6 +30,9 @@ parameters: - name: run_flags type: string default: '' +- name: unit_test_list + type: string + default: '' =20 - name: extra_install_step type: stepList @@ -49,7 +52,9 @@ steps: displayName: 'Install/Upgrade pip modules' =20 # Set default -- bash: echo "##vso[task.setvariable variable=3Dpkg_count]${{ 1 }}" +- bash: | + echo "##vso[task.setvariable variable=3Dpkg_count]${{ 1 }}" + echo "##vso[task.setvariable variable=3Dpkgs_to_build]${{ 'all' }}" =20 # Fetch the target branch so that pr_eval can diff them. # Seems like azure pipelines/github changed checkout process in nov 2020. @@ -62,7 +67,7 @@ steps: displayName: Check if ${{ parameters.build_pkg }} need testing inputs: filename: stuart_pr_eval - arguments: -c ${{ parameters.build_file }} -t ${{ parameters.build_tar= get}} -a ${{ parameters.build_arch}} --pr-target origin/$(System.PullReques= t.targetBranch) --output-count-format-string "##vso[task.setvariable variab= le=3Dpkg_count;isOutpout=3Dtrue]{pkgcount}" + arguments: -c ${{ parameters.build_file }} -t ${{=20 + parameters.build_target}} -a ${{ parameters.build_arch}} --pr-target + origin/$(System.PullRequest.targetBranch) --output-count-format-string=20 + "##vso[task.setvariable variable=3Dpkg_count;isOutpout=3Dtrue]{pkgcount}" + --output-csv-format-string "##vso[task.setvariable=20 + variable=3Dpkgs_to_build]{pkgcsv}" ${{ parameters.unit_test_list}} condition: eq(variables['Build.Reason'], 'PullRequest') =20 # Setup repo @@ -97,14 +102,22 @@ steps: inputs: filename: stuart_build arguments: -c ${{ parameters.build_file }} TOOL_CHAIN_TAG=3D${{ parame= ters.tool_chain_tag}} TARGET=3D${{ parameters.build_target}} -a ${{ paramet= ers.build_arch}} ${{ parameters.build_flags}} - condition: and(gt(variables.pkg_count, 0), succeeded()) + condition: and(and(gt(variables.pkg_count, 0), succeeded()),=20 + eq(variables.unit_test_list, '')) + +# Build specific pkg for UnitTest +- task: CmdLine@1 + displayName: Build UnitTest + inputs: + filename: stuart_build + arguments: ${{ parameters.unit_test_list}} -p $(pkgs_to_build) -c=20 +${{ parameters.build_file }} TOOL_CHAIN_TAG=3D${{=20 +parameters.tool_chain_tag}} TARGET=3D${{ parameters.build_target}} -a ${{= =20 +parameters.build_arch}} ${{ parameters.build_flags}} + condition: and(and(gt(variables.pkg_count, 0), succeeded()),=20 +not(eq(variables.unit_test_list, ''))) =20 # Run - task: CmdLine@1 displayName: Run to shell inputs: filename: stuart_build - arguments: -c ${{ parameters.build_file }} TOOL_CHAIN_TAG=3D${{ parame= ters.tool_chain_tag}} TARGET=3D${{ parameters.build_target}} -a ${{ paramet= ers.build_arch}} ${{ parameters.build_flags}} ${{ parameters.run_flags }} -= -FlashOnly + arguments: -c ${{ parameters.build_file }} TOOL_CHAIN_TAG=3D${{=20 + parameters.tool_chain_tag}} TARGET=3D${{ parameters.build_target}} -a=20 + ${{ parameters.build_arch}} ${{ parameters.build_flags}} ${{=20 + parameters.run_flags }} --FlashOnly ${{ parameters.unit_test_list}} condition: and(and(gt(variables.pkg_count, 0), succeeded()), eq(variable= s['Run'], true)) timeoutInMinutes: 1 =20 -- 2.31.1.windows.1