public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "Guo, Gua" <gua.guo@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Guo" <guo.dong@intel.com>,
	"Rhodes, Sean" <sean@starlabs.systems>,
	"Lu, James" <james.lu@intel.com>
Subject: Re: [edk2-devel] [PATCH v1] UefiPayloadPkg/Gop: Clean up unused protocol and Guid
Date: Fri, 9 Feb 2024 16:38:02 +0000	[thread overview]
Message-ID: <BN9PR11MB5483EC0D6F6389DD4AFBD8BCE64B2@BN9PR11MB5483.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240209093426.756-1-gua.guo@intel.com>


Thanks Gua!
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>



> -----Original Message-----
> From: Guo, Gua <gua.guo@intel.com>
> Sent: Friday, February 9, 2024 1:34 AM
> To: devel@edk2.groups.io
> Cc: Guo, Gua <gua.guo@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Dong, Guo <guo.dong@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Lu,
> James <james.lu@intel.com>
> Subject: [PATCH v1] UefiPayloadPkg/Gop: Clean up unused protocol and Guid
> 
> From: Gua Guo <gua.guo@intel.com>
> 
> Below Guid is redundant code on UefiPayloadPkg.dec 1. gBmpImageGuid 2.
> gPlatformGOPPolicyGuid
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Sean Rhodes <sean@starlabs.systems>
> Cc: James Lu <james.lu@intel.com>
> Cc: Gua Guo <gua.guo@intel.com>
> Signed-off-by: Gua Guo <gua.guo@intel.com>
> ---
>  UefiPayloadPkg/UefiPayloadPkg.dec | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.dec
> b/UefiPayloadPkg/UefiPayloadPkg.dec
> index 2f1fd82487..23dcdf9a0c 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.dec
> +++ b/UefiPayloadPkg/UefiPayloadPkg.dec
> @@ -27,11 +27,6 @@
>    ## Include/Guid/UniversalPayloadBase.h   gUniversalPayloadBaseGuid =
> { 0x03d4c61d, 0x2713, 0x4ec5, {0xa1, 0xcc, 0x88, 0x3b, 0xe9, 0xdc, 0x18, 0xe5 } }
> -  #-  # Gop Temp-  #-  gBmpImageGuid                           = { 0x878AC2CC, 0x5343,
> 0x46F2, { 0xB5, 0x63, 0x51, 0xF8, 0x9D, 0xAF, 0x56, 0xBA } }-
> gEdkiiDebugPrintErrorLevelGuid = { 0xad82f436, 0x75c5, 0x4aa9, { 0x92, 0x93,
> 0xc5, 0x55, 0x0a, 0x7f, 0xf9, 0x71 }}   gUefiAcpiBoardInfoGuid   = {0xad3d31b,
> 0xb3d8, 0x4506, {0xae, 0x71, 0x2e, 0xf1, 0x10, 0x6, 0xd9, 0xf}}
> gUefiSerialPortInfoGuid  = { 0x6c6872fe, 0x56a9, 0x4403, { 0xbb, 0x98, 0x95,
> 0x8d, 0x62, 0xde, 0x87, 0xf1 } }@@ -47,12 +42,6 @@
>  [Ppis]   gEfiPayLoadHobBasePpiGuid = { 0xdbe23aa1, 0xa342, 0x4b97, {0x85,
> 0xb6, 0xb2, 0x26, 0xf1, 0x61, 0x73, 0x89} } -[Protocols]-  #-  # Gop Temp-  #-
> gPlatformGOPPolicyGuid                  = { 0xec2e931b, 0x3281, 0x48a5, { 0x81, 0x07,
> 0xdf, 0x8a, 0x8b, 0xed, 0x3c, 0x5d } }-
> #################################################################
> ############### # # PCD Declarations section - list of all PCDs Declared by this
> Package--
> 2.39.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115310): https://edk2.groups.io/g/devel/message/115310
Mute This Topic: https://groups.io/mt/104256147/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      reply	other threads:[~2024-02-09 16:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09  9:34 [edk2-devel] [PATCH v1] UefiPayloadPkg/Gop: Clean up unused protocol and Guid Guo, Gua
2024-02-09 16:38 ` Chiu, Chasel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN9PR11MB5483EC0D6F6389DD4AFBD8BCE64B2@BN9PR11MB5483.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox