Re: [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library.

["Chiu, Chasel" <chasel.chiu@intel.com>]

Agree. I'm sending patch to rename this lib from edk2 and will send patch to rename this lib from MinPlatformPkg dsc too.

Thanks,
Chasel


> -----Original Message-----
> From: Oram, Isaac W <isaac.w.oram@intel.com>
> Sent: Wednesday, August 31, 2022 4:10 PM
> To: Chiu, Chasel <chasel.chiu@intel.com>; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
> Subject: RE: [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4
> MultiPhase library.
> 
> This sample library does not do anything.  If the design is such that a NULL
> library is functional, then a NULL library should be implemented.  Having a
> sample library that has the same function as a NULL library doesn't make
> sense to me.
> It looks like a NULL library would work fine in this design.  If you update to
> IntelFsp2WrapperPkg/Library/BaseFspWrapperPlatformMultiPhaseLibNull/B
> aseFspWrapperPlatformMultiPhaseLibNull.inf, that would be acceptable to
> me.
> 
> Regards,
> Isaac
> 
> -----Original Message-----
> From: Chiu, Chasel <chasel.chiu@intel.com>
> Sent: Wednesday, August 31, 2022 11:19 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Oram, Isaac W
> <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong,
> Eric <eric.dong@intel.com>
> Subject: [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase
> library.
> 
> FSP Wrapper has implemented FSP 2.4 MultiPhase support and required
> platform to include new library instance.
> 
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
> index 8e91dba6ac..d4191c4b01 100644
> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
> @@ -54,6 +54,8 @@
> 
> TpmPlatformHierarchyLib|MinPlatformPkg/Tcg/Library/PeiDxeTpmPlatform
> HierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf
> FspMeasurementLib|IntelFsp2WrapperPkg/Library/BaseFspMeasurementLi
> b/BaseFspMeasurementLib.inf+
> FspWrapperPlatformMultiPhaseLib|IntelFsp2WrapperPkg/Library/BaseFspW
> rapperPlatformMultiPhaseLibSample/BaseFspWrapperPlatformMultiPhaseLi
> bSample.inf+
> FspWrapperMultiPhaseProcessLib|IntelFsp2WrapperPkg/Library/FspWrappe
> rMultiPhaseProcessLib/FspWrapperMultiPhaseProcessLib.inf
> TcgEventLogRecordLib|SecurityPkg/Library/TcgEventLogRecordLib/TcgEventL
> ogRecordLib.inf
> TpmMeasurementLib|SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpm
> MeasurementLib.inf --
> 2.35.0.windows.1